{"id":2223995,"url":"http://patchwork.ozlabs.org/api/patches/2223995/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-12-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416131453.308611-12-pablo@netfilter.org>","list_archive_url":null,"date":"2026-04-16T13:14:53","name":"[net,11/11] netfilter: nf_tables: join hook list via splice_list_rcu() in commit phase","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"6e9e6b82bf3b8bb393bc45041bb87c8e62f2ac94","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-12-pablo@netfilter.org/mbox/","series":[{"id":500161,"url":"http://patchwork.ozlabs.org/api/series/500161/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500161","date":"2026-04-16T13:14:48","name":"[net,01/11] netfilter: arp_tables: fix IEEE1394 ARP payload parsing in arp_packet_match()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223995/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223995/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=fyQd5E7A;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11979-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"fyQd5E7A\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxJZX1qtMz1yCv\n\tfor ; Thu, 16 Apr 2026 23:21:56 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 8D09731AF792\n\tfor ; Thu, 16 Apr 2026 13:16:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6DB503CEB9D;\n\tThu, 16 Apr 2026 13:15:19 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C8ED93CEBB7;\n\tThu, 16 Apr 2026 13:15:17 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id C3D3960262;\n\tThu, 16 Apr 2026 15:15:15 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776345319; cv=none;\n b=CtjgqATuS2KMWoUtYEgQxrcRMqi8rYQWfqjx7du0GEYUs9mTMt4AcyV5mPX0DX/5rttJB0kAGFA6HgbXjMka9OvMog1XtXH23W4i/S3iLwqDlIeSru5KT3UB1Zk7Pvg6RxNhDb+Gb5vZCvUvLPozW+8OX+JNfJTrHtRaRmYtWF4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776345319; c=relaxed/simple;\n\tbh=2efQzCiXJ2Wli7t6Ka/6/L85zMRoJKZJe6aw1Fet5zM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=dqOgdRFn7LYzmYby7u8RwTEiENDPwVbDSE46GqnscZZgUeFvNXK9zx4pZeRFYhZHsjMGTE1+x6FONPzLi0Djcu+WQJqlWXtUwFRpmtvr2QzpH06d43JhBWC0cPpnrlsX7CVi9jq4389bmQWg66bZjRlK+4JWDhDgfAuCA9HceMY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=fyQd5E7A; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776345316;\n\tbh=7UGc+WvpSbrw5BeuDggd8MZE8BV2R6UfQGJ2bjLPyRI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fyQd5E7A0pF/xC+Ck6UCpFefucdrp0sIxMZijVAk+AFRy7aPj5rXQYHSJtKqS2Q2D\n\t AL3ejfBhtdO8Sn/BDPdjgxkgJ296Rj/Z7aS7wRMfbSuzFh94f0CRpmFCYKJLsNQuNF\n\t og9ADkcQmgl4VQuj60Oue3rvAsLqgjf4xM+Rg560SadGGqHV9BjdqtMQCySAyPApvN\n\t Z6tTOCSu9mVTNT4BekoabGlp3SD2PhwCbk++c5qXQWXZNaul5KL3DlHcoBuNDb0Ent\n\t iEQYrt0tbdp5MczIOBUtugBy73MUwnkPCBqcuqsTmYcVdvf44iTDSKXA4RjzrhEgBZ\n\t TT3cqFY46Stiw==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org","Subject":"[PATCH net 11/11] netfilter: nf_tables: join hook list via\n splice_list_rcu() in commit phase","Date":"Thu, 16 Apr 2026 15:14:53 +0200","Message-ID":"<20260416131453.308611-12-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260416131453.308611-1-pablo@netfilter.org>","References":"<20260416131453.308611-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Publish new hooks in the list into the basechain/flowtable using\nsplice_list_rcu() to ensure netlink dump list traversal via rcu is safe\nwhile concurrent ruleset update is going on.\n\nFixes: 78d9f48f7f44 (\"netfilter: nf_tables: add devices to existing flowtable\")\nFixes: b9703ed44ffb (\"netfilter: nf_tables: support for adding new devices to an existing netdev chain\")\nSigned-off-by: Pablo Neira Ayuso \n---\n net/netfilter/nf_tables_api.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c\nindex 090d4d688a33..8c0706d6d887 100644\n--- a/net/netfilter/nf_tables_api.c\n+++ b/net/netfilter/nf_tables_api.c\n@@ -10904,8 +10904,8 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)\n \t\t\t\tnft_chain_commit_update(nft_trans_container_chain(trans));\n \t\t\t\tnf_tables_chain_notify(&ctx, NFT_MSG_NEWCHAIN,\n \t\t\t\t\t\t &nft_trans_chain_hooks(trans));\n-\t\t\t\tlist_splice(&nft_trans_chain_hooks(trans),\n-\t\t\t\t\t &nft_trans_basechain(trans)->hook_list);\n+\t\t\t\tlist_splice_rcu(&nft_trans_chain_hooks(trans),\n+\t\t\t\t\t\t&nft_trans_basechain(trans)->hook_list);\n \t\t\t\t/* trans destroyed after rcu grace period */\n \t\t\t} else {\n \t\t\t\tnft_chain_commit_drop_policy(nft_trans_container_chain(trans));\n@@ -11034,8 +11034,8 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)\n \t\t\t\t\t\t\t nft_trans_flowtable(trans),\n \t\t\t\t\t\t\t &nft_trans_flowtable_hooks(trans),\n \t\t\t\t\t\t\t NFT_MSG_NEWFLOWTABLE);\n-\t\t\t\tlist_splice(&nft_trans_flowtable_hooks(trans),\n-\t\t\t\t\t &nft_trans_flowtable(trans)->hook_list);\n+\t\t\t\tlist_splice_rcu(&nft_trans_flowtable_hooks(trans),\n+\t\t\t\t\t\t&nft_trans_flowtable(trans)->hook_list);\n \t\t\t} else {\n \t\t\t\tnft_clear(net, nft_trans_flowtable(trans));\n \t\t\t\tnf_tables_flowtable_notify(&ctx,\n","prefixes":["net","11/11"]}