{"id":2223993,"url":"http://patchwork.ozlabs.org/api/patches/2223993/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-8-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416131453.308611-8-pablo@netfilter.org>","list_archive_url":null,"date":"2026-04-16T13:14:49","name":"[net,07/11] netfilter: nat: use kfree_rcu to release ops","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"f45216d1f994ac3632b7e66689e85a49958cea90","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-8-pablo@netfilter.org/mbox/","series":[{"id":500161,"url":"http://patchwork.ozlabs.org/api/series/500161/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500161","date":"2026-04-16T13:14:48","name":"[net,01/11] netfilter: arp_tables: fix IEEE1394 ARP payload parsing in arp_packet_match()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223993/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223993/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=Fw03q+8R;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11975-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"Fw03q+8R\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxJYB01drz1yCv\n\tfor ; Thu, 16 Apr 2026 23:20:45 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 2E3C9318C456\n\tfor ; Thu, 16 Apr 2026 13:15:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BD1643CD8C2;\n\tThu, 16 Apr 2026 13:15:13 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 08CF814A4F0;\n\tThu, 16 Apr 2026 13:15:11 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id D2E2960254;\n\tThu, 16 Apr 2026 15:15:09 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776345313; cv=none;\n b=eY+OioVwKvHbxwqMHnU+wK9Q93xCwKTTp9NimHr9pnAS7jA92FcPsGlIntc98e2uTO8N8+5374Z18lUBJz6JxQXutCaw6G5ExZdO9JHk9aNhC8QHMaCLQBLjeZSmZLAAUDL+L/npo2St/RRxrb9+0BPi0GDz8nDmXr5DSPNGPj0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776345313; c=relaxed/simple;\n\tbh=qeMJhnYimVlICJ5eTnyKmjZw7xRdiqN4RqTkKuKW6j8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=U4+KUwh0sJjtkNbUkD4fv89xylpElM32E/ac/9je++B+P9X+WWKGREUHvSOtFX/qCFFm3JF96LwE28VUo/GxCMAVBVbSnthcOel6umBWYuuCayt8P5ZMfzPRVbI/v45mfv2PBlkz5IDdf6MxejXd50tWI5QWBDtiWXyoDjwdyWQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=Fw03q+8R; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776345310;\n\tbh=1b6i10nqRPpCr482KhE186G03DU2qm9L1tneVbMcDng=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Fw03q+8RcxtyOSLKZTg+yM7ZA3UMnjHEUwfi199xOB/0vcaOb5DY4EmCz/x1Ci7Cj\n\t 38JCvi6mHMf2ThyjY8zw8gCdqo3QI2IJ3COO+/nyH27mojW5aRBpU21/AUMowAIzqJ\n\t GEDADUtK+qWnMI3G7kqTe6O5PiOjHncX/ls84Q4ExhChVyp/jZtsHXAqg0SQWcqhyU\n\t tAm+435xqZjCEK20Id9P1K9w7lU8PPgdp0XDt86x5IfunAEMAk9+IQmdd+lwph5YQL\n\t +prnnMrEgWXi6GdL2R3cq/H3HRjflotwKMHJLJmLryO/vdbwyOO0zwRIGxM6TXxlfW\n\t GKjBAiQUBNH+A==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org","Subject":"[PATCH net 07/11] netfilter: nat: use kfree_rcu to release ops","Date":"Thu, 16 Apr 2026 15:14:49 +0200","Message-ID":"<20260416131453.308611-8-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260416131453.308611-1-pablo@netfilter.org>","References":"<20260416131453.308611-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Florian Westphal says:\n\n\"Historically this is not an issue, even for normal base hooks: the data\npath doesn't use the original nf_hook_ops that are used to register the\ncallbacks.\n\nHowever, in v5.14 I added the ability to dump the active netfilter\nhooks from userspace.\n\nThis code will peek back into the nf_hook_ops that are available\nat the tail of the pointer-array blob used by the datapath.\n\nThe nat hooks are special, because they are called indirectly from\nthe central nat dispatcher hook. They are currently invisible to\nthe nfnl hook dump subsystem though.\n\nBut once that changes the nat ops structures have to be deferred too.\"\n\nUpdate nf_nat_register_fn() to deal with partial exposition of the hooks\nfrom error path which can be also an issue for nfnetlink_hook.\n\nFixes: e2cf17d3774c (\"netfilter: add new hook nfnl subsystem\")\nSigned-off-by: Pablo Neira Ayuso \n---\n net/ipv4/netfilter/iptable_nat.c | 2 +-\n net/ipv6/netfilter/ip6table_nat.c | 2 +-\n net/netfilter/nf_nat_core.c | 10 ++++++----\n 3 files changed, 8 insertions(+), 6 deletions(-)","diff":"diff --git a/net/ipv4/netfilter/iptable_nat.c b/net/ipv4/netfilter/iptable_nat.c\nindex a5db7c67d61b..3b1de7f82bf8 100644\n--- a/net/ipv4/netfilter/iptable_nat.c\n+++ b/net/ipv4/netfilter/iptable_nat.c\n@@ -100,7 +100,7 @@ static void ipt_nat_unregister_lookups(struct net *net)\n \tfor (i = 0; i < ARRAY_SIZE(nf_nat_ipv4_ops); i++)\n \t\tnf_nat_ipv4_unregister_fn(net, &ops[i]);\n \n-\tkfree(ops);\n+\tkfree_rcu(ops, rcu);\n }\n \n static int iptable_nat_table_init(struct net *net)\ndiff --git a/net/ipv6/netfilter/ip6table_nat.c b/net/ipv6/netfilter/ip6table_nat.c\nindex e119d4f090cc..9adfbfeaab0c 100644\n--- a/net/ipv6/netfilter/ip6table_nat.c\n+++ b/net/ipv6/netfilter/ip6table_nat.c\n@@ -102,7 +102,7 @@ static void ip6t_nat_unregister_lookups(struct net *net)\n \tfor (i = 0; i < ARRAY_SIZE(nf_nat_ipv6_ops); i++)\n \t\tnf_nat_ipv6_unregister_fn(net, &ops[i]);\n \n-\tkfree(ops);\n+\tkfree_rcu(ops, rcu);\n }\n \n static int ip6table_nat_table_init(struct net *net)\ndiff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c\nindex 3b5434e4ec9c..b30ca94c2bb7 100644\n--- a/net/netfilter/nf_nat_core.c\n+++ b/net/netfilter/nf_nat_core.c\n@@ -1228,9 +1228,11 @@ int nf_nat_register_fn(struct net *net, u8 pf, const struct nf_hook_ops *ops,\n \t\tret = nf_register_net_hooks(net, nat_ops, ops_count);\n \t\tif (ret < 0) {\n \t\t\tmutex_unlock(&nf_nat_proto_mutex);\n-\t\t\tfor (i = 0; i < ops_count; i++)\n-\t\t\t\tkfree(nat_ops[i].priv);\n-\t\t\tkfree(nat_ops);\n+\t\t\tfor (i = 0; i < ops_count; i++) {\n+\t\t\t\tpriv = nat_ops[i].priv;\n+\t\t\t\tkfree_rcu(priv, rcu_head);\n+\t\t\t}\n+\t\t\tkfree_rcu(nat_ops, rcu);\n \t\t\treturn ret;\n \t\t}\n \n@@ -1294,7 +1296,7 @@ void nf_nat_unregister_fn(struct net *net, u8 pf, const struct nf_hook_ops *ops,\n \t\t}\n \n \t\tnat_proto_net->nat_hook_ops = NULL;\n-\t\tkfree(nat_ops);\n+\t\tkfree_rcu(nat_ops, rcu);\n \t}\n unlock:\n \tmutex_unlock(&nf_nat_proto_mutex);\n","prefixes":["net","07/11"]}