{"id":2223990,"url":"http://patchwork.ozlabs.org/api/patches/2223990/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-5-pablo@netfilter.org/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416131453.308611-5-pablo@netfilter.org>","list_archive_url":null,"date":"2026-04-16T13:14:46","name":"[net,04/11] netfilter: nfnetlink_osf: fix null-ptr-deref in nf_osf_ttl","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"84887649eb91594a98305d9001e5aa6a1c00b0bf","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/?format=json","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-5-pablo@netfilter.org/mbox/","series":[{"id":500161,"url":"http://patchwork.ozlabs.org/api/series/500161/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500161","date":"2026-04-16T13:14:48","name":"[net,01/11] netfilter: arp_tables: fix IEEE1394 ARP payload parsing in arp_packet_match()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223990/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223990/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=Nk0O2Psr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11972-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"Nk0O2Psr\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxJWq1NgWz1yG9\n\tfor ; Thu, 16 Apr 2026 23:19:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C11A03171173\n\tfor ; Thu, 16 Apr 2026 13:15:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A47EE3CCA15;\n\tThu, 16 Apr 2026 13:15:09 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C17A91F09A8;\n\tThu, 16 Apr 2026 13:15:07 +0000 (UTC)","from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id 90C7C60177;\n\tThu, 16 Apr 2026 15:15:05 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776345309; cv=none;\n b=OQLRxwOKwfYvNjPLFtNwhtAmEogD/uYom0GfjqkufMsc+0omtRnBOxtXZKVMoTV4gxoJuBJZf9YcCR4IW91gwqRO4hpsVdtMXu4Qv35/TI/jSM85yPUNlVftvchZljO8qhx7tYroLhYxFZBv4L/Jz0nIFoe8YyA9N3myeWQbcmA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776345309; c=relaxed/simple;\n\tbh=la5PxyZ6zfqAlWe7ze7U2BoSo9vipP6VepoVDS9ueko=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=uCn6D9FUeYJ4iQhmVfMkA4JuIapY3PuuLej6MDRQ6XCBGIzV4uqj/MEHjkX/w1EBZhaA5Ixh5kDdqItgDzHCjdi0QwyKqTYWYJqsW0YlXM7vDj45JUitVn0yaQEx/pTBOz8LqN83zM7h5V5XdrY5wja7gLWbCMWGpR8gEgqgvug=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=Nk0O2Psr; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776345306;\n\tbh=LeFaSGjPCTTf+pALMTZtcj2GKEbk7aP/xGJb/KuJWaQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Nk0O2PsrdVnySBCQMs4/YoTmCfv5PAFdPRdG6IZfu5OhgLzhEzuKwiBTjS1bZ9L/j\n\t G3DquQZWeB4VS6OUvHAonjI2/oDccMmKAh28yUaAeTnUDcpupeEWHctF1PK4yRrqeR\n\t 5BmU72n6wC3UMXKwxPqScBmiExAb4iYvNKKqzi13YDEQ1Rt2mHf6qRgAn3+8ve9Ean\n\t G9TS2lZxkMJLDqZwPJtmcRiFVbCvy5yl8L0syZKsmlcMU7JTYorIXHJruszIgw0hsC\n\t BP9pAEhQewVMLC+m8vD377OlAmSUteUEIQ9yxupixT7//8UcS7qIYxBI4dEY51Ea2K\n\t 2oH2nR8jLixyA==","From":"Pablo Neira Ayuso ","To":"netfilter-devel@vger.kernel.org","Cc":"davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org","Subject":"[PATCH net 04/11] netfilter: nfnetlink_osf: fix null-ptr-deref in\n nf_osf_ttl","Date":"Thu, 16 Apr 2026 15:14:46 +0200","Message-ID":"<20260416131453.308611-5-pablo@netfilter.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260416131453.308611-1-pablo@netfilter.org>","References":"<20260416131453.308611-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: \"Kito Xu (veritas501)\" \n\nnf_osf_ttl() calls __in_dev_get_rcu(skb->dev) and passes the result\nto in_dev_for_each_ifa_rcu() without checking for NULL. When the\nreceiving device has no IPv4 configuration (ip_ptr is NULL),\n__in_dev_get_rcu() returns NULL and in_dev_for_each_ifa_rcu()\ndereferences it unconditionally, causing a kernel crash.\n\nThis can happen when a packet arrives on a device that has had its\nIPv4 configuration removed (e.g., MTU set below IPV4_MIN_MTU causing\ninetdev_destroy) or on a device that was never assigned an IPv4\naddress, while an xt_osf or nft_osf rule with TTL_LESS mode is\nactive and the packet TTL exceeds the fingerprint TTL.\n\nAdd a NULL check for in_dev before using it. When in_dev is NULL,\nreturn 0 (no match) since source-address locality cannot be\ndetermined without IPv4 addresses on the device.\n\nKASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017]\nRIP: 0010:nf_osf_match_one+0x204/0xa70\nCall Trace:\n \n nf_osf_match+0x2f8/0x780\n xt_osf_match_packet+0x11c/0x1f0\n ipt_do_table+0x7fe/0x12b0\n nf_hook_slow+0xac/0x1e0\n ip_rcv+0x123/0x370\n __netif_receive_skb_one_core+0x166/0x1b0\n process_backlog+0x197/0x590\n __napi_poll+0xa1/0x540\n net_rx_action+0x401/0xd80\n handle_softirqs+0x19f/0x610\n \n\nFixes: a218dc82f0b5 (\"netfilter: nft_osf: Add ttl option support\")\nSuggested-by: Pablo Neira Ayuso \nSigned-off-by: Kito Xu (veritas501) \nReviewed-by: Fernando Fernandez Mancera \nReviewed-by: Florian Westphal \nSigned-off-by: Pablo Neira Ayuso \n---\n net/netfilter/nfnetlink_osf.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/net/netfilter/nfnetlink_osf.c b/net/netfilter/nfnetlink_osf.c\nindex 70172ca07858..4bbe64288b90 100644\n--- a/net/netfilter/nfnetlink_osf.c\n+++ b/net/netfilter/nfnetlink_osf.c\n@@ -36,6 +36,9 @@ static inline int nf_osf_ttl(const struct sk_buff *skb,\n \tconst struct in_ifaddr *ifa;\n \tint ret = 0;\n \n+\tif (!in_dev)\n+\t\treturn 0;\n+\n \tif (ttl_check == NF_OSF_TTL_TRUE)\n \t\treturn ip->ttl == f_ttl;\n \tif (ttl_check == NF_OSF_TTL_NOCHECK)\n","prefixes":["net","04/11"]}