{"id":2223910,"url":"http://patchwork.ozlabs.org/api/patches/2223910/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260416113952.389405-2-poros@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416113952.389405-2-poros@redhat.com>","list_archive_url":null,"date":"2026-04-16T11:39:51","name":"[net,v6,1/2] dpll: export __dpll_pin_change_ntf() for use under dpll_lock","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"450f724c0f22ca87a40ce5ff5156abae5bf380fd","submitter":{"id":74657,"url":"http://patchwork.ozlabs.org/api/people/74657/?format=json","name":"Petr Oros","email":"poros@redhat.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260416113952.389405-2-poros@redhat.com/mbox/","series":[{"id":500138,"url":"http://patchwork.ozlabs.org/api/series/500138/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500138","date":"2026-04-16T11:39:50","name":"ice: fix missing dpll notifications for SW pins","version":6,"mbox":"http://patchwork.ozlabs.org/series/500138/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223910/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223910/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=RN5bG8Jh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxGKK5JSYz1yCv\n\tfor ; Thu, 16 Apr 2026 21:40:21 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id CD3BF6070E;\n\tThu, 16 Apr 2026 11:40:19 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id PgnymcpWa1gx; Thu, 16 Apr 2026 11:40:17 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 9AC566070A;\n\tThu, 16 Apr 2026 11:40:17 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id C624F775\n for ; Thu, 16 Apr 2026 11:40:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id B88E440478\n for ; Thu, 16 Apr 2026 11:40:16 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lrMMLmxjEaDL for ;\n Thu, 16 Apr 2026 11:40:16 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id A984A40475\n for ; Thu, 16 Apr 2026 11:40:15 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-HRIe96FFPWqaQpJJXgMH5w-1; Thu,\n 16 Apr 2026 07:40:09 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4110518005AB; Thu, 16 Apr 2026 11:40:07 +0000 (UTC)","from ShadowPeak.redhat.com (unknown [10.44.32.76])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id BB88D180047F; Thu, 16 Apr 2026 11:40:01 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9AC566070A","OpenDKIM Filter v2.11.0 smtp4.osuosl.org A984A40475"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776339617;\n\tbh=7y4RG+Ooy20ucTBsnvZrm2OADKlaSNt80O0jTVn3eCg=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=RN5bG8JhyaiEtZLGOvVE2s6EsxLRm6Sn2iCORt0GQZMXDg3pJo5kMWVbbmC4jvB5a\n\t nmwPM66/dRCdAGrTyF3o0WSScXAhR8MI8q1Yii4h5M+V+U4oo2TXfbnEgoBGy0WjQt\n\t SPTtNbad9CkbVIoJj7/r6x0Vc8RQbE3nu3ZgluViceAA8LD8spt+LDbCpfbE7hQ8qN\n\t hpq+MlGVWY5YZeDm8qjUOOBTtb5Wut2zlAQddi7IcxQWSI2Bq1KjgD5VUABYyCWpGX\n\t xmJ4vl2UXyTIyj5Ocz2+dlhtqMLF0E3aq2i67ErlBTuEHt9vuATdmS28SxouJzcqa2\n\t SMhb+xF09S06Q==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org A984A40475","X-MC-Unique":"HRIe96FFPWqaQpJJXgMH5w-1","X-Mimecast-MFC-AGG-ID":"HRIe96FFPWqaQpJJXgMH5w_1776339607","From":"Petr Oros ","To":"netdev@vger.kernel.org","Date":"Thu, 16 Apr 2026 13:39:51 +0200","Message-ID":"<20260416113952.389405-2-poros@redhat.com>","In-Reply-To":"<20260416113952.389405-1-poros@redhat.com>","References":"<20260416113952.389405-1-poros@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-MFC-PROC-ID":"nYxOn0IWV9XyDlr3qooWdZG8OltPQ8oRJ7XIon9fLP8_1776339607","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776339614;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7y4RG+Ooy20ucTBsnvZrm2OADKlaSNt80O0jTVn3eCg=;\n b=hUL+B/VIL8Dd+1KzQ34d6etID/VtiHHOcSXk3C1ZrXM4qJgVn77yajwp5uRxXUQNP76xVM\n 985mExDzgSgnG/CNwXmifPP1fGCEieU3KZM3r4k1cCqoTlbRmMvUB1hgPCAfvM9aDsXt33\n 7GTPb+K6iuNimWN/bXLl4DoyIwB/8Pw=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp4.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=hUL+B/VI"],"Subject":"[Intel-wired-lan] [PATCH net v6 1/2] dpll: export\n __dpll_pin_change_ntf() for use under dpll_lock","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Ivan Vecera , Jiri Pirko ,\n Rinitha S ,\n Przemek Kitszel ,\n Eric Dumazet ,\n Arkadiusz Kubalewski ,\n Aleksandr Loktionov ,\n Andrew Lunn ,\n Tony Nguyen ,\n Simon Horman , Jakub Kicinski ,\n Jacob Keller ,\n Vadim Fedorenko , Paolo Abeni ,\n \"David S. Miller\" , linux-kernel@vger.kernel.org,\n intel-wired-lan@lists.osuosl.org","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Ivan Vecera \n\nExport __dpll_pin_change_ntf() so that drivers can send pin change\nnotifications from within pin callbacks, which are already called\nunder dpll_lock. Using dpll_pin_change_ntf() in that context would\ndeadlock.\n\nAdd lockdep_assert_held() to catch misuse without the lock held.\n\nSigned-off-by: Ivan Vecera \nSigned-off-by: Petr Oros \n---\n drivers/dpll/dpll_netlink.c | 10 ++++++++++\n drivers/dpll/dpll_netlink.h | 2 --\n include/linux/dpll.h | 1 +\n 3 files changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c\nindex 83cbd64abf5a47..95ae786e98aab3 100644\n--- a/drivers/dpll/dpll_netlink.c\n+++ b/drivers/dpll/dpll_netlink.c\n@@ -842,11 +842,21 @@ int dpll_pin_delete_ntf(struct dpll_pin *pin)\n \treturn dpll_pin_event_send(DPLL_CMD_PIN_DELETE_NTF, pin);\n }\n \n+/**\n+ * __dpll_pin_change_ntf - notify that the pin has been changed\n+ * @pin: registered pin pointer\n+ *\n+ * Context: caller must hold dpll_lock. Suitable for use inside pin\n+ * callbacks which are already invoked under dpll_lock.\n+ * Return: 0 if succeeds, error code otherwise.\n+ */\n int __dpll_pin_change_ntf(struct dpll_pin *pin)\n {\n+\tlockdep_assert_held(&dpll_lock);\n \tdpll_pin_notify(pin, DPLL_PIN_CHANGED);\n \treturn dpll_pin_event_send(DPLL_CMD_PIN_CHANGE_NTF, pin);\n }\n+EXPORT_SYMBOL_GPL(__dpll_pin_change_ntf);\n \n /**\n * dpll_pin_change_ntf - notify that the pin has been changed\ndiff --git a/drivers/dpll/dpll_netlink.h b/drivers/dpll/dpll_netlink.h\nindex dd28b56d27c56d..a9cfd55f57fc42 100644\n--- a/drivers/dpll/dpll_netlink.h\n+++ b/drivers/dpll/dpll_netlink.h\n@@ -11,5 +11,3 @@ int dpll_device_delete_ntf(struct dpll_device *dpll);\n int dpll_pin_create_ntf(struct dpll_pin *pin);\n \n int dpll_pin_delete_ntf(struct dpll_pin *pin);\n-\n-int __dpll_pin_change_ntf(struct dpll_pin *pin);\ndiff --git a/include/linux/dpll.h b/include/linux/dpll.h\nindex 2ce295b46b8cdc..8f97120ee7b37d 100644\n--- a/include/linux/dpll.h\n+++ b/include/linux/dpll.h\n@@ -276,6 +276,7 @@ int dpll_pin_ref_sync_pair_add(struct dpll_pin *pin,\n \n int dpll_device_change_ntf(struct dpll_device *dpll);\n \n+int __dpll_pin_change_ntf(struct dpll_pin *pin);\n int dpll_pin_change_ntf(struct dpll_pin *pin);\n \n int register_dpll_notifier(struct notifier_block *nb);\n","prefixes":["net","v6","1/2"]}