{"id":2223874,"url":"http://patchwork.ozlabs.org/api/patches/2223874/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260416093927.602613-4-daniel@thingy.jp/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416093927.602613-4-daniel@thingy.jp>","list_archive_url":null,"date":"2026-04-16T09:39:22","name":"[v5,3/8] timer: goldfish: Use __raw_readl()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0d9dc5d4ae1bebe597a4f727e1cb880cd427c29b","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/people/85408/?format=json","name":"Daniel Palmer","email":"daniel@thingy.jp"},"delegate":{"id":14103,"url":"http://patchwork.ozlabs.org/api/users/14103/?format=json","username":"spectrum","first_name":"Angelo","last_name":"Dureghello","email":"sysamfw@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260416093927.602613-4-daniel@thingy.jp/mbox/","series":[{"id":500127,"url":"http://patchwork.ozlabs.org/api/series/500127/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500127","date":"2026-04-16T09:39:20","name":"Add virtio-mmio support to m68k virt machine","version":5,"mbox":"http://patchwork.ozlabs.org/series/500127/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223874/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223874/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=k8ETBCSl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"k8ETBCSl\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxCgC2p2kz1yCv\n\tfor ; Thu, 16 Apr 2026 19:40:39 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E284884258;\n\tThu, 16 Apr 2026 11:40:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 5E62684246; Thu, 16 Apr 2026 11:40:08 +0200 (CEST)","from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com\n [IPv6:2607:f8b0:4864:20::42d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 298CA8407E\n for ; Thu, 16 Apr 2026 11:40:06 +0200 (CEST)","by mail-pf1-x42d.google.com with SMTP id\n d2e1a72fcca58-82a655cfab5so6364939b3a.1\n for ; Thu, 16 Apr 2026 02:40:06 -0700 (PDT)","from kinako.work.home.arpa\n (p1329195-ipxg00a01sizuokaden.shizuoka.ocn.ne.jp. [114.145.5.195])\n by smtp.googlemail.com with ESMTPSA id\n 41be03b00d2f7-c79581a2fc2sm4423568a12.21.2026.04.16.02.40.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 02:40:04 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1776332404; x=1776937204; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Y13x06t9MNZeSMACuzaERlgtCziZSbpHJl/qeN8+ObQ=;\n b=k8ETBCSltjoTvaq5Uh46MjM9DM0nus+6XDjZGu0r7n4XdnllS+b1dt8Nd7fwHo7J3W\n nQxZAj/f5xP/UXmmmcKXun533bXGmj4KUkodVQkkfY7BBkWfht4tARFtoHCBWhSrGFSp\n sw2iuOJFNvQVSJzJzmvPMLm5CDs26fyKQ83MM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776332404; x=1776937204;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Y13x06t9MNZeSMACuzaERlgtCziZSbpHJl/qeN8+ObQ=;\n b=ck0h5iq2fucfH/u1xF1T1F1qzJ7HLB52uJUL9wfp1mzc1CdJWnfS5zKcYXTHAZp06S\n uWdwC9RryIzSpDDN/6PyZzxocANrah33nyS/M3rrijk/sMq+zRlWuMXd5mtLB83mdyKT\n OaanHK61iY8Zya+b5REmVV0E+uioXgPu8aYlW/g2AE3IEGfJZpOQbjwq9eKillrf/yqi\n /Obu7dNscAyAC+TmPcBXb3w04Pbh9NV0Zi2NMoPQAfvFUd247pHkJzl0/qdNrskHAOmw\n kugoq6GRv8fUuUaHLRoGXBGPxw+PeecHQJzCNchpgZbxkI6AB9122D1K1+14VoJzmVgH\n mHZg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/p7IvanA23FISKhA7J4snmXWL6PdmGtUA3708Kn8wszudQc9IU1vgf9fVDcj9ubME1yxVlc/g=@lists.denx.de","X-Gm-Message-State":"AOJu0YwK+wOqdexNLmKBv75O5lStM2pUWIBJA2WOodMR1wKLZTZX3PIb\n gMJL8EH5QB80HJojV5bMiZJPHhjalkJsDDtiM8M1LhvEHjc/Jn0SbHRVY5M0wEc7Tlo=","X-Gm-Gg":"AeBDiesE19oxJMn3do5kp6F8jHFLuaRiSvomp/QX7QbAXcgPXEoAt/jcpadW/cKY5Xu\n zPWYme9h9UHZ0ZX0U2ckDAbv4fPoLPkhKVhFEVabLhaHPctpYhFsumKrl135KBtI/WQb9Dlmn7t\n 1weS/eX312XMSeRO6f2rFvAWxBIq4+P7lX2DgTnYRht1Jr+8xeOcvcWp7FTOlXgZ7KnLHgVIbcv\n VnefpnAhCGV+aLQT0zUCL4TMIonFiTkM+QjuOVnpRCDXDLVOHofYW1Y8RXFqcuA5kaIkf/xY7+O\n v5sc7hhtBAMMkFbSsR3NEfSzNL6tL7tKdEfb2Ru8uxY95xWkVLIUgrMHgKCE3hltmoirbc2kmRs\n i6Jco8/Y/FOLSBAlfrjpBkNl45zZcjLiwXVCe1M5K9g+KwtkxocjKIOfdDoZqpSzylqU34aXKzi\n v0e2MCOVtw6mKvvA054HR47SyMa2fI+VQDHZUxgu/Kw8wupXLPYs3ha1b55cbN54mbGkpn2XFrd\n wivFw7J7mxEtQ==","X-Received":"by 2002:a05:6a20:9188:b0:399:196:1430 with SMTP id\n adf61e73a8af0-39fe3d82535mr27711530637.20.1776332404629;\n Thu, 16 Apr 2026 02:40:04 -0700 (PDT)","From":"Daniel Palmer ","To":"visitorckw@gmail.com,\n\tangelo@kernel-space.org,\n\tbmeng.cn@gmail.com","Cc":"sjg@chromium.org, u-boot@lists.denx.de, Daniel Palmer ","Subject":"[PATCH v5 3/8] timer: goldfish: Use __raw_readl()","Date":"Thu, 16 Apr 2026 18:39:22 +0900","Message-ID":"<20260416093927.602613-4-daniel@thingy.jp>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260416093927.602613-1-daniel@thingy.jp>","References":"<20260416093927.602613-1-daniel@thingy.jp>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Kuan-Wei Chiu \n\nThe Goldfish timer registers are native endian, so they act as\nbig-endian on the m68k virt machine. Currently, this driver uses\nreadl(), which works by luck because it's currently broken on m68k.\n\nUse __raw_readl() instead to avoid breaking this driver when the\nendianness of readl() is fixed.\n\nSigned-off-by: Kuan-Wei Chiu \nTested-by: Daniel Palmer \nSigned-off-by: Daniel Palmer \n---\n drivers/timer/goldfish_timer.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/timer/goldfish_timer.c b/drivers/timer/goldfish_timer.c\nindex 70673bbd93c2..91277d7932ac 100644\n--- a/drivers/timer/goldfish_timer.c\n+++ b/drivers/timer/goldfish_timer.c\n@@ -31,8 +31,8 @@ static u64 goldfish_timer_get_count(struct udevice *dev)\n \t * We must read LOW before HIGH to latch the high 32-bit value\n \t * and ensure a consistent 64-bit timestamp.\n \t */\n-\tlow = readl(priv->base + TIMER_TIME_LOW);\n-\thigh = readl(priv->base + TIMER_TIME_HIGH);\n+\tlow = __raw_readl(priv->base + TIMER_TIME_LOW);\n+\thigh = __raw_readl(priv->base + TIMER_TIME_HIGH);\n \n \ttime = ((u64)high << 32) | low;\n \n","prefixes":["v5","3/8"]}