{"id":2223873,"url":"http://patchwork.ozlabs.org/api/patches/2223873/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260416093927.602613-3-daniel@thingy.jp/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416093927.602613-3-daniel@thingy.jp>","list_archive_url":null,"date":"2026-04-16T09:39:21","name":"[v5,2/8] rtc: goldfish: Use __raw_readl() and __raw_writel()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bee8227dea7e1b4d9774962ac24cae0bc1460245","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/people/85408/?format=json","name":"Daniel Palmer","email":"daniel@thingy.jp"},"delegate":{"id":14103,"url":"http://patchwork.ozlabs.org/api/users/14103/?format=json","username":"spectrum","first_name":"Angelo","last_name":"Dureghello","email":"sysamfw@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260416093927.602613-3-daniel@thingy.jp/mbox/","series":[{"id":500127,"url":"http://patchwork.ozlabs.org/api/series/500127/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500127","date":"2026-04-16T09:39:20","name":"Add virtio-mmio support to m68k virt machine","version":5,"mbox":"http://patchwork.ozlabs.org/series/500127/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223873/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223873/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=CzOwZbS1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"CzOwZbS1\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxCg166sZz1yCv\n\tfor ; Thu, 16 Apr 2026 19:40:29 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A5B2C8423F;\n\tThu, 16 Apr 2026 11:40:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 79C0984105; Thu, 16 Apr 2026 11:40:07 +0200 (CEST)","from mail-pg1-x530.google.com (mail-pg1-x530.google.com\n [IPv6:2607:f8b0:4864:20::530])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 638A284105\n for ; Thu, 16 Apr 2026 11:40:04 +0200 (CEST)","by mail-pg1-x530.google.com with SMTP id\n 41be03b00d2f7-c795a88e8acso590689a12.3\n for ; Thu, 16 Apr 2026 02:40:04 -0700 (PDT)","from kinako.work.home.arpa\n (p1329195-ipxg00a01sizuokaden.shizuoka.ocn.ne.jp. [114.145.5.195])\n by smtp.googlemail.com with ESMTPSA id\n 41be03b00d2f7-c79581a2fc2sm4423568a12.21.2026.04.16.02.40.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 02:40:02 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1776332403; x=1776937203; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nMlSqEMzLHIBrMWBPw3/su0lh/eopHFl9flEYxjRn38=;\n b=CzOwZbS1oRR4/2GwTl8EB3z4PDk6ZTCJP2rvqi7I5pNBpcngWqWL3orySMtd8wGEHq\n pi6eO/X5D1H1rFW1AQN0QcCALNzF5IAaQG/y56tKrWxOC9NT7y2oivApAdE3yXYC0juU\n 16TpSAk2VfQ/wDesmsWWxY8o24SuTVmpSmad8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776332403; x=1776937203;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=nMlSqEMzLHIBrMWBPw3/su0lh/eopHFl9flEYxjRn38=;\n b=EMj16M4kYP+wC4pC5UUkKTRZiEZ//hcUENpDq75zNRsRHgs3WCk3g/3HjGM7+wnlI5\n BJaPSyvgHnEJzBsOh4fvQPPQtymkno7Yx88PjtQ7/LMYoYBzQDSJKtH5lU55DAjKxEEJ\n gv4Y6khKx5pYZU0omjG9pT84NhB/3rITmQW0xxNZRClXQwh+LX2avmTgU7G9JRxs3Asr\n I5GvhT9+zT8amKdXUQonJhULRns97H/bwRMxB7AbX2OcqvAmnCOVaIqRZYFMUoLtT2E6\n rqwnP1gNAxzwjt+QxWYkGEmbkfBQnNitAqR4MfLVP6C65Z6Z178Q52e5DizeopzRwqVw\n DkZQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/3JkAnQa3hw7rUX+9YJJHpe1vlZzd/V4exNdhRjXT7dTNcd9iJWFjY1k7r9pThlYveEu+uYqs=@lists.denx.de","X-Gm-Message-State":"AOJu0YxSaenvhqYhIpScb8U4eTN0NCWUB6oV0xkSAkKXabg59AqIOYJm\n HnOjj4BWo0eGb0Z75f3noqi/F7xSB+zn8nVvQ7nEO6QssFu8nX9UZPpr9QNTZMQyZjI=","X-Gm-Gg":"AeBDievr7KK+6NTU3a69tQ8XKSUwmjU7XfPOycLchc2r5NWevrv+a2p1Y2XsWHYXXYF\n B2AIlLwAqRv5P9Y2RfL3P9n07MV+AwtFS5X5EZ1mdDUrfpW8zlPaifd9ZJ3tcCjW5qlh3ofKf82\n GTel5sT85caK361CLYjQ3r26T1NllmnAsWHJtkjX+qNjurKV9m0F2lFR6aGYZe1YbsdXBDrtrv8\n gkr6+r2uMOt+aqJ2iNfzeGrOGCAUtbrKWtbAFeA1fnORP7KUNiQSOY12xW5hlSzj7iRkDcOYHNI\n upXKD/UtDt+dnXyyrGVTuH94mPV6UuG/3XEkprXjhLTv1Ge+uooWrKgiPoZWMRstFGl80GsS46y\n NwLI+dMrgeFaEtYYeHbqPiuA7x9eYsyLqugSVtKLKazuFyKhJonswG7b+W2dKpB3T0YN5PKP5EF\n Enexuvc25vcIPlCpS8uAtj5sfgn9jshLNjXe0P6IcM22NmyKjsPJ8T+XaIZqGIrkqA0Yhgd3wY4\n uyweYJy1yJ4SA==","X-Received":"by 2002:a05:6a21:644d:b0:39b:d937:8020 with SMTP id\n adf61e73a8af0-39fe400f835mr22638395637.42.1776332402900;\n Thu, 16 Apr 2026 02:40:02 -0700 (PDT)","From":"Daniel Palmer ","To":"visitorckw@gmail.com,\n\tangelo@kernel-space.org,\n\tbmeng.cn@gmail.com","Cc":"sjg@chromium.org, u-boot@lists.denx.de, Daniel Palmer ","Subject":"[PATCH v5 2/8] rtc: goldfish: Use __raw_readl() and __raw_writel()","Date":"Thu, 16 Apr 2026 18:39:21 +0900","Message-ID":"<20260416093927.602613-3-daniel@thingy.jp>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260416093927.602613-1-daniel@thingy.jp>","References":"<20260416093927.602613-1-daniel@thingy.jp>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Kuan-Wei Chiu \n\nIn QEMU, the Goldfish RTC is explicitly instantiated as a big-endian\ndevice on the m68k virt machine (via the 'big-endian=true' property).\nCurrently, this driver uses ioread32() and iowrite32(), which works\nby luck because the underlying readl() and writel() are currently\nbroken on m68k.\n\nUse __raw_readl() and __raw_writel() instead to avoid breaking this\ndriver when the endianness of readl() and writel() is fixed.\n\nSigned-off-by: Kuan-Wei Chiu \nTested-by: Daniel Palmer \nSigned-off-by: Daniel Palmer \n---\n drivers/rtc/goldfish_rtc.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/rtc/goldfish_rtc.c b/drivers/rtc/goldfish_rtc.c\nindex d2991ca67192..4892a63f8d80 100644\n--- a/drivers/rtc/goldfish_rtc.c\n+++ b/drivers/rtc/goldfish_rtc.c\n@@ -40,8 +40,8 @@ static int goldfish_rtc_get(struct udevice *dev, struct rtc_time *time)\n \tu64 time_low;\n \tu64 now;\n \n-\ttime_low = ioread32(base + GOLDFISH_TIME_LOW);\n-\ttime_high = ioread32(base + GOLDFISH_TIME_HIGH);\n+\ttime_low = __raw_readl(base + GOLDFISH_TIME_LOW);\n+\ttime_high = __raw_readl(base + GOLDFISH_TIME_HIGH);\n \tnow = (time_high << 32) | time_low;\n \n \tdo_div(now, 1000000000U);\n@@ -62,8 +62,8 @@ static int goldfish_rtc_set(struct udevice *dev, const struct rtc_time *time)\n \t\treturn -EINVAL;\n \n \tnow = rtc_mktime(time) * 1000000000ULL;\n-\tiowrite32(now >> 32, base + GOLDFISH_TIME_HIGH);\n-\tiowrite32(now, base + GOLDFISH_TIME_LOW);\n+\t__raw_writel(now >> 32, base + GOLDFISH_TIME_HIGH);\n+\t__raw_writel(now, base + GOLDFISH_TIME_LOW);\n \n \tif (time->tm_isdst > 0)\n \t\tpriv->isdst = 1;\n","prefixes":["v5","2/8"]}