{"id":2223535,"url":"http://patchwork.ozlabs.org/api/patches/2223535/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-2-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260415142841.3222399-2-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-04-15T14:28:36","name":"[iwl-net,v3,1/6] ixgbe: fix SWFW semaphore timeout for X550 family","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"a0b710ab824f687d2694a9b0d90a1e8f581ac564","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/?format=json","name":"Aleksandr Loktionov","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-2-aleksandr.loktionov@intel.com/mbox/","series":[{"id":499995,"url":"http://patchwork.ozlabs.org/api/series/499995/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499995","date":"2026-04-15T14:28:35","name":"ixgbe: six bug fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/499995/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223535/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223535/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=eEddseY7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwk6G1pjPz1yHc\n\tfor ; Thu, 16 Apr 2026 00:28:54 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id EA7924B0ED;\n\tWed, 15 Apr 2026 14:28:51 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id UHn1yJIM_1MU; Wed, 15 Apr 2026 14:28:50 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 931654B08F;\n\tWed, 15 Apr 2026 14:28:50 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id D2217283\n for ; Wed, 15 Apr 2026 14:28:47 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id B7C2D4AF73\n for ; Wed, 15 Apr 2026 14:28:46 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Gr95nognu6PK for ;\n Wed, 15 Apr 2026 14:28:45 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp4.osuosl.org (Postfix) with ESMTPS id B95C54B08F\n for ; Wed, 15 Apr 2026 14:28:45 +0000 (UTC)","from orviesa003.jf.intel.com ([10.64.159.143])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 07:28:45 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa003.jf.intel.com with ESMTP; 15 Apr 2026 07:28:43 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 931654B08F","OpenDKIM Filter v2.11.0 smtp4.osuosl.org B95C54B08F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776263330;\n\tbh=OcZDITMIuszZw8Rk9/XENma4MVinhqEcJqCy5y9ZdC0=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=eEddseY7Yj83BxrkpoYjoH6/DoqWZ5t4Q/Nli4zYwUHLTKG4vJpDF6ibE3ZByow9+\n\t p5WvqvFkXJhWX8E6XUYiroRJlCo7Pve0Q2loUMCtDqGZHmAB/qHFoqnQQs2Snlbznn\n\t KsEa7UI41+v3x0ssWfwuRmLlJVUA15OacDNbaE6SQe3N0wJz68v0ReMPUjHg4PeZkR\n\t vI/vOXLsU/ohc5jvFwW5Qm+1YQE/8tDB2/wX/q4yEmxNpwQSeDD0VIBDZtGEKme9ve\n\t KveXHHJVa6SnRC9l2Xo4YHfN8EOsh/YJWvpij9n+nho6Q6wqNcKfiAyE5zhY98bGSM\n\t hu3ngSRjVj+Og==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org B95C54B08F","X-CSE-ConnectionGUID":["7K5yiF+VSfKyilbjddlI7w==","p8WwbvmeQryNK1OaKDX03Q=="],"X-CSE-MsgGUID":["1iRrIEQjRnK8/WuKtoMecQ==","LFzYkiuVSZuRDUCnJd0bmQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11760\"; a=\"77423729\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"77423729\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"234467829\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org, Simon Horman ,\n Jacob Keller ","Date":"Wed, 15 Apr 2026 16:28:36 +0200","Message-ID":"<20260415142841.3222399-2-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260415142841.3222399-1-aleksandr.loktionov@intel.com>","References":"<20260415142841.3222399-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776263325; x=1807799325;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=GUF4ORCJjHX1uOeyka72W243jz1bbjHEIX86BDqtL08=;\n b=nDdDUI5kNjOW8zdwoPmL/eBlW6q3GxuvnhVudc1gJB9uOgMK0d/qVHcW\n DiJtK/eVvxGf590rUHu3JZgTNJQvOrxObU/IrEXQhlc+ji744cYdT2Ngs\n 76E6QVcIacXxURkKvcd3/cIDzMOBYP+mHSZXXL0ctoLF5YECxNcmc7iOs\n MgSfZCk0oaRrSudxM6cgY7hOVD06Rhcg8QBPI8pVkckQbr6iEFgdQ9mIM\n Wbi99VnfUTxlmnsYRG9ZCUGl+0AG8NF0lVyMLezE6BEx9as2V6XeasU0M\n FQJcCxkuoEl2i05T4CFKD7DE0fXp08V9p9L8Sa1hgjhS2npQf6FnFdxfG\n A==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=nDdDUI5k"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v3 1/6] ixgbe: fix SWFW semaphore\n timeout for X550 family","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"According to FW documentation, the most time-consuming FW operation is\nShadow RAM (SR) dump which takes up to 3.2 seconds. For X550 family\ndevices the module-update FW command can take over 4.5 s. The default\nsemaphore loop runs 200 iterations with a 5 ms sleep each, giving a\nmaximum wait of 1 s -- not \"200 ms\" as previously stated in error.\nThis is insufficient for X550 family FW update operations and causes\nspurious EBUSY failures.\n\nExtend the SW/FW semaphore timeout from 1 s to 5 s (1000 iterations x\n5 ms) for all three X550 variants: ixgbe_mac_X550, ixgbe_mac_X550EM_x,\nand ixgbe_mac_x550em_a. All three share the same FW and exhibit the\nsame worst-case latency. Use three explicit mac.type comparisons rather\nthan a range check so future MAC additions are not inadvertently\ncaptured.\n\nThe timeout variable is set immediately before the loop so the intent\nis clear, with an inline comment stating the resulting maximum delay.\n\nFixes: 030eaece2d77 (\"ixgbe: Add x550 SW/FW semaphore support\")\nSuggested-by: Soumen Karmakar \nSuggested-by: Marta Plantykow \nCc: stable@vger.kernel.org\nSigned-off-by: Aleksandr Loktionov \nReviewed-by: Simon Horman \nReviewed-by: Jacob Keller \n---\nv2 -> v3:\n - Add Reviewed-by: Simon Horman, Reviewed-by: Jacob Keller; no code\n change (Jacob suggested read_poll_timeout() but accepted as-is).\n\nv1 -> v2:\n - Squash with 0015 (X550EM extension); fix commit message (\"200ms\" was\n wrong, actual default is 1 s); replace >= / <= range check with three\n explicit mac.type == comparisons per Tony Nguyen.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\nindex e67e2fe..a3c8f51 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n@@ -577,6 +577,15 @@ int ixgbe_acquire_swfw_sync_X540(struct ixgbe_hw *hw, u32 mask)\n \n \tswmask |= swi2c_mask;\n \tfwmask |= swi2c_mask << 2;\n+\t/* Extend to 5 s (1000 x 5 ms) for X550 family; default is 1 s\n+\t * (200 x 5 ms). FW SR-dump takes up to 3.2 s; module-update up\n+\t * to 4.5 s.\n+\t */\n+\tif (hw->mac.type == ixgbe_mac_X550 ||\n+\t hw->mac.type == ixgbe_mac_X550EM_x ||\n+\t hw->mac.type == ixgbe_mac_x550em_a)\n+\t\ttimeout = 1000;\n+\n \tfor (i = 0; i < timeout; i++) {\n \t\t/* SW NVM semaphore bit is used for access to all\n \t\t * SW_FW_SYNC bits (not just NVM)\n","prefixes":["iwl-net","v3","1/6"]}