{"id":2223413,"url":"http://patchwork.ozlabs.org/api/patches/2223413/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260415094014.88977-2-mehmet.basaran@canonical.com/","project":{"id":15,"url":"http://patchwork.ozlabs.org/api/projects/15/?format=json","name":"Ubuntu Kernel","link_name":"ubuntu-kernel","list_id":"kernel-team.lists.ubuntu.com","list_email":"kernel-team@lists.ubuntu.com","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260415094014.88977-2-mehmet.basaran@canonical.com>","list_archive_url":null,"date":"2026-04-15T09:40:14","name":"[REGR-FIX,N,1/1] UBUNTU: SAUCE: Fix skb_vlan_inet_prepare() usage","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c1e0ff3e7ad16ce33f23c153e3f4d01f63898b79","submitter":{"id":89305,"url":"http://patchwork.ozlabs.org/api/people/89305/?format=json","name":"Mehmet Basaran","email":"mehmet.basaran@canonical.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260415094014.88977-2-mehmet.basaran@canonical.com/mbox/","series":[{"id":499950,"url":"http://patchwork.ozlabs.org/api/series/499950/?format=json","web_url":"http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=499950","date":"2026-04-15T09:40:13","name":"Fix Upstream stable v6.6.122, v6.12.67, v6.12.68","version":1,"mbox":"http://patchwork.ozlabs.org/series/499950/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223413/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223413/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=UC9GKUAt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwbjV1BBqz1yHM\n\tfor ; Wed, 15 Apr 2026 19:40:29 +1000 (AEST)","from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1wCwjL-0001oL-KX; Wed, 15 Apr 2026 09:40:19 +0000","from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from )\n id 1wCwjK-0001o2-Jm\n for kernel-team@lists.ubuntu.com; Wed, 15 Apr 2026 09:40:18 +0000","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 529763F6B1\n for ; Wed, 15 Apr 2026 09:40:18 +0000 (UTC)","by mail-wm1-f70.google.com with SMTP id\n 5b1f17b1804b1-488c74405ecso41474355e9.1\n for ; Wed, 15 Apr 2026 02:40:18 -0700 (PDT)","from localhost ([149.86.141.159]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ede249fasm113514555e9.7.2026.04.15.02.40.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 02:40:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1776246018;\n bh=4EJFo3ROYwjF3DYfV85gAfKLTgwqmZipRzrusbTxMZ8=;\n h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=UC9GKUAtI+wYhfNnSRkn5YQMugvhrr/u3/KqKFNsXtIhUHFo+5ONoIuy74Tp6mPQw\n nPxd6RWTU4ywG2Uienox6R1dnMAYr/ucggSfwYE/LCBC1q8cqAOz2UgseKJeF5nG5q\n T2UFCp1uKAP+E45AKtUtfPXYgSzEW8EZlq7Uw5KmsveZEcdyGVp55A861hc4E4Fs3D\n B7zDYOhyxYbnzpXNWvwCp5svxSvLo5IGivZyYsmw9AiSXR304B1j8gCBtmiu0exnFM\n lG9A3cjSFIhH/6PRgoMEMY8TvSIDUG+gGzOAVNIJbDQQskeKi7Okj9mj+kAR/FSudR\n NssY8xq67WDjYpTbPlZ4hf8iNvJT8gNmeqyHSh4Qsntpg/w2zbH3qI/o6+Xg8Lfl9E\n 6ocJgc4T+Gb2CLHq2rq+DwUIVMYpeXO4MjShAau0K4z+nEVhBNavgjQSI+okQREYtC\n wf0QtpZo+FLSpRdGMBFfCJEGJ6Im3yFjQ9UZIxKNBaSDaUCU66JROzlkZx9FvphdnY\n L4grJ27Q3HI0XbV0Wm71LuCoDfrgtUD7EUAdiwq8XQ7YGPLuqB3gY+KFF1fdH66Kcz\n FT0qICsmH+Jo+PrVfKsCnI1QUXTZxr/HEuR0DLJqX8tZhn+Q8QGqKGbuMaQ2OZ9S34\n nYabnclO0QvAdHS4xcBO3i54=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776246017; x=1776850817;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4EJFo3ROYwjF3DYfV85gAfKLTgwqmZipRzrusbTxMZ8=;\n b=C3aeQoCIOXlEDBLiW7CDsDn4yDOvWCXDvI4VGElKRm0/cwGWGW4bKxdjMxLR1duVdI\n S9YUEwNN56sWdh87CciGEHqIMZlDn3yrcewoCY69d3zKnzqD15702kYeGbUwxjrHymNK\n JdvO5rwQ40faCj2YIgRbzd+q0BWCpwK21voIYjsWa5Lm7ZGtBl7ayPUcSMbEeWXKPO2M\n xddY4CKw05OmZDa9f58Q85VQ5Hh2NwFOmeAYcmFx6wBfbFvLKR7Shd++18Tc3EW55qTr\n wClbw0PVUv6P3pa/N8TgTeyVVEaPi4aHWTgutwX3bEpdlqQD/sYM7+Xgj9o6OQ5ZlnfJ\n ayBw==","X-Gm-Message-State":"AOJu0YxBorA7OWobit2SYMrC+pfO67rAdxNYxEdYbVL+qKtVfecYYQNK\n l3DXYBNJPxDtQ0frkpW2YZAE7Yvse2DUY/w/xBJGhd1oeCZv12UCLuPHGWz88cecBxGzdgP/0Zr\n iXJHOKh5M2klqQHp++6SudlUrfs4W5tFNwSpDWlZkJTYyeFjDPCtXGSLOYcOOQlDOH5ueV/UWVb\n y7hOHzOr9JFX/OsDNQ","X-Gm-Gg":"AeBDieu4shEx3jUywjyqNk3F6TnsuTbiAWJb8JRJIe9QPXnr03Bc7kJQ81ZDkZmbgoA\n NDDG2tP+rtx5jffEJHIJSrG9374HxJKpEPvE6XCScRDeWXptg5qKloHVYeq8QPW+3drASk2iyGG\n dsw08YMCJyCTCEb9TotT0FYpZb/iCMxwOe31YC67U4b6C6LzWyEaYkC1POhOUCoJ5Fyt/xszcTF\n F6coj4PRHYOBv/Rj5Osop061TFmtFR1AQCcRaF4Vdcy2AoK3ZiqP9J6p2oMp8XPdualXH8zN20H\n 8ro07/QkYn4CQCblEJtccsTE+cjG7i8ZpABFBF1NKomJThjO2OfbbXv3ywxX3MjKFEBMwXWRK/e\n VOyTEdt8HokHtmzLdYArCTBvBPTd30d1Y3b5gQXXFfg==","X-Received":["by 2002:a05:600c:8218:b0:488:a14d:3d81 with SMTP id\n 5b1f17b1804b1-488d67c7034mr345611585e9.2.1776246017556;\n Wed, 15 Apr 2026 02:40:17 -0700 (PDT)","by 2002:a05:600c:8218:b0:488:a14d:3d81 with SMTP id\n 5b1f17b1804b1-488d67c7034mr345611065e9.2.1776246017093;\n Wed, 15 Apr 2026 02:40:17 -0700 (PDT)"],"From":"Mehmet Basaran ","To":"kernel-team@lists.ubuntu.com","Subject":"[REGR-FIX][N][PATCH 1/1] UBUNTU: SAUCE: Fix skb_vlan_inet_prepare()\n usage","Date":"Wed, 15 Apr 2026 12:40:14 +0300","Message-ID":"<20260415094014.88977-2-mehmet.basaran@canonical.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260415094014.88977-1-mehmet.basaran@canonical.com>","References":"<20260415094014.88977-1-mehmet.basaran@canonical.com>","MIME-Version":"1.0","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "},"content":"BugLink: https://bugs.launchpad.net/bugs/2146465\n\nUpstream stable changed net/ipv6/ip6_tunnel.c to use\nskb_vlan_inet_prepare() instead of pskb_inet_may_pull().\nHowever for newer kernels this change was made after\n \"net: tunnel: make skb_vlan_inet_prepare() return drop reasons\"\nwhich changed the return value of skb_blan_inet_prepare() from\nboolean to int. Which means successful execution is signalled\nby rc=0 which is false.\nTo keep delta minimal, just change the expected return value to\nassume success when true is returned. This stops incorrect drops.\n\nFixes: f842901be344 (\"ip6_tunnel: use skb_vlan_inet_prepare() in __ip6_tnl_rcv()\")\nSigned-off-by: Mehmet Basaran \n---\n net/ipv6/ip6_tunnel.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c\nindex 8a04feb2810b..d49d4637e6c7 100644\n--- a/net/ipv6/ip6_tunnel.c\n+++ b/net/ipv6/ip6_tunnel.c\n@@ -844,7 +844,7 @@ static int __ip6_tnl_rcv(struct ip6_tnl *tunnel, struct sk_buff *skb,\n \n \tskb_reset_network_header(skb);\n \n-\tif (skb_vlan_inet_prepare(skb, true)) {\n+\tif (!skb_vlan_inet_prepare(skb, true)) {\n \t\tDEV_STATS_INC(tunnel->dev, rx_length_errors);\n \t\tDEV_STATS_INC(tunnel->dev, rx_errors);\n \t\tgoto drop;\n","prefixes":["REGR-FIX","N","1/1"]}