{"id":2223386,"url":"http://patchwork.ozlabs.org/api/patches/2223386/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260415-pcie-intel-gw-v4-5-ad45d2418c8e@dev.tdt.de/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260415-pcie-intel-gw-v4-5-ad45d2418c8e@dev.tdt.de>","list_archive_url":null,"date":"2026-04-15T08:01:51","name":"[v4,5/7] PCI: intel-gw: Add start_link callback function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d6a6128d2a6e97ec7062e1388f696d2b4c175d14","submitter":{"id":72238,"url":"http://patchwork.ozlabs.org/api/people/72238/?format=json","name":"Florian Eckert","email":"fe@dev.tdt.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260415-pcie-intel-gw-v4-5-ad45d2418c8e@dev.tdt.de/mbox/","series":[{"id":499942,"url":"http://patchwork.ozlabs.org/api/series/499942/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499942","date":"2026-04-15T08:01:47","name":"PCI: intel-gw: Fixes to make the driver working again","version":4,"mbox":"http://patchwork.ozlabs.org/series/499942/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223386/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223386/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=temperror header.d=dev.tdt.de header.i=@dev.tdt.de header.a=rsa-sha256\n header.s=z1-selector1 header.b=WVp/r6yu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52536-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de\n header.b=\"WVp/r6yu\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.198.224.70","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=dev.tdt.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=dev.tdt.de"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwYvr3XpNz1yHM\n\tfor ; Wed, 15 Apr 2026 18:19:20 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9D61D30492A1\n\tfor ; Wed, 15 Apr 2026 08:19:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E1DC03CC9E6;\n\tWed, 15 Apr 2026 08:19:06 +0000 (UTC)","from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E9873AD527;\n\tWed, 15 Apr 2026 08:19:05 +0000 (UTC)","from [194.37.255.9] (helo=mxout.expurgate.net)\n\tby relay.expurgate.net with smtp (Exim 4.92)\n\t(envelope-from )\n\tid 1wCvC7-00BwXO-RI; Wed, 15 Apr 2026 10:01:55 +0200","from [195.243.126.94] (helo=securemail.tdt.de)\n\tby relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n\t(Exim 4.92)\n\t(envelope-from )\n\tid 1wCvC7-003sdd-9N; Wed, 15 Apr 2026 10:01:55 +0200","from securemail.tdt.de (localhost [127.0.0.1])\n\tby securemail.tdt.de (Postfix) with ESMTP id DA1B6240040;\n\tWed, 15 Apr 2026 10:01:54 +0200 (CEST)","from mail.dev.tdt.de (unknown [10.2.4.42])\n\tby securemail.tdt.de (Postfix) with ESMTP id D18E7240047;\n\tWed, 15 Apr 2026 10:01:54 +0200 (CEST)","from [10.2.3.40] (unknown [10.2.3.40])\n\tby mail.dev.tdt.de (Postfix) with ESMTPSA id AEE4E24028;\n\tWed, 15 Apr 2026 10:01:54 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776241146; cv=none;\n b=P64wS3tEyh1ivwe6eBwKGCImcEqRTxHSYpfoUjNOtlBq/flmpNYxHJk3Po9sD/f7lDUzdCNFc977bhRgqm4IiWyP7osCn+I0E7FNKNlGtDPlkubhdJy45R/OqHzm43ajjaAsgauQopUCx/MHGaLQi6eozBWm/SThDNm5d14gwfk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776241146; c=relaxed/simple;\n\tbh=1QhwwO0tMMhb5/PF/9cK8bvzkNyUt/Wf2sydrtsZXUc=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References:\n\t In-Reply-To:To:Cc;\n b=W40Sjyg3GC3wNnDf1SFeSHQ1YAhX0mHAPeBzTV/08htdOiVaSbYhoW0n2Tfhwj/gsXOZK67nlsAtoTtzjjooBt5ftnCQJoSd+FKi0y5UBzkguKoXdkMKzHtAriqlMWuSkl5ZW8HArlt5v7yCiEvgAiTYhcfvNBRmHs/8g6NjAGc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=dev.tdt.de;\n spf=pass smtp.mailfrom=dev.tdt.de;\n dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de\n header.b=WVp/r6yu; arc=none smtp.client-ip=91.198.224.70","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de;\n\ts=z1-selector1; t=1776240114;\n\tbh=3A2J+2MFklTaE6h9BZznlvghg/HLXg4vKOLkKJTaKbc=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=WVp/r6yuM+8liV0iBHcJkduZI7Ed7rwtZ2yntqBxD0cHSzGPcwpqolOp/nadP3e63\n\t hmBEafbvb6ZR+MADq9xuBIFas3yJfQIG0vEQcz104lwQzzn0dbNSPqlTwDJZXcXFNI\n\t 9G9E1gqjR9EoaZKDfxwWZJqkQa/R40mS+ZePgtPlswz9W8OyKJXlA7tBj722j0HzUJ\n\t Q7AZruP02RCGuBnCXAVH3144gaqahuLr24oIqW2wFLpVxIzymYqUAVz5snDg3bchDl\n\t TrWbzpBao4U7BNZtLwDFofOORzf1KkxzHGfzlpsdj9VN+3M3pe5d6M/4wH0Uwe3QMh\n\t LbCBo9p5eu5BA==","From":"Florian Eckert ","Date":"Wed, 15 Apr 2026 10:01:51 +0200 (CEST)","Subject":"[PATCH v4 5/7] PCI: intel-gw: Add start_link callback function","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-ID":"<20260415-pcie-intel-gw-v4-5-ad45d2418c8e@dev.tdt.de>","References":"<20260415-pcie-intel-gw-v4-0-ad45d2418c8e@dev.tdt.de>","In-Reply-To":"<20260415-pcie-intel-gw-v4-0-ad45d2418c8e@dev.tdt.de>","To":"Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?=\n\t=?utf-8?q?=C5=84ski?= ,\n Manivannan Sadhasivam , Rob Herring ,\n Bjorn Helgaas , Johan Hovold ,\n Sajid Dalvi , Ajay Agarwal ,\n Krzysztof Kozlowski , Conor Dooley ","Cc":"linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, Florian Eckert ,\n\tEckert.Florian@googlemail.com, ms@dev.tdt.de","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1776240111; l=3153;\n i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id;\n bh=1QhwwO0tMMhb5/PF/9cK8bvzkNyUt/Wf2sydrtsZXUc=;\n b=xZWea6SKVdk8phIcykeaa/lhRj/xE1Y9ygqH+pY5UY96jz7IKdcP9cj7gN61L3J8+881a41Sc\n /PFBb6JmNuoDX1FbkB+JcTEbKiSEPrGm/QuV7y8lPzoIZJSkQ8EVhRO","X-Developer-Key":"i=fe@dev.tdt.de; a=ed25519;\n pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk=","X-purgate-type":"clean","X-purgate":"clean","X-purgate-ID":"151534::1776240115-FBFF42EC-C76EFE1C/0/0"},"content":"The pcie-intel-gw driver has no start_link callback function. This commit\nadds the missing callback function so that the driver works again and does\nnot abort with the following error messages during probing.\n\n[ 2.512015] intel-gw-pcie d1000000.pcie: host bridge /soc/pcie@d1000000 ranges:\n[ 2.517868] intel-gw-pcie d1000000.pcie: MEM 0x00dc000000..0x00ddffffff -> 0x00dc000000\n[ 2.528450] intel-combo-phy d0c00000.combo-phy: Set combo mode: combophy[1]: mode: PCIe single lane mode\n[ 2.551619] intel-gw-pcie d1000000.pcie: No outbound iATU found\n[ 2.556060] intel-gw-pcie d1000000.pcie: Cannot initialize host\n[ 2.561901] intel-gw-pcie d1000000.pcie: probe with driver intel-gw-pcie failed with error -22\n[ 2.571041] intel-gw-pcie c1100000.pcie: host bridge /soc/pcie@c1100000 ranges:\n[ 2.577736] intel-gw-pcie c1100000.pcie: MEM 0x00ce000000..0x00cfffffff -> 0x00ce000000\n[ 2.588299] intel-combo-phy c0c00000.combo-phy: Set combo mode: combophy[3]: mode: PCIe single lane mode\n[ 2.611471] intel-gw-pcie c1100000.pcie: No outbound iATU found\n[ 2.615934] intel-gw-pcie c1100000.pcie: Cannot initialize host\n[ 2.621759] intel-gw-pcie c1100000.pcie: probe with driver intel-gw-pcie failed with error -22\n\nFixes: c5097b9869a1 (\"Revert \"PCI: dwc: Wait for link up only if link is started\"\")\nFixes: da56a1bfbab5 (\"PCI: dwc: Wait for link up only if link is started\")\nSigned-off-by: Florian Eckert \n---\n drivers/pci/controller/dwc/pcie-intel-gw.c | 24 +++++++++++-------------\n 1 file changed, 11 insertions(+), 13 deletions(-)","diff":"diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c\nindex 6d9499d954674a26a74bff56b7fb5759767424c0..afd933050c92ee31c477e0b1738ab1136bdcfbf6 100644\n--- a/drivers/pci/controller/dwc/pcie-intel-gw.c\n+++ b/drivers/pci/controller/dwc/pcie-intel-gw.c\n@@ -284,6 +284,16 @@ static void intel_pcie_turn_off(struct intel_pcie *pcie)\n \tpcie_rc_cfg_wr_mask(pcie, PCI_COMMAND, PCI_COMMAND_MEMORY, 0);\n }\n \n+static int intel_pcie_start_link(struct dw_pcie *pci)\n+{\n+\tstruct intel_pcie *pcie = dev_get_drvdata(pci->dev);\n+\n+\tintel_pcie_device_rst_deassert(pcie);\n+\tintel_pcie_ltssm_enable(pcie);\n+\n+\treturn 0;\n+}\n+\n static int intel_pcie_host_setup(struct intel_pcie *pcie)\n {\n \tint ret;\n@@ -310,25 +320,12 @@ static int intel_pcie_host_setup(struct intel_pcie *pcie)\n \tintel_pcie_link_setup(pcie);\n \tintel_pcie_init_n_fts(pci);\n \n-\tret = dw_pcie_setup_rc(&pci->pp);\n-\tif (ret)\n-\t\tgoto err;\n-\n \tdw_pcie_upconfig_setup(pci);\n \n-\tintel_pcie_device_rst_deassert(pcie);\n-\tintel_pcie_ltssm_enable(pcie);\n-\n-\tret = dw_pcie_wait_for_link(pci);\n-\tif (ret)\n-\t\tgoto err;\n-\n \tintel_pcie_core_irq_enable(pcie);\n \n \treturn 0;\n \n-err:\n-\tphy_exit(pcie->phy);\n phy_err:\n \tclk_disable_unprepare(pcie->core_clk);\n clk_err:\n@@ -386,6 +383,7 @@ static int intel_pcie_rc_init(struct dw_pcie_rp *pp)\n }\n \n static const struct dw_pcie_ops intel_pcie_ops = {\n+\t.start_link = intel_pcie_start_link,\n };\n \n static const struct dw_pcie_host_ops intel_pcie_dw_ops = {\n","prefixes":["v4","5/7"]}