{"id":2223365,"url":"http://patchwork.ozlabs.org/api/patches/2223365/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415064838.652297-4-joel@jms.id.au/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260415064838.652297-4-joel@jms.id.au>","list_archive_url":null,"date":"2026-04-15T06:48:35","name":"[v2,3/4] hw/riscv/boot: Warn if a ELF format file is loaded as a binary","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"70678d7b4fb82737017916e385167b874269748c","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/?format=json","name":"Joel Stanley","email":"joel@jms.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260415064838.652297-4-joel@jms.id.au/mbox/","series":[{"id":499931,"url":"http://patchwork.ozlabs.org/api/series/499931/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499931","date":"2026-04-15T06:48:32","name":"hw/riscv: Boot setup improvements","version":2,"mbox":"http://patchwork.ozlabs.org/series/499931/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223365/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223365/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=e/D8XYyD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwWwW5zQQz1yDF\n\tfor ; Wed, 15 Apr 2026 16:49:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCu3j-0001N9-4t; Wed, 15 Apr 2026 02:49:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCu3d-0001LW-Jb\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 02:49:05 -0400","from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCu3c-0001k4-0b\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 02:49:05 -0400","by mail-pl1-x62e.google.com with SMTP id\n d9443c01a7336-2aae146b604so46020285ad.3\n for ; Tue, 14 Apr 2026 23:49:03 -0700 (PDT)","from donnager-debian.. ([45.124.203.19])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b478142565sm10353195ad.37.2026.04.14.23.48.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 23:49:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776235743; x=1776840543; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date\n :message-id:reply-to;\n bh=saXM7xSssgxjzAfOLez7avcgUU6NwNqgzcU4H5W0wO8=;\n b=e/D8XYyDJvnLQd2gmxbYyXaRQdlsyudDAcq5iMSw7Mn3VIo6dhbFJVUUcTcP0JOBFA\n E4zwxfZx4zRFTHugN6IciuOtN6Ek5Wd3+L1LbZTt3lzyTHIzqUBNg7TTCp9io8x23etd\n /qGbjYiLMYQBd3xDIZCyz6OOlr6vkjyB9rNJcY8+XlZXus23tZQNp+QfI+b+DZM3x9DM\n rSPU0Kg5e66NCOE5/Hiyo5Ak8EW3PXCNFnQrwruoIFi1bi7KMEkQ7MPs03Dlc9MC5AsO\n GpnjDzgzN2qF7Xlqkoh9fgdDB7wWr6i37+uliTh5+StYR2yiVF6UgwsGdAWEeosNwfwu\n Qs2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776235743; x=1776840543;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:sender:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=saXM7xSssgxjzAfOLez7avcgUU6NwNqgzcU4H5W0wO8=;\n b=LRzPEmrxqFdfZtVt6lSt4Qne8XSD+nefskl6xiR+Z1sBPqvMeSy5bg83FAWAzaKy68\n UkbDFB+OxgBL86bBqW24Ce1wVjJDhCXlPMWHYz89Pttsffxc55urVF6YCGIKBbIRaZTt\n kzeuSyLKBHvOC3KintxbXudVF0/D9Fv3MMFGMWniujkUR0KfsgaNYH0Ftuwna4+zSN3/\n 3WO6A3EMvZByf4/RQvog//3cN8dpykkC3KQhA7iIGzwMZXT8zT6KrS251DqodjFxPc2w\n KbZtUX45ctFhjc1jhVK1Udm+6rglKOtbZSSHzpH6H9OMcDNJZ8sSBxtytgBlUFBXuRlF\n DZig==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+9nQH233ng/MgXrU6HRZpnL8f9ibUkaMnKc2iPoC7NVUvqafpQLk5uaqpj1DECbZ0IYQcr0c0VmAJv@nongnu.org","X-Gm-Message-State":"AOJu0YwtwPrpaCzFhsdzKJSCwhOU6QQtNvt3jHFGOEL1xkBEqdowRf2j\n q9FywgQQ5YhvR7BndUh2z2PjlIfvem9/zyDUWhu18XCXKK5lMLc8Uh4L","X-Gm-Gg":"AeBDievyq0VIz6Zxv82VCr+VbQXuJbl6WJ1+ZltAB5WfmNx2OmV2I0r5YtY2ArZ7LIt\n 54FgkNZ2VUUGnkMQ27+o94dEaf0L+t1MHYwCXzhNkvgIhWj/SvmMsmU/LuO/5IisxWovFv31DPe\n 904mAr+UEHuhlT/X15GZ8tQj6orWn8XpkVb3t+pOmDrqgEQbBpKoFj6914T+WEVkGZ2MOxkN6v7\n 7hgpewQLHfqGyKake8KZwNUIeIL1bclCzfGRBpFkVpO5vi6FiGdhHTk/4xD7fxhGxuyRYyhc4Dz\n QaEymhgTWNNlcq1kPpjeQi1kPzlNV66M0dBeEo00tT35/LWqEIeImsTqcxRahTaewQyWnfWlaca\n Tm7QoSyMS4z/6ILToufXeLiH0Y9VyDwpivbO+v9W+1tEgx9t7mE47CJ3Dad1ES6OdbIQzraq1EB\n f0NRhyVsgfuZjfJe6b/rn1LGpCBO5DQFB3DLFMggltEkvI1mcScaEvbsKmu7Ob+MU7R5EYLY1Cq\n b/auFeog7YDKx2h8ulVRA==","X-Received":"by 2002:a17:903:2ac3:b0:2b2:6b58:9317 with SMTP id\n d9443c01a7336-2b2d5a77878mr201111515ad.39.1776235742750;\n Tue, 14 Apr 2026 23:49:02 -0700 (PDT)","From":"Joel Stanley ","To":"Alistair Francis ,\n Daniel Henrique Barboza ,\n qemu-devel@nongnu.org","Cc":"Nicholas Piggin , Weiwei Li ,\n Michael Ellerman ,\n Joel Stanley ,\n Nick Piggin ,\n Anirudh Srinivasan , qemu-riscv@nongnu.org","Subject":"[PATCH v2 3/4] hw/riscv/boot: Warn if a ELF format file is loaded as\n a binary","Date":"Wed, 15 Apr 2026 16:48:35 +1000","Message-ID":"<20260415064838.652297-4-joel@jms.id.au>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260415064838.652297-1-joel@jms.id.au>","References":"<20260415064838.652297-1-joel@jms.id.au>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62e;\n envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62e.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001,\n FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Nicholas Piggin \n\nIt is possible that an ELF file can not be loaded, in that\ncase the loader falls back to loading the file as a binary\nblob. Print a warning in this case because it is likely that\nit is not intended.\n\nSigned-off-by: Nicholas Piggin \nReviewed-by: Daniel Henrique Barboza \nSigned-off-by: Joel Stanley \n---\n hw/riscv/boot.c | 23 +++++++++++++++++++----\n 1 file changed, 19 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c\nindex f3857e984240..3ea95c175c14 100644\n--- a/hw/riscv/boot.c\n+++ b/hw/riscv/boot.c\n@@ -179,13 +179,27 @@ hwaddr riscv_load_firmware(MachineState *machine,\n \n g_assert(firmware_filename != NULL);\n \n- if (load_elf_ram_sym(firmware_filename, NULL, NULL, NULL,\n- &firmware_entry, NULL, &firmware_end, NULL,\n- 0, EM_RISCV, 1, 0, NULL, true, sym_cb) > 0) {\n+ firmware_size = load_elf_ram_sym(firmware_filename, NULL, NULL, NULL,\n+ &firmware_entry, NULL, &firmware_end,\n+ NULL, 0, EM_RISCV, 1, 0, NULL, false,\n+ sym_cb);\n+ if (firmware_size > 0) {\n *firmware_load_addr = firmware_entry;\n return firmware_end;\n }\n \n+ if (firmware_size != ELF_LOAD_NOT_ELF) {\n+ /*\n+ * If the user specified an ELF format firmware that could not be\n+ * loaded as an ELF, it's possible that loading it as a binary is\n+ * not what was intended.\n+ */\n+ warn_report(\"could not load ELF format firmware '%s' (%s). \"\n+ \"Attempting to load as binary.\",\n+ firmware_filename,\n+ load_elf_strerror(firmware_size));\n+ }\n+\n firmware_size = load_image_targphys_as(firmware_filename,\n *firmware_load_addr,\n mem_size, NULL,\n@@ -195,7 +209,8 @@ hwaddr riscv_load_firmware(MachineState *machine,\n return *firmware_load_addr + firmware_size;\n }\n \n- error_report(\"could not load firmware '%s'\", firmware_filename);\n+ error_report(\"could not load firmware '%s': %s\", firmware_filename,\n+ load_elf_strerror(firmware_size));\n exit(1);\n }\n \n","prefixes":["v2","3/4"]}