{"id":2223162,"url":"http://patchwork.ozlabs.org/api/patches/2223162/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414155433.483186-3-magnuskulke@linux.microsoft.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414155433.483186-3-magnuskulke@linux.microsoft.com>","list_archive_url":null,"date":"2026-04-14T15:54:26","name":"[v4,2/9] target/i386/mshv: fix cpuid propagation bug","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"27c025ad952a41e19525f16387f4c318e14e4923","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/?format=json","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414155433.483186-3-magnuskulke@linux.microsoft.com/mbox/","series":[{"id":499862,"url":"http://patchwork.ozlabs.org/api/series/499862/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499862","date":"2026-04-14T15:54:24","name":"Support QEMU cpu models in MSHV accelerator","version":4,"mbox":"http://patchwork.ozlabs.org/series/499862/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223162/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223162/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=Bq5cjNQb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw84l0CHSz1xtJ\n\tfor ; Wed, 15 Apr 2026 01:55:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCg6B-0004Ih-OJ; Tue, 14 Apr 2026 11:54:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCg6A-0004Gk-6N\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 11:54:46 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wCg68-0000Dp-MT\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 11:54:45 -0400","from DESKTOP-TUU1E5L.localdomain (unknown [167.220.208.32])\n by linux.microsoft.com (Postfix) with ESMTPSA id 213F020B6F0C;\n Tue, 14 Apr 2026 08:54:41 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 213F020B6F0C","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1776182083;\n bh=FbXEXuqW8Bve0EgBTU0ARZN82HgvfmY8otXukE5Cjuw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Bq5cjNQbf/adrEydu6bWZlMfWpEylIwr2iFBILgVwtD2ICYAfcvAXE+GO8xj7voWM\n 91bS9QbrBIQ9RwFCQwgMeGITzg3O8wEB8/BgUnuBkEHU55Fb5C1ecT8cz8KTzzd0am\n X0XhoJFkBSsHx3ann6XEmSSKw/+aeDbHk3opj16M=","From":"Magnus Kulke ","To":"qemu-devel@nongnu.org","Cc":"Wei Liu , Wei Liu ,\n Magnus Kulke ,\n Magnus Kulke , Zhao Liu ,\n Paolo Bonzini ","Subject":"[PATCH v4 2/9] target/i386/mshv: fix cpuid propagation bug","Date":"Tue, 14 Apr 2026 17:54:26 +0200","Message-Id":"<20260414155433.483186-3-magnuskulke@linux.microsoft.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260414155433.483186-1-magnuskulke@linux.microsoft.com>","References":"<20260414155433.483186-1-magnuskulke@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-42","X-Spam_score":"-4.3","X-Spam_bar":"----","X-Spam_report":"(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The list argument was missing a pointer and hence e.g. -cpu qemu64 and\n-cpu EPYC would produce the same of cpuid leaves.\n\nFixes: 4fa04dd1621 (\"target/i386: Register CPUID entries with MSHV\")\n\nSigned-off-by: Magnus Kulke \nReviewed-by: Philippe Mathieu-Daudé \nReviewed-by: Anirudh Rayabharam (Microsoft) \n---\n target/i386/mshv/mshv-cpu.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c\nindex 2bc978deb2..f1cc4abc5c 100644\n--- a/target/i386/mshv/mshv-cpu.c\n+++ b/target/i386/mshv/mshv-cpu.c\n@@ -441,7 +441,7 @@ int mshv_load_regs(CPUState *cpu)\n return 0;\n }\n \n-static void add_cpuid_entry(GList *cpuid_entries,\n+static void add_cpuid_entry(GList **cpuid_entries,\n uint32_t function, uint32_t index,\n uint32_t eax, uint32_t ebx,\n uint32_t ecx, uint32_t edx)\n@@ -456,10 +456,10 @@ static void add_cpuid_entry(GList *cpuid_entries,\n entry->ecx = ecx;\n entry->edx = edx;\n \n- cpuid_entries = g_list_append(cpuid_entries, entry);\n+ *cpuid_entries = g_list_append(*cpuid_entries, entry);\n }\n \n-static void collect_cpuid_entries(const CPUState *cpu, GList *cpuid_entries)\n+static void collect_cpuid_entries(const CPUState *cpu, GList **cpuid_entries)\n {\n X86CPU *x86_cpu = X86_CPU(cpu);\n CPUX86State *env = &x86_cpu->env;\n@@ -615,7 +615,7 @@ static int set_cpuid2(const CPUState *cpu)\n struct hv_cpuid_entry *entry;\n GList *entries = NULL;\n \n- collect_cpuid_entries(cpu, entries);\n+ collect_cpuid_entries(cpu, &entries);\n n_entries = g_list_length(entries);\n \n cpuid_size = sizeof(struct hv_cpuid)\n","prefixes":["v4","2/9"]}