{"id":2223114,"url":"http://patchwork.ozlabs.org/api/patches/2223114/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260414132735.943125-1-torbjorn.svensson@foss.st.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414132735.943125-1-torbjorn.svensson@foss.st.com>","list_archive_url":null,"date":"2026-04-14T13:27:10","name":"testsuite: add explicit comparison to if statement","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"11c9b45f810b6d3cb9dd4c83995d7d6dcb84fb49","submitter":{"id":84848,"url":"http://patchwork.ozlabs.org/api/people/84848/?format=json","name":"Torbjörn SVENSSON","email":"torbjorn.svensson@foss.st.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260414132735.943125-1-torbjorn.svensson@foss.st.com/mbox/","series":[{"id":499845,"url":"http://patchwork.ozlabs.org/api/series/499845/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499845","date":"2026-04-14T13:27:10","name":"testsuite: add explicit comparison to if statement","version":1,"mbox":"http://patchwork.ozlabs.org/series/499845/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223114/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223114/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=dJ/Avslz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=dJ/Avslz","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","sourceware.org; spf=pass smtp.mailfrom=foss.st.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=40.107.162.40"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw4qB3KKyz1xtJ\n\tfor ; Tue, 14 Apr 2026 23:28:37 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 1272C4BA2E13\n\tfor ; Tue, 14 Apr 2026 13:28:35 +0000 (GMT)","from PA4PR04CU001.outbound.protection.outlook.com\n (mail-francecentralazon11013040.outbound.protection.outlook.com\n [40.107.162.40])\n by sourceware.org (Postfix) with ESMTPS id 032E14BA2E07\n for ; Tue, 14 Apr 2026 13:28:05 +0000 (GMT)","from DUZPR01CA0005.eurprd01.prod.exchangelabs.com\n (2603:10a6:10:3c3::9) by DU0PR10MB7921.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:10:322::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 13:27:59 +0000","from DB1PEPF000509E4.eurprd03.prod.outlook.com\n (2603:10a6:10:3c3:cafe::e2) by DUZPR01CA0005.outlook.office365.com\n (2603:10a6:10:3c3::9) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.48 via Frontend Transport; Tue,\n 14 Apr 2026 13:27:59 +0000","from smtpO365.st.com (164.130.1.60) by\n DB1PEPF000509E4.mail.protection.outlook.com (10.167.242.54) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9745.21 via Frontend Transport; Tue, 14 Apr 2026 13:27:58 +0000","from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com\n (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 14 Apr\n 2026 15:30:43 +0200","from jkgcxl0012.jkg.st.com (10.74.22.122) by STKDAG1NODE2.st.com\n (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 14 Apr\n 2026 15:27:54 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 1272C4BA2E13","OpenDKIM Filter v2.11.0 sourceware.org 032E14BA2E07"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 032E14BA2E07","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 032E14BA2E07","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776173285; cv=pass;\n b=u83ZL4oykoaN6x+UJjHHCDTuHRj9n2OtmCh4AWHS+fH0Mkmac2yNAmEVoKIiREk4OcoRCo6e9maax3cJoazTCdV/9T49nYN+BXZwWPiFIDA22F/q4kPW5B/CYigq5YV2b9tcS31EigO5xxTQDVzNTdpqFnwzROlUibMdvr1cWv8=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=NaVcl+TnHAspn1W4aferRRBF28/LQr6VIIRMYyk3jIeiCJOB/UXXVbdIeA3965T61ppNfibZLjl5rotT1HS/R/+7TCTxSBgMK2PV/kxpsA0sBeeXPmwhqrdWszNb4k7O9TIgYpmqKAHKUMtLn9JDa80N63/92z8PV8W42xfTXI9G3lyaakdOOUXrdHsDDf4exsaplM6j81x0aYEk1usRIjKbGK8ycmaUaJv7NITR3X0BAofwHq+IkZEl+Bk+Z54PcD/CM35yx3E2Taqu7RcMReSjVNbAFVH8t5uqd6tQHkLnWkOznR6igRL+BGxzA6OLchtyIBBVeRJedlgZLYhmxg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776173285; c=relaxed/simple;\n bh=hI8m3OFXybk7HPAj3Nr8n9Z51MseH7evZVLP87+l/WY=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=kCLPjBlE7rJrmZotNm7FfvxaByFH05pP0sCFBmUj6XXrWKhrco2rIcHTM9QGwzVz561cIwnI12bcRnDIH/BN3jfEYmRQPDDJ+lGSJazO7wBCDeboGhdg/I8+HYkuMzjjPBRmjn5/qmX9/sTnkIBRhF2xQSSV3NZvEe7hp15pSF4=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=38NlwE/z3gN/CYyaO9xccJ+HqwPbJCr22oFT+cpnhSM=;\n b=dM67NqBaHNShcuH9lonkKQN++2e9Q/jmzvld0c1uBoqmyYewyejv4rci6+5JqEUuf4ARd89KBul7BKtd7vUh6lzjwNyT1Hj2q44dFGzxd41LIK03ZV/yVK6sxbpTMSf8Hm2qpUht+huTa1mnE6wvY6DHa1i3Xw4fi0+7hnZ6LdPLH/5X++li96DimtINlQW7Q9nrc39JKML+A0V0gyGe8kyTa7j8XZYXRHo+98YBIOCHn7QV4LIHK0jQapwcAvC9+toJCvmpd5iWN5xAYbU6jSVvpOBn2plq2TQJ6K2mwZrCoXuZ1fjgD5fe/WnBG6uSrwYVPM4Xot9YHFnt+m4I7Q=="],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 164.130.1.60) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=foss.st.com;\n dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com;\n dkim=none (message not signed); arc=none (0)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=38NlwE/z3gN/CYyaO9xccJ+HqwPbJCr22oFT+cpnhSM=;\n b=dJ/AvslzKfxBILr0NdZFQtLqWimEaj5EQPPUxHJ2sFtHFr53va5RpO8tRuEDnTWWr1KtG4Zh0yX3siLo7b2DpZ6b6V2JkX3Mq8GXgLpJMaXvFoseeTW6lQAPp+wNZSW18Y0U/I4G849Ha1xdNVNFG/KWtfXQd+f61Ww6hL1SwvhgCzAENwu67uM7C3+4GcJR47L0CCDw93+vHmR4rWVSK1RU0Gn/i8pi/AWosk3zjgQkrTyy8JEsNyCbcRB0L4sa86PQjBXIYB558U2K1UON/jRg+fh2iwmNVcT5gko+RrTWs7qivVCcuE3K0QluVrvRYDD8bYNTIfV+lNZ+tOAVyA==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 164.130.1.60)\n smtp.mailfrom=foss.st.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=none header.from=foss.st.com;","Received-SPF":"Fail (protection.outlook.com: domain of foss.st.com does not\n designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com;\n client-ip=164.130.1.60; helo=smtpO365.st.com;","From":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","To":", ,\n ","CC":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","Subject":"[PATCH] testsuite: add explicit comparison to if statement","Date":"Tue, 14 Apr 2026 15:27:10 +0200","Message-ID":"<20260414132735.943125-1-torbjorn.svensson@foss.st.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8bit","X-Originating-IP":"[10.74.22.122]","X-ClientProxiedBy":"ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com\n (10.75.128.133)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DB1PEPF000509E4:EE_|DU0PR10MB7921:EE_","X-MS-Office365-Filtering-Correlation-Id":"5bffe30f-06e4-4ea0-7a73-08de9a29a50b","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|42112799006|1800799024|36860700016|82310400026|13003099007|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n qiK2eYaJkQlZ40ecOapzlGHRqz5cPROrJd7p5Naq9vB66udRMxMZZWzBB69Efh7eIFdXanCojYsa6k44wHi58NYH8CFHEBbc7BkXxzifqyS1nOjbb0oTG3UNlsMfpYk1AEsjABGKeB7D8pmIzd0rPyNsnsVr9SKOAkaKi7ZMdgypxGPtKtKTZL7CuRQBGDv5yI74+gpYkViNIahpG8heTDOxmn5jhQCZcfwdb2r0y+f7ig3qfkIm0zj13N4jyWk+b4BUFtMkxSYI1a7hX4FEhcJxZZepna2noLrAtBG42IB3Ft/5L0KjRAz8QY5La2dCM5K8F6vhztOZMM/PgCN3nuXUQf88DXe0U/vKpPErRZMbIgOo6gHdJfZ2SQd78KWtPFjYIA+GQ9X6HRE7Uud4esbrTi+J2U/tOmVmDDRBKGZ4UIUCZslrmr7IYkxGkNfneFUqtvmzMfoVcnWov2adAAab70l1eldD7dek4B0nshFmkaPhiGPXRENckOyT1+k1hUkhk23aj3m1Ac2D1Kl0bdeqIAoGiuGy34tLFR6LrwpSxmIgghb/3/LBNtzni0ubND1B7vHrQST+MN5YjMhMxQ+LUoY5iZ26Y1fxPEIFMbe6jzQCQGiZoom7zWEmUfS4FOQVfpL4PaJIBsEezsICzDmoIbCbRPQoFJJxrk6OKIOAf54hd17P4g63d/IE5i+uHs4em18XX3tlyoKpZAJbYQFK3kODObpWhw7ZwpDlSWE=","X-Forefront-Antispam-Report":"CIP:164.130.1.60; CTRY:IT; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(376014)(42112799006)(1800799024)(36860700016)(82310400026)(13003099007)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n Xea6Xy4sltraw74YQAfd9zcyZxlDHbFmxd6vCrI/8uxUZ5YKgOV4qn6eee/y2WkjaEJsDgXkIitTQS05W5XiObfNqeccarTAbVzFn8P9rOKLqcSEmWU8wz4yqKNsG6VmIW0m8N5Mq+22nippvlndpORtXYV44ez2uBdhbbebBUZqXT+RRhP5/llcrxZquK7+89CLa/scibYKsHcV/AVdSG0IqzhNwmGqJAiKSR/S52RbmyclsRKz2iIhIf5oyVhUWyNcX5RRSkr9J0ba+HShAlYMB3Ps3ceHo0OmYt4hoZcqtFJNY1dfjn24pTu1NX5lQNSFVVuQdbeJEXHNBNaEh7Ji2/B8mZMXNoAUkFCGTjuVHZCdORfE/2pJQUBqX1BlFSqFLEjYKEgYXYemrscJkva6FVe9ZB3G9/t9znYorrZV/shidl1fJQqWeaYc/XOT","X-OriginatorOrg":"foss.st.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 13:27:58.5299 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 5bffe30f-06e4-4ea0-7a73-08de9a29a50b","X-MS-Exchange-CrossTenant-Id":"75e027c9-20d5-47d5-b82f-77d7cd041e8f","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; Ip=[164.130.1.60];\n Helo=[smtpO365.st.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n DB1PEPF000509E4.eurprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DU0PR10MB7921","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"Ok for trunk?\n\n--\n\nWithout this patch, this ends up in the logs with llvm as the default\ncompiler for the host:\n\n/build/gcc_src/gcc/testsuite/gcc.dg/plugin/diagnostic_plugin_test_paths.cc:484:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]\n 484 | if (call = check_for_named_call (stmt, \"acquire_lock_a\", 0))\n | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n/build/gcc_src/gcc/testsuite/gcc.dg/plugin/diagnostic_plugin_test_paths.cc:484:17: note: place parentheses around the assignment to silence this warning\n 484 | if (call = check_for_named_call (stmt, \"acquire_lock_a\", 0))\n | ^\n | ( )\n/build/gcc_src/gcc/testsuite/gcc.dg/plugin/diagnostic_plugin_test_paths.cc:484:17: note: use '==' to turn this assignment into an equality comparison\n 484 | if (call = check_for_named_call (stmt, \"acquire_lock_a\", 0))\n | ^\n | ==\n...\n2 warnings generated.\n\ngcc/testsuite/ChangeLog:\n\n\t* gcc.dg/plugin/diagnostic_plugin_test_paths.cc: Compare with\n\tNULL in if statement.\n\nSigned-off-by: Torbjörn SVENSSON \n---\n .../gcc.dg/plugin/diagnostic_plugin_test_paths.cc | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/gcc/testsuite/gcc.dg/plugin/diagnostic_plugin_test_paths.cc b/gcc/testsuite/gcc.dg/plugin/diagnostic_plugin_test_paths.cc\nindex 875f4a849e8..7fa67d0bf0f 100644\n--- a/gcc/testsuite/gcc.dg/plugin/diagnostic_plugin_test_paths.cc\n+++ b/gcc/testsuite/gcc.dg/plugin/diagnostic_plugin_test_paths.cc\n@@ -481,12 +481,13 @@ example_4 ()\n \t gimple *stmt = gsi_stmt (gsi);\n \t event_location_t *evloc = NULL;\n \t gcall *call = NULL;\n-\t if (call = check_for_named_call (stmt, \"acquire_lock_a\", 0))\n+\t if ((call = check_for_named_call (stmt, \"acquire_lock_a\", 0)) !=\n+\t\t NULL)\n \t\tevloc = (in_foo\n \t\t\t ? &call_to_acquire_lock_a_in_foo\n \t\t\t : &call_to_acquire_lock_a_in_bar);\n-\t else if (call\n-\t\t = check_for_named_call (stmt, \"acquire_lock_b\", 0))\n+\t else if ((call = check_for_named_call (stmt, \"acquire_lock_b\",\n+\t\t\t\t\t\t 0)) != NULL)\n \t\tevloc = (in_foo\n \t\t\t ? &call_to_acquire_lock_b_in_foo\n \t\t\t : &call_to_acquire_lock_b_in_bar);\n","prefixes":[]}