{"id":2223105,"url":"http://patchwork.ozlabs.org/api/patches/2223105/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260414131558.538656-2-yan.wang@softathome.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414131558.538656-2-yan.wang@softathome.com>","list_archive_url":null,"date":"2026-04-14T13:15:56","name":"[v6,1/3] binman: Generate preload header and sign data only once","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6ff4fb0d52e04fc31a295d55665ceb65db6ddb86","submitter":{"id":90652,"url":"http://patchwork.ozlabs.org/api/people/90652/?format=json","name":"Yan WANG","email":"yan.wang@softathome.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260414131558.538656-2-yan.wang@softathome.com/mbox/","series":[{"id":499840,"url":"http://patchwork.ozlabs.org/api/series/499840/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499840","date":"2026-04-14T13:15:55","name":"binman: Fix preload signing with encrypted FIT","version":6,"mbox":"http://patchwork.ozlabs.org/series/499840/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223105/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223105/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=TgrhYqkx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"TgrhYqkx\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=yan.wang@softathome.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw4YY29Bcz1yDF\n\tfor ; Tue, 14 Apr 2026 23:16:49 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D4EC78423E;\n\tTue, 14 Apr 2026 15:16:28 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B1A6C8421E; Tue, 14 Apr 2026 15:16:27 +0200 (CEST)","from MRZP264CU002.outbound.protection.outlook.com\n (mail-francesouthazlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c207::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C6BBB84206\n for ; Tue, 14 Apr 2026 15:16:25 +0200 (CEST)","from PA7P264CA0160.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:36c::8)\n by MRYP264MB7000.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:a0::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 13:16:22 +0000","from PA1PEPF000CC3FA.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:36c:cafe::ce) by PA7P264CA0160.outlook.office365.com\n (2603:10a6:102:36c::8) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.48 via Frontend Transport; Tue,\n 14 Apr 2026 13:16:22 +0000","from proxy.softathome.com (149.6.166.170) by\n PA1PEPF000CC3FA.mail.protection.outlook.com (10.167.242.5) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.17\n via Frontend Transport; Tue, 14 Apr 2026 13:16:22 +0000","from sah1lpt719.softathome.com (unknown [192.168.72.213])\n by proxy.softathome.com (Postfix) with ESMTPSA id 4350220737;\n Tue, 14 Apr 2026 15:16:22 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=tchaf+IcdI3I1OsiitaCc8UX+jpMvTbxpbNbLizpN8Dut4ah5iaBEZEtwBErdNrQ/RRo/jD7aJIGPKtBc/exwpeOiR4qvkJxLQnrQRu/LJTU93VL8F4yJjLvFG7oE2uFDhcquKou+jrjHygD+hI9cV/fDO2jOPMQBzfeuLgj0VCnJGoBMCYDfcgVPSWy5yhz4eIZXo0wmX4mbNvPtUKXs7Y7VgsdA7PESXiHwWGe3le7feaiyEJfB90H/pk04gQYklNFj4X4tV6kOLOHBVmULNk0xwH/z+mhWmGe+JZLXhqecm/JEhNBCMyHayaaVPSugvmy/DXV89JRHxSXwEqCxw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=qYl4RAHaOA5rAhND/Wffz9SfSa8U9abvtgRogrANwTk=;\n b=Sh5JTMQkxDOa2YZK6IgslpgsrSTbRQ4svSNGeb6J/x5EXsLdZ0VRF/ve84HysKEJFyed9b0eDHT2cxIMm5K7mA/nP+6vzIHnISZkGhUaT22cer2Z0bnULjLhyz5/Vur86XaMcKJLL72p4mRB+tCv4V6UjgDDA717GF9DqnmBmT1Retq2GaBQYtGhkgTvxelbACmJn3/vSxYcJT9Se/MOm07Lmm6s0eyyHzQpDjMxUxhdnJimheI7FYOgIddMgA1FC6/Oci/HP/e2Tpb3MSk2+txN3m6EpFLBRI7EKCesHS4mHm+Mo9GNs1MsG6+st/IxpdxkNUMVGocF7ae8/B0CWw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=chromium.org smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qYl4RAHaOA5rAhND/Wffz9SfSa8U9abvtgRogrANwTk=;\n b=TgrhYqkxbgXu+fSz047JRgn098v58oeYSlp2tqMdmCjq3ERe0G6UXB7uGlQSnuWWkIeIWnyO/7AgGo8jGyfW61z6xH0v8xvtP5xN4RxOpHLvnAO+K/e4+YGuZE7aQQOEDJ+1knIj8hyMusee8CVesPVwp1baQE8w7eI0EORbU7fKjnBHRZRfx0HnPsnW20G8c0NGSuGQt+NehfAkJ6dbu65F1sZGKNjR7JmI1X0/EtObfRD345MaG7Dxa37Ya0fAlUSX+OlSEEy9y/5x2cewuaGBIaEw4H/I/YD5cgFswA+kxCsxz/jk3yWcqR+QkH3LL1mQL1hGmpW9g8ubt0Z8xg==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;","Received-SPF":"Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C","From":"Yan WANG ","To":"trini@konsulko.com,\n\tsjg@chromium.org,\n\talpernebiyasak@gmail.com","Cc":"paul.henrys_ext@softathome.com,\n\tu-boot@lists.denx.de","Subject":"[PATCH v6 1/3] binman: Generate preload header and sign data only\n once","Date":"Tue, 14 Apr 2026 15:15:56 +0200","Message-Id":"<20260414131558.538656-2-yan.wang@softathome.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20260414131558.538656-1-yan.wang@softathome.com>","References":"<20260408150201.217942-3-paul.henrys_ext@softathome.com>\n <20260414131558.538656-1-yan.wang@softathome.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PA1PEPF000CC3FA:EE_|MRYP264MB7000:EE_","Content-Type":"text/plain","X-MS-Office365-Filtering-Correlation-Id":"cccdf9ad-c90b-4d95-e67e-08de9a280628","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|36860700016|82310400026|376014|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n 3IspqO8cArxvev/4WqqI+yCgJM3QZA+tt2M0IIOTqjSJJI8vNl2cPaO7qxjLYjTBQoxkMN5ztH/kwIhj14NBETzDcfGivf+m+cD5zOxeRCb64fAItpLzR9n1+BIPd255X/uNDpvOFs6CQspRyB4fAybH/cGsgPihDB/JcAqmL2JeUr+yj6ndmCd79CY4tXAD8WWb2RGeJhMqn9HY10UeXFNUX0Fl4WJ5X5QI56bDC6SuofDlYtMMSjvHhY0IccSb9l2eN4CpEn718dvkJ7BYm2zAQBLIpaOeHpExCn5ZPAFFbFHGDzgcp+dip8tMGDNiWd9GmhpbsPnHLHDREvTg6VV894t/zxqqrUumIYOi6QtNiz7DdEo0MmaaPyYXNL/Jk3OJYc4Y6EPnVxQctkFX3dP15Glq+28kNdLQxn3rFFCQzxZWWBRefVT2nSN5JOF1udbEvVWL5FBFSBBHACa9eacIrXlj3kacJUDSQqig3pFBPhgiglQeHHrlqinom4Q6+l0r1J9vLZQChoQ4IbIzAIx4SLdn0LlKSOS17/Mp4SjaSs+YsPDZUPF7XUKEBpJ59iBCpq9WWtUNx3yBUQGHoJfglVms24YX+oucx+xUQtgNioWBeQZ+okWINiB/SAvftRXdGKeP4De7bgJvcyoOD7mtaTTanoPWLyVVu4p5Fq/DmjOW0Hums5PYcj4CpHweXIotNkmw8NNy6biZmOG6CVCh1lkhKKwgJeis0SQTs0OF/aZo650UIVTR4C3Ls95z1UcLNMHmOUdVxYCUcF47GA==","X-Forefront-Antispam-Report":"CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n d4nJC02EAQj0TpEJswqhHAga0dCITvpCptZaaE3F1h9rpWEB02jOA0EPzLB0m789Qr2a2cBGuC+ai2+b7l9lOxjV/t5ATA1TKgU7PANcJjOFRefYgvHilcoJGEF6eTNXLe8/gx5uQm4McTImBtAqxQwAEASUCNrb8tY9F/Q7NNvjodp/uUKrx8iVzjgBqtePASeCdZrT4AtBkg9tBwQP4h7RXGYw3REHPoQBSpdw3Cf/UdcmM8WaKRbMrTk8iP4VsmOGGB0h+k1sLqQbifA093BkPLtkIpQQjUW4bLrOHjiT4FfwyJor8IdgyrXU0sr9lqLY0QBX8P3WxMwHwIg7bkeYDS8NEuZ/PsANa1Gy0yRHr8ILcxf55mF9seJViR7mfPgYj4YSldLZavhgxAg4E1YKDGZET3+oNu2F8VY1K/Mk1yFe/gDwnevjaAcZwkVS","X-OriginatorOrg":"softathome.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 13:16:22.5107 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n cccdf9ad-c90b-4d95-e67e-08de9a280628","X-MS-Exchange-CrossTenant-Id":"aa10e044-e405-4c10-8353-36b4d0cce511","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]","X-MS-Exchange-CrossTenant-AuthSource":"PA1PEPF000CC3FA.FRAP264.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MRYP264MB7000","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Paul HENRYS \n\nTo optimize preload generation, generate the header and signatures only\nafter all data has been collected in ProcessContentsUpdate(). This\navoids signing the data multiple times.\n\nSince header_size is known upfront (from __init__), create a placeholder\nin `ObtainContents()` to avoid an extra packing pass when\nProcessContentsUpdate() detects a size change.\n\nThis reduces unnecessary repacking and signing operations.\n\nSigned-off-by: Paul HENRYS \n---\n\nChanges in v6:\n- No changes\n\n tools/binman/etype/pre_load.py | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/tools/binman/etype/pre_load.py b/tools/binman/etype/pre_load.py\nindex 00f1a896767..0d953cb258e 100644\n--- a/tools/binman/etype/pre_load.py\n+++ b/tools/binman/etype/pre_load.py\n@@ -152,14 +152,11 @@ class Entry_pre_load(Entry_collection):\n return data + pad\n \n def ObtainContents(self):\n- \"\"\"Obtain a placeholder for the header contents\"\"\"\n- # wait that the image is available\n- self.image = self.GetContents(False)\n- if self.image is None:\n- return False\n- self.SetContents(self._CreateHeader())\n+ \"\"\"Create a placeholder for the header\"\"\"\n+ self.SetContents(tools.get_bytes(0, self.header_size))\n return True\n \n def ProcessContents(self):\n+ self.image = self.GetContents(True)\n data = self._CreateHeader()\n return self.ProcessContentsUpdate(data)\n","prefixes":["v6","1/3"]}