{"id":2223038,"url":"http://patchwork.ozlabs.org/api/patches/2223038/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414082915.112122-4-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414082915.112122-4-armenon@redhat.com>","list_archive_url":null,"date":"2026-04-14T08:29:08","name":"[v4,03/10] hw/tpm: Add internal buffer state for chunking","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"31a279af35a297e3d4cab55ba78af68916d5243f","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414082915.112122-4-armenon@redhat.com/mbox/","series":[{"id":499802,"url":"http://patchwork.ozlabs.org/api/series/499802/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499802","date":"2026-04-14T08:29:05","name":"hw/tpm: CRB chunking capability to handle PQC","version":4,"mbox":"http://patchwork.ozlabs.org/series/499802/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223038/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223038/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KP8QBFHc;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=V91NdXND;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvyCc0hxyz1yDF\n\tfor ; Tue, 14 Apr 2026 18:30:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCZAJ-0007hK-9P; Tue, 14 Apr 2026 04:30:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCZA7-0007fX-12\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:30:24 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCZA5-00040N-06\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:30:22 -0400","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-149-WWBfrX90OgmJr2P4ANiTgg-1; Tue, 14 Apr 2026 04:30:18 -0400","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b24a00d12cso55058305ad.1\n for ; Tue, 14 Apr 2026 01:30:18 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.202])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4e0f909sm181493785ad.35.2026.04.14.01.30.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 01:30:11 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776155420;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6ZlI7ZJ5l97a8qYb33N5MiMsq0vmJ/gwOXd4mdNCCoE=;\n b=KP8QBFHcBkgAg+lpGHh6Z61g+kLx6mWUdr0c1W9nQ21Xq4w3a68Jj9ZMRSFprU8H58+fFK\n R3C1XOd6w4yGZSpcwttO4gXyv0WlsnB3Fpaq+UWweV0JcxyKZdd+K8/dfHdCm6prfoc2Ye\n Xbw6RyZO+TKbbsFdtXK3qMoGLBq+8k8=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776155417; x=1776760217; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6ZlI7ZJ5l97a8qYb33N5MiMsq0vmJ/gwOXd4mdNCCoE=;\n b=V91NdXNDxNtXqmkjJF+/EWLblz8ubYO28zlaTjb4+IXBoovO36h4te5L9DHnluPOZT\n sEii/26FBCtT8izVYM7GsWpunH1tmC1l/uv+ABZ/4ynMK6ZePqec+rrcWNeXvoLxTb77\n t4RPE1IACpX5mrVXTIhU2AcWsYmDPgDTXmN+Z7ur2PFv+AwkHPIb+PqlJ/T312xEZQ9O\n ocJwxx7tudhZ70t9rX5V9tK6m7xTKTVW1L8McXR0E19WRKiQPe3c/O0Q3yp6rFtkzsEN\n GjnjE92FIsNA3dbbYQcISTbl6qI3SP8Maw0+wQ6FIN7j62u5yAitFmdkw6a1T3Jl46qA\n hdlQ=="],"X-MC-Unique":"WWBfrX90OgmJr2P4ANiTgg-1","X-Mimecast-MFC-AGG-ID":"WWBfrX90OgmJr2P4ANiTgg_1776155418","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776155417; x=1776760217;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=6ZlI7ZJ5l97a8qYb33N5MiMsq0vmJ/gwOXd4mdNCCoE=;\n b=fh5Q0Xpt3Pn8kVPCZGE76y3cLGYzW8pdg8TF5I1+RWibDgHeSu3rfpW6UOhAw77xeX\n OluRUcJodKyAp4UmN8+ZLzM3441DgAWdCtX3lthMsHGbrxg2EciOE6n2wntNujGwxzMQ\n d7sIMHhk1xTVVzF/CGAlkJeLo8eaX/jUUXOcFhPXtP9VK5GvG/FG3801jC1mpPdG6GDC\n MJ0mWW3rFAwtl5SNNaArl2nt1z0kzcs9rKEmoIBzN5WAXPiY6quriXiQ8ZHq7OhZZ34R\n ZoYceL415WLKO/+oq1agpdzIm+7o6h9kNgOE/fNhyGKyjnKp/xAYkS3d6DBkGCFdBUGA\n UBeg==","X-Gm-Message-State":"AOJu0Yz6swUb9+k3t0DY1KmSxTHkwzc1FEUbhkTnIRKsilkCkF/nr6Mw\n R3e/feDUllRMJlksSXFSpjolKHA0cZSzNb2UN/ydNjLh2Lsv64oF+xPVWNjjsySNSfQ5GXw799M\n aiPj43Y9sPaXdcC/S03qlRzCwjWBRikznQZRDZE7Vzgwv44vnPY92VtwXW7TNk1MXPAX0Zo+qP6\n Da3XtW4x+SHkiWMSmA8lqpQ7LwT/KNzFqGBgkurrQ=","X-Gm-Gg":"AeBDiesLknAkreOEvDu92UHgp1j5HQ1qIFy++H/Tof2ntCZlE4mwXiRKdjIyl6t5PeU\n G+A802z7Y6PpfY3n6Rq+4f7Go22rrWJDmoD94fdNpKlY8DlaMJJ1xRdNM1WQff3CTRdzHdAR82b\n pWQq5YPXhueH9Indpq+j/LNS+XE6oVF5/CdHr2ysfqn0hAtm3kuHnsTHRWZeb3s7K2hdtWRTIsC\n 2i1H/J7jwUYQligVbabNQDpfZvNUlsbaqkdisIMxi7hbUsij6CPOGbm580PF2h3vJ8aZEIBTipQ\n UPP6F9y14yZU0is9FdpydfnXoKQMAWU2+R98bNe8fF7t8BwmcAbv3DToJ7bCMptt8xcr00Axro6\n JTbCQqACyHb4xs/HrQyxIfoh6DWFRJosXXblCQQ203xvgJ83b9/prd+1wmM3WfHI=","X-Received":["by 2002:a17:903:289:b0:2b4:5e65:5d0e with SMTP id\n d9443c01a7336-2b45e655efamr77399095ad.10.1776155417493;\n Tue, 14 Apr 2026 01:30:17 -0700 (PDT)","by 2002:a17:903:289:b0:2b4:5e65:5d0e with SMTP id\n d9443c01a7336-2b45e655efamr77394665ad.10.1776155411684;\n Tue, 14 Apr 2026 01:30:11 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Yanan Wang , Ani Sinha ,\n \"Michael S. Tsirkin\" , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ,\n Stefan Berger ,\n Paolo Bonzini ,\n Marcel Apfelbaum ,\n Zhao Liu , marcandre.lureau@redhat.com,\n Igor Mammedov , Laurent Vivier ,\n Fabiano Rosas , Arun Menon ","Subject":"[PATCH v4 03/10] hw/tpm: Add internal buffer state for chunking","Date":"Tue, 14 Apr 2026 13:59:08 +0530","Message-ID":"<20260414082915.112122-4-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260414082915.112122-1-armenon@redhat.com>","References":"<20260414082915.112122-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\n- Introduce GByteArray buffers to hold the command request and response\n data during chunked TPM CRB transactions.\n- Add helper function to clean them.\n\nSigned-off-by: Arun Menon \nReviewed-by: Marc-André Lureau \n---\n hw/tpm/tpm_crb.c | 33 +++++++++++++++++++++++++++++----\n 1 file changed, 29 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex 8e6ec44711..89f4113c97 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -38,10 +38,13 @@ struct CRBState {\n TPMBackend *tpmbe;\n TPMBackendCmd cmd;\n uint32_t regs[TPM_CRB_R_MAX];\n+ size_t be_buffer_size;\n MemoryRegion mmio;\n MemoryRegion cmdmem;\n \n- size_t be_buffer_size;\n+ GByteArray *command_buffer;\n+ GByteArray *response_buffer;\n+ uint32_t response_offset;\n \n bool ppi_enabled;\n TPMPPI ppi;\n@@ -85,6 +88,13 @@ enum crb_cancel {\n \n #define TPM_CRB_NO_LOCALITY 0xff\n \n+static void tpm_crb_clear_internal_buffers(CRBState *s)\n+{\n+ g_byte_array_set_size(s->response_buffer, 0);\n+ g_byte_array_set_size(s->command_buffer, 0);\n+ s->response_offset = 0;\n+}\n+\n static uint64_t tpm_crb_mmio_read(void *opaque, hwaddr addr,\n unsigned size)\n {\n@@ -134,9 +144,11 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n }\n break;\n case A_CRB_CTRL_CANCEL:\n- if (val == CRB_CANCEL_INVOKE &&\n- s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {\n- tpm_backend_cancel_cmd(s->tpmbe);\n+ if (val == CRB_CANCEL_INVOKE) {\n+ if (s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {\n+ tpm_backend_cancel_cmd(s->tpmbe);\n+ }\n+ tpm_crb_clear_internal_buffers(s);\n }\n break;\n case A_CRB_CTRL_START:\n@@ -240,6 +252,7 @@ static void tpm_crb_reset(void *dev)\n tpm_ppi_reset(&s->ppi);\n }\n tpm_backend_reset(s->tpmbe);\n+ tpm_crb_clear_internal_buffers(s);\n \n memset(s->regs, 0, sizeof(s->regs));\n \n@@ -306,6 +319,9 @@ static void tpm_crb_realize(DeviceState *dev, Error **errp)\n memory_region_add_subregion(get_system_memory(),\n TPM_CRB_ADDR_BASE + sizeof(s->regs), &s->cmdmem);\n \n+ s->command_buffer = g_byte_array_new();\n+ s->response_buffer = g_byte_array_new();\n+\n if (s->ppi_enabled) {\n tpm_ppi_init(&s->ppi, get_system_memory(),\n TPM_PPI_ADDR_BASE, OBJECT(s));\n@@ -318,12 +334,21 @@ static void tpm_crb_realize(DeviceState *dev, Error **errp)\n }\n }\n \n+static void tpm_crb_unrealize(DeviceState *dev)\n+{\n+ CRBState *s = CRB(dev);\n+\n+ g_clear_pointer(&s->command_buffer, g_byte_array_unref);\n+ g_clear_pointer(&s->response_buffer, g_byte_array_unref);\n+}\n+\n static void tpm_crb_class_init(ObjectClass *klass, const void *data)\n {\n DeviceClass *dc = DEVICE_CLASS(klass);\n TPMIfClass *tc = TPM_IF_CLASS(klass);\n \n dc->realize = tpm_crb_realize;\n+ dc->unrealize = tpm_crb_unrealize;\n device_class_set_props(dc, tpm_crb_properties);\n dc->vmsd = &vmstate_tpm_crb;\n dc->user_creatable = true;\n","prefixes":["v4","03/10"]}