{"id":2223037,"url":"http://patchwork.ozlabs.org/api/patches/2223037/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414082915.112122-2-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414082915.112122-2-armenon@redhat.com>","list_archive_url":null,"date":"2026-04-14T08:29:06","name":"[v4,01/10] hw/tpm: Add TPM CRB chunking fields","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"13bafee08128f867e7a1de8d09f5cedf509e5aa0","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414082915.112122-2-armenon@redhat.com/mbox/","series":[{"id":499802,"url":"http://patchwork.ozlabs.org/api/series/499802/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499802","date":"2026-04-14T08:29:05","name":"hw/tpm: CRB chunking capability to handle PQC","version":4,"mbox":"http://patchwork.ozlabs.org/series/499802/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223037/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223037/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Tsh8YWOX;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Q2brY/xV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvyCV5zlbz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 18:30:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCZ9v-0007aO-1z; Tue, 14 Apr 2026 04:30:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wCZ9t-0007Za-QY\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:30:09 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wCZ9s-0003yW-1y\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:30:09 -0400","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-479-LKiWTZFUMqKa881Uj6gn4Q-1; Tue, 14 Apr 2026 04:29:50 -0400","by mail-pl1-f197.google.com with SMTP id\n d9443c01a7336-2b4530a90fdso48062265ad.1\n for <qemu-devel@nongnu.org>; Tue, 14 Apr 2026 01:29:50 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.202])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4e0f909sm181493785ad.35.2026.04.14.01.29.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 01:29:48 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776155407;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8b4xtkIhhKFmSZ8qyvLhxx+v9owHMfnrKqDv6T+JeSY=;\n b=Tsh8YWOX+dlPmcwLIqtlRA//6uxqoTSM09V34l4ntIGzm0nzG9Bf1YE+gfli7FQUaGzfFL\n BtMnskgxs5KBpjDsOKE0+Tmrsqw0E2i6mQB8S7t1WWoy+EVMMoUdFvyGxHBqLKxslNISI7\n qj5jR00hO1Dvsiw6o6X7r/sLN3hYrvQ=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776155389; x=1776760189; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8b4xtkIhhKFmSZ8qyvLhxx+v9owHMfnrKqDv6T+JeSY=;\n b=Q2brY/xVZSe3eGIHtrCZhIy/H2lCOlT5LW8q2fbnSD9Pte7h+rmuoD44qaBzTaC9O/\n cHmSutOfHJmblnOSDiX7dVy9beiuQ3NII3TGn5pjT0/Fdq4ppjI4WFWZJLC90wBcbwVk\n furroyIBxDkVs5lB+8GLxnLRuJUtq3oX+9ul0sZeh4KwZDBXjtOrTcUPtbWEta11KTXI\n 4ZNj0BUBtmUwxU7Mq0wRvaf5g/tlSzd4iMmRmLrM/bWd33e4kxiehqmqn09u12bApXqE\n hmTZ1ZMIfNDTlxWBDpf3NYXxO5iceG6Qm3qjVpMvkJJAQiPqanhMcn+x3nCjpx7OJcS1\n 5Q6g=="],"X-MC-Unique":"LKiWTZFUMqKa881Uj6gn4Q-1","X-Mimecast-MFC-AGG-ID":"LKiWTZFUMqKa881Uj6gn4Q_1776155389","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776155389; x=1776760189;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8b4xtkIhhKFmSZ8qyvLhxx+v9owHMfnrKqDv6T+JeSY=;\n b=Cv9XhguNJ2/oSnstqWsdhV0xNdQyQH5wYVKmsSGf22KWgxbluUTwclJwnbONCKxijL\n hUxIAxOsiKs+axIgsD9aSgQDqN2KyrsRB7YQeNsC7iZq6/zNYyisoCuF7rTruFwzshn8\n JbHZ2LwA5zyZSYdGN6lvpVYBjoQ41Hb32Zb+suM5zoZuEZYlOIctTNJbtCZ3rAqFeMcA\n HZ7k18DoVL8AiUlRM3LBmFEeB36A0UF634+k8vZLcikCfMcLuuAw3upWdhh9GTr7SXso\n JRBiNh0qs9c7Sbbcc9LDErdWlkicQvmf+nkdSXPOF9v7MyTlaK4Q8YGyU2OT7xMVwUBo\n 2wwQ==","X-Gm-Message-State":"AOJu0Yxv0lQzvTkyf8yuHxKnY8Gh2PJMsdQvZUas9NCuRgVUk4FRysQq\n tQJs658gy7BjWfXD3RMpEt+wTKZs9wbmyg6R9ITLJcDBCDg11TW3LJH6jEHfLZAyjZaGoPlNL4S\n Xty8GfPBt+zmvYccekT/7ptFu1A9jnjgCgRPYGfK4+xIfWv02T/TtfPxh5b/SD9/ko2YScmX0sF\n 0NHgLKyxkG1yZ7J/vy+mHNUnhQNN4ti2T46+sm96k=","X-Gm-Gg":"AeBDietzcrzOtit8Po3d1Rc2S81jvXPi73opgoEcbip45I4ZHLpIKVuBl2yNrqny6N3\n 5ZVEbYUQicRU2gk18nL/Wi9j0Ar5NngnD5KsJGRjb8wIuYej4ck9+UMfrBeB2y/yMOHHnA3UXtp\n tr8w1ZRI0O4nXmElec6vTsPo2pWsA2VCRE3puYkQ+xOKuMVVonxzeKnNDMDVS+i0pY1SybPV+5h\n ox3oCajf65I7PPdxxYoBSYHwjOev+ey9pxQx32buCSAM4UBiPy4GzVzL3bCSIfOUuA1IVlLG/Oi\n /QEEKUxAsWg9IML4gpIW70lLdVsjRV17cschm/HJ2U/bZQ8XjSvIcyGdwh86HaERctpxXEfNChf\n fs3jxBwGPctDDBEnnFtShpO9dvtlusXkMMMZIUQ8p8DhOYgYKPhz0QqdY8DNoidg=","X-Received":["by 2002:a17:902:be03:b0:2b2:71b4:a3cf with SMTP id\n d9443c01a7336-2b2d59d398emr130703135ad.19.1776155389072;\n Tue, 14 Apr 2026 01:29:49 -0700 (PDT)","by 2002:a17:902:be03:b0:2b2:71b4:a3cf with SMTP id\n d9443c01a7336-2b2d59d398emr130702705ad.19.1776155388490;\n Tue, 14 Apr 2026 01:29:48 -0700 (PDT)"],"From":"Arun Menon <armenon@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Yanan Wang <wangyanan55@huawei.com>, Ani Sinha <anisinha@redhat.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,\n Stefan Berger <stefanb@linux.vnet.ibm.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Zhao Liu <zhao1.liu@intel.com>, marcandre.lureau@redhat.com,\n Igor Mammedov <imammedo@redhat.com>, Laurent Vivier <lvivier@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, Arun Menon <armenon@redhat.com>,\n Stefan Berger <stefanb@linux.ibm.com>","Subject":"[PATCH v4 01/10] hw/tpm: Add TPM CRB chunking fields","Date":"Tue, 14 Apr 2026 13:59:06 +0530","Message-ID":"<20260414082915.112122-2-armenon@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260414082915.112122-1-armenon@redhat.com>","References":"<20260414082915.112122-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon <armenon@redhat.com>\n\n- Add new fields to the CRB Interface Identifier and the CRB\n  Control Start registers.\n- CRB_CTRL_START now has 2 new settings, that can be toggled using the\n  nextChunk and crbRspRetry bits.\n- CapCRBChunk bit (10) was Reserved1 previously. The field is reused in\n  this revision of the specification.\n- Refer to section 6.4.2.2 of [1]\n\n[1] https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p07_Pub.pdf\n\nSigned-off-by: Arun Menon <armenon@redhat.com>\nReviewed-by: Stefan Berger <stefanb@linux.ibm.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/tpm/tpm_crb.c      | 3 +++\n include/hw/acpi/tpm.h | 5 ++++-\n 2 files changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex 8723536f93..0a1c7ecdc6 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -59,6 +59,7 @@ DECLARE_INSTANCE_CHECKER(CRBState, CRB,\n #define CRB_INTF_CAP_FIFO_NOT_SUPPORTED 0b0\n #define CRB_INTF_CAP_CRB_SUPPORTED 0b1\n #define CRB_INTF_IF_SELECTOR_CRB 0b1\n+#define CRB_INTF_CAP_CRB_CHUNK 0b1\n \n #define CRB_CTRL_CMD_SIZE (TPM_CRB_ADDR_SIZE - A_CRB_DATA_BUFFER)\n \n@@ -262,6 +263,8 @@ static void tpm_crb_reset(void *dev)\n                      CapCRB, CRB_INTF_CAP_CRB_SUPPORTED);\n     ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n                      InterfaceSelector, CRB_INTF_IF_SELECTOR_CRB);\n+    ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n+                     CapCRBChunk, CRB_INTF_CAP_CRB_CHUNK);\n     ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID,\n                      RID, 0b0000);\n     ARRAY_FIELD_DP32(s->regs, CRB_INTF_ID2,\ndiff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h\nindex d2bf6637c5..6eece21397 100644\n--- a/include/hw/acpi/tpm.h\n+++ b/include/hw/acpi/tpm.h\n@@ -149,7 +149,7 @@ REG32(CRB_INTF_ID, 0x30)\n   FIELD(CRB_INTF_ID, InterfaceVersion, 4, 4)\n   FIELD(CRB_INTF_ID, CapLocality, 8, 1)\n   FIELD(CRB_INTF_ID, CapCRBIdleBypass, 9, 1)\n-  FIELD(CRB_INTF_ID, Reserved1, 10, 1)\n+  FIELD(CRB_INTF_ID, CapCRBChunk, 10, 1)\n   FIELD(CRB_INTF_ID, CapDataXferSizeSupport, 11, 2)\n   FIELD(CRB_INTF_ID, CapFIFO, 13, 1)\n   FIELD(CRB_INTF_ID, CapCRB, 14, 1)\n@@ -168,6 +168,9 @@ REG32(CRB_CTRL_STS, 0x44)\n   FIELD(CRB_CTRL_STS, tpmIdle, 1, 1)\n REG32(CRB_CTRL_CANCEL, 0x48)\n REG32(CRB_CTRL_START, 0x4C)\n+  FIELD(CRB_CTRL_START, Start, 0, 1)\n+  FIELD(CRB_CTRL_START, crbRspRetry, 1, 1)\n+  FIELD(CRB_CTRL_START, nextChunk, 2, 1)\n REG32(CRB_INT_ENABLED, 0x50)\n REG32(CRB_INT_STS, 0x54)\n REG32(CRB_CTRL_CMD_SIZE, 0x58)\n","prefixes":["v4","01/10"]}