{"id":2223031,"url":"http://patchwork.ozlabs.org/api/patches/2223031/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260414082004.3756080-7-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414082004.3756080-7-dhowells@redhat.com>","list_archive_url":null,"date":"2026-04-14T08:20:02","name":"[v2,6/7] netfs: Fix zeropoint update where i_size > remote_i_size","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"604da45f5c0b2ab03f30711d4f3aab5d62f37df5","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260414082004.3756080-7-dhowells@redhat.com/mbox/","series":[{"id":499799,"url":"http://patchwork.ozlabs.org/api/series/499799/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=499799","date":"2026-04-14T08:19:56","name":"netfs: Miscellaneous fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/499799/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223031/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223031/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bwRgtF92;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10799-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"bwRgtF92\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvy7g1whJz1xtJ\n\tfor ; Tue, 14 Apr 2026 18:27:27 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id D305A301FDEB\n\tfor ; Tue, 14 Apr 2026 08:21:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 92314396B85;\n\tTue, 14 Apr 2026 08:20:58 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 481B43ACA61\n\tfor ; Tue, 14 Apr 2026 08:20:52 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-m_grForOOaqNqNBiknMCGQ-1; Tue,\n 14 Apr 2026 04:20:45 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 235601956066;\n\tTue, 14 Apr 2026 08:20:44 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.34.160])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7451C19560AB;\n\tTue, 14 Apr 2026 08:20:40 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776154857; cv=none;\n b=JRV3L6JHCw1m9PpGfV9CtvtT6mOLKRdJ7Ipc9l/nmVpimfdULb2IpjE3NNO7+rxfDjPC9PW8oVQni8De5f/vE8KYUNml18vyuqCt5b8b8wl0xBLShWQdQ4lz+/W2+pYJ2oHBeEnfJorFg7send7XAsPtgxtwoIW2B4z8V/lQwP8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776154857; c=relaxed/simple;\n\tbh=0RD9WK7Z8b1cfNWJfuywH/XVdQi+DID7QaHnobdiupA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=QBgKPuP0P98A1FZlN3cfzTFc9xjkf7o1tpeJ9EmzfWy1jOHqADkD+6XusCufWmrypfG7AjGUcw8CiEbKBgNMcU6tCHDI0Rs7NSaXKxyhzsi7w0mL9+jhBolZr5/UD50g/b9TTpDJDLvWg+vi0lhHaodUamVimNHIRUmpsXBlBCU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=bwRgtF92; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1776154851;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=hwkDzJJVkIB8QUWldBqXDsmI02iLpH9t4nRKDWmeUI0=;\n\tb=bwRgtF92x3x1dHF9zUqAT3gEBDwSGKjtp60ElzDPGfOP/tJqpU6f2snaHQ0jp5fKweMV2d\n\tp141qO80uJTY26J3WyoLGXx3lMZEXF6pDp3ZRJQ4U0HEi+KgRJ+QmpiIZa/RiHUsE3nA7Z\n\tNs8srBPWSUL1y7CAl1h6XQGZZnIFK4Y=","X-MC-Unique":"m_grForOOaqNqNBiknMCGQ-1","X-Mimecast-MFC-AGG-ID":"m_grForOOaqNqNBiknMCGQ_1776154844","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tPaulo Alcantara ,\n\tMatthew Wilcox ","Subject":"[PATCH v2 6/7] netfs: Fix zeropoint update where i_size >\n remote_i_size","Date":"Tue, 14 Apr 2026 09:20:02 +0100","Message-ID":"<20260414082004.3756080-7-dhowells@redhat.com>","In-Reply-To":"<20260414082004.3756080-1-dhowells@redhat.com>","References":"<20260414082004.3756080-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12"},"content":"Fix the update of the zero point[*] by netfs_release_folio() when there is\nuncommitted data in the pagecache beyond the folio being released but the\non-server EOF is in this folio (ie. i_size > remote_i_size). The update\nneeds to limit zero_point to remote_i_size, not i_size as i_size is a local\nphenomenon reflecting updates made locally to the pagecache, not stuff\nwritten to the server. remote_i_size tracks the server's i_size.\n\n[*] The zero point is the file position from which we can assume that the\n server will just return zeros, so we can avoid generating reads.\n\nNote that netfs_invalidate_folio() probably doesn't need fixing as\nzero_point should be updated by setattr after truncation.\n\nFound with:\n\n fsx -q -N 1000000 -p 10000 -o 128000 -l 600000 \\\n /xfstest.test/junk --replay-ops=junk.fsxops\n\nusing the following as junk.fsxops:\n\n truncate 0x0 0x1bbae 0x82864\n write 0x3ef2e 0xf9c8 0x1bbae\n write 0x67e05 0xcb5a 0x4e8f6\n mapread 0x57781 0x85b6 0x7495f\n copy_range 0x5d3d 0x10329 0x54fac 0x7495f\n write 0x64710 0x1c2b 0x7495f\n mapread 0x64000 0x1000 0x7495f\n\non cifs with the default cache option.\n\nIt shows read-gaps on folio 0x64 failing with a short read (ie. it hits\nEOF) if the FMODE_READ check is commented out in netfs_perform_write():\n\n if (//(file->f_mode & FMODE_READ) ||\n netfs_is_cache_enabled(ctx)) {\n\nand no fscache. This was initially found with the generic/522 xfstest.\n\nFixes: cce6bfa6ca0e (\"netfs: Fix trimming of streaming-write folios in netfs_inval_folio()\")\nSigned-off-by: David Howells \ncc: Paulo Alcantara \ncc: Matthew Wilcox \ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/misc.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/fs/netfs/misc.c b/fs/netfs/misc.c\nindex d8e8a4b59768..e386cf31eb1e 100644\n--- a/fs/netfs/misc.c\n+++ b/fs/netfs/misc.c\n@@ -302,7 +302,7 @@ bool netfs_release_folio(struct folio *folio, gfp_t gfp)\n \tif (folio_test_dirty(folio))\n \t\treturn false;\n \n-\tend = umin(folio_next_pos(folio), i_size_read(&ctx->inode));\n+\tend = umin(folio_next_pos(folio), ctx->remote_i_size);\n \tif (end > ctx->zero_point)\n \t\tctx->zero_point = end;\n \n","prefixes":["v2","6/7"]}