{"id":2223029,"url":"http://patchwork.ozlabs.org/api/patches/2223029/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/ec5a0e5e98c4fe55b8571c408ca891bd02208cc3.1776150071.git.sayalip@linux.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"","list_archive_url":"https://lore.kernel.org/linuxppc-dev/ec5a0e5e98c4fe55b8571c408ca891bd02208cc3.1776150071.git.sayalip@linux.ibm.com/","date":"2026-04-14T08:22:07","name":"[v5,13/14] selftests/mm: move hwpoison setup into run_test() and silence modprobe output for memory-failure category","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"1f0981f29e5bb04b03f984ee64bcfb8215bd3b68","submitter":{"id":92656,"url":"http://patchwork.ozlabs.org/api/people/92656/?format=json","name":"Sayali Patil","email":"sayalip@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/ec5a0e5e98c4fe55b8571c408ca891bd02208cc3.1776150071.git.sayalip@linux.ibm.com/mbox/","series":[{"id":499800,"url":"http://patchwork.ozlabs.org/api/series/499800/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499800","date":"2026-04-14T08:21:54","name":"selftests/mm: fix failures and robustness improvements","version":5,"mbox":"http://patchwork.ozlabs.org/series/499800/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223029/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223029/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Vkd/bYnE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19741-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Vkd/bYnE;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=sayalip@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvy4B1x3Nz1y2d\n\tfor ; Tue, 14 Apr 2026 18:24:26 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvy3K2fQwz3bfY;\n\tTue, 14 Apr 2026 18:23:41 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvy3J4mmQz2yvL\n\tfor ; Tue, 14 Apr 2026 18:23:40 +1000 (AEST)","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63DLJ8NK1834698;\n\tTue, 14 Apr 2026 08:23:23 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dh89r9sfj-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 14 Apr 2026 08:23:22 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63E4suMx004179;\n\tTue, 14 Apr 2026 08:23:21 GMT","from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg24k8ht3-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 14 Apr 2026 08:23:21 +0000","from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com\n [10.20.54.103])\n\tby smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63E8NHfM15794638\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 14 Apr 2026 08:23:17 GMT","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 98CD920043;\n\tTue, 14 Apr 2026 08:23:17 +0000 (GMT)","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9A5E62004D;\n\tTue, 14 Apr 2026 08:23:13 +0000 (GMT)","from li-3f69264c-2ce6-11b2-a85c-c3f414d24014.ibm.com.com (unknown\n [9.39.26.223])\n\tby smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 14 Apr 2026 08:23:13 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776155021;\n\tcv=none;\n b=lb2fph16VS1TFO8/mpLfR5kwt712OsUf1ItsMHotz1rV1YpVjoC23vqVpEzCdFJ4p1R06fe7598jkkxOJgSHUz8KkOJPGNe3rVHK4/2Sqj8I8hulldv+Tqr6vJWy4u0/8k4u2DCb7oLEg0/gMU54SSPypbqOg29xfHcPczZaqCmnMyJrp1gwxBf+5Em2pf12Wo9kFPpLcpGU24APOF1s0BVR0s8hDEQ+HCRIfWD1Vl28exm1PIz2qFEs+aybgNet0AFGLQi8/5U1ZDg47KtL74OJ7iPof4gYPCdgrTbZAxA2r90wv5J1w/7MYzQ5utzcQn//8iZ00HqGIPfSsovT4w==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776155021; c=relaxed/relaxed;\n\tbh=iCumWvX/ac3jXvh4F1ZXlL3cuNPYnkwd3hOEkAJPAF4=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=cFOBfPgDTi/VlVAajHpcvLEJhDRhkoAt59X/uRk25k7GPRTq6hYB2ZWTLaNv2f6nCDyF+Q+ytuWtugbng3Qc2dB0dYslflmUAZLyjViurQBr6erpjXHowphjfH8yvAvCDDferxHRLNtrgqjYMpHlmMTVAdfErctPCYzN28TUGvHLzGztSQxnOjWE9H76bzCqaZlK3b4m4/r+VrOX5zMOhTGUe6jyph4gmpM6xDyVo9kPDQhLm/DlNGvcSFcvihqhUNzsCKIgCNp7ikOMi7YVtg1c91QQPbc1rlDi2k0hH/XNv124RpRkQsNahvgwY0wrrF6AI2XaaB6H8RDs2DDKOg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Vkd/bYnE; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=sayalip@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=iCumWvX/ac3jXvh4F\n\t1ZXlL3cuNPYnkwd3hOEkAJPAF4=; b=Vkd/bYnEdECk+Adr7PcmWYAGy5r5K1pf0\n\tIsbG2Mi9CoUgzMAmfoeWt6Xz2hhtYf18tyvbvM+hDrEQemhaq9QfiuO9AQXjxVdb\n\tgaD2tYNUc3SJj7coddjO+ldhZhgOvcuBhfs+ZQBYoZohDh+my2M5O9R0FlwTOzuh\n\tn6hs/q7dHbp2iirLqThnKtGhgsi22CYeacXSDBGAIaH5ghjb6F5nxS+UukQhVZjx\n\tchdgK8F2UUqjVyNuvA1EJrf7qeydakva1SGVZZqAMFyRN2YVYVZh+owriVmd85jV\n\tccAYLZtMtmZYhF4vvcvuGzu1DGt8so4qq8CM4JoJKNOCmSZpBHgMQ==","From":"Sayali Patil ","To":"Andrew Morton , Shuah Khan ,\n linux-mm@kvack.org, linux-kernel@vger.kernel.org,\n linux-kselftest@vger.kernel.org,\n Ritesh Harjani ","Cc":"David Hildenbrand , Zi Yan ,\n Michal Hocko , Oscar Salvador ,\n Lorenzo Stoakes ,\n Dev Jain , Liam.Howlett@oracle.com,\n linuxppc-dev@lists.ozlabs.org, Miaohe Lin ,\n Venkat Rao Bagalkote ,\n Sayali Patil ","Subject":"[PATCH v5 13/14] selftests/mm: move hwpoison setup into run_test()\n and silence modprobe output for memory-failure category","Date":"Tue, 14 Apr 2026 13:52:07 +0530","Message-ID":"\n ","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"","References":"","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE0MDA3NyBTYWx0ZWRfX5ABL9MhlKMiS\n IZ8T3OISac/cfvyB7e0yO7isf51Eji0Pu0DIsl3b+KrS3nT6D+r2G9StCY/2arzCcQMoKZ1X90N\n GqVORKHJVmoZ+RkDkavyeOmm19NxAGoT08P23f922NDqwlUv3ytMha4Bu6t8lzZKvGLeNDjMm/V\n gWaexN5sz3ccXbSEP7RFh4o2Md/WbhvvOCVtYxB81ywgIUB9jXInJvxkaLMmRK9ezEZxAVcKGuH\n uz2Bhh381vCrpq3Iofc3Zyx4uCkx7EMpiPWhrULiTYJIFroJnPWa9LdQjv43dOSI2xP9pS24HXx\n Z4fPGAIXbXUNtlUxk+U7jdU8sFXTNMWH84YqdzvUSzZxF9TUuJzg8Hsl5wb/0sdpiTeuA7Ink+l\n EN8RmuTHodJJq5qb+h5/bVpSl5d2j/hdc74EI1h9eV+xqkA/FcBrhj/SPFaJ2o4DVRSneFNY0kr\n XRXDzUvv4m4M/pJQCGQ==","X-Proofpoint-ORIG-GUID":"uFrQIKN5WM9lAcwSJUA3irW3UnP4U4wF","X-Proofpoint-GUID":"8w_gV9ei4Z6ZlLW6S7AyAzvbHThjrPju","X-Authority-Analysis":"v=2.4 cv=fYidDUQF c=1 sm=1 tr=0 ts=69ddf97b cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=U7nrCbtTmkRpXpFmAIza:22 a=Ikd4Dj_1AAAA:8 a=VnNF1IyMAAAA:8\n a=w_JUWIshtjp1QPcyv1YA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0\n bulkscore=0 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140077","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"run_vmtests.sh contains special handling to ensure the hwpoison_inject\nmodule is available for the memory-failure tests. This logic was\nimplemented outside of run_test(), making the setup category-specific\nbut managed globally.\n\nMove the hwpoison_inject handling into run_test() and restrict it\nto the memory-failure category so that:\n1. the module is checked and loaded only when memory-failure tests run,\n2. the test is skipped if the module or the debugfs interface\n(/sys/kernel/debug/hwpoison/) is not available.\n3. the module is unloaded after the test if it was loaded by the script.\n\nThis localizes category-specific setup and makes the test flow\nconsistent with other per-category preparations.\n\nWhile updating this logic, fix the module availability check.\nThe script previously used:\n\n\tmodprobe -R hwpoison_inject\n\nThe -R option prints the resolved module name to stdout, causing every\nrun to print:\n\n\thwpoison_inject\n\nin the test output, even when no action is required, introducing\nunnecessary noise.\n\nReplace this with:\n\n\tmodprobe -n hwpoison_inject\n\nwhich verifies that the module is loadable without producing output,\nkeeping the selftest logs clean and consistent.\n\nAlso, ensure that skipped tests do not override a previously recorded\nfailure. A skipped test currently sets exitcode to ksft_skip even if a\nprior test has failed, which can mask failures in the final exit status.\nUpdate the logic to only set exitcode to ksft_skip when no failure has\nbeen recorded.\n\nFixes: ff4ef2fbd101 (\"selftests/mm: add memory failure anonymous page test\")\nReviewed-by: Zi Yan \nTested-by: Venkat Rao Bagalkote \nSigned-off-by: Sayali Patil \n---\n tools/testing/selftests/mm/run_vmtests.sh | 52 ++++++++++++++---------\n 1 file changed, 33 insertions(+), 19 deletions(-)","diff":"diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh\nindex afdcfd0d7cef..62dcfbb9887b 100755\n--- a/tools/testing/selftests/mm/run_vmtests.sh\n+++ b/tools/testing/selftests/mm/run_vmtests.sh\n@@ -235,6 +235,7 @@ pretty_name() {\n run_test() {\n \tif test_selected ${CATEGORY}; then\n \t\tlocal skip=0\n+\t\tlocal LOADED_HWPOISON_INJECT_MOD=0\n \n \t\t# On memory constrainted systems some tests can fail to allocate hugepages.\n \t\t# perform some cleanup before the test for a higher success rate.\n@@ -250,6 +251,28 @@ run_test() {\n \t\t\tfi\n \t\tfi\n \n+\t\t# Ensure hwpoison_inject is available for memory-failure tests\n+\t\tif [ \"${CATEGORY}\" = \"memory-failure\" ]; then\n+\t\t\t# Try to load hwpoison_inject if not present.\n+\t\t\tHWPOISON_DIR=/sys/kernel/debug/hwpoison/\n+\t\t\tif [ ! -d \"$HWPOISON_DIR\" ]; then\n+\t\t\t\tif ! modprobe -n hwpoison_inject > /dev/null 2>&1; then\n+\t\t\t\t\techo \"Module hwpoison_inject not found, skipping...\" \\\n+\t\t\t\t\t\t| tap_prefix\n+\t\t\t\t\tskip=1\n+\t\t\t\telse\n+\t\t\t\t\tmodprobe hwpoison_inject > /dev/null 2>&1\n+\t\t\t\t\tLOADED_HWPOISON_INJECT_MOD=1\n+\t\t\t\t\tif [ ! -d \"$HWPOISON_DIR\" ]; then\n+\t\t\t\t\t\techo \"hwpoison debugfs interface not present\" \\\n+\t\t\t\t\t\t\t| tap_prefix\n+\t\t\t\t\t\tskip=1\n+\t\t\t\t\tfi\n+\t\t\t\tfi\n+\t\t\tfi\n+\n+\t\tfi\n+\n \t\tlocal test=$(pretty_name \"$*\")\n \t\tlocal title=\"running $*\"\n \t\tlocal sep=$(echo -n \"$title\" | tr \"[:graph:][:space:]\" -)\n@@ -261,6 +284,12 @@ run_test() {\n \t\telse\n \t\t\tlocal ret=$ksft_skip\n \t\tfi\n+\n+\t\t# Unload hwpoison_inject if we loaded it\n+\t\tif [ -n \"${LOADED_HWPOISON_INJECT_MOD}\" ]; then\n+\t\t\tmodprobe -r hwpoison_inject > /dev/null 2>&1\n+\t\tfi\n+\n \t\tcount_total=$(( count_total + 1 ))\n \t\tif [ $ret -eq 0 ]; then\n \t\t\tcount_pass=$(( count_pass + 1 ))\n@@ -270,7 +299,9 @@ run_test() {\n \t\t\tcount_skip=$(( count_skip + 1 ))\n \t\t\techo \"[SKIP]\" | tap_prefix\n \t\t\techo \"ok ${count_total} ${test} # SKIP\" | tap_output\n-\t\t\texitcode=$ksft_skip\n+\t\t\tif [ $exitcode -eq 0 ]; then\n+\t\t\t\texitcode=$ksft_skip\n+\t\t\tfi\n \t\telse\n \t\t\tcount_fail=$(( count_fail + 1 ))\n \t\t\techo \"[FAIL]\" | tap_prefix\n@@ -529,24 +560,7 @@ CATEGORY=\"page_frag\" run_test ./test_page_frag.sh nonaligned\n \n CATEGORY=\"rmap\" run_test ./rmap\n \n-# Try to load hwpoison_inject if not present.\n-HWPOISON_DIR=/sys/kernel/debug/hwpoison/\n-if [ ! -d \"$HWPOISON_DIR\" ]; then\n-\tif ! modprobe -q -R hwpoison_inject; then\n-\t\techo \"Module hwpoison_inject not found, skipping...\"\n-\telse\n-\t\tmodprobe hwpoison_inject > /dev/null 2>&1\n-\t\tLOADED_MOD=1\n-\tfi\n-fi\n-\n-if [ -d \"$HWPOISON_DIR\" ]; then\n-\tCATEGORY=\"memory-failure\" run_test ./memory-failure\n-fi\n-\n-if [ -n \"${LOADED_MOD}\" ]; then\n-\tmodprobe -r hwpoison_inject > /dev/null 2>&1\n-fi\n+CATEGORY=\"memory-failure\" run_test ./memory-failure\n \n if [ \"${HAVE_HUGEPAGES}\" = 1 ]; then\n \techo \"$orig_nr_hugepgs\" > /proc/sys/vm/nr_hugepages\n","prefixes":["v5","13/14"]}