{"id":2223003,"url":"http://patchwork.ozlabs.org/api/patches/2223003/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-2-jamin_lin@aspeedtech.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414080025.3005916-2-jamin_lin@aspeedtech.com>","list_archive_url":null,"date":"2026-04-14T08:00:27","name":"[v2,01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and dead code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e7883b379fa2c4e52ad241b4bd9280102e80b2fb","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/people/81768/?format=json","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-2-jamin_lin@aspeedtech.com/mbox/","series":[{"id":499795,"url":"http://patchwork.ozlabs.org/api/series/499795/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499795","date":"2026-04-14T08:00:26","name":"hw/usb/ehci: Add 64-bit descriptor addressing support","version":2,"mbox":"http://patchwork.ozlabs.org/series/499795/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223003/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223003/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=McWJvBoJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxcr67L4z1yHH\n\tfor ; Tue, 14 Apr 2026 18:04:12 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCYhY-0003Yt-7p; Tue, 14 Apr 2026 04:00:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCYhS-0003X2-2D; Tue, 14 Apr 2026 04:00:47 -0400","from mail-koreacentralazlp170130006.outbound.protection.outlook.com\n ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCYhM-0005oL-LE; Tue, 14 Apr 2026 04:00:43 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 08:00:27 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 08:00:27 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=esZ4GZqikxOn8U2Di9yPgsDNZZGD/mUyT4xLoaVHIyMQUlKlZWhB8Fkowne6RbhKxQQjqpfJJh1TkGolVjdQJRVqs+hhmyZ3s8eoNRVbdWMduioQmh5ZXUz2R26FpxcpXRwCr0hbi0NaX2rJn12C+NvxiHymvM6LJ5BxbmiMP2KkOw2WY/dfXvO8FAHnIY2T64b1bDo+WGVjrBdSFrAi5OxC/Hg4huZhlk75XeKjb8kJEbGdnRgA05quKLAj0BfQVydwoAOVK1VPhiZdm8Pifsah+iPiQhW5JQkbF83JJcp6mbP6TQcqUVwNzQOrkbHM27J7mVzTWpdqz79m/ntCLA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=1+qkXLls/pt40Z1VqrqM0+XkmKAxAHjDWMBW47cohns=;\n b=lTpA8k+hoo8qxizavmA8UAm92b3q1MBxsghrwomXVM805Z0Jer73dBZ00FU3gwdEM3g0x8xnRacZbFcdgbJbl1VKetVz5IuPGZf+6XGsBpmKVI+oxnbqJYu2Mlo+HTcmtUZ4MNSJEIj/DZCq5AwXfxgwYIYRNVY6Zq60/QCNuxhHMDMM3FiiTUBfRQjAO3tn3CdQmaNeqEuHutBEdAqwqK6lGOo6cLZPeql5xViuLhRX1AaEgMYOcRd8fu3slBf0xg5PSAXLQ7WDP5CAufKXoj52HbtpVbAHoEYhaNrsDvWlSR8SR4wCDHv5/VTT3HEjr40ZkPdhHOmAUeisEx0rpw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=1+qkXLls/pt40Z1VqrqM0+XkmKAxAHjDWMBW47cohns=;\n b=McWJvBoJ+BV8XOAP7OO+gITyt/Wf3ffX9MfnhNrVp9x7GnJzYxXWza2e5NstnmDeUKIvsthxe1drnrDkgRodPlpHOAk/+JGyRUdJCISnciOfFTybf0npcHzXT2SPAuOv6A2tWIBCaVxbC9R9Q9vx5N1J4ixw6wWoWC4jUqSoN977m3BUzUbJGoJeldpB/7Ra/Xh+J8zD0WmXRTvGPNlH1C4alnIqLK6mVDrOGkfUhPik6XpMOi7n9IXjiLcD6ozZT04vMSFYR5YipVXVGdr2V0lrxlqP5kIZuWX/539aMkfK1YfXr3JlvRQMG1XjwD36yV43wSFHN0uzqOBJ//5Ung==","From":"Jamin Lin ","To":"=?iso-8859-1?q?C=E9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","CC":"Jamin Lin , Troy Lee ,\n \"flwu@google.com\" , \"nabihestefan@google.com\"\n ","Subject":"[PATCH v2 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure\n and dead code","Thread-Topic":"[PATCH v2 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","Thread-Index":"AQHcy+TBUiPPKxc1sEqzhE5+L5C51g==","Date":"Tue, 14 Apr 2026 08:00:27 +0000","Message-ID":"<20260414080025.3005916-2-jamin_lin@aspeedtech.com>","References":"<20260414080025.3005916-1-jamin_lin@aspeedtech.com>","In-Reply-To":"<20260414080025.3005916-1-jamin_lin@aspeedtech.com>","Accept-Language":"zh-TW, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=McWJvBoJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|TYZPR06MB6745:EE_","x-ms-office365-filtering-correlation-id":"7f009c84-72c3-45ec-02d3-08de99fbe427","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003;","x-microsoft-antispam-message-info":"\n Aak86oRoS53oGy/9YXzmVE25SBQoCzq4b9CmeBMLDwVMdccV1Seqh7e6izxU21M1u+oeJcAU+tDBNsSA1YbAb+qoErqL4uKCnaM4VPiFyhZ+mwYt+pHxSInf1+EIyjDSdusQLAK0oBNYXdhznSb7wjZnDHaM34ar9+Z/43r7dG1akglLshJQ5nPAdI7rGb9aB0ELtBwl8e89Wiq7849KNVACrD/isPBS6BTYb8uVsHqWNE6n1OntZxhsTliP6koRXdWtbb5cRL4fV4QRV7v99CEX1u4dJRwe+2l8xvVr2XLCRSS/lAiynEvgnYczzwTtAZ3nm1hzn0VDh8F6z9Ce6urdwo6utonD9b05axwZdf9ssULN88RuxsZM74U/akXbnRNnQtDjOdywURDEEnGgL7FwtG4XMRDz+rxB1ModZQ6kDAHnQD8ZJFf7rKocVNVX9Kn7suh5D87UeNL/gvgWSCnn0OO/2DoRAGtpH9pZeIF2N+N8OxPAO881LTxJHIolNJYAFnLB+qfhlKOdOS9WO3YjYQTlwRcptXBPZHgLvNApfSQD/gpbOmBpz6SjZoXRidQY+9GLwfIRfF04YkbOKuo/0wyf1uP/NumJW9c4FXT4WAtXKbMQMAhaeIEsMSu6GOqW37LY93C/8XHU5l9vSby/Lz1G8DL6+2TcwQM2RxnoRh2IVjjXoMVb6rzqYLhOO1bbpzXAJKvigLmxRMkg8j9LbtV1N+5FevSFdPh0AXVDLP8I/8rXGTYLWxQyzjHiUSlO945PXsoiesvPJjvDX7pe4UCP0QaRQp4yY+gvdOs=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?kDdpW5lAKO/fszwQrZxaR3I?=\n\t=?iso-8859-1?q?I+TKNl4qnGp3B4D5/UZb48nhjoHd3FeKYpLjfdQDBQNRHeYoJPPIGaUcBrMA?=\n\t=?iso-8859-1?q?FSIsHxB5Zx88AVPyqUY3X8PFZYPoGXtPHd/4k196CWmBb6KgC+ot3ln/fRXY?=\n\t=?iso-8859-1?q?f51XqCSNaXI0NeeNdYTkHGLWhkVdZf7URtPlTMmQoyAR2du/JTCDCsGnP4J2?=\n\t=?iso-8859-1?q?4AzBd8Q0uW+mr3MPow3dcZ/diqXlUlwTytKBd8vwryoaK3Zy/Q8ZBGWRd0IA?=\n\t=?iso-8859-1?q?wcKD+v4lRbdP7ZNJfqkFJ2h3JGzyfRGyK37fufipU7TdB0kKgyBeQiO1dWxV?=\n\t=?iso-8859-1?q?V4FmysJSFPzw+MCkFq6dc7yLRUAs/M6vwaWvBuiqHvVkamSR4dw98Q0/Z1mE?=\n\t=?iso-8859-1?q?AuwL9KUVy5V7WEQGxG+FhTlGq8e+NbbbYcO4mIX8cie4EX6ISa30oPfMbZPK?=\n\t=?iso-8859-1?q?47gVVjsInoQCQTm9+H4IeAooYFGOIs+5geaMs0GayTGDFJ60iWslmfpGwIOM?=\n\t=?iso-8859-1?q?+Gw+n+7PFqfWutzUlRePESiM0N82rRWBXheUK1REKVo9DG5obiL5A8pz0Tn2?=\n\t=?iso-8859-1?q?kxjtoyYW1OmvHhurSuT9CHSxIsQPcac7ToPjvA0FEAZGtlhMiFgsCgqHCd//?=\n\t=?iso-8859-1?q?S5Xo6HZ7odTSVbswNQ0cB/kQCLZKOwDWbfPW16h/mf40Mv/bvZmg8HQ7gZ6v?=\n\t=?iso-8859-1?q?BcC5TBDURQAOox/9Tv7Q3Vs2+HUuKNqJEdho90RV9ldnLRmvbsK8lSW37u0S?=\n\t=?iso-8859-1?q?F2POu5IgHR/1GtUnyoPHTk1EOh0Gm3pH9f5SVqqLbKznKIFwVYYYVdjT1iUt?=\n\t=?iso-8859-1?q?3utbx/UTasPeyETLC81JfPHbsELYYziSj6ApdMHYo2ihGuLtQvuahFtT1UNZ?=\n\t=?iso-8859-1?q?iODe4840mFfjQBr5qkoOFqKk8Etpq/qL6gSZEg3MqVXyhWDBSUsdhVwGLfCx?=\n\t=?iso-8859-1?q?4fvOiSVpC/4+9WRs6/pwAT4SSry0Frpulb62fOJAnGj6UbpYPVriJvNS3OSz?=\n\t=?iso-8859-1?q?lUXq2sP6JEZQEmxBibRJ4OnigRL6Ta2//awP9MXQoMXF5bslRSd4Bmr0GKVZ?=\n\t=?iso-8859-1?q?YgvO7WCBVN1F1gayQb6on0AzTHRZCVEehXgjdZF7jrG+Wf8RCJxlU4DGjauZ?=\n\t=?iso-8859-1?q?idHeKaqenKOp3rjf8U2M4gPCxEEc/gn4hOXx4Jhb4+xWBlKsmR+k0E5WWLSb?=\n\t=?iso-8859-1?q?RUHP0W+pWWLJuF5iVrCnY/WD6Ua7w+MzAAacWvxo4hADJ/VbmHnbAQRt83Lr?=\n\t=?iso-8859-1?q?Is1jmtpb7YZ6RX9mqNEeUWWZY6aiIL1J2HYyZHAECgDf5iHRMgIC3UZO7YD6?=\n\t=?iso-8859-1?q?+Yx/TRhoScEAJDK73Oa5V2GzRBxo+gJGmeS5JK39F1FisDKAhcBY8kH4/H24?=\n\t=?iso-8859-1?q?g8gI84KvMp+Go1ioiQwYVRVYiK/Y/UgMjpF0WCAuFebCw07bM3mmnCNVTB53?=\n\t=?iso-8859-1?q?mW/YO08k13BnRCvOK/X3rjrbUapUGWuuVw0JhJ8ZvBsR7cv50ep0IvCkim81?=\n\t=?iso-8859-1?q?A1cA0Q3mlM2Ndl5sdwIHrpBQKaQoaCol8rRnpHqNqAH7WTqm++TxrHtNOOKv?=\n\t=?iso-8859-1?q?wjl1M/pwT9Xs8yWdclQK7l2sJUZcBbhFuDj3ES+80Z02kcZp6VYo4jFsrYHr?=\n\t=?iso-8859-1?q?vR01MlPt+OYfdV/4LFJF7wFFjuUGsqyfDZpt2vPLGmLCLq6uaCorkZB7ujf7?=\n\t=?iso-8859-1?q?x/tb+8a4cJPFd8MH2HjddrSW8I+YhpfmAv+r7Z3TrudqBOUc751i1mumKY/b?=\n\t=?iso-8859-1?q?h40f4c/LWC/etj77MwOqPv/IS1yyWrEu/LTp4fPnVLHZ5Rg=3D=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n czZXOIbOvmTKIwVXOXB5zF6MjCqBSgc78aK8Dkpl40qhYsjY5eK/a5upz0jUCcIrLhBRoKb4DC8e/oYpCkUO04kOnUengJTRYdLUTg+OGJQlFLYm2g18dKmMaPrR9JtSGbPIu52qe5XLm+SkUfctOilwGg1/OlcIbGVajN0IS5G5gVdVjb8pVNieYrL/lr5LoKoMXeDDfD83XQrDdxtrmLwP9MqgYkyda0tSWq9y8AzSjZ3keaVTdrv2Wx+YYUlfWrJYa1grNGe0g5tQvxGh1IWaS6Rxiz54FZ9AV9GqPhPHOXjol6NmlZ3Gec0IfxpjxSNHBHb3rmkUwZYqjA6aBw==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 7f009c84-72c3-45ec-02d3-08de99fbe427","X-MS-Exchange-CrossTenant-originalarrivaltime":"14 Apr 2026 08:00:27.6149 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n hBp4j80pb2Ez1UYtqkidiaii7XrKCfPNY6r0CK2cnKQ8dL9MX00gJkBXpBYHiMrtGMQvr2F54IZuwxYsdicz8wGg2YCiYg+7PrOKiMJ580s=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TYZPR06MB6745","Received-SPF":"pass client-ip=2a01:111:f403:c40f::6;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=SEYPR02CU001.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The EHCIfstn structure, defined according to EHCI spec section 3.7,\nis currently unused in the EHCI implementation. Remove it to reduce\nunused code and improve maintainability.\n\nAdditionally, drop a block of disabled (#if 0) code in\nehci_state_advqueue() that was never implemented. This code path\nis incomplete and has no functional impact.\n\nNo functional change.\n\nSigned-off-by: Jamin Lin \n---\n hw/usb/hcd-ehci.h | 7 -------\n hw/usb/hcd-ehci.c | 11 -----------\n 2 files changed, 18 deletions(-)","diff":"diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\nindex 0ae8c06331..3aec0e047c 100644\n--- a/hw/usb/hcd-ehci.h\n+++ b/hw/usb/hcd-ehci.h\n@@ -202,13 +202,6 @@ typedef struct EHCIqh {\n #define BUFPTR_SBYTES_SH 5\n } EHCIqh;\n \n-/* EHCI spec version 1.0 Section 3.7\n- */\n-typedef struct EHCIfstn {\n- uint32_t next; /* Standard next link pointer */\n- uint32_t backptr; /* Standard next link pointer */\n-} EHCIfstn;\n-\n enum async_state {\n EHCI_ASYNC_NONE = 0,\n EHCI_ASYNC_INITIALIZED,\ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 57f930b099..5ea8461f70 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n /* Section 4.10.2 - paragraph 3 */\n static int ehci_state_advqueue(EHCIQueue *q)\n {\n-#if 0\n- /* TO-DO: 4.10.2 - paragraph 2\n- * if I-bit is set to 1 and QH is not active\n- * go to horizontal QH\n- */\n- if (I-bit set) {\n- ehci_set_state(ehci, async, EST_HORIZONTALQH);\n- goto out;\n- }\n-#endif\n-\n /*\n * want data and alt-next qTD is valid\n */\n","prefixes":["v2","01/17"]}