{"id":2222999,"url":"http://patchwork.ozlabs.org/api/patches/2222999/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-9-jamin_lin@aspeedtech.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414080025.3005916-9-jamin_lin@aspeedtech.com>","list_archive_url":null,"date":"2026-04-14T08:00:35","name":"[v2,08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without 64-bit capability","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"51430a696438c922fcf5c341b976770c1f9f0456","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/people/81768/?format=json","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-9-jamin_lin@aspeedtech.com/mbox/","series":[{"id":499795,"url":"http://patchwork.ozlabs.org/api/series/499795/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499795","date":"2026-04-14T08:00:26","name":"hw/usb/ehci: Add 64-bit descriptor addressing support","version":2,"mbox":"http://patchwork.ozlabs.org/series/499795/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222999/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222999/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=YavMIYNf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxcB5F9bz1yDF\n\tfor ; Tue, 14 Apr 2026 18:03:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCYhf-0003f6-LS; Tue, 14 Apr 2026 04:00:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCYhd-0003dz-H4; Tue, 14 Apr 2026 04:00:57 -0400","from mail-koreacentralazlp170130006.outbound.protection.outlook.com\n ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCYhc-0005oL-2R; Tue, 14 Apr 2026 04:00:57 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 08:00:36 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 08:00:36 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Ndb7YumKcqR+09RcXRTu+3SVumBkOWfLj/0kFJoFAoBkKKTfjjMAKUGWwhYS3GBrdWh/zHQwsmly0G2UZILf9VwZ1aYJsb+TitK7F6+TRy6WgD541gI2YK8yPy2zAudvZGEmOu8hfv2zOc6gLwNNC2ToHTb2YCPBG7p5OYvuRaC7EBKR7uxFGVzKlx2BagumZ0+S5mjrJVQuznVM+UFl0tAog8kbfheqZsud2SrL/GuZvBxvSYtYBGrOO5SEglkfeUaR2jGQbhAQBcm7UCmDaA8LOA8C6vUPmkfKvGOeyNTgZr4uBI3iKEzlnt9u5LTRg7F0zsNBeC8p+1PP2lYswA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=aU8IkWc7WfKzrDM3ZBQ+aMW/imqYQd9QOl9MxOe/UGs=;\n b=KOj0EVbqeQbLZP1f8Tn9DXSu9RxBSKtYuQWkmOWA1Gnd5TJeporIWCJ3R48WR+7n/c9kI7my+7ZQ+M5KRUesgw6JeS5IrfINVLWEOQz84fZRbmW0KxAE1Mzxn+8ZBOdAaIUfjDWXDVmRsH/gFVChf9kti9iy9u1MOJCOMKBbPjw4rwjtMDPsCTAD5UXLAgFHmH3rna08nQkvpO9Xm87QrCl2Xy6uFvYcfYKl6cplqJFq2cK4kH9ZrlU5MvCps3ZlywkSMSgdh99ZDOTmdBBmVUEa2S8yv7QQaYfxeubabezPPpw3epIT3pxOs2wCIa/jnmZUUMnxzn2F8FDPApLclA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=aU8IkWc7WfKzrDM3ZBQ+aMW/imqYQd9QOl9MxOe/UGs=;\n b=YavMIYNfyKZrL36x6M9ox0XXDpsjQrkac7uDufN7a4vMKWrgbMSnwxdxBHcMosaWJrlaJr1qVB8MszqManm72ES9IfNmf9kCqrPJD3yJE2nHaMbPPSmvHwhFnfgMMFyEJp6AeH69nx8Rz4odequTn3lO+GiqWUP/5Mh+T+sCciG4GjxKuRQmMqBvIm2+PwOMOciLWxjsUdz+MY3fqjrnVvmukNSx3fYi936PyMiJ2nIAIth2IGga/gEJ2oZdG4mq3FVl5cR0PsGoX4iz3cUd2Qe7F38BZOvfZ+lNnVl0cF+0d3xCGF7YLidkAS0P5DQSVFPNEV6yOXmWJUeqhGNK6A==","From":"Jamin Lin ","To":"=?iso-8859-1?q?C=E9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","CC":"Jamin Lin , Troy Lee ,\n \"flwu@google.com\" , \"nabihestefan@google.com\"\n ","Subject":"[PATCH v2 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes without\n 64-bit capability","Thread-Topic":"[PATCH v2 08/17] hw/usb/hcd-ehci: Reject CTRLDSSEGMENT writes\n without 64-bit capability","Thread-Index":"AQHcy+TG7IgZ0tbh9EGKhlnAj2UbFQ==","Date":"Tue, 14 Apr 2026 08:00:35 +0000","Message-ID":"<20260414080025.3005916-9-jamin_lin@aspeedtech.com>","References":"<20260414080025.3005916-1-jamin_lin@aspeedtech.com>","In-Reply-To":"<20260414080025.3005916-1-jamin_lin@aspeedtech.com>","Accept-Language":"zh-TW, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=YavMIYNf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|TYZPR06MB6745:EE_","x-ms-office365-filtering-correlation-id":"380b9096-beaa-47ff-ae7c-08de99fbe936","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003;","x-microsoft-antispam-message-info":"\n uKe/DhumztJHphZCStZJkcp6zB3rEt5k1waDo9T9jV/SLqXcgvfRWrpcchFHIeQ0oZ2WGfN5Q4zmkCjxSatHztVt2EJ9ooO9ON63JpTtIigTQu0AwSYJaQdFsA2tUKBbGQtP6kNgZea0zI9fNBzwwWLRc6p83xmShguusVVcTqf2W4oTZFQE0LUNIplHiBGc9npKQZ2L0OK0EleNrFEIJl82rJ6V8zkc5qG5JylbQdPtRJZJPhxghwgpFAofOTEuHu9j8xwOAzJU6yVqR07seKo+OmCBBmjoIX0wdBq4qCcCifybehvkSsj6OQuKSmYZp332NxX4/enD3/Ps3eGuzfMVxhFhxkAANMFVTRHwPz7zg4jxfiAF0wGuYxDlBtkhJencAoBKR/m0fC+DlChA3f4Nh8Oxj4Jx11gqDF+fF09WLctRR9cm4zF6mkNikldNmP/gOjkHCIIC6k0rFi/8nkyOZI6SvXsWB8Fjp4TNgzWxx4lFMKByA69LI3usZiz7RVffh9NgNYWm4dVEyC2BeUr0AFKr5wa05fcDrhTwuCuzmaXgZCFsimIN9qqMbVN6dYamSPcE0onMC027vOfBYrhUVMpnko87y2Fu25bm4jyACVWIRgf2YCVLOlMvixq1DRjRd/yenSlRZpLEHWdYZEz64ytJeUqxBlWUMsaDCJQGn0hDobJ8zmsC1QE2rGTHYULtSG3CGMhEY+iKB/ekyZrO64SPhehOtocFxyNTlLCTTLEy4jWrmxsdXX0uhFpi5GbAnNA69UZKsoskc4V8dyl1pJVR0SqIPwrXgx8rtd0=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?N4vbQ9fdCID3ir72TyItXjj?=\n\t=?iso-8859-1?q?EMMC3zgI96cGEcZ2BAwuugPM9/v9uqV+00Ctp7yy5sO6ZWmp1oyaNHzejUez?=\n\t=?iso-8859-1?q?EDa4LZvix0AwUSMNunqXeqnT7ME0PT9zdc1dwEYWO7WfglBJ/FXP/AzE1IzS?=\n\t=?iso-8859-1?q?cAqlBse0tAuID7O/+FLJzFp0HkdRPcHNJFki4groTNKVeEJcl2ebQpDtx2Gr?=\n\t=?iso-8859-1?q?u9xRZa3yISxuqFRVUJPIf7tK3s6PhIq6mMaFAXUQT9Msd9tpKGsD9Gpmvw2K?=\n\t=?iso-8859-1?q?xm8ifJds2BWNwibXhGYhPKNq8glQMwotOmQ9KEE20cAldQmxWH+QMGuKZcxa?=\n\t=?iso-8859-1?q?Vrqr10sGjPnbJUgnIQ2CHfYvibiavjX3WRHeL4ZDiouqsrRFMqrjlwdJQ415?=\n\t=?iso-8859-1?q?EXjwgS+tEWJfUkszUr3bKrFPtHxafkSLS+zU6zsiIHnT+XAYSDk+6oRbFMHW?=\n\t=?iso-8859-1?q?XLkPoPeOIcuy0HX3KaUz3W0mz3kFsvGNl48K+UKUIwDJuWe7LKfUq1mwhMjP?=\n\t=?iso-8859-1?q?aUXltqUUEldNe8bqvQGfH75uKjYPkyc87/ol9O7+wRTzu0aaVaLVLvw42vhc?=\n\t=?iso-8859-1?q?HaWJqAZe6+SOnDzF2FiyhhTBuil14VTJdEZn3s5UvgvvWJYoGH3KAjfZMFkX?=\n\t=?iso-8859-1?q?3A4L6MKkMyWKPChseFmbC28efWyJzDLgsDjfFL+wz0SdZJ9/8cUoB6RT8ZSl?=\n\t=?iso-8859-1?q?uJyJiZfYfKvTXGCST2tTCG9jarvCxeypFf4qGoxxMp0VQfPTdBb3fqpTuKtP?=\n\t=?iso-8859-1?q?m2K8JXy8DCkgIE4fAGum/p8xepNZ7K3hl+rCEIuuWOcpoEQzQUlCmfA93bSs?=\n\t=?iso-8859-1?q?brkCoBd9QG29A4cNOSovPhpT7+UGbmD9cN0akchsSqES8xDdFfFDIW8X2JXJ?=\n\t=?iso-8859-1?q?3dyTB+y2m5GPvfvLQrIhFBhRUuXsIdxUu5IGAYN7F93vPnUA08pnSrNPyyK8?=\n\t=?iso-8859-1?q?SR6UO9MrdSUweT8Y9kFiewGOVm0OE3SPxr3lQivLTxaf/byppEvtN2bZjwfB?=\n\t=?iso-8859-1?q?/ELKrJ3LXk4zA1Oy97oDNEX7ZkwOCgLxBdo+e1hFi36+NgllUyiOccTMa1Ys?=\n\t=?iso-8859-1?q?lM33nf7/j7+yVp3IITYlVnpn0x1LzWFnqGCHXCMp7/fV88OQukaQipIpeuiV?=\n\t=?iso-8859-1?q?QIm/KSp7wHVaZAWtJlvMj/FvXEHpbdj4D3wtEDSM8lSOJQjYa2FyssKUayyF?=\n\t=?iso-8859-1?q?UEO6mVASB21X0V1KTxjY3DU0ydpAK6U6N5sgQxxDCqw6/VGeTtgRABLl1kBL?=\n\t=?iso-8859-1?q?8TQGekFM/XO62LDxEcuVt5uwzRIU5akLV7fm7fDXChYcUGc4lS91o5Nwaxy9?=\n\t=?iso-8859-1?q?PE3nlGejPEBp2qFq7f4cI4VACHZvCIfgfzwOl5oswUAc4vwAwgO8E7Zd8vL7?=\n\t=?iso-8859-1?q?Aowu4pYF84EK4LEm+F4FpGtB+54Wyvs3uyj6b1QUfi80VaZQ5Q2sPDSwYleh?=\n\t=?iso-8859-1?q?iAbearmUpPF8odRwT5jZRsA673+MG1jU9G/CRjtNkCWUz16SuKltktjJSQe2?=\n\t=?iso-8859-1?q?XXrgTjSfQhlW2fFywPRnj9yMWOwSSETNBScjgwwEI4I1H80S/mdAwhT6YLDi?=\n\t=?iso-8859-1?q?UO22Pa1wSUsU+sRFuwBrdDwvkv1tUXqaA2z0TY5xOb9Wvks8DNdvEGULAxMr?=\n\t=?iso-8859-1?q?U5dVT+toiMHAFLOlhrCB4UOVLthQCmCItcVu7X0nPeKvqHpunomhxPyWv3f1?=\n\t=?iso-8859-1?q?avfiUvCmUCMiCARgtnEWsBmKTbWQy+GSWldLFvittKIPJIt3iNdVu9w+NY/Q?=\n\t=?iso-8859-1?q?n43NYM2rnbb4es9NwJ43jTTjOZyqnYUb7oat5mMdYvxGaPw=3D=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n r3zpIWIYoy41LzXldVmpY+/7Ruli4obMmlzOz/UiYhsyWR6eFs94psd78cZTVOoFBJkisrau3Zpf9LKK/XYTXkWGp//ya3Nmlri6MVcuXEf4x152fDHSRvdV6ZhKiu2240viiPF0cY1CcTOFpkAhwNUyQCYWSTTcm8vZyuug2U2lU0I3QRqV9oZzvVyPh+Ovf3aKhY4LqwBhxLolZePjEcMC+uif0gcbQRbQsYwluO5TfDw/6oYMKvOX2wTmhUCNQWk3zYU0/0ifg3c/UWG+4Y1wJJcf0IBOo89t1MtMjPmLN3zm01LBCtCr9wvzj4fvWhwryyJ21CH635SLYKosYg==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 380b9096-beaa-47ff-ae7c-08de99fbe936","X-MS-Exchange-CrossTenant-originalarrivaltime":"14 Apr 2026 08:00:35.7570 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n b6oxE8oLHeqlIzdWBs0xvOEFpXX5xyd3+uR7Xw8DcYDNo7J14HBWJsUKQaXPWmoDUt7ApddfTTOg0AvTpBkKrAt7VyhwtRYSRzBIVx6enmo=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TYZPR06MB6745","Received-SPF":"pass client-ip=2a01:111:f403:c40f::6;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=SEYPR02CU001.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The EHCI CTRLDSSEGMENT register provides the upper 32 bits [63:32] used to\nform 64-bit addresses for EHCI control data structures. Per EHCI 1.0\nspec section 2.3.5, when the HCCPARAMS 64-bit Addressing Capability bit\nis zero, CTRLDSSEGMENT is not used: software cannot write it and reads\nmust return zero.\n\nAdd a capability check in the operational register write handler and\nreject guest writes to CTRLDSSEGMENT when 64-bit addressing is\nnot enabled.\n\nSigned-off-by: Jamin Lin \n---\n hw/usb/hcd-ehci.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex e3bff8e518..54a1a6f7f3 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -1108,7 +1108,14 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \" is enabled and HC is enabled\\n\");\n }\n break;\n-\n+ case CTRLDSSEGMENT:\n+ if (!s->caps_64bit_addr) {\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"ehci: write to CTRLDSSEGMENT while \"\n+ \" 64-bit addressing capability is disabled\\n\");\n+ return;\n+ }\n+ break;\n case ASYNCLISTADDR:\n if (ehci_async_enabled(s)) {\n qemu_log_mask(LOG_GUEST_ERROR,\n","prefixes":["v2","08/17"]}