{"id":2222980,"url":"http://patchwork.ozlabs.org/api/patches/2222980/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260414063243.4062926-1-keerthana.kalyanasundaram@broadcom.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414063243.4062926-1-keerthana.kalyanasundaram@broadcom.com>","list_archive_url":null,"date":"2026-04-14T06:32:43","name":"[v5.10] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":true,"hash":"3dfc8451e538ab1b2092a11507cb35f9ee1e5103","submitter":{"id":92585,"url":"http://patchwork.ozlabs.org/api/people/92585/?format=json","name":"Keerthana K","email":"keerthana.kalyanasundaram@broadcom.com"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260414063243.4062926-1-keerthana.kalyanasundaram@broadcom.com/mbox/","series":[{"id":499784,"url":"http://patchwork.ozlabs.org/api/series/499784/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499784","date":"2026-04-14T06:32:43","name":"[v5.10] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","version":1,"mbox":"http://patchwork.ozlabs.org/series/499784/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222980/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222980/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256\n header.s=google header.b=Ti2EBGoj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11859-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=\"Ti2EBGoj\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.161.97","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=broadcom.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvvwg4p3Lz1yDF\n\tfor ; Tue, 14 Apr 2026 16:47:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 06FAB307E37A\n\tfor ; Tue, 14 Apr 2026 06:40:20 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 18683370D43;\n\tTue, 14 Apr 2026 06:40:19 +0000 (UTC)","from mail-oo1-f97.google.com (mail-oo1-f97.google.com\n [209.85.161.97])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC3936E48B\n\tfor ; Tue, 14 Apr 2026 06:40:17 +0000 (UTC)","by mail-oo1-f97.google.com with SMTP id\n 006d021491bc7-66dfeb899f4so139807eaf.1\n for ;\n Mon, 13 Apr 2026 23:40:17 -0700 (PDT)","from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com\n (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24])\n by smtp-relay.gmail.com with ESMTPS id\n 006d021491bc7-68bc84df866sm878004eaf.12.2026.04.13.23.40.15\n for \n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 13 Apr 2026 23:40:16 -0700 (PDT)","by mail-qk1-f198.google.com with SMTP id\n af79cd13be357-8cfd003bfe2so93340685a.0\n for ;\n Mon, 13 Apr 2026 23:40:14 -0700 (PDT)","from keerthanak-ph5-dev.. ([192.19.161.250])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8aca5222c8esm71566416d6.28.2026.04.13.23.40.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 23:40:13 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776148818; cv=none;\n b=lN8yKY01RrK/UAi8rpXeNASwNZpHSE6zU2Sgi2WF5VNNfLp3EsJ1orjVWZsNjv1Sd8o6qgS4SPsM8i42A2rh+TyZQ9HggR5foqmJvIcoIn0oR5PRmPEHi+VB+DULVMQldVLGg0iHKFKWv7XNzHEgElFTdjss9MOB2cyNEqZ/g/w=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776148818; c=relaxed/simple;\n\tbh=eUByrnPJ2nona1QXhiPKoFAJ4ou5D+Pn4Dg2jpFDt6M=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=PGfsius9L8SsrGUFTNdXtPablRKT2AM2C50zhN2ksykitEjyeHd7Bltm1qFk5rPLe+D4xlqQNPC1CIoawkCqWMrUyuXG2Me24Pk4Xjw9wMranaP53vB4+NNQcPmkMNLhLSzVRZ0637OUOGfPe7pC9oHD3XDsP89BBfAsOIgGaO4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com;\n spf=fail smtp.mailfrom=broadcom.com;\n dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=Ti2EBGoj; arc=none smtp.client-ip=209.85.161.97","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776148816; x=1776753616;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2l7i8vnpUJQTdJaWwY66SR5P0SKGOILNorZy9BBZKRQ=;\n b=DoUiVOpcQeRGCatTsBObTjqCEQhV98Sen2lUJTUd3qpqccR6+Rw+nPyYZX9/lri33O\n 9Q0RoCnNDJsJFvHLmh5vN+nMV3052/vS1gTJDrfPESTd2J4qyybUjbmPNeK8T+5lLQ56\n Vov5BHvR98mIqxYpEHLDO+bTj465tVfbKozP4hheFa+D3JrJRDdPyoDBvL0NGW/XuHUC\n hHgnabkTO7yMzguGAJ5JX4+N0rY5Ok4h5YORe4SaWfOqvJrDGM3GoFx4HiO9VjLMXeNN\n kYd4Qyg2PqNw3DdlkSLxCgjmmcaB33pa8xop8+mCTqVgx42Wes4iqfb/YuWXfFQrtpLj\n NsDA==","X-Forwarded-Encrypted":["i=1;\n AFNElJ80efjrEsrzzQQsAgT4Gv46NOGcu9Twtj8s4XmOKdhMJxHdy1shKshwHTPYPxxcHbV3ZKDL/MLH5nuHLLJ8OM8=@vger.kernel.org","i=1;\n AFNElJ9MxWlmqIl/zB42EJzYP8TogFKFCvF8/cnvfroTpUKKY45jeZe8qR6238SiFA1AgeWFfKNQXk4g7AOvY9LLDrI=@vger.kernel.org"],"X-Gm-Message-State":"AOJu0YwZkwzavqUCVu26YPWCLcsFBUNMvglPpbJOux/9QE5c7OtoXzNl\n\tqsDSYTqIS3MoqYf0HY2dIxrL3FnJi2JPN1HXl6WzIWtLI58uCA/dYeFehO9F25x0tzSq503RAoE\n\trjM1dynucrl7eSPIYNqy/suWD5MrcC84t2Z2E/xV+P3V1Se0Eylo7GZ/LA8aL6o1/24+bNgUM62\n\tHQSWg7MgvwPF6gLejxrlv4Vb3YOb0hxZb4xuTugrnT+Q/eEubVjz4j/qvrCMWUqeNtLKJeWzHLn\n\t2JSI7es7o2ic/6CiCb2S3rdQ5lJdPoYdouYHTcM5pU=","X-Gm-Gg":"AeBDieuyC/QP4F6HN4Z2VZ71V0MpMjuOEV12tLD/hwQ42ccCI2seCBLuGzYwK96GLTr\n\tL/HnN5OFqWfEVDNXrdTI909JEpr1S+lbBr6OdA/EM7zeTYAgWiM24YMEMWEyZMPxGhkzasrHmp8\n\tpO1W6EyoOODRGz3ayUimkx2ukg2doRRJJA3soJu1J+nfd3AGUp7IZJyxbgSsH5LD6W09weSUdq8\n\tMbUSYKC1ZG2GcXfRzaZT6Jf5B1tjiyuFWTvx1qtNgv+eJP15/LRqP19Mr/SELDiU3RRXcpmWPb6\n\tlEDpRMI+Gz4G2R8gUYPX8InLkSvVnJAn4on5L278PxHY/h/bSpRGxQlQatM/VthqyF7inCOwjPc\n\tlI5eWSbvl2hvJMTRWIOi0oKmR9WO5yNTwBbUhMzC/AL4LbIGJVuw4m/DwOxSj023P+U9a1WE7bz\n\tb8asFi0VYF9XbIQhlxISncAEdPorUp+2p0kSB8839rtrIS/UrJqAuGE0l62Im91dEhZ55xOjZj1\n\t1m9VgL8MZKp","X-Received":["by 2002:a05:6820:a284:10b0:682:ad5:f1d0 with SMTP id\n 006d021491bc7-68c291aac2bmr3392603eaf.2.1776148816286;\n Mon, 13 Apr 2026 23:40:16 -0700 (PDT)","by 2002:a05:620a:44d1:b0:8cf:c757:f1e8 with SMTP id\n af79cd13be357-8ddec1f0d27mr1636847185a.7.1776148814389;\n Mon, 13 Apr 2026 23:40:14 -0700 (PDT)","by 2002:a05:620a:44d1:b0:8cf:c757:f1e8 with SMTP id\n af79cd13be357-8ddec1f0d27mr1636845685a.7.1776148813891;\n Mon, 13 Apr 2026 23:40:13 -0700 (PDT)"],"X-Relaying-Domain":"broadcom.com","X-CFilter-Loop":"Reflected","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1776148814; x=1776753614;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=2l7i8vnpUJQTdJaWwY66SR5P0SKGOILNorZy9BBZKRQ=;\n b=Ti2EBGojhCEoCjHxHmHkv1o2ejoAfa6151Jh1Nh6c07CljOglc3Gg6ilw9iYl3JpGB\n MyCp2ORQ054YiPpwIYlIglO58Sqv24PC0plyxkj0v9j+V8Xu5h4yyx0afm3nrrgikHhv\n YJOtXhgylpAmOE1lrjxoGAuNW8CdR6HZ2Z9N4=","From":"Keerthana K ","To":"stable@vger.kernel.org,\n\tgregkh@linuxfoundation.org","Cc":"pablo@netfilter.org,\n\tkadlec@netfilter.org,\n\tfw@strlen.de,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tajay.kaher@broadcom.com,\n\talexey.makhalov@broadcom.com,\n\tvamsi-krishna.brahmajosyula@broadcom.com,\n\tyin.ding@broadcom.com,\n\ttapas.kundu@broadcom.com,\n\tStefano Brivio ,\n\tMukul Sikka ,\n\tBrennan Lamoreaux ,\n\tKeerthana K ","Subject":"[PATCH v5.10] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","Date":"Tue, 14 Apr 2026 06:32:43 +0000","Message-ID":"<20260414063243.4062926-1-keerthana.kalyanasundaram@broadcom.com>","X-Mailer":"git-send-email 2.43.7","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-DetectorID-Processed":"b00c1d49-9d2e-4205-b15f-d015386d3d5e"},"content":"From: Florian Westphal \n\ncommit 07ace0bbe03b3d8e85869af1dec5e4087b1d57b8 upstream\n\npipapo relies on kmalloc(0) returning ZERO_SIZE_PTR (i.e., not NULL\nbut pointer is invalid).\n\nRework this to not call slab allocator when we'd request a 0-byte\nallocation.\n\nReviewed-by: Stefano Brivio \nSigned-off-by: Florian Westphal \nSigned-off-by: Mukul Sikka \nSigned-off-by: Brennan Lamoreaux \n[Keerthana: In older stable branches (v6.6 and earlier), the allocation logic in\npipapo_clone() still relies on `src->rules` rather than `src->rules_alloc`\n(introduced in v6.9 via 9f439bd6ef4f). Consequently, the previously\nbackported INT_MAX clamping check uses `src->rules`. This patch correctly\nmoves that `src->rules > (INT_MAX / ...)` check inside the new\n`if (src->rules > 0)` block]\nSigned-off-by: Keerthana K \n---\n net/netfilter/nft_set_pipapo.c | 21 +++++++++++++++------\n 1 file changed, 15 insertions(+), 6 deletions(-)","diff":"diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c\nindex a4fdd1587bb3..83606dfde033 100644\n--- a/net/netfilter/nft_set_pipapo.c\n+++ b/net/netfilter/nft_set_pipapo.c\n@@ -524,6 +524,9 @@ static struct nft_pipapo_elem *pipapo_get(const struct net *net,\n \tstruct nft_pipapo_field *f;\n \tint i;\n \n+\tif (m->bsize_max == 0)\n+\t\treturn ret;\n+\n \tres_map = kmalloc_array(m->bsize_max, sizeof(*res_map), GFP_ATOMIC);\n \tif (!res_map) {\n \t\tret = ERR_PTR(-ENOMEM);\n@@ -1363,14 +1366,20 @@ static struct nft_pipapo_match *pipapo_clone(struct nft_pipapo_match *old)\n \t\t src->bsize * sizeof(*dst->lt) *\n \t\t src->groups * NFT_PIPAPO_BUCKETS(src->bb));\n \n-\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n-\t\t\tgoto out_mt;\n+\t\tif (src->rules > 0) {\n+\t\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n+\t\t\t\tgoto out_mt;\n \n-\t\tdst->mt = kvmalloc(src->rules * sizeof(*src->mt), GFP_KERNEL);\n-\t\tif (!dst->mt)\n-\t\t\tgoto out_mt;\n+\t\t\tdst->mt = kvmalloc_array(src->rules, sizeof(*src->mt),\n+\t\t\t\t\t\t GFP_KERNEL);\n+\t\t\tif (!dst->mt)\n+\t\t\t\tgoto out_mt;\n+\n+\t\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n+\t\t} else {\n+\t\t\tdst->mt = NULL;\n+\t\t}\n \n-\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n \t\tsrc++;\n \t\tdst++;\n \t}\n","prefixes":["v5.10"]}