{"id":2222978,"url":"http://patchwork.ozlabs.org/api/patches/2222978/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260414063131.4054234-1-keerthana.kalyanasundaram@broadcom.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414063131.4054234-1-keerthana.kalyanasundaram@broadcom.com>","list_archive_url":null,"date":"2026-04-14T06:31:31","name":"[v2,v5.15-v6.1] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":true,"hash":"6dbc351232eab70e92d0dc0c4e849f55ffac350a","submitter":{"id":92585,"url":"http://patchwork.ozlabs.org/api/people/92585/?format=json","name":"Keerthana K","email":"keerthana.kalyanasundaram@broadcom.com"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260414063131.4054234-1-keerthana.kalyanasundaram@broadcom.com/mbox/","series":[{"id":499782,"url":"http://patchwork.ozlabs.org/api/series/499782/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499782","date":"2026-04-14T06:31:31","name":"[v2,v5.15-v6.1] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","version":2,"mbox":"http://patchwork.ozlabs.org/series/499782/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222978/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222978/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256\n header.s=google header.b=Eu6URQhC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11858-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=\"Eu6URQhC\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.98","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=broadcom.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvvtc5z2qz1yDF\n\tfor ; Tue, 14 Apr 2026 16:46:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C482D30B2AB4\n\tfor ; Tue, 14 Apr 2026 06:39:05 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3964F370D53;\n\tTue, 14 Apr 2026 06:39:04 +0000 (UTC)","from mail-pj1-f98.google.com (mail-pj1-f98.google.com\n [209.85.216.98])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD7536EA86\n\tfor ; Tue, 14 Apr 2026 06:39:02 +0000 (UTC)","by mail-pj1-f98.google.com with SMTP id\n 98e67ed59e1d1-35e57611113so389887a91.0\n for ;\n Mon, 13 Apr 2026 23:39:02 -0700 (PDT)","from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com\n (address-144-49-247-15.dlp.protect.broadcom.com. [144.49.247.15])\n by smtp-relay.gmail.com with ESMTPS id\n 98e67ed59e1d1-35fc6efeba7sm93170a91.6.2026.04.13.23.39.01\n for \n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 13 Apr 2026 23:39:01 -0700 (PDT)","by mail-dl1-f70.google.com with SMTP id\n a92af1059eb24-1273683a5dcso1000923c88.1\n for ;\n Mon, 13 Apr 2026 23:39:00 -0700 (PDT)","from keerthanak-ph5-dev.. ([192.19.161.250])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2d5630ac330sm19396261eec.29.2026.04.13.23.38.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 23:38:58 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776148743; cv=none;\n b=cArj9GvMER+8GPNnixKSUHjTD1qhae2pTo+uWvaDK3DsSkPLI/yTx9hL2lRueSwD2jW9Bxlxl7tpsF9uedH720Oh2YssveJ0viOmJyw0K/Czedo4DaQTmS+M9iIYgyQspiXV8fbLWxqPhbwnU6B8w5ixx5FoSKN0b531o2JCQMo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776148743; c=relaxed/simple;\n\tbh=5ww9EE9Omd+lxTQKlJOWj/4hV3jbfueaHdGT5uwPtjc=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=r1uRTkEissngBg9+yrQRTpolmI2v7231nV1/wuF4jolGoGd+qYRX0iTKp3Eqmfz/y4tH0BfFUrO3lCuzr+09KYkcxnH02RKrvHoz83XRrlNjuaVts4QCEFyUVb7aQcGDYujivnA2oXRRa8DVmWKHFGZ2uPXalSdxuZAiuRZYJ2U=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com;\n spf=fail smtp.mailfrom=broadcom.com;\n dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=Eu6URQhC; arc=none smtp.client-ip=209.85.216.98","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776148742; x=1776753542;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=GYL2a3cReHZZ5YSJ0wmm3zCuDsPFAtU2gKvk7jCr2V0=;\n b=hRTJgFZqohM8Q9pbbh2Poybag1TUHJy0aWXXE/e1Sk5Bg6t/gKk8hxClB1P9uzh0Jv\n lkeDk6WzfD68++X9Jg01fyaoSnJk+jIB++oMDWxLm+oR9Whk1WXoTK5pXH7XYwOPsq8L\n sgJuHeqrMAjBQlnQMX5h4nf2q7XA5oySeZuRUCR3m3ruWHdIR+A7pNWbHDwfNi815NZy\n +WJk6fjHABz+Fz8jNRimY2YcWNnjjJuAAeXllH49LjALpYvRucYztLsqKOKZ5okYaysp\n ZX4xZ7AtewTK3+RzwdPxSE/EMLVYFuvwwnkg75sp9yH/t1pIYEwbWnii0wRHYWbB6xhD\n 956w==","X-Forwarded-Encrypted":["i=1;\n AFNElJ/8+9evsC67LINDkVyGhg+DUW/quRa/K4SmzEBOZYEhTL1FIlelg5IYT7qYAWEp7czfQ5/gLwqHTumycgE5l8Y=@vger.kernel.org","i=1;\n AFNElJ+zIKFSAK+8Z4EoEPrRyDoSyHFC4Yokpsn55XQNnvqmu/iTt3GskpmC7v6m0Guwkpm4xLxZ3vgyQnOyJpENZgQ=@vger.kernel.org"],"X-Gm-Message-State":"AOJu0Yx2d6JOW4ZK5UGW8duU2HYSQMU82kzusx6cwWgv96fnaT5x3KSg\n\tbqshqUM+x0gm8jx69uAnJbM1pzkA6j0gtz8UEtNKSp/oLh8m+0gvr5U9UXnZeUxeqNnWEZFE1uK\n\tIhBvJpp9mHOYwO9ThFl0KaR8nyC7qBaOkIeFOCdOsjY9i/ZTejIDxggUocNhgXc9AhP7T13b7gd\n\tDxYnIrGZF86Cg9oLN95B0AJsLujplAJZJvniWFN8F2ZHVbhQeGwraDPSPX5l3k+rpD8TfLVOeWN\n\tvbZsrQToTQQjq9UKOcrxk4EJMu6Or2fnfQDxP//NMQ=","X-Gm-Gg":"AeBDiev4P/JXvtHjTjOdNDLacJ/a30WNjkRrIWebsKVNhAba6s+zN7PqeJS0383SXJp\n\tRMuV0qFhffTr3aqXzv6nXrjjJ2y9GavCsFRmnDdYdccnBdOPGghaeC0OWKoYOnhMJATdoiI3rGa\n\t6E9eyucvUWppSryD1F1O+MXXLTDMWm21papKoq0FAn6mcQdsYZzEdaXlbA17LMk+TyOFgp4JNZv\n\teFEYu3JJnHsE2G7b6FaRGhottGdrxBKB/4Poupliijgf7r5N9M7DXr4aI1zlkFv3qySWLB6E34a\n\tG+vKljfub0Fu2D1RH9xU1mDec9O+FL5tA9IRnsNt/WH2BSnWQbai/iP9Pisav9xUkaAwvYpHF/S\n\tGCAWmmgtu1Tm35k3eOhvkh9RpPtVYF+Ml6J3wEKNvejAUvypg8z2If8xQvg1YZVDcoEZU8NUwht\n\tDNAdrr6s38DZDochai9pl9NgUPHbTJjHDiJaZd7GwUEQqwwmeEc8sBHorV0yVygt8lDLEu09BHS\n\t0u4cLGwFMrg","X-Received":["by 2002:a17:90b:4b8d:b0:35b:94db:fdaf with SMTP id\n 98e67ed59e1d1-35e44297be3mr9644057a91.4.1776148741647;\n Mon, 13 Apr 2026 23:39:01 -0700 (PDT)","by 2002:a05:693c:300d:b0:2bd:d8e6:90a0 with SMTP id\n 5a478bee46e88-2d5c39f6544mr3735045eec.3.1776148739852;\n Mon, 13 Apr 2026 23:38:59 -0700 (PDT)","by 2002:a05:693c:300d:b0:2bd:d8e6:90a0 with SMTP id\n 5a478bee46e88-2d5c39f6544mr3735024eec.3.1776148739232;\n Mon, 13 Apr 2026 23:38:59 -0700 (PDT)"],"X-Relaying-Domain":"broadcom.com","X-CFilter-Loop":"Reflected","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1776148740; x=1776753540;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=GYL2a3cReHZZ5YSJ0wmm3zCuDsPFAtU2gKvk7jCr2V0=;\n b=Eu6URQhC3iV+FnxPjArmO6tA160eauufzD4dJrNcAGsjIEKmhoPe+M155F533tudRM\n aBOuuIHfTDbnk8XaO/rMhC9jeTdykKu+Ucy+WjyTaeH0N2oaKJTwr+K3CmD26fAPv1cB\n AXqdps3MPyjfegbB4WX8ZDl9c+6tZqCxukoAA=","From":"Keerthana K ","To":"stable@vger.kernel.org,\n\tgregkh@linuxfoundation.org","Cc":"pablo@netfilter.org,\n\tkadlec@netfilter.org,\n\tfw@strlen.de,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tajay.kaher@broadcom.com,\n\talexey.makhalov@broadcom.com,\n\tvamsi-krishna.brahmajosyula@broadcom.com,\n\tyin.ding@broadcom.com,\n\ttapas.kundu@broadcom.com,\n\tStefano Brivio ,\n\tMukul Sikka ,\n\tBrennan Lamoreaux ,\n\tKeerthana K ","Subject":"[PATCH v2 v5.15-v6.1] netfilter: nft_set_pipapo: do not rely on\n ZERO_SIZE_PTR","Date":"Tue, 14 Apr 2026 06:31:31 +0000","Message-ID":"<20260414063131.4054234-1-keerthana.kalyanasundaram@broadcom.com>","X-Mailer":"git-send-email 2.43.7","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-DetectorID-Processed":"b00c1d49-9d2e-4205-b15f-d015386d3d5e"},"content":"From: Florian Westphal \n\ncommit 07ace0bbe03b3d8e85869af1dec5e4087b1d57b8 upstream\n\npipapo relies on kmalloc(0) returning ZERO_SIZE_PTR (i.e., not NULL\nbut pointer is invalid).\n\nRework this to not call slab allocator when we'd request a 0-byte\nallocation.\n\nReviewed-by: Stefano Brivio \nSigned-off-by: Florian Westphal \nSigned-off-by: Mukul Sikka \nSigned-off-by: Brennan Lamoreaux \n[Keerthana: In older stable branches (v6.6 and earlier), the allocation logic in\npipapo_clone() still relies on `src->rules` rather than `src->rules_alloc`\n(introduced in v6.9 via 9f439bd6ef4f). Consequently, the previously\nbackported INT_MAX clamping check uses `src->rules`. This patch correctly\nmoves that `src->rules > (INT_MAX / ...)` check inside the new\n`if (src->rules > 0)` block]\nSigned-off-by: Keerthana K \n---\nChanges in v2:\n- Fixed patch apply failure\n\nv1: https://lore.kernel.org/all/20260413043247.3327855-1-keerthana.kalyanasundaram@broadcom.com/\n\n net/netfilter/nft_set_pipapo.c | 20 ++++++++++++++------\n 1 file changed, 14 insertions(+), 6 deletions(-)","diff":"diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c\nindex 863162c82330..2072c89a467d 100644\n--- a/net/netfilter/nft_set_pipapo.c\n+++ b/net/netfilter/nft_set_pipapo.c\n@@ -525,6 +525,8 @@ static struct nft_pipapo_elem *pipapo_get(const struct net *net,\n \tint i;\n \n \tm = priv->clone;\n+\tif (m->bsize_max == 0)\n+\t\treturn ret;\n \n \tres_map = kmalloc_array(m->bsize_max, sizeof(*res_map), GFP_ATOMIC);\n \tif (!res_map) {\n@@ -1365,14 +1367,20 @@ static struct nft_pipapo_match *pipapo_clone(struct nft_pipapo_match *old)\n \t\t src->bsize * sizeof(*dst->lt) *\n \t\t src->groups * NFT_PIPAPO_BUCKETS(src->bb));\n \n-\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n-\t\t\tgoto out_mt;\n+\t\tif (src->rules > 0) {\n+\t\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n+\t\t\t\tgoto out_mt;\n+\n+\t\t\tdst->mt = kvmalloc_array(src->rules, sizeof(*src->mt),\n+\t\t\t\t\t\t GFP_KERNEL);\n+\t\t\tif (!dst->mt)\n+\t\t\t\tgoto out_mt;\n \n-\t\tdst->mt = kvmalloc(src->rules * sizeof(*src->mt), GFP_KERNEL);\n-\t\tif (!dst->mt)\n-\t\t\tgoto out_mt;\n+\t\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n+\t\t} else {\n+\t\t\tdst->mt = NULL;\n+\t\t}\n \n-\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n \t\tsrc++;\n \t\tdst++;\n \t}\n","prefixes":["v2","v5.15-v6.1"]}