{"id":2222968,"url":"http://patchwork.ozlabs.org/api/patches/2222968/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20260414-s2mu005-pmic-v4-8-7fe7480577e6@disroot.org/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414-s2mu005-pmic-v4-8-7fe7480577e6@disroot.org>","list_archive_url":null,"date":"2026-04-14T06:33:00","name":"[v4,08/13] mfd: sec: resolve PMIC revision in S2MU005","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d6d4279f8344b36866701f1a2b3081b5d9c68098","submitter":{"id":88698,"url":"http://patchwork.ozlabs.org/api/people/88698/?format=json","name":"Kaustabh Chakraborty","email":"kauschluss@disroot.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/20260414-s2mu005-pmic-v4-8-7fe7480577e6@disroot.org/mbox/","series":[{"id":499781,"url":"http://patchwork.ozlabs.org/api/series/499781/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=499781","date":"2026-04-14T06:32:53","name":"Support for Samsung S2MU005 PMIC and its sub-devices","version":4,"mbox":"http://patchwork.ozlabs.org/series/499781/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222968/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222968/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=disroot.org header.i=@disroot.org header.a=rsa-sha256\n header.s=mail header.b=dkvQJKY7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6324-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org\n header.b=\"dkvQJKY7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=178.21.23.139","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=disroot.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=disroot.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvvfh1h2Wz1y2d\n\tfor ; Tue, 14 Apr 2026 16:35:40 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 6DCAC30628D8\n\tfor ; Tue, 14 Apr 2026 06:34:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 084A536E466;\n\tTue, 14 Apr 2026 06:34:09 +0000 (UTC)","from layka.disroot.org (layka.disroot.org [178.21.23.139])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E5636E48E;\n\tTue, 14 Apr 2026 06:34:07 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1])\n\tby disroot.org (Postfix) with ESMTP id BE78A2650D;\n\tTue, 14 Apr 2026 08:34:05 +0200 (CEST)","from layka.disroot.org ([127.0.0.1])\n by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Y4442GowqPVb; Tue, 14 Apr 2026 08:34:05 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776148448; cv=none;\n b=tp/NY/9ihrGmaG1B9zYw9eWKIbHVD5yGVvcHyoPQ2XYby/Ys4JsGGvWxYLcPQ4PwTSYtPMDjnkLg9irYMqbzjCLs1Veg+y8XXuVSN5k+iMTxF8z/GJeE89N22b+Y0dZJy2eiq2qPcL0XrLod79LoqguG6lVODCJztpd+tuutGrk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776148448; c=relaxed/simple;\n\tbh=3JY42Vf1SNv8/FMxe2JJ5LDxHnc0a3Q8zyvF8JRl1PQ=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=GliXtcqyou2QpD/nqk9h8ADElaTEEu2az7uhIMzC1PALNfRR1T4thveXLX0xmEVhqVaJn3oIqk1qg+P+VN94OsDMjYvKzNrjn6F/v9XJz9RRm4LaSMnMe4B7cdQg7jRMAx5BXNO0BFuwxUMcTEfc5t4IcRgTE3AJyBItRlOdmz8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=disroot.org;\n spf=pass smtp.mailfrom=disroot.org;\n dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org\n header.b=dkvQJKY7; arc=none smtp.client-ip=178.21.23.139","X-Virus-Scanned":"SPAM Filter at disroot.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;\n\tt=1776148445; bh=3JY42Vf1SNv8/FMxe2JJ5LDxHnc0a3Q8zyvF8JRl1PQ=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc;\n\tb=dkvQJKY73jg51Po2BWhu7OZ2JT3E1HmnSWDmRJgNwwgJOzlOUOavBxMrGI/O5OJBX\n\t fdXgPE7HYT8QNidW9kUbe0Q81pzuPNVsyvcyRJlm5twqtlr384gmWME67n0gAbA9nm\n\t Xk/7AqBo0t9POyRrMtisXeWdkBe+ysya/f3zRZTEtxiVM5UmbGzBqe2KJE7krcO5V7\n\t 3f9jNYpuWSZq6AGUlG2H/mjRSbCH/F6LGhR3Cu+HouLnixSjZ4oVkJUGJOij06H1Us\n\t uGc4yiSryI9Cmb1HlbR5jaSU9RDTCHxMZ/SUmXh2UDIB1FAM4zkAaYpGjw883p4Lqk\n\t Ak9jDrONy0cmw==","From":"Kaustabh Chakraborty ","Date":"Tue, 14 Apr 2026 12:03:00 +0530","Subject":"[PATCH v4 08/13] mfd: sec: resolve PMIC revision in S2MU005","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260414-s2mu005-pmic-v4-8-7fe7480577e6@disroot.org>","References":"<20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org>","In-Reply-To":"<20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org>","To":"Lee Jones , Pavel Machek ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , MyungJoo Ham ,\n Chanwoo Choi , Sebastian Reichel ,\n Krzysztof Kozlowski ,\n =?utf-8?q?Andr=C3=A9_Draszik?= ,\n Alexandre Belloni ,\n Jonathan Corbet , Shuah Khan ,\n Nam Tran ,\n =?utf-8?b?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= ","Cc":"linux-leds@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,\n linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org,\n linux-doc@vger.kernel.org, Kaustabh Chakraborty "},"content":"In devices other than S2MPG1X, the revision can be retrieved from the\nfirst register of the PMIC regmap. In S2MU005 however, the location is\nin offset 0x73. Introduce a switch-case block to allow selecting the\nREG_ID register.\n\nS2MU005 also has a field mask for the revision. Apply it using\nFIELD_GET() and get the extracted value.\n\nSigned-off-by: Kaustabh Chakraborty \n---\n drivers/mfd/sec-common.c | 18 +++++++++++++-----\n 1 file changed, 13 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c\nindex 883e6d0aa3f06..43215605191e4 100644\n--- a/drivers/mfd/sec-common.c\n+++ b/drivers/mfd/sec-common.c\n@@ -16,6 +16,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -119,20 +120,27 @@ static const struct mfd_cell s2mu005_devs[] = {\n \n static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic)\n {\n-\tunsigned int val;\n+\tunsigned int reg, mask, val;\n \n-\t/* For s2mpg1x, the revision is in a different regmap */\n \tswitch (sec_pmic->device_type) {\n \tcase S2MPG10:\n \tcase S2MPG11:\n+\t\t/* For s2mpg1x, the revision is in a different regmap */\n \t\treturn;\n-\tdefault:\n+\tcase S2MU005:\n+\t\treg = S2MU005_REG_ID;\n+\t\tmask = S2MU005_ID_MASK;\n \t\tbreak;\n+\tdefault:\n+\t\t/* For other device types, REG_ID is always the first register. */\n+\t\treg = S2MPS11_REG_ID;\n+\t\tmask = ~0;\n \t}\n \n-\t/* For each device type, the REG_ID is always the first register */\n-\tif (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val))\n+\tif (!regmap_read(sec_pmic->regmap_pmic, reg, &val)) {\n+\t\tval = FIELD_GET(S2MU005_ID_MASK, val);\n \t\tdev_dbg(sec_pmic->dev, \"Revision: 0x%x\\n\", val);\n+\t}\n }\n \n static void sec_pmic_configure(struct sec_pmic_dev *sec_pmic)\n","prefixes":["v4","08/13"]}