{"id":2222478,"url":"http://patchwork.ozlabs.org/api/patches/2222478/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412071754.569575-1-mjt@tls.msk.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412071754.569575-1-mjt@tls.msk.ru>","list_archive_url":null,"date":"2026-04-12T07:17:49","name":"[trivial,v3] net/slirp: allow hostfwd socket paths with dashes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4dd39687fa5342aaa95d3f75488de54bac198a79","submitter":{"id":183,"url":"http://patchwork.ozlabs.org/api/people/183/?format=json","name":"Michael Tokarev","email":"mjt@tls.msk.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412071754.569575-1-mjt@tls.msk.ru/mbox/","series":[{"id":499587,"url":"http://patchwork.ozlabs.org/api/series/499587/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499587","date":"2026-04-12T07:17:49","name":"[trivial,v3] net/slirp: allow hostfwd socket paths with dashes","version":3,"mbox":"http://patchwork.ozlabs.org/series/499587/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222478/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222478/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=tls.msk.ru header.i=@tls.msk.ru header.a=rsa-sha256\n header.s=202602 header.b=ncI27t+U;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fthjR1z42z1y2d\n\tfor ; Sun, 12 Apr 2026 17:18:49 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBp5C-0007ZQ-1x; Sun, 12 Apr 2026 03:18:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBp59-0007Z7-2l; Sun, 12 Apr 2026 03:18:11 -0400","from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBp56-00057T-9q; Sun, 12 Apr 2026 03:18:10 -0400","from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id 3039A19D611;\n Sun, 12 Apr 2026 10:17:09 +0300 (MSK)","from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by tsrv.corpit.ru (Postfix) with ESMTP id E3306394611;\n Sun, 12 Apr 2026 10:18:03 +0300 (MSK)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602;\n t=1775978229; bh=Ii6uLQ7SVYIqmQDuAU/zlm75kkuTaU3xz0u4cZXiKP4=;\n h=From:To:Cc:Subject:Date;\n b=ncI27t+UjP2SvbTvtN9hZQpigYdeg31Kj9UWSMltbEWEJjOZfwkiqDrKLKTQtf+6Z\n BAy0p6bkcByG8NUcUP3xJU8ou9XtixvImGpG3Rpw8XFHCy8vvIO2dWTkz74n3+Vc5W\n KMmkJ+X/w/wT7ABSuw9TU5Jqa6480y5Lx1CIxEIW92Ax4CQ0x6G2qpaMVfJ4de1Z8J\n YiYjZpAq8pfXYK80WELosiluEi25k8R2kjYbgniLG3rMW5W7YbmPaIOghk9CPchV8J\n 6rlZrBPVE6vNN0GXVJqTYjQihEcdwW9WXJ8n7AxrsjAl0y6QhLhtvMwCqXm3MPkrVo\n PU0IVTN6TzVkg==","From":"Michael Tokarev ","To":"qemu-devel@nongnu.org","Cc":"Michael Tokarev , qemu-trivial@nongnu.org,\n Christopher Palmer-Richez ","Subject":"[PATCH trivial v3] net/slirp: allow hostfwd socket paths with dashes","Date":"Sun, 12 Apr 2026 10:17:49 +0300","Message-ID":"<20260412071754.569575-1-mjt@tls.msk.ru>","X-Mailer":"git-send-email 2.47.3","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The format of hostfwd parameter is:\n hostfwd=hostpart-guestaddr:guestport\nso a minus sign can not be part of the hostpart.\nIf hostpart specifies a unix socket path, this becomes problematic.\n\nTo solve this, look for the LAST minus/dash char in the string,\nnot first.\n\nUnfortunately, [-guestaddr] is optional (defaults to 10.0.0.15),\nso we still can't parse the thing in an uniform way.\n\nExtend get_str_sep() to accept negative separator to indicate searching\nfrom the end of buffer, to find the last occurence. Update slirp_hostfwd\nto search for the last separator when parsing unix domain socket path.\n\nInspired-by: Christopher Palmer-Richez \nResolves: https://gitlab.com/qemu-project/qemu/-/issues/347\nSigned-off-by: Michael Tokarev \n---\nv3: instead of adding an additional argument to\n get_str_sep() and changing all callers,\n (ab)use signedness of the separator.\n\n net/slirp.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/net/slirp.c b/net/slirp.c\nindex 04925f3318..847e7dab63 100644\n--- a/net/slirp.c\n+++ b/net/slirp.c\n@@ -54,7 +54,8 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)\n const char *p, *p1;\n int len;\n p = *pp;\n- p1 = strchr(p, sep);\n+ /* negative sep means to search -sep from the end of buf */\n+ p1 = sep >= 0 ? strchr(p, sep) : strrchr(p, -sep);\n if (!p1)\n return -1;\n len = p1 - p;\n@@ -848,7 +849,7 @@ static int slirp_hostfwd(SlirpState *s, const char *redir_str, Error **errp)\n \n #if !defined(WIN32) && SLIRP_CHECK_VERSION(4, 7, 0)\n if (is_unix) {\n- if (get_str_sep(buf, sizeof(buf), &p, '-') < 0) {\n+ if (get_str_sep(buf, sizeof(buf), &p, 0 - '-') < 0) {\n fail_reason = \"Missing - separator\";\n goto fail_syntax;\n }\n","prefixes":["trivial","v3"]}