{"id":2222438,"url":"http://patchwork.ozlabs.org/api/patches/2222438/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260411185721.234936-1-devnexen@gmail.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260411185721.234936-1-devnexen@gmail.com>","list_archive_url":null,"date":"2026-04-11T18:57:21","name":"netfilter: nfnl_cthelper: apply per-class values when updating policies","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f29a611338ce9e578da8b5d72817bc62d55049db","submitter":{"id":76714,"url":"http://patchwork.ozlabs.org/api/people/76714/?format=json","name":"David Carlier","email":"devnexen@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260411185721.234936-1-devnexen@gmail.com/mbox/","series":[{"id":499570,"url":"http://patchwork.ozlabs.org/api/series/499570/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499570","date":"2026-04-11T18:57:21","name":"netfilter: nfnl_cthelper: apply per-class values when updating policies","version":1,"mbox":"http://patchwork.ozlabs.org/series/499570/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222438/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222438/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hYeH1gIm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11823-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"hYeH1gIm\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.42","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftNJ226v6z1yGb\n\tfor ; Sun, 12 Apr 2026 04:59:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 676003067B3D\n\tfor ; Sat, 11 Apr 2026 18:57:30 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 489283BADBC;\n\tSat, 11 Apr 2026 18:57:29 +0000 (UTC)","from mail-wm1-f42.google.com (mail-wm1-f42.google.com\n [209.85.128.42])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F8DD3B6C07\n\tfor ; Sat, 11 Apr 2026 18:57:26 +0000 (UTC)","by mail-wm1-f42.google.com with SMTP id\n 5b1f17b1804b1-4887fd35e60so21508375e9.2\n for ;\n Sat, 11 Apr 2026 11:57:26 -0700 (PDT)","from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d5d703c1sm52012375e9.3.2026.04.11.11.57.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 11 Apr 2026 11:57:24 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775933848; cv=none;\n b=H8HvIyeDAtjm85z0Zayilb1aDSbszpt9c9hmk8zZvPuT06dCoX2GiXFUV95ie190FIUQGSW7xorzRKYzp/exp96usO01MRiZly2QhC8A7m67PM841K8tQADrFYK3ijB4v1LGTqBWDnCfA5/gla+mA2Csn0aP2ayxlL3DXlkqgDY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775933848; c=relaxed/simple;\n\tbh=s8DvPKpa7mA+qHyXVl0NHzUIBYxwCvFo6gHuWEJk5ds=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=FTQomQe+zxhA74VdxdnIR7GULyelx9DrnxKizikpEktBjhskLlRiBRtQKIaoanW6iVdfMaX33GTJdaCxBYL3KmDBcYcLSutvX051AE9HhkvAhRA1O6kbU2SkARBdSCihgKhmaVON0MfWiXlotGdq2B0b/MeCkIV4eGOV8bJuIiE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=hYeH1gIm; arc=none smtp.client-ip=209.85.128.42","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775933845; x=1776538645;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=asmRMjtAdynfNNM/fvaGPOkC+0FMwoOWdK0OJmKnM5g=;\n b=hYeH1gImvN7NJBo9KDzRBfBCU34VMqRUt3zcgO3EWYAsUqIY5OTjRLykxui8j5YE+L\n XOfSgf5Ktids1LRZsNLletkNN9fgWzWM/0YSYo/l5NiRTt6XKsttoOnDhLty1t4+Bw7z\n /pSrJZ1CAMvWigIzzRCz6oBAPrxKYkN/4Ml7zKuVJGLsl3kmUWJy9lX/xJWy28H5irfm\n IQUUXCSxLLeWFulg0mLsBmgj5JwH1PxeAAObMroxcbsQHLFDn5/cf3wUC5PlZEVxXo6w\n SCffgYGNqdPVFQGYyn4nd9Woq3OiPmOxpFv/4EL5o6aVzXJZosgZ/1KY1CCl8L3XLk21\n py9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775933845; x=1776538645;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=asmRMjtAdynfNNM/fvaGPOkC+0FMwoOWdK0OJmKnM5g=;\n b=QoRICbMVMDKTAQhyS97y43wbK5K53oxB2eUjLK9ABI0Hxo3fOSklPHmGeFwCV6AQUI\n o0D4UWhYNsT/nAtOTmoRVBpEKIPQEP+HzVpksMsxQAOdQpePaCAbubs8BWf8/prOyR+3\n HqpERt06dQEU4Mm57N+qkUPpTa4z83/vR4t4ze2TUo6qdgGyKyn41vILFDgmeN1UjhHh\n /Udw/YsNVfQrD5ycRSV543tsJ5N9SWXZWsBe/apBnjfLJQDm5UtXm0eZlDLhXAIyHX6X\n KgHk8BHkYL0/Gj5DI39WwGRDQZVNhYK2V6/sMSzBag0LTSNfaO76dY3VKAFHpcy+1LnN\n W+6g==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX107IQ78SrpJw7MkLdC0SV90LTxu/f/+dsd5rWkKPHkmWb1UlTGOXl2UXAD4C4P+rs9JsEtq/xTNmHr4q2ezg=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzPUIW1HSKosTQIHJeq2t6VoYb77dbLGSqhjqTMvDaE/MgDCx46\n\t7m9FI7i66//bJjAzlM/gViT8qkP01Swr8vF8w1grmni+JwRmtBMtaWDL","X-Gm-Gg":"AeBDiesKF0b0nkuMYrFwdWwJ1jt3usoZUSosSKXc7L4z+OOQvsFzbbIyqypdh5bFrQz\n\txihrpn66zn62kTAboFDcIA7kCFxu8Skn1H3YDehqf14OG29hEHp7BVZwocxFupsglJJnheXNSnN\n\toOtrgB2YDcShzz5BngDrRwNBGzvAya2jIOAinwunO1XlLVLM0sZxT6EaviE7j4OX0lMXdThSLTD\n\tSHqbjjTLcrBZs0UqzzXer3Aa4rtNiV5+dP/0ggmUlqTSfWGkJ70Vw4eYfVVu/HpaS6KU7RzJth9\n\t6dR1I2ZEsVp4IVQ/+y8pxNtBGLf3gIYumOHu0gUOOkWQYgYfOl9PdQE2jS/FJCE5Vecjjp9QCl3\n\tKvRV/Ao98EUAy4Y/lT9QZMFeml47fJ3EfgQoI4QecZNN41Fk+dEpKuUCwKgHQJRfa+KO5sOsbKM\n\tYzZsgv7q7MPsRYZmgLGKwEY6MC8GjYuBgVXUzJZWv8lVuZh2MCinmdsWN7SvJRw84RIXHyNh5cB\n\tMytg0Xg4quO","X-Received":"by 2002:a05:600c:350c:b0:488:9661:2570 with SMTP id\n 5b1f17b1804b1-488d67ce8c2mr100910025e9.8.1775933844696;\n Sat, 11 Apr 2026 11:57:24 -0700 (PDT)","From":"David Carlier ","To":"pablo@netfilter.org","Cc":"fw@strlen.de,\n\tphil@nwl.cc,\n\tkadlec@netfilter.org,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tDavid Carlier ,\n\tstable@vger.kernel.org","Subject":"[PATCH] netfilter: nfnl_cthelper: apply per-class values when\n updating policies","Date":"Sat, 11 Apr 2026 19:57:21 +0100","Message-ID":"<20260411185721.234936-1-devnexen@gmail.com>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"When a userspace conntrack helper with multiple expectation classes is\nupdated via nfnetlink, every class ends up with the first class's\nmax_expected and timeout values.\n\nnfnl_cthelper_update_policy_all() validates each new policy into the\ncorresponding slot of the temporary new_policy array, but the second\nloop that commits the values into the live helper dereferences\nnew_policy as a pointer instead of indexing it, so every iteration\nreads new_policy[0] regardless of i. An update that changes per-class\nvalues is silently collapsed onto class 0's values with no error\nreturned to userspace.\n\nIndex the temporary array by i in the commit loop so each class gets\nits own validated values.\n\nFixes: 2c422257550f (\"netfilter: nfnl_cthelper: fix runtime expectation policy updates\")\nCc: stable@vger.kernel.org\nSigned-off-by: David Carlier \n---\n net/netfilter/nfnetlink_cthelper.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/net/netfilter/nfnetlink_cthelper.c b/net/netfilter/nfnetlink_cthelper.c\nindex 0d16ad82d70c..34af6840803e 100644\n--- a/net/netfilter/nfnetlink_cthelper.c\n+++ b/net/netfilter/nfnetlink_cthelper.c\n@@ -346,8 +346,8 @@ static int nfnl_cthelper_update_policy_all(struct nlattr *tb[],\n \tfor (i = 0; i < helper->expect_class_max + 1; i++) {\n \t\tpolicy = (struct nf_conntrack_expect_policy *)\n \t\t\t\t&helper->expect_policy[i];\n-\t\tpolicy->max_expected = new_policy->max_expected;\n-\t\tpolicy->timeout\t= new_policy->timeout;\n+\t\tpolicy->max_expected = new_policy[i].max_expected;\n+\t\tpolicy->timeout\t= new_policy[i].timeout;\n \t}\n \n err:\n","prefixes":[]}