{"id":2221814,"url":"http://patchwork.ozlabs.org/api/patches/2221814/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410120318.727211419@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260410120318.727211419@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260410120318.727211419@kernel.org/","date":"2026-04-10T12:19:52","name":"[17/38] ext4: Replace get_cycles() usage with ktime_get()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c06cc6692667c07c0089e633f890f1e1c3d22bb6","submitter":{"id":92397,"url":"http://patchwork.ozlabs.org/api/people/92397/?format=json","name":"Thomas Gleixner","email":"tglx@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260410120318.727211419@kernel.org/mbox/","series":[{"id":499449,"url":"http://patchwork.ozlabs.org/api/series/499449/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499449","date":"2026-04-10T12:18:27","name":"treewide: Cleanup LATCH, CLOCK_TICK_RATE and get_cycles() [ab]use","version":1,"mbox":"http://patchwork.ozlabs.org/series/499449/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221814/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221814/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=jdPhw8GN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19587-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=jdPhw8GN;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=tglx@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsbVY4PSFz1y2d\n\tfor ; Fri, 10 Apr 2026 22:20:37 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsbTn5VRjz2ypw;\n\tFri, 10 Apr 2026 22:19:57 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsbTm6S1Jz2yZ6\n\tfor ; Fri, 10 Apr 2026 22:19:56 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 3B39F41A7C;\n\tFri, 10 Apr 2026 12:19:55 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 5B407C2BC87;\n\tFri, 10 Apr 2026 12:19:54 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775823597;\n\tcv=none;\n b=OeFoHNBNW1+LcH8TCJTiAJDvK4L82xVUp12Q8qc8VGG1qds5IG14Y9EgSbpn7ywSfIhJu+X2tyMxEa5imDag6JC0VV5kDWhI3cz56oExnok5E8ExHA6RUJJz4ZxyTqOYDyUrO1J6ovjh7igkX1CBS4Qi7ghCtDMKjpgbYgVKarFufOBzc9BMF0eBmEzqIzTn3ySttO70TbMOxMGRdEFlwbn82SdwnZlmmvba3qAqcQNibr/T3MNTK3AMydzxcMfvtjT5GjRV1jkd/BVJDNSSdm3vS/g5QisQtHHr9kt9e0cG2q9CsOq/4kXIFlUmDWRUaaoC7Ll/j7UjP1nZ7nyE2g==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775823597; c=relaxed/relaxed;\n\tbh=UDyKTHGnMCmYbgJ8T4kKNARn1fh97FJoB2dW0qVXMMM=;\n\th=Date:Message-ID:From:To:Cc:Subject:References:MIME-Version:\n\t Content-Type;\n b=d0Lp+BRGyqtBsxCH4AG16zfsY39LmMzokRCvQABm6FnaICA0Yl8lsSyOSmv/gDQklXq+NIVNj/UANwmJm5AECOlMUgCF89N+LayXxe1fp12vxF45tmKi51LDLYGt9tRxYDw11qDxYK/d9oKbA9nHuRdrIkFCXmn7JHegiog6sDBJ9+Iq/Jiz23+vQEfwJTzA8XzpBZ65zD4c2rSYeqVSP5fOhqzFrHfTafzwB1NzrNaig5AUdpnYaJdSZj17tRi1iA6LrutqZ953HkDBAAoiI5+rj9bCeFUAFR8dQL33MRQU9r/ALbaVuABH9Zs5B+zLmB0RE+D21Y6hESzI5ImzQg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=jdPhw8GN; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=tglx@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775823595;\n\tbh=QF8xu2w1ekYQn9h8hXu1i+73iAYxDniq8hK08qkXVok=;\n\th=Date:From:To:Cc:Subject:References:From;\n\tb=jdPhw8GNcCbidbYQHfvNnynlBMQ6C8yak4JEVkjtLiGZL97Y3Kg6hDMEq3+pAZn9l\n\t eebAKa8zdYjNIUhQRVD9BnFcdpgh+r9+oY8nCOOBP3TXDWg59J0yEe49bjDh/j5GY1\n\t J/+Mrsj5Z9JlM/AmirqGD8HvbUDB7O2+WSvwYb2Dt2w8mdLS3mlRSvEUCA//cm+I50\n\t T3lnhTwlF7Ll8vkIeV4joWfasbaLJDpe8kQqwYnenbDJtbX6i3a/y8coaGgKPKMk+y\n\t /Al4CmKTrbd6SuhGXm70yx904ODj2E0CWQ5/8mFozaTW1DKtHUVqiCNDO1sI7Gfirg\n\t PX6BMdDjfEFyw==","Date":"Fri, 10 Apr 2026 14:19:52 +0200","Message-ID":"<20260410120318.727211419@kernel.org>","User-Agent":"quilt/0.68","From":"Thomas Gleixner ","To":"LKML ","Cc":"\"Theodore Tso\" ,\n linux-ext4@vger.kernel.org,\n Arnd Bergmann ,\n x86@kernel.org,\n Lu Baolu ,\n iommu@lists.linux.dev,\n Michael Grzeschik ,\n netdev@vger.kernel.org,\n linux-wireless@vger.kernel.org,\n Herbert Xu ,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka ,\n linux-mm@kvack.org,\n David Woodhouse ,\n Bernie Thompson ,\n linux-fbdev@vger.kernel.org,\n Andrew Morton ,\n Uladzislau Rezki ,\n Marco Elver ,\n Dmitry Vyukov ,\n kasan-dev@googlegroups.com,\n Andrey Ryabinin ,\n Thomas Sailer ,\n linux-hams@vger.kernel.org,\n \"Jason A. Donenfeld\" ,\n Richard Henderson ,\n linux-alpha@vger.kernel.org,\n Russell King ,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas ,\n Huacai Chen ,\n loongarch@lists.linux.dev,\n Geert Uytterhoeven ,\n linux-m68k@lists.linux-m68k.org,\n Dinh Nguyen ,\n Jonas Bonn ,\n linux-openrisc@vger.kernel.org,\n Helge Deller ,\n linux-parisc@vger.kernel.org,\n Michael Ellerman ,\n linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley ,\n linux-riscv@lists.infradead.org,\n Heiko Carstens ,\n linux-s390@vger.kernel.org,\n \"David S. Miller\" ,\n sparclinux@vger.kernel.org","Subject":"[patch 17/38] ext4: Replace get_cycles() usage with ktime_get()","References":"<20260410120044.031381086@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"get_cycles() is not guaranteed to be functional on all systems/platforms\nand the values returned are unitless and not easy to map to something\nuseful.\n\nUse ktime_get() instead, which provides nanosecond timestamps and is\nfunctional everywhere.\n\nThis is part of a larger effort to limit get_cycles() usage to low level\narchitecture code.\n\nSigned-off-by: Thomas Gleixner \nCc: \"Theodore Ts'o\" \nCc: linux-ext4@vger.kernel.org\n---\n fs/ext4/mballoc.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"--- a/fs/ext4/mballoc.c\n+++ b/fs/ext4/mballoc.c\n@@ -1289,7 +1289,7 @@ void ext4_mb_generate_buddy(struct super\n \text4_grpblk_t len;\n \tunsigned free = 0;\n \tunsigned fragments = 0;\n-\tunsigned long long period = get_cycles();\n+\tktime_t period = ktime_get();\n \n \t/* initialize buddy from bitmap which is aggregation\n \t * of on-disk bitmap and preallocations */\n@@ -1328,7 +1328,7 @@ void ext4_mb_generate_buddy(struct super\n \n \tclear_bit(EXT4_GROUP_INFO_NEED_INIT_BIT, &(grp->bb_state));\n \n-\tperiod = get_cycles() - period;\n+\tperiod = ktime_get() - period;\n \tatomic_inc(&sbi->s_mb_buddies_generated);\n \tatomic64_add(period, &sbi->s_mb_generation_time);\n }\n","prefixes":["17/38"]}