{"id":2221691,"url":"http://patchwork.ozlabs.org/api/patches/2221691/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-write_booster-v5-5-d44e1a0e191c@samsung.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260410-write_booster-v5-5-d44e1a0e191c@samsung.com>","list_archive_url":null,"date":"2026-04-10T05:57:18","name":"[v5,5/5] tests/qtest: Add UFS Write Booster QTest","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4b3464975d4b3155c0150e23e7e09735fa711f37","submitter":{"id":93039,"url":"http://patchwork.ozlabs.org/api/people/93039/?format=json","name":"Jaemyung Lee","email":"ldc.jml@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-write_booster-v5-5-d44e1a0e191c@samsung.com/mbox/","series":[{"id":499400,"url":"http://patchwork.ozlabs.org/api/series/499400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499400","date":"2026-04-10T05:57:14","name":"hw/ufs: Add Write Booster Support on UFS","version":5,"mbox":"http://patchwork.ozlabs.org/series/499400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221691/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221691/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=odOEuxPS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsR1r4Dnwz1y2d\n\tfor ; Fri, 10 Apr 2026 15:58:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wB4sE-0004vt-2y; Fri, 10 Apr 2026 01:57:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wB4sC-0004t2-7d\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 01:57:44 -0400","from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wB4sA-0007zM-Cz\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 01:57:44 -0400","by mail-pg1-x535.google.com with SMTP id\n 41be03b00d2f7-c70fb6aa323so671296a12.3\n for ; Thu, 09 Apr 2026 22:57:42 -0700 (PDT)","from [172.17.0.5] ([168.126.243.22])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c79218fc8d9sm1225965a12.12.2026.04.09.22.57.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 22:57:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775800661; x=1776405461; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=UvnDam+RI7xNOArU3spJiI07Kx70RBnYFEvTvltBdIM=;\n b=odOEuxPSULQeUrqIBSKO9zOBgyfXoUy9cnR2a349r0DzstylLTDjM+/tB85SZ1y9/b\n l6e+Drht6NZhYfT9X2o8SpcaAH0F9yXpmLynNNJGa7KNsrUWxn/Ohm2gxofRAAxYLiKC\n OyUrKAOIWz1c/8I3aQxxNu9lY8NtW/mtk6qTf/dCqfwzPvU83dAr+8v9iKrzWVkcO7GN\n rW0l9Q3RMTd6aCZ7YwkdjRbaruRhEFLyAsfHhmGRovk1BY8YcArCf/zQ771netcpIk1A\n S8T5X+0/QjrCStm/e7U+euSFzmN2xX92xyuNpNf4RHJ23FlHWCX05ad68WQOVxvAcfkR\n ZZJg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775800661; x=1776405461;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=UvnDam+RI7xNOArU3spJiI07Kx70RBnYFEvTvltBdIM=;\n b=Qzy2TfeBApd86/3XWrv7IEDU8+7eonJMCZngXRQIBi1/q57dbNHJ9AOmbzvotp5D4y\n lmtCJIFQta9SnE1SmSbL0YbnDebqzjLhHbZjacN2A9x8nscXVte4BSAocaur49b0eKw7\n iVpUPwkUomodE6UtwH53wokD8pSmFpY2spsHKF4qMsIgRYj20DsQZ47KXQU6BXUx6wE/\n puVA+Y1VuyeW3qYrOctlTh6aGDJe23BhFa1Ec+wopxVHMd+HaL0KsynQBhg0GtQOY2HR\n Wm0aWullz2IDpeKWp06aa4Xf5acWrg7pkpmU0RGVWWfd+8hbZwTxelhqD2xjJfh5JIrM\n vmMA==","X-Gm-Message-State":"AOJu0YxiTBcQ++2wz4pjcWXGddyCipsbLV/XGjEnoeDHhifUoGZQgBwX\n WV8d9F4xVIML+Ql9JEFvaPRlN62Waza6YLNN1DeBKq5awsCk6Bry6oQC","X-Gm-Gg":"AeBDievaHMMIyuKbqg6rsK80vskrPwPHI6sCLQ3+tPvOxH68YJmuoCKgoGeA51Nqn0T\n tmxvOim2i31jr3NYS8SriAaw/og4mm0kF2eq7Ik7O8TCVkOjrxMqwRnTEBhU8B1WUbSCwtcq/Dy\n vP5SSRzD/w2Z1m0BE5vWVYVzgyxE6IkIZY3hGqFZkFnWJ0jeIbdql8N2ETEqBDUDV/GOux0veoe\n R3n2aTvtBFOiK23Tm+43OsvbOxZWbHfun95b6bxbcIC8aXKwAs1xlDttp9Jg3NRPJUqHHBNpUPp\n ESlL2RB9D9pJo/YXISMq/I6kDPSBDU3bGeYcmTyMlR4vRwtCIU+inqpzgLxrWmhciqN0vYWWnlg\n hrmwY5FkhwefcE9cZGjMa/M0MouS+u5grwBYVh79YjP9ZBF0sFP3abRob/76/Ejnzs1y4ElOxvn\n q3NQvWTXPPD1Yj2gzo1K1gfq+Oh/2T0DSVPvdjTL3g","X-Received":"by 2002:a05:6a20:6a1d:b0:39f:a8fb:3354 with SMTP id\n adf61e73a8af0-39fe3cf233fmr2319155637.17.1775800660823;\n Thu, 09 Apr 2026 22:57:40 -0700 (PDT)","From":"Jaemyung Lee ","X-Google-Original-From":"Jaemyung Lee ","Date":"Fri, 10 Apr 2026 14:57:18 +0900","Subject":"[PATCH v5 5/5] tests/qtest: Add UFS Write Booster QTest","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260410-write_booster-v5-5-d44e1a0e191c@samsung.com>","References":"<20260410-write_booster-v5-0-d44e1a0e191c@samsung.com>","In-Reply-To":"<20260410-write_booster-v5-0-d44e1a0e191c@samsung.com>","To":"qemu-devel@nongnu.org","Cc":"Jeuk Kim , Kevin Wolf ,\n Hanna Reitz , qemu-block@nongnu.org,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini ,\n Jaemyung Lee ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1775800645; l=8918;\n i=jaemyung.lee@samsung.com; s=20260402; h=from:subject:message-id;\n bh=rU67KxRcVLL6ZVBVhiBQ/INRn8llY3KXffQmzbO047E=;\n b=9aBa1DA8BEB/wBsYy+k3c3Bh5gJpLqOCExbaDWns0ydiSQAT4zknTw3J0R5LIH1lumD5kFBAg\n vG0L80gPwyVAlDvp+poDJy9rVT3+uylJ8BRUYBTJnEaIMFpflPBuWUH","X-Developer-Key":"i=jaemyung.lee@samsung.com; a=ed25519;\n pk=bZPd7A/kteUO62FfUM6IrI1LuBPe5QrcqfvsitM1ZjE=","Received-SPF":"pass client-ip=2607:f8b0:4864:20::535;\n envelope-from=ldc.jml@gmail.com; helo=mail-pg1-x535.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"It adds 'wb-init' and 'wb-read-write' TCs into tests/qtest/ufs-test.c.\n'wb-init' tests that the WB support is properly initialized with UFS\ndevice and 'wb-read-write' tests that WB can be enabled and WRITE I/O\ncan be handled/buffered as a WB command.\n\nSigned-off-by: Jaemyung Lee \n---\n tests/qtest/ufs-test.c | 176 +++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 176 insertions(+)","diff":"diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c\nindex 7f999441552a105987aaaf8e2b976f4a05f953ed..253fea27a5e52619f433d15075500a566eddeccc 100644\n--- a/tests/qtest/ufs-test.c\n+++ b/tests/qtest/ufs-test.c\n@@ -1182,6 +1182,173 @@ static void ufstest_query_desc_request(void *obj, void *data,\n ufs_exit(ufs, alloc);\n }\n \n+static void ufstest_wb_init(void *obj, void *data, QGuestAllocator *alloc)\n+{\n+ QUfs *ufs = obj;\n+ enum UtpOcsCodes ocs;\n+ UtpUpiuRsp rsp_upiu;\n+ uint8_t *desc;\n+ uint32_t value;\n+\n+ ufs_init(ufs, alloc);\n+\n+ /* Read Device Descriptor */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_DESC,\n+ UFS_QUERY_DESC_IDN_DEVICE, 0, 0, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.opcode, ==, UFS_UPIU_QUERY_OPCODE_READ_DESC);\n+ g_assert_cmpuint(rsp_upiu.qr.idn, ==, UFS_QUERY_DESC_IDN_DEVICE);\n+ g_assert_cmpuint(rsp_upiu.qr.data[0], ==, sizeof(DeviceDescriptor));\n+ g_assert_cmpuint(rsp_upiu.qr.data[1], ==, UFS_QUERY_DESC_IDN_DEVICE);\n+\n+ /* Check Write Booster Supportability */\n+ desc = rsp_upiu.qr.data;\n+\n+ value = *(uint16_t *)(desc + UFS_DEVICE_DESC_PARAM_EXT_WB_SUP);\n+ value = be16_to_cpu(value);\n+ g_assert_cmpuint(value, ==, WB_RESIZE | WB_FIFO | WB_PINNED);\n+\n+ value = *(uint32_t *)(desc + UFS_DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);\n+ value = be32_to_cpu(value);\n+ g_assert_cmpuint(value & UFS_DEV_WB_SUPPORT, ==, UFS_DEV_WB_SUPPORT);\n+\n+ /* Read Geometry Descriptor */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_DESC,\n+ UFS_QUERY_DESC_IDN_GEOMETRY, 0, 0, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.data[0], ==, sizeof(GeometryDescriptor));\n+ g_assert_cmpuint(rsp_upiu.qr.data[1], ==, UFS_QUERY_DESC_IDN_GEOMETRY);\n+\n+ /* Check Write Booster Configuration */\n+ desc = rsp_upiu.qr.data;\n+\n+ value = *(uint32_t *)(desc + UFS_GEOMETRY_DESC_PARAM_WB_MAX_ALLOC_UNITS);\n+ value = be32_to_cpu(value);\n+ g_assert_cmpuint(value, ==, 1024);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_MAX_WB_LUNS];\n+ g_assert_cmpuint(value, ==, 1);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_BUFF_CAP_ADJ];\n+ g_assert_cmpuint(value, ==, 3);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_SUP_RED_TYPE];\n+ g_assert_cmpuint(value, ==, 1);\n+\n+ value = desc[UFS_GEOMETRY_DESC_PARAM_WB_SUP_WB_TYPE];\n+ g_assert_cmpuint(value, ==, 1);\n+\n+ ufs_exit(ufs, alloc);\n+}\n+\n+static void ufstest_wb_read_write(void *obj, void *data, QGuestAllocator *alloc)\n+{\n+ QUfs *ufs = obj;\n+ uint8_t read_buf[4096] = { 0 };\n+ uint8_t write_buf[4096] = { 0 };\n+ const uint8_t read_capacity_cdb[UFS_CDB_SIZE] = {\n+ /* allocation length 4096 */\n+ SERVICE_ACTION_IN_16,\n+ SAI_READ_CAPACITY_16,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x00,\n+ 0x10,\n+ 0x00,\n+ 0x00,\n+ 0x00\n+ };\n+ const uint8_t request_sense_cdb[UFS_CDB_SIZE] = {\n+ REQUEST_SENSE,\n+ };\n+ const uint8_t write_cdb[UFS_CDB_SIZE] = {\n+ /* WRITE(10) to LBA 0, transfer length 1 */\n+ WRITE_10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00\n+ };\n+ uint32_t block_size;\n+ enum UtpOcsCodes ocs;\n+ UtpUpiuRsp rsp_upiu;\n+ const int test_lun = 1;\n+ uint64_t end_time;\n+\n+ ufs_init(ufs, alloc);\n+\n+ /* Clear Unit Attention */\n+ ocs = ufs_send_scsi_command(ufs, test_lun, request_sense_cdb, NULL, 0,\n+ read_buf, sizeof(read_buf), &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.scsi_status, ==, CHECK_CONDITION);\n+\n+ /* Read capacity */\n+ ocs = ufs_send_scsi_command(ufs, test_lun, read_capacity_cdb, NULL, 0,\n+ read_buf, sizeof(read_buf), &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.scsi_status, ==,\n+ UFS_COMMAND_RESULT_SUCCESS);\n+ block_size = ldl_be_p(&read_buf[8]);\n+ g_assert_cmpuint(block_size, ==, 4096);\n+\n+ /* Check available buffer size */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_ATTR,\n+ UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE, 0, 0, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.opcode, ==, UFS_UPIU_QUERY_OPCODE_READ_ATTR);\n+ g_assert_cmpuint(rsp_upiu.qr.idn, ==, UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE);\n+ g_assert_cmpuint(rsp_upiu.qr.value, ==, cpu_to_be32(0xA));\n+\n+ /* Enable WB */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_WRITE_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_SET_FLAG,\n+ UFS_QUERY_FLAG_IDN_WB_EN, 0, 0, 0,\n+ &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.value, ==, be32_to_cpu(1));\n+\n+ /* Write data */\n+ for (int i = 0; i < 256; i++) {\n+ memset(write_buf, 0xab, block_size);\n+ ocs = ufs_send_scsi_command(ufs, test_lun, write_cdb, write_buf,\n+ block_size, NULL, 0, &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.scsi_status, ==,\n+ UFS_COMMAND_RESULT_SUCCESS);\n+ }\n+\n+ end_time = g_get_monotonic_time() + TIMEOUT_SECONDS * G_TIME_SPAN_SECOND;\n+ do {\n+ qtest_clock_step(ufs->dev.bus->qts, 100);\n+\n+ /* Check available buffer size */\n+ ocs = ufs_send_query(ufs, UFS_UPIU_QUERY_FUNC_STANDARD_READ_REQUEST,\n+ UFS_UPIU_QUERY_OPCODE_READ_ATTR,\n+ UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE, 0, 0, 0,\n+ &rsp_upiu);\n+ g_assert_cmpuint(ocs, ==, UFS_OCS_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.header.response, ==, UFS_COMMAND_RESULT_SUCCESS);\n+ g_assert_cmpuint(rsp_upiu.qr.opcode, ==, UFS_UPIU_QUERY_OPCODE_READ_ATTR);\n+ g_assert_cmpuint(rsp_upiu.qr.idn, ==, UFS_QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE);\n+ } while (rsp_upiu.qr.value == cpu_to_be32(0xA) && g_get_monotonic_time() < end_time);\n+\n+ /* Check available buffer size */\n+ g_assert_cmpuint(rsp_upiu.qr.value, ==, cpu_to_be32(0x9));\n+\n+ ufs_exit(ufs, alloc);\n+}\n+\n static void drive_destroy(void *path)\n {\n unlink(path);\n@@ -1234,6 +1401,13 @@ static void ufs_register_nodes(void)\n .edge.extra_device_opts =\n \"mcq=true,mcq-maxq=1\" };\n \n+ QOSGraphTestOptions wb_test_opts = { .before = ufs_blk_test_setup,\n+ .edge.extra_device_opts =\n+ \"mcq=false,nutrs=32,nutmrs=8,\"\n+ \"wb-max-size=1024,wb-min-size=256,\"\n+ \"wb-max-lus=1,wb-cap-adj-fac=3,\"\n+ \"wb-reduction=1\" };\n+\n add_qpci_address(&edge_opts, &(QPCIAddress){ .devfn = QPCI_DEVFN(4, 0) });\n \n qos_node_create_driver(\"ufs\", ufs_create);\n@@ -1262,6 +1436,8 @@ static void ufs_register_nodes(void)\n &io_test_opts);\n qos_add_test(\"query-desciptor\", \"ufs\", ufstest_query_desc_request,\n &io_test_opts);\n+ qos_add_test(\"wb-init\", \"ufs\", ufstest_wb_init, &wb_test_opts);\n+ qos_add_test(\"wb-read-write\", \"ufs\", ufstest_wb_read_write, &wb_test_opts);\n }\n \n libqos_init(ufs_register_nodes);\n","prefixes":["v5","5/5"]}