{"id":2221668,"url":"http://patchwork.ozlabs.org/api/patches/2221668/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-10-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260410055040.39233-10-kwilczynski@kernel.org>","list_archive_url":null,"date":"2026-04-10T05:50:29","name":"[09/20] PCI/sysfs: Limit pci_sysfs_init() late_initcall compile scope","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c7d3eb554ce2fd44590ce4955f82eaf879f035e1","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-10-kwilczynski@kernel.org/mbox/","series":[{"id":499398,"url":"http://patchwork.ozlabs.org/api/series/499398/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499398","date":"2026-04-10T05:50:21","name":"PCI: Convert all dynamic sysfs attributes to static","version":1,"mbox":"http://patchwork.ozlabs.org/series/499398/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2221668/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221668/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=CVeUMnFB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-52271-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"CVeUMnFB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsQsP6R6Wz1yGb\n\tfor ; Fri, 10 Apr 2026 15:51:21 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 7F7E7300ACB2\n\tfor ; Fri, 10 Apr 2026 05:51:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C914A30F52A;\n\tFri, 10 Apr 2026 05:51:17 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D4F30BF5C;\n\tFri, 10 Apr 2026 05:51:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0B6F9C2BCAF;\n\tFri, 10 Apr 2026 05:51:13 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775800277; cv=none;\n b=BdBzfsCODigH1nz8FisUDXQ14cEGf0w60MRZQR+RS9CIfO8bXkxSmpligCPXUdij8oj9QM697zcIEww//D4IsbQy0avBqr5kqGUwzqzsRxx58mzYUJ6cc+O9rLmrRwLHIBZs6iiElOWgM84NhgrH16PmK9y06ZPNJ2RhbZqN6Ng=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775800277; c=relaxed/simple;\n\tbh=3hptuhV9yvRK5QFViJmdIejaERCBcfDgF46k3rwUdzg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=cPgruCb45cHsrTZvGaFtVHAcVkWGHL8eZqzgZ5n3kJIeguMq6aoFgd087qD9t/apc9xhiw/I23hsUAcO9e8oLd9alqkGjIgyKK9zVQC3qI0GjE71ydrXdM5syjyf14r9HtIkg37ggW4uwypQlBZR/bPaYbf4djGxu1I/OkpyxSo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=CVeUMnFB; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775800277;\n\tbh=3hptuhV9yvRK5QFViJmdIejaERCBcfDgF46k3rwUdzg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CVeUMnFB92kckEyX6w4AOLTj43SKV6JPyWI+WtBUYmkpZDDOQKifdnGtDYcPQlEPl\n\t afN0P4N57mX3XV53stpV1j8HBs+zNnRRsrSDWkSZW2FeRnTy0lYBaKE78W/7GD6iXz\n\t to+Zhxoks60apXrm5tH+1kUihP78QNon1tQB4gDPxTrIUjv9To/eMvOTNpYH1sBOaN\n\t pzJm/EIB9e7iJ63Tjxx2RJtHBPsEChZ3vdZssI0RN4+ZdYCHcrh3rHGg2cXIUr5LMG\n\t gg/NUq3Cu6u2LyDUIPOP81q2j00XYpnfbEUrXfYgt54IOy+Znj7kTfry/QjxyPHBdO\n\t 7iMU488IS78SQ==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH 09/20] PCI/sysfs: Limit pci_sysfs_init() late_initcall compile\n scope","Date":"Fri, 10 Apr 2026 05:50:29 +0000","Message-ID":"<20260410055040.39233-10-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410055040.39233-1-kwilczynski@kernel.org>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, pci_sysfs_init() and sysfs_initialized compile\nunconditionally, even on platforms where static attribute\ngroups handle all resource file creation.\n\nThus, place them behind a new HAVE_PCI_SYSFS_INIT macro,\nespecially as the late_initcall is only needed when:\n\n - HAVE_PCI_LEGACY is set, to iterate buses and create legacy\n I/O and memory files.\n\n - Neither HAVE_PCI_MMAP nor ARCH_GENERIC_PCI_MMAP_RESOURCE is\n set, to iterate devices and create resource files via the\n __weak pci_create_resource_files() stub override (this is\n how the Alpha architecture handles this currently).\n\nOn most systems both conditions are false and the entire\nlate_initcall compiles away.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex e200514bbaed..062921d5df9b 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -37,7 +37,14 @@\n #define ARCH_PCI_DEV_GROUPS\n #endif\n \n+#if defined(HAVE_PCI_LEGACY) || \\\n+\t!defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n+#define HAVE_PCI_SYSFS_INIT\n+#endif\n+\n+#ifdef HAVE_PCI_SYSFS_INIT\n static int sysfs_initialized;\t/* = 0 */\n+#endif\n \n /* show configuration fields */\n #define pci_config_attr(field, format_string)\t\t\t\t\\\n@@ -1791,6 +1798,7 @@ void pci_remove_sysfs_dev_files(struct pci_dev *pdev)\n }\n #endif\n \n+#ifdef HAVE_PCI_SYSFS_INIT\n static int __init pci_sysfs_init(void)\n {\n #if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n@@ -1817,6 +1825,7 @@ static int __init pci_sysfs_init(void)\n \treturn 0;\n }\n late_initcall(pci_sysfs_init);\n+#endif\n \n static struct attribute *pci_dev_dev_attrs[] = {\n \t&dev_attr_boot_vga.attr,\n","prefixes":["09/20"]}