{"id":2220187,"url":"http://patchwork.ozlabs.org/api/patches/2220187/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406112057.906685-3-jtornosm@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260406112057.906685-3-jtornosm@redhat.com>","list_archive_url":null,"date":"2026-04-06T11:20:56","name":"[net,2/3] i40e: skip unnecessary VF reset when setting trust","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b0094f653fc86665ab2424289712e3d4c32af0bb","submitter":{"id":93070,"url":"http://patchwork.ozlabs.org/api/people/93070/?format=json","name":"Jose Ignacio Tornos Martinez","email":"jtornosm@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406112057.906685-3-jtornosm@redhat.com/mbox/","series":[{"id":498871,"url":"http://patchwork.ozlabs.org/api/series/498871/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498871","date":"2026-04-06T11:20:55","name":"Fix i40e/iavf VF bonding after netdev lock changes","version":1,"mbox":"http://patchwork.ozlabs.org/series/498871/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220187/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220187/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=fdBwFToV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqCbb2Ng8z1xy1\n\tfor ; Tue, 07 Apr 2026 01:16:43 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B19B040904;\n\tMon, 6 Apr 2026 15:16:38 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id QBSUwgUl_Dsk; Mon, 6 Apr 2026 15:16:38 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E8A3A40752;\n\tMon, 6 Apr 2026 15:16:37 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id D1FDC219\n for ; Mon, 6 Apr 2026 11:21:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id B7DBA80EBD\n for ; Mon, 6 Apr 2026 11:21:32 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id v1AKW9igEeEy for ;\n Mon, 6 Apr 2026 11:21:31 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 9B83680D36\n for ; Mon, 6 Apr 2026 11:21:31 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-KSdgjjPRORm_AoLDMpOZpQ-1; Mon,\n 06 Apr 2026 07:21:27 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 057D01800764; Mon, 6 Apr 2026 11:21:26 +0000 (UTC)","from fedora.redhat.com (unknown [10.44.48.51])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 72126300019F; Mon, 6 Apr 2026 11:21:22 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org E8A3A40752","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9B83680D36"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775488598;\n\tbh=9mJAFR2P64r9/LOJtwiqZN1rPSkz3fb8OpCJmbM7VKg=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=fdBwFToV2P4jj2L5ws1OgNUJQNiwUrU3AjTp6eXWdc6JgDjO0wymUJu5L8QQet5Ai\n\t wqGCzS8bKpV9RecvtlF7RhJ83ZrcNaAD8+XkKYR5sPwzQm+X0iJBQMff0h1S9JUDM8\n\t nkamNYBYce6RRV7IU6G5OasE0QbgpC4pm2oMbbNT962kfIKtW0AGA0wvFNA36eP+Mn\n\t gbk08CqrHU7RzwUe0rGPk1TWQis+lryYkCDpu3QUn2l5CNFP3QWCY2UU+OASVCZv1W\n\t xNUuCrxhNblE6HfLJzcHNlVvCqIquGaq4SuA0bDcIl7v7jZXHkW06DbdFyLGxMnVwx\n\t gtONmfdjd+4ZA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 9B83680D36","X-MC-Unique":"KSdgjjPRORm_AoLDMpOZpQ-1","X-Mimecast-MFC-AGG-ID":"KSdgjjPRORm_AoLDMpOZpQ_1775474486","From":"Jose Ignacio Tornos Martinez ","To":"netdev@vger.kernel.org","Cc":"intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,\n anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com,\n Jose Ignacio Tornos Martinez ","Date":"Mon, 6 Apr 2026 13:20:56 +0200","Message-ID":"<20260406112057.906685-3-jtornosm@redhat.com>","In-Reply-To":"<20260406112057.906685-1-jtornosm@redhat.com>","References":"<20260406112057.906685-1-jtornosm@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-MFC-PROC-ID":"dVbZB0zIx_P_6V26Q-rzza-UuihFCCjeHNI8JXsn7W8_1775474486","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Approved-At":"Mon, 06 Apr 2026 15:16:35 +0000","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775474490;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9mJAFR2P64r9/LOJtwiqZN1rPSkz3fb8OpCJmbM7VKg=;\n b=UFjjz5vPKw3ToexvARyWbF+KHdFa8e7ZRFF1GROjq95LWzo3pMmOqaJV00UQwVeyU6iLug\n s9islvNDBVctDHzNBp0FwBwqO4tieippEAr7F/zvZ7PZOZjPKLlXs1LmnlC4n9IQ6sRCKV\n 0SKt8F5rxETwkSCnOI8S6NI+qOzwTdQ=","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp1.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UFjjz5vP"],"Subject":"[Intel-wired-lan] [PATCH net 2/3] i40e: skip unnecessary VF reset\n when setting trust","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"When VF trust is changed, i40e_ndo_set_vf_trust() always calls\ni40e_vc_reset_vf() to sync MAC/VLAN filters. However, this reset is\nonly necessary when trust is removed from a VF that has ADQ (advanced\nqueue) filters, which need to be deleted\n\nIn all other cases, the reset causes a ~10 second delay during which:\n- VF must reinitialize completely\n- Any in-progress operations (like bonding enslave) fail with timeouts\n- VF is unavailable\n\nThe MAC/VLAN filter sync will happen naturally through the normal VF\noperations and doesn't require a forced reset.\n\nFix by only resetting when actually needed: when removing trust from a\nVF that has ADQ cloud filters. For all other trust changes, just update\nthe trust flag and let normal operation continue.\n\nSigned-off-by: Jose Ignacio Tornos Martinez \n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex a26c3d47ec15..fea267af7afe 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -4987,16 +4987,21 @@ int i40e_ndo_set_vf_trust(struct net_device *netdev, int vf_id, bool setting)\n \tset_bit(__I40E_MACVLAN_SYNC_PENDING, pf->state);\n \tpf->vsi[vf->lan_vsi_idx]->flags |= I40E_VSI_FLAG_FILTER_CHANGED;\n \n-\ti40e_vc_reset_vf(vf, true);\n \tdev_info(&pf->pdev->dev, \"VF %u is now %strusted\\n\",\n \t\t vf_id, setting ? \"\" : \"un\");\n \n+\t/* Only reset VF if we're removing trust and it has ADQ cloud filters.\n+\t * Cloud filters can only be added when trusted, so they must be\n+\t * removed when trust is revoked. Other trust changes don't require\n+\t * reset - MAC/VLAN filter sync happens through normal operation.\n+\t */\n \tif (vf->adq_enabled) {\n \t\tif (!vf->trusted) {\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"VF %u no longer Trusted, deleting all cloud filters\\n\",\n \t\t\t\t vf_id);\n \t\t\ti40e_del_all_cloud_filters(vf);\n+\t\t\ti40e_vc_reset_vf(vf, true);\n \t\t}\n \t}\n \n","prefixes":["net","2/3"]}