{"id":2220096,"url":"http://patchwork.ozlabs.org/api/patches/2220096/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260406104708.1218648-4-18255117159@163.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260406104708.1218648-4-18255117159@163.com>","list_archive_url":null,"date":"2026-04-06T10:47:08","name":"[v5,3/3] PCI: dwc: Use common speed conversion function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"76c6bc4fb6e4dd482a2393b38af12ef124983dac","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/people/89937/?format=json","name":"Hans Zhang","email":"18255117159@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260406104708.1218648-4-18255117159@163.com/mbox/","series":[{"id":498838,"url":"http://patchwork.ozlabs.org/api/series/498838/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=498838","date":"2026-04-06T10:47:06","name":"PCI: Refactor PCIe speed validation and conversion functions","version":5,"mbox":"http://patchwork.ozlabs.org/series/498838/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220096/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220096/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=egnCr7Xa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-51944-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"egnCr7Xa\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.4","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fq5dW3jFsz1xy1\n\tfor ; Mon, 06 Apr 2026 20:47:59 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 1680030072B2\n\tfor ; Mon, 6 Apr 2026 10:47:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A325A32ED3A;\n\tMon, 6 Apr 2026 10:47:50 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A13442048;\n\tMon, 6 Apr 2026 10:47:46 +0000 (UTC)","from Precision-7960.. (unknown [])\n\tby gzsmtp3 (Coremail) with SMTP id PigvCgDXX3Qwj9NpKHYUAA--.1246S5;\n\tMon, 06 Apr 2026 18:47:19 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775472470; cv=none;\n b=c0ryuj5qrjVbHVr1L1PjGWa1ZIoDYNPX9fPnJRaY5NEpDHcQyBwZUOuD/NzOHHe4c/dg7FuXmr0/mKWXZaEg6fQM+EDgYjs3YYcG9P0zV8G6ndXxugAorfF3zTJa9RBgD1L7N6JdbgWz5QRG7rumFLdpQ9xhSVEXIorl9aXMghY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775472470; c=relaxed/simple;\n\tbh=S2AriIuBuvp30fejzWifk5ycdL1eaTUQo96fmsrDPw8=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=FxNJCW7YbMFTmETfNc6jG9/8MewF7UXjr/NHG1yHnJg9ZPy5ht+NygJny9nN+BZZ1Kx7ONXU7E8rTdBBD0EuU6GbGNRN1DIubqAMgJX5HaMPG25SvcbCOeOeaKXmarvuFP1JFcva6+BV00NcWZa1ILYjVg79y0uIxmCZMYSc6D8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=egnCr7Xa; arc=none smtp.client-ip=220.197.31.4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Rz\n\t1RVpHgELYtDURXbx4h0IiL7ZYeCIBnAb166C8nHmg=; b=egnCr7XaJdH34zQFQL\n\tZ7iiOUww5aGG6WeyAOAxKKQl/4WV33/f6GEvYlar5skg/yfbJgcOXPeatYhTgRnn\n\tc9/9RpqL7TAoa/ZL9SoDq0goKctUYcDlNkuFJ8vyk57Go7vtCfgQf1pPDZIKobuc\n\tlwDy3l1nHVV1H1lt1M53bWHRA=","From":"Hans Zhang <18255117159@163.com>","To":"bhelgaas@google.com,\n\tlpieralisi@kernel.org,\n\tkw@linux.com,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\tilpo.jarvinen@linux.intel.com,\n\tjingoohan1@gmail.com","Cc":"robh@kernel.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHans Zhang <18255117159@163.com>","Subject":"[PATCH v5 3/3] PCI: dwc: Use common speed conversion function","Date":"Mon, 6 Apr 2026 18:47:08 +0800","Message-Id":"<20260406104708.1218648-4-18255117159@163.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260406104708.1218648-1-18255117159@163.com>","References":"<20260406104708.1218648-1-18255117159@163.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"PigvCgDXX3Qwj9NpKHYUAA--.1246S5","X-Coremail-Antispam":"1Uf129KBjvJXoW7uFWDZFy3tr4UWF4DXw1kKrg_yoW8Ary5pa\n\ty3AF4IyF48Ar43ZFs09as7ZFyUXFnxCrWDCFZ8W3ZaqFyayasxWF10y34Sq34akrZ2yr1a\n\t9w13JrWUG3W7tF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRYXdbUUUUU=","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbC7BdA42nTjzf69gAA3W"},"content":"Replace the private switch-based speed conversion in\ndw_pcie_link_set_max_speed() with the public pci_bus_speed2lnkctl2()\nfunction.\n\nThis eliminates duplicate conversion logic and ensures consistency with\nother PCIe drivers, while handling invalid speeds by falling back to\nhardware capabilities.\n\nSigned-off-by: Hans Zhang <18255117159@163.com>\nAcked-by: Manivannan Sadhasivam \n---\n drivers/pci/controller/dwc/pcie-designware.c | 17 ++---------------\n 1 file changed, 2 insertions(+), 15 deletions(-)","diff":"diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c\nindex 06792ba92aa7..f2dd5da69c76 100644\n--- a/drivers/pci/controller/dwc/pcie-designware.c\n+++ b/drivers/pci/controller/dwc/pcie-designware.c\n@@ -861,24 +861,11 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci)\n \tctrl2 = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCTL2);\n \tctrl2 &= ~PCI_EXP_LNKCTL2_TLS;\n \n-\tswitch (pcie_get_link_speed(pci->max_link_speed)) {\n-\tcase PCIE_SPEED_2_5GT:\n-\t\tlink_speed = PCI_EXP_LNKCTL2_TLS_2_5GT;\n-\t\tbreak;\n-\tcase PCIE_SPEED_5_0GT:\n-\t\tlink_speed = PCI_EXP_LNKCTL2_TLS_5_0GT;\n-\t\tbreak;\n-\tcase PCIE_SPEED_8_0GT:\n-\t\tlink_speed = PCI_EXP_LNKCTL2_TLS_8_0GT;\n-\t\tbreak;\n-\tcase PCIE_SPEED_16_0GT:\n-\t\tlink_speed = PCI_EXP_LNKCTL2_TLS_16_0GT;\n-\t\tbreak;\n-\tdefault:\n+\tlink_speed = pci_bus_speed2lnkctl2(link_speed);\n+\tif (link_speed == 0) {\n \t\t/* Use hardware capability */\n \t\tlink_speed = FIELD_GET(PCI_EXP_LNKCAP_SLS, cap);\n \t\tctrl2 &= ~PCI_EXP_LNKCTL2_HASD;\n-\t\tbreak;\n \t}\n \n \tdw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCTL2, ctrl2 | link_speed);\n","prefixes":["v5","3/3"]}