{"id":2220029,"url":"http://patchwork.ozlabs.org/api/patches/2220029/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406005830.2250373-2-tactii@gmail.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260406005830.2250373-2-tactii@gmail.com>","list_archive_url":null,"date":"2026-04-06T00:58:31","name":"[net,v2] i40e: Cleanup PTP registration on probe failure","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"499b8ef6ffceb74f130c869d12547100fcbc9bde","submitter":{"id":92679,"url":"http://patchwork.ozlabs.org/api/people/92679/?format=json","name":"Matt Vollrath","email":"tactii@gmail.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406005830.2250373-2-tactii@gmail.com/mbox/","series":[{"id":498810,"url":"http://patchwork.ozlabs.org/api/series/498810/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498810","date":"2026-04-06T00:58:31","name":"[net,v2] i40e: Cleanup PTP registration on probe failure","version":2,"mbox":"http://patchwork.ozlabs.org/series/498810/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2220029/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2220029/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=dqkI+6QT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fprbG18FNz1xy1\n\tfor ; Mon, 06 Apr 2026 11:00:08 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 266254068A;\n\tMon, 6 Apr 2026 01:00:00 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bkfVu0daaT21; Mon, 6 Apr 2026 00:59:58 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id DC03640675;\n\tMon, 6 Apr 2026 00:59:57 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 0869B1EB\n for ; Mon, 6 Apr 2026 00:59:56 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id D9D894035D\n for ; Mon, 6 Apr 2026 00:59:55 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4mPuJ14MqFJi for ;\n Mon, 6 Apr 2026 00:59:55 +0000 (UTC)","from mail-dy1-x132a.google.com (mail-dy1-x132a.google.com\n [IPv6:2607:f8b0:4864:20::132a])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 230DE402D2\n for ; Mon, 6 Apr 2026 00:59:54 +0000 (UTC)","by mail-dy1-x132a.google.com with SMTP id\n 5a478bee46e88-2cc4c693d59so5615883eec.1\n for ; Sun, 05 Apr 2026 17:59:54 -0700 (PDT)","from devobuntu.lan ([2600:6c5c:6b00:62b::23])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2cf1af62347sm3249228eec.22.2026.04.05.17.59.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 05 Apr 2026 17:59:52 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org DC03640675","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 230DE402D2"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775437197;\n\tbh=tAiOfRInaVupAzzjCM+nMcXrmYbAjEitRdUAHT6Jfhw=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=dqkI+6QTfi8Kf7vIyohUO7dSqOCrom/MkzerercNCB9BAzsZKphjbmWCr0wdfrzQz\n\t ZP0ybPbSSs97addnPpgn5I0jLUNBK5wwoL7goyG0rS285c61897Ub7mRjKuaOqP1cO\n\t oTkkR3eI+tkmqcZzX5CRFqLxePS/lp9l4fCeRRbMcB+bVuXNCCeuhRLKf1wb9HQkq3\n\t DwmHLg2SJ7dCFSfSxFITIq5No2mnBed73fchDNdVFEK4YF1FHatHkazBgEB4Z8rdiC\n\t /nCdMoU2rkCokXhT9Lf1EQgvXcsL00TuCcSUbFyCGxeBK0HHXIhZh/Z05IkiT/YG2A\n\t PCxFhaI8TgHjw==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::132a; helo=mail-dy1-x132a.google.com;\n envelope-from=tactii@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 230DE402D2","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775437193; x=1776041993;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tAiOfRInaVupAzzjCM+nMcXrmYbAjEitRdUAHT6Jfhw=;\n b=ScVg8MWTRua7hKcop65DyWimoTA7MA7bPmub0UldOPseWMYTxRE//5KkILIBeAOhu9\n qhBa5PoZe7SXl9NL4xbpl+PA0TJdIjf0+YhqZk5BKMvkh/mFa9yekNXE+mL0IdeQ9dXL\n VN/kDOEHXqQRNkAWANEgD5CsoxX03OApWzB5v7xLHtJS9Y85rGQ/soVhAoIf9Rdvyvhn\n IhtVvHzomaXKWcbAhYIt4LgEkEMAx4j3P2VsfhtTasgw1+Np2Qg0BRf+rN0HeDVsy6/L\n BCKFDNW753j7kadTYzfHgQlKHWAxkOH6vJz0PUkdNXP+tAj3/u+HoNNFF7EvgxCAeH9d\n WOWg==","X-Gm-Message-State":"AOJu0Yz8NPqa7NEX3zFjvrvsSbTPKavoYZCkGyS0EMaIvmn1N0aIYG6c\n im7QBiRRnRZkY0EkUmFvTVCKOUR845DSkbHQiqcNSvTLjEG8VOKG65Psdx1qPvK8","X-Gm-Gg":"AeBDieuux7//Qte1loQUb3lOWvoi9kM8YKagDElVTWN4BNVcRcUg/2V6Q/1YcE4ShDd\n ygCDKi4KBUkLbbiKyOkgT6IJD3vJs2DPihnGbejPNf23s25AZasGrjd5CxjZXHxjqPyXr6sJSCC\n Tw1Jkhdq+gLJmonnki1++muHByiMzFdz5FMmpyegfSZT5/8/aL08UJmBoZT7wwY4rOUHbEbj27/\n fJnYKXqwrmkXfjCSYuSJFdTsQrEUvErtlOFp/ZgDzYYorvMQiWjfasOu6lstfbeNQqOMBNT3iTl\n tyS2uRuFymW5cwychXxnzq6bRx47y5srnkNGKRcInSDHRVO2obwJGLaqG8USpECl+Rmx0W1GjTZ\n IrLuClZvubGL2tGEtPOFss+dy+PUnbgPX+tF0LtK3AypFkFEprBf22yHcNtn55tGBr72z5/5pDG\n XdmJs=","X-Received":"by 2002:a05:7300:b594:b0:2c5:220c:5673 with SMTP id\n 5a478bee46e88-2cbf99ec1e9mr5457205eec.5.1775437193402;\n Sun, 05 Apr 2026 17:59:53 -0700 (PDT)","From":"Matt Vollrath ","To":"intel-wired-lan@osuosl.org","Cc":"Matt Vollrath ","Date":"Sun, 5 Apr 2026 20:58:31 -0400","Message-ID":"<20260406005830.2250373-2-tactii@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775437193; x=1776041993; darn=osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=tAiOfRInaVupAzzjCM+nMcXrmYbAjEitRdUAHT6Jfhw=;\n b=dsANMB0cQR2kQ/DEsRmSYq7LfA6EZgZT6xB7tLgYAOz6LoQfF3Y2gM0ew+liBy//1u\n 2fehLbrQLHEkDtlcwKVDd07g9U502zhppyxQLNw9xnL8dmv6CUpOBD9Xg0DDTwkv0Y6w\n B0NvTE2T0BMUiG/9dFe+OXw/iNS3if8Lu3UTOs513BC0P3ai0b9SKO05ayDETywofAvA\n Y0PCN3EQLVJBEz4Z6JuwpmqTHMSdIsL5dGZCxjnl4EilMb+NCmFR1ct+mEi5u8AuniG6\n JPjXPxexn0xGwzwT+pf5espnzlzWu30pBC3v1dMa//tDtZHRsDh5uLLWdfog9VKlXPIW\n luaA==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=dsANMB0c"],"Subject":"[Intel-wired-lan] [PATCH net v2] i40e: Cleanup PTP registration on\n probe failure","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Fix two conditions which would leak PTP registration on probe failure:\n\n1. i40e_setup_pf_switch can encounter an error in\n i40e_setup_pf_filter_control, call i40e_ptp_init, then return\n non-zero, sending i40e_probe to err_vsis.\n\n2. i40e_setup_misc_vector can return non-zero, sending i40e_probe to\n err_vsis.\n\nBoth of these conditions have been present since PTP was introduced in\nthis driver.\n\nFound with coccinelle.\n\nFixes: beb0dff1251db (\"i40e: enable PTP\")\nSigned-off-by: Matt Vollrath \n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 926d001b2150..f3de147aaddf 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -16109,6 +16109,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t/* Unwind what we've done if something failed in the setup */\n err_vsis:\n \tset_bit(__I40E_DOWN, pf->state);\n+\ti40e_ptp_stop(pf);\n \ti40e_clear_interrupt_scheme(pf);\n \tkfree(pf->vsi);\n err_switch_setup:\n","prefixes":["net","v2"]}