{"id":2219998,"url":"http://patchwork.ozlabs.org/api/patches/2219998/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260405154816.4774-1-devnexen@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260405154816.4774-1-devnexen@gmail.com>","list_archive_url":null,"date":"2026-04-05T15:48:16","name":"[ovs-dev,v3,net-next] net: use get_random_u{16, 32, 64}() where appropriate","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a0767bcb1f6742c6fa2de9720483e5f6f9c74323","submitter":{"id":76714,"url":"http://patchwork.ozlabs.org/api/people/76714/?format=json","name":"David CARLIER","email":"devnexen@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260405154816.4774-1-devnexen@gmail.com/mbox/","series":[{"id":498797,"url":"http://patchwork.ozlabs.org/api/series/498797/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=498797","date":"2026-04-05T15:48:16","name":"[ovs-dev,v3,net-next] net: use get_random_u{16, 32, 64}() where appropriate","version":3,"mbox":"http://patchwork.ozlabs.org/series/498797/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219998/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219998/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=YCE/+y5e;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=YCE/+y5e","smtp2.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp2.osuosl.org; dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=YCE/+y5e"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpdTq0SMZz1xy1\n\tfor ; Mon, 06 Apr 2026 02:39:42 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 0648040A1F;\n\tSun, 5 Apr 2026 16:39:40 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id tGNUplqyWL5S; Sun, 5 Apr 2026 16:39:38 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id C42B240A08;\n\tSun, 5 Apr 2026 16:39:38 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 9DD81C04FB;\n\tSun, 5 Apr 2026 16:39:38 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id C29C9C04FA\n for ; Sun, 5 Apr 2026 15:48:24 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id BAC5C4016F\n for ; Sun, 5 Apr 2026 15:48:24 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id R2bNTNNlAXGE for ;\n Sun, 5 Apr 2026 15:48:22 +0000 (UTC)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n [IPv6:2a00:1450:4864:20::329])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 2D9F54015F\n for ; Sun, 5 Apr 2026 15:48:21 +0000 (UTC)","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-488aa77a06eso9827355e9.0\n for ; Sun, 05 Apr 2026 08:48:21 -0700 (PDT)","from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4887e93cf2dsm390530145e9.11.2026.04.05.08.48.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 05 Apr 2026 08:48:19 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org C42B240A08","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2D9F54015F"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::329; helo=mail-wm1-x329.google.com;\n envelope-from=devnexen@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 2D9F54015F","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775404100; x=1776008900; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=8ejC9X9oL82T7UTRyPRfLQE9jbWqA07yGBE+sGIzbzg=;\n b=YCE/+y5e2M/Sq5KjWsBi9JPNmHQTCtWmDqXI1xJXYiZkJobTsuOnm+v2ykKOnFO93S\n J/ZJJrWh8DhVz6PHwko4v9RVsXuUliTQ6imQ2OYPHgs2DAm0DFHIPKlcJMenm01sXuov\n fsc/NiU81yPGiPW/MnvlBCEJM3N+4UMckaA1j5+zPjLHm7G7UYnzr3GpbzyXsZpM6A7Y\n /fcsXNJ1HdvuBIp0WY3v/vlfol0mFHNOcnff6e5aIKHspDbc37oJqQrF14fKGmxWxViH\n sNOr5ijBn0phCRT/srCGMJV0KUz1uskeTUjwp4lCocxCO4Atfn8UQR783W69HQr7FWw0\n iYKQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775404100; x=1776008900;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8ejC9X9oL82T7UTRyPRfLQE9jbWqA07yGBE+sGIzbzg=;\n b=H18WhnKfSTo+AHjm4kNoC9xkgZlRtFXI0RI0AnZ5kqIS3IRzwKWBv3k2BES9/Iew7D\n 4RbviBT6ktEDOZNwDhAraR4ujHaDbIh3za4mTtHUovZlKkGzSbzHzLDX2Q3BPOPFkph1\n DzObXUAH/XUwmrmjIqd/z7dfqNsrtBvD3NnnCNcWMmo9IpekCutO7A2TmIEWknWe9G2I\n gYBy+0ez4MlUxfadTTxqpg6VoCZ4JNtQMAZnharXFDrYjn4JddPG9y+UEz4NtxTEEgcT\n kiwiB/gGQNzvaThe31oGdi0NdnuNduFMEs24GZIGB/d6lItTG1p9xmRcSCmTMsocEaAh\n xZdg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXhBzoxIvlJN0h5hLQF/UYmKJEc5MdnTLAa12nt5MeW8QqfElKoUydcEMUKYKcCe1BWfV4=@openvswitch.org","X-Gm-Message-State":"AOJu0Yz09HCatKl5Mpk1RNW2P0FFC1IvEV+KEKpq8Z2kP7BANMAZ0gt5\n twl5/g2OOIFe9NynH8mlc8eFF6gSSLHq46l+X3kPAtxOnNoLf9vTiqe4","X-Gm-Gg":"AeBDietoOeN/dtgyfMcKXTBbK4qDHhQyfr0CgZ5aEbkQpS7pFSySw9JG8DRTIOMWk7U\n NbSCSoA6cofCWznX93yoGmTmxWSj0jbIq7wJoUS/TxKEoefm+dlumvEepMwzQmQrN/Sh6GRHDX3\n 6A+FVGKJc3kozMHpRA9zdT1aOfWU8yWWexwSUDwmYCc2xTARbu57LkmFwJm0etFhYCGv03hff78\n 68W380ZqA9bQiziZ2BtXCJ0j0su8lBcUskrcsl/YjVkvwqkGfmIhC4aDEg7bek/uuTP6/22AIjd\n a/eWz6kAJzTx8dJw9GFXuHtb06e+eXkVJv5lIYFtLx8U91EK80B3/5EVgVr+R6fauAlGvuNtXhS\n wRc21ZZku3lUo1CKiGT7p6L3L6vCyUWZi2pO8ZM6de2HW2ruGxAEs6Yc/BFibWDpEvtJ9bslA/U\n hLLc10xHbKpQR2rk4524SDdl8TijhokaziE8k64lwA1gQfaW2h9PX2SgRNvgR98vmZLsQ4UiV0T\n 6R2Dc5Bip22","X-Received":"by 2002:a05:600c:1396:b0:487:338:b4f3 with SMTP id\n 5b1f17b1804b1-488997d1371mr147256185e9.17.1775404099759;\n Sun, 05 Apr 2026 08:48:19 -0700 (PDT)","From":"David Carlier ","To":"Jakub Kicinski ,\n \"David S . Miller\" ,\n Eric Dumazet , Paolo Abeni ","Date":"Sun, 5 Apr 2026 16:48:16 +0100","Message-ID":"<20260405154816.4774-1-devnexen@gmail.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Mailman-Approved-At":"Sun, 05 Apr 2026 16:39:37 +0000","Subject":"[ovs-dev] [PATCH v3 net-next] net: use get_random_u{16, 32,\n 64}() where appropriate","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"dev@openvswitch.org, linux-wireless@vger.kernel.org,\n Marcelo Ricardo Leitner ,\n Xin Long , David Carlier ,\n netdev@vger.kernel.org, Geliang Tang ,\n linux-sctp@vger.kernel.org, Ilya Maximets ,\n Mat Martineau , Jon Maloy ,\n Andrew Lunn , Matthieu Baerts ,\n tipc-discussion@lists.sourceforge.net, Simon Horman ,\n mptcp@lists.linux.dev, ceph-devel@vger.kernel.org,\n Ilya Dryomov , Johannes Berg ,\n linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Use the typed random integer helpers instead of\nget_random_bytes() when filling a single integer variable.\nThe helpers return the value directly, require no pointer\nor size argument, and better express intent.\n\nSkipped sites writing into __be16 fields (netdevsim) where\na direct assignment would trigger sparse endianness warnings.\n\nSigned-off-by: David Carlier \n---\n drivers/net/netdevsim/psample.c | 4 ++--\n net/ceph/auth_x.c | 2 +-\n net/core/net_namespace.c | 2 +-\n net/mac80211/mesh_plink.c | 2 +-\n net/mptcp/subflow.c | 4 ++--\n net/openvswitch/flow_table.c | 2 +-\n net/sctp/sm_make_chunk.c | 4 ++--\n net/tipc/node.c | 2 +-\n 8 files changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/drivers/net/netdevsim/psample.c b/drivers/net/netdevsim/psample.c\nindex 47d24bc64ee4..717d157c3ae2 100644\n--- a/drivers/net/netdevsim/psample.c\n+++ b/drivers/net/netdevsim/psample.c\n@@ -94,7 +94,7 @@ static void nsim_dev_psample_md_prepare(const struct nsim_dev_psample *psample,\n \tif (psample->out_tc_occ_max) {\n \t\tu64 out_tc_occ;\n \n-\t\tget_random_bytes(&out_tc_occ, sizeof(u64));\n+\t\tout_tc_occ = get_random_u64();\n \t\tmd->out_tc_occ = out_tc_occ & (psample->out_tc_occ_max - 1);\n \t\tmd->out_tc_occ_valid = 1;\n \t}\n@@ -102,7 +102,7 @@ static void nsim_dev_psample_md_prepare(const struct nsim_dev_psample *psample,\n \tif (psample->latency_max) {\n \t\tu64 latency;\n \n-\t\tget_random_bytes(&latency, sizeof(u64));\n+\t\tlatency = get_random_u64();\n \t\tmd->latency = latency & (psample->latency_max - 1);\n \t\tmd->latency_valid = 1;\n \t}\ndiff --git a/net/ceph/auth_x.c b/net/ceph/auth_x.c\nindex 692e0b868822..936b43ae4a95 100644\n--- a/net/ceph/auth_x.c\n+++ b/net/ceph/auth_x.c\n@@ -571,7 +571,7 @@ static int ceph_x_build_request(struct ceph_auth_client *ac,\n \t\t\tblob = enc_buf + SHA256_DIGEST_SIZE;\n \t\t}\n \n-\t\tget_random_bytes(&auth->client_challenge, sizeof(u64));\n+\t\tauth->client_challenge = get_random_u64();\n \t\tblob->client_challenge = auth->client_challenge;\n \t\tblob->server_challenge = cpu_to_le64(xi->server_challenge);\n \ndiff --git a/net/core/net_namespace.c b/net/core/net_namespace.c\nindex 1057d16d5dd2..deb8b2ec5674 100644\n--- a/net/core/net_namespace.c\n+++ b/net/core/net_namespace.c\n@@ -411,7 +411,7 @@ static __net_init int preinit_net(struct net *net, struct user_namespace *user_n\n \tref_tracker_dir_init(&net->refcnt_tracker, 128, \"net_refcnt\");\n \tref_tracker_dir_init(&net->notrefcnt_tracker, 128, \"net_notrefcnt\");\n \n-\tget_random_bytes(&net->hash_mix, sizeof(u32));\n+\tnet->hash_mix = get_random_u32();\n \tnet->dev_base_seq = 1;\n \tnet->user_ns = user_ns;\n \ndiff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c\nindex 803106fc3134..7cbab90c8784 100644\n--- a/net/mac80211/mesh_plink.c\n+++ b/net/mac80211/mesh_plink.c\n@@ -712,7 +712,7 @@ void mesh_plink_timer(struct timer_list *t)\n \t\t\t\t\"Mesh plink for %pM (retry, timeout): %d %d\\n\",\n \t\t\t\tsta->sta.addr, sta->mesh->plink_retries,\n \t\t\t\tsta->mesh->plink_timeout);\n-\t\t\tget_random_bytes(&rand, sizeof(u32));\n+\t\t\trand = get_random_u32();\n \t\t\tsta->mesh->plink_timeout = sta->mesh->plink_timeout +\n \t\t\t\t\t rand % sta->mesh->plink_timeout;\n \t\t\t++sta->mesh->plink_retries;\ndiff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c\nindex 5cfe19990f31..1a7736145dbc 100644\n--- a/net/mptcp/subflow.c\n+++ b/net/mptcp/subflow.c\n@@ -72,7 +72,7 @@ static void subflow_req_create_thmac(struct mptcp_subflow_request_sock *subflow_\n \tstruct mptcp_sock *msk = subflow_req->msk;\n \tu8 hmac[SHA256_DIGEST_SIZE];\n \n-\tget_random_bytes(&subflow_req->local_nonce, sizeof(u32));\n+\tsubflow_req->local_nonce = get_random_u32();\n \n \tsubflow_generate_hmac(READ_ONCE(msk->local_key),\n \t\t\t READ_ONCE(msk->remote_key),\n@@ -1639,7 +1639,7 @@ int __mptcp_subflow_connect(struct sock *sk, const struct mptcp_pm_local *local,\n \tssk = sf->sk;\n \tsubflow = mptcp_subflow_ctx(ssk);\n \tdo {\n-\t\tget_random_bytes(&subflow->local_nonce, sizeof(u32));\n+\t\tsubflow->local_nonce = get_random_u32();\n \t} while (!subflow->local_nonce);\n \n \t/* if 'IPADDRANY', the ID will be set later, after the routing */\ndiff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c\nindex 61c6a5f77c2e..67d5b8c0fe79 100644\n--- a/net/openvswitch/flow_table.c\n+++ b/net/openvswitch/flow_table.c\n@@ -167,7 +167,7 @@ static struct table_instance *table_instance_alloc(int new_size)\n \n \tti->n_buckets = new_size;\n \tti->node_ver = 0;\n-\tget_random_bytes(&ti->hash_seed, sizeof(u32));\n+\tti->hash_seed = get_random_u32();\n \n \treturn ti;\n }\ndiff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c\nindex 2c0017d058d4..de86ac088289 100644\n--- a/net/sctp/sm_make_chunk.c\n+++ b/net/sctp/sm_make_chunk.c\n@@ -2727,7 +2727,7 @@ __u32 sctp_generate_tag(const struct sctp_endpoint *ep)\n \t__u32 x;\n \n \tdo {\n-\t\tget_random_bytes(&x, sizeof(__u32));\n+\t\tx = get_random_u32();\n \t} while (x == 0);\n \n \treturn x;\n@@ -2738,7 +2738,7 @@ __u32 sctp_generate_tsn(const struct sctp_endpoint *ep)\n {\n \t__u32 retval;\n \n-\tget_random_bytes(&retval, sizeof(__u32));\n+\tretval = get_random_u32();\n \treturn retval;\n }\n \ndiff --git a/net/tipc/node.c b/net/tipc/node.c\nindex af442a5ef8f3..97aa970a0d83 100644\n--- a/net/tipc/node.c\n+++ b/net/tipc/node.c\n@@ -1275,7 +1275,7 @@ void tipc_node_check_dest(struct net *net, u32 addr,\n \t\t\tgoto exit;\n \n \t\tif_name = strchr(b->name, ':') + 1;\n-\t\tget_random_bytes(&session, sizeof(u16));\n+\t\tsession = get_random_u16();\n \t\tif (!tipc_link_create(net, if_name, b->identity, b->tolerance,\n \t\t\t\t b->net_plane, b->mtu, b->priority,\n \t\t\t\t b->min_win, b->max_win, session,\n","prefixes":["ovs-dev","v3","net-next"]}