{"id":2219847,"url":"http://patchwork.ozlabs.org/api/patches/2219847/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/CAJBeyFHrv+xMV0qivRC=AAzrzQGks6DOx0KZJrHzaofDPtaM1g@mail.gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-03T12:07:37","name":"[ovs-dev] netdev-dpdk: Fix possible memory leak when configuring rx-steering","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0f29d1be96aadfb87aed23abc3a9b8a9349ab730","submitter":{"id":93057,"url":"http://patchwork.ozlabs.org/api/people/93057/?format=json","name":"Mikhail Dmitrichenko","email":"m.dmitrichenko222@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/CAJBeyFHrv+xMV0qivRC=AAzrzQGks6DOx0KZJrHzaofDPtaM1g@mail.gmail.com/mbox/","series":[{"id":498751,"url":"http://patchwork.ozlabs.org/api/series/498751/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=498751","date":"2026-04-03T12:07:37","name":"[ovs-dev] netdev-dpdk: Fix possible memory leak when configuring rx-steering","version":1,"mbox":"http://patchwork.ozlabs.org/series/498751/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219847/comments/","check":"fail","checks":"http://patchwork.ozlabs.org/api/patches/2219847/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=e87LHoEj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=e87LHoEj","smtp3.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fp8N70nfbz1y2d\n\tfor ; Sun, 05 Apr 2026 07:48:06 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 144F9608DB;\n\tSat, 4 Apr 2026 21:48:04 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id I2Mg_frlkdGW; Sat, 4 Apr 2026 21:48:02 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 28B8460714;\n\tSat, 4 Apr 2026 21:48:02 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 0B194C04FB;\n\tSat, 4 Apr 2026 21:48:02 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id EEDA3C003D\n for ; Fri, 3 Apr 2026 12:07:49 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id DCE37608EB\n for ; Fri, 3 Apr 2026 12:07:49 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id rPap3gQUMeXo for ;\n Fri, 3 Apr 2026 12:07:49 +0000 (UTC)","from mail-pf1-x433.google.com (mail-pf1-x433.google.com\n [IPv6:2607:f8b0:4864:20::433])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 2C631608EA\n for ; Fri, 3 Apr 2026 12:07:49 +0000 (UTC)","by mail-pf1-x433.google.com with SMTP id\n d2e1a72fcca58-82c28f0a4ecso1409781b3a.3\n for ; Fri, 03 Apr 2026 05:07:49 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 28B8460714","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2C631608EA"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::433; helo=mail-pf1-x433.google.com;\n envelope-from=m.dmitrichenko222@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 2C631608EA","ARC-Seal":"i=1; a=rsa-sha256; t=1775218068; cv=none;\n d=google.com; s=arc-20240605;\n b=RsfXwp99jkKcvegqM3WxVCpJU8rnTQERuHZCbFPR2T6KDS3tckb652D+9nMCXx3Oe2\n 5m7K/0G6ZyudQ6oYx7qGlKrfLj4Agsd60rlHhiYPeBVZepCIP6mU6Vthzp+oi3KYDLJ+\n K9U929DTy5zmdrygVqSrhQ6hw7jhBV0kQxn7jDkyxReaDb1KFnXb9wIeIB2AN0rnEp+q\n hOQ9RfMHc01elnqD/+ILxpjUkEcfC0V6lglXXPqU50ANbD9JVSuNIjM1HuiErt6ez0TQ\n JdrWmqgAan+ZWVVobummBoP4PlCQxd4I4axnK5I3ouJK7AYT5CRZrNX/WF8bCqcQDcfF\n C9OA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=to:subject:message-id:date:from:mime-version:dkim-signature;\n bh=wfH47theMaAcgQXT6gZiLqUsErrlnON2L0ykofbiMp8=;\n fh=WnO6tfRXfzNkmVvpHWPU0Sn0nugAh6D8VsZG77w0RnY=;\n b=SpaCJ52Fc4L6YkbW3d3wQ5TUoLU7rFCORLFjj3RF6XQLKRyrgCDi9yI0MQLhtBe5/T\n h+DYZPz2NYEpKqk0fOU1uYaWJM9rvVujn16Mo6ptroqoHTU47qWbjjqG0ky5pDZQNqSU\n 3Yn2esFC3fvdSrYI2/N4h4sU2UmAsCMpxFbF1D2hQaNY6ZqiHFAGLBKsgo2Znl0HieiU\n 5f2Oai0NNaAfrksD45DzuBsgw6dAq1BHXRyQjYs3HFcIAmpebjfn9O4GgVTYbeUygYVU\n ldJ+WrxEt/e5g7Jh58YaGpLadA33lxlHe07gpSP1SSMXtLsikv4Lqclq8P3FKqbRbWhX\n 9ZTQ==; darn=openvswitch.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775218068; x=1775822868; darn=openvswitch.org;\n h=to:subject:message-id:date:from:mime-version:from:to:cc:subject\n :date:message-id:reply-to;\n bh=wfH47theMaAcgQXT6gZiLqUsErrlnON2L0ykofbiMp8=;\n b=e87LHoEjg8mIrJV945++AI7G8/Xbc+SSE56GFRfeP4IzdN9Edwnqd4bY78b206yM7f\n eAJ9dDbw6C2lP4k5cAbG2XLw6X6cgpqcaZTnAUUG9OnlQ6Fofo3j+rXtFH0xKf7H8oTe\n +kAWCuKKKZdE+JZ+2oFS6oZZUIcucACE6a3Z896tY/gAzGooGjy/QN86QF3/iQ2YbdX5\n EHSnbHPOSVl3utzLB0INKHJ6LJ6WdCA/7/aH1x8uchl/UaDcWppgIdOnzJPGgHKzzwlD\n BvkfHCP1I+y4rOjXxf0IPzmZ4xmgaSl96Cx3Fr/lpjFgGFeUnptQX6B5gPIxCj3yNgkh\n 8Tsw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775218068; x=1775822868;\n h=to:subject:message-id:date:from:mime-version:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=wfH47theMaAcgQXT6gZiLqUsErrlnON2L0ykofbiMp8=;\n b=kwo4JJWh8YJvsaSb7o9dRMZPOAycOdkjYNI4ZLdHC/YCDGbrixPefkqfzJRM8x7E9r\n vEHcPTDj9zFdMv+hCX9r7wsrpzJnK+N5HcQqnP+0IqmB8ep2ICdY+YcoNymNgsjpR3aG\n 0zx7gZO13oDHcbpoX9A7l511JzKf9f0jGjwKo2oTF3XElZCZgppwkqGWogalw90eOMPW\n XKd1Y1ZEbBoApj/pwJTnsCCSXV98FPWIE7sJilByZ7jOqdKp6Or2BgdOX0ZROgW9wqfp\n TixRXow41rxn7lfINv67Wt2h4VDeNWyHfn1MbMFAFad4EAxq0AgxmTdkqnilyN69C0Rz\n yB7g==","X-Gm-Message-State":"AOJu0Yw4FVkWp94hZx7oIMV50dquVly6IYIDt9PKYEgTqiapiYHpcaL3\n zGkIHVb/1E753t3wuSxg2i5ZHja90y4lmY1gu7PSMq2yFVdughyVbFoEscGSr0e8wJOgOotUIYJ\n yLll4fgx3+wajUoLlBJMnLXroNqQRwniF3WLh","X-Gm-Gg":"ATEYQzyqOqjwhUvFVrRojhg9FnxiBjZyU8N4wwrZeWkox2s2iKUY0uFZFvQyLXZqGd6\n 9paV6vZzFngFYtIweIhuXtBA05frynPWmRUbtefkjz5WXm4vQ2LK+bL+4qzwATnKJxyCJGrhO1I\n pWCIXj5kU6dtnv3pZmMMUoeFgLR3Zklpdbq57ZUzmpLmBYRYeyHxUvVguaavcgmiRxxPWjeM3Tx\n sB+DPfN9RkX3D6DzoTlmzXGBDXxnXFUCU9U74aQMKt7oaG2m7aYiIGe223lwyGg1Gjl0SwLjRxR\n jQ==","X-Received":"by 2002:a05:6a00:4b56:b0:82c:9c90:54cf with SMTP id\n d2e1a72fcca58-82d0dba133dmr2956534b3a.43.1775218068082; Fri, 03 Apr 2026\n 05:07:48 -0700 (PDT)","MIME-Version":"1.0","From":"Mikhail Dmitrichenko ","Date":"Fri, 3 Apr 2026 15:07:37 +0300","X-Gm-Features":"AQROBzBqZlh7ia6LlvEhIYmuT8UWCDoZ5AYAjjO_2FOGPs836s9Wnx_c3FHH5X4","Message-ID":"\n ","To":"dev@openvswitch.org","X-Mailman-Approved-At":"Sat, 04 Apr 2026 21:48:00 +0000","Subject":"[ovs-dev] [PATCH] netdev-dpdk: Fix possible memory leak when\n configuring rx-steering","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"From 81def5ff65881ce6cb4ccdd23a34da8a2870568f Mon Sep 17 00:00:00 2001\nFrom: Mikhail Dmitrichenko \nDate: Fri, 3 Apr 2026 14:19:13 +0300\nSubject: [PATCH] netdev-dpdk: Fix possible memory leak when configuring\n rx-steering\n\nVLOG_WARN_BUF() allocates a new string with xasprintf() every time it is\ncalled and overwrites *errp without freeing the previous value. This can\nlead to a memory leak if multiple warnings are emitted or if a later\nhard error in netdev_dpdk_set_config() also writes\nto errp.\n\nThe three cases in dpdk_set_rx_steer_config() are not fatal errors:\n- unsupported rx-steering value\n- rss+lacp on non-ethernet port\n- rss+lacp together with hw-offload\n\nIn all cases program simply log a warning and fall back to default RSS\nsteering. Configuration continues normally (err remains 0 and execution\nflow do not goto out).\n\nTherefore change them to plain VLOG_WARN(). As a result the 'errp'\nparameter becomes unused and is removed from the function signature and\nthe call site in netdev_dpdk_set_config().\n\nThis makes the code cleaner and consistent with the rest of netdev-dpdk.\n\nFound by Linux Verification Center (linuxtesting.org) with SVACE.\n\nFixes: fc06ea (\"netdev-dpdk: Add custom rx-steering configuration.\")\nSigned-off-by: Mikhail Dmitrichenko \n---\n lib/netdev-dpdk.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\n uint64_t flags = 0;\n@@ -2259,22 +2259,22 @@ dpdk_set_rx_steer_config(struct netdev\n*netdev, struct netdev_dpdk *dev,\n if (!strcmp(arg, \"rss+lacp\")) {\n flags = DPDK_RX_STEER_LACP;\n } else if (strcmp(arg, \"rss\")) {\n- VLOG_WARN_BUF(errp, \"%s: options:rx-steering \"\n- \"unsupported parameter value '%s'\",\n- netdev_get_name(netdev), arg);\n+ VLOG_WARN(\"%s: options:rx-steering \"\n+ \"unsupported parameter value '%s'\",\n+ netdev_get_name(netdev), arg);\n }\n\n if (flags && dev->type != DPDK_DEV_ETH) {\n- VLOG_WARN_BUF(errp, \"%s: options:rx-steering \"\n- \"is only supported on ethernet ports\",\n- netdev_get_name(netdev));\n+ VLOG_WARN(\"%s: options:rx-steering \"\n+ \"is only supported on ethernet ports\",\n+ netdev_get_name(netdev));\n flags = 0;\n }\n\n if (flags && dpif_offload_enabled()) {\n- VLOG_WARN_BUF(errp, \"%s: options:rx-steering \"\n- \"is incompatible with hw-offload\",\n- netdev_get_name(netdev));\n+ VLOG_WARN(\"%s: options:rx-steering \"\n+ \"is incompatible with hw-offload\",\n+ netdev_get_name(netdev));\n flags = 0;\n }\n\n@@ -2304,7 +2304,7 @@ netdev_dpdk_set_config(struct netdev *netdev,\nconst struct smap *args,\n ovs_mutex_lock(&dpdk_mutex);\n ovs_mutex_lock(&dev->mutex);\n\n- dpdk_set_rx_steer_config(netdev, dev, args, errp);\n+ dpdk_set_rx_steer_config(netdev, dev, args);\n\n dpdk_set_rxq_config(dev, args);","diff":"diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex 54959ff0d..9fbb204ef 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -2251,7 +2251,7 @@ dpdk_process_queue_size(struct netdev *netdev,\nconst struct smap *args,\n\n static void\n dpdk_set_rx_steer_config(struct netdev *netdev, struct netdev_dpdk *dev,\n- const struct smap *args, char **errp)\n+ const struct smap *args)\n {\n const char *arg = smap_get_def(args, \"rx-steering\", \"rss\");\n","prefixes":["ovs-dev"]}