{"id":2219844,"url":"http://patchwork.ozlabs.org/api/patches/2219844/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260404194210.20876-1-ebiggers@kernel.org/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260404194210.20876-1-ebiggers@kernel.org>","list_archive_url":null,"date":"2026-04-04T19:42:10","name":"smb: client: Remove unnecessary selection of CRYPTO_ECB","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"92a288aab536939d423f7ee71d8daf90a4d8f7a2","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/people/74690/?format=json","name":"Eric Biggers","email":"ebiggers@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260404194210.20876-1-ebiggers@kernel.org/mbox/","series":[{"id":498748,"url":"http://patchwork.ozlabs.org/api/series/498748/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=498748","date":"2026-04-04T19:42:10","name":"smb: client: Remove unnecessary selection of CRYPTO_ECB","version":1,"mbox":"http://patchwork.ozlabs.org/series/498748/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219844/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219844/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=JIQdg8um;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10665-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"JIQdg8um\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fp5dk3Yzfz1xtJ\n\tfor ; Sun, 05 Apr 2026 05:44:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 05A5A300AB16\n\tfor ; Sat, 4 Apr 2026 19:44:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 57476322533;\n\tSat, 4 Apr 2026 19:44:24 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 344F1137923;\n\tSat, 4 Apr 2026 19:44:23 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 670C6C19421;\n\tSat, 4 Apr 2026 19:44:23 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775331864; cv=none;\n b=u6u1W4xQklI6z2lGDg560VkNIyUm2yPefjZqX9KPWG0+Sju2P/tYG24NorJcsZu91QA1+oPpIts8aghkTE8UDqFIpsKtqON2WQc3brs+fZXl/91LLGcawHLdg4bLDq2dSdNOBP088QrKzm6BByaVHCuoqDtUcaN/zqq0w2x9qdo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775331864; c=relaxed/simple;\n\tbh=m2A5Yy4h38l28Ps/ZrrBwv9IT49CQmsgL2an3SFnHTk=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=f1K/fX1vC50rmc3mfF/fK79jbCcbY/GtychOcj47LOD9ZY4YpCQ2YZ9cYSHOCAAhFnRJaDxegR4/NDuAlGDEs9uDHO/CHuJ6Ht1+fjew0+WB+ZTJDxmL6GYDiEAQOvQxinmdgmRdpgz3IXo9T/1q7tb03vdNnPvrG6taQEiA5uU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=JIQdg8um; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775331863;\n\tbh=m2A5Yy4h38l28Ps/ZrrBwv9IT49CQmsgL2an3SFnHTk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=JIQdg8umcnQlwISS4DvXHi/wH6tuHU7aivaPznHQWFzjz8Fimf0r2dOo/kh1H3Prd\n\t DNXN8quF1e6CDBQ2LF5KHK84ecVwisgPnVIjcapCUZzgk4r8OfQB2WMusFu94VvPpQ\n\t eKRvUM0HEOBky+baMDkCrp4b0hXaJtT1hSINDE5mdyqsbo3QuM1isLh4pQTbFnBU+e\n\t oyZEE6tgsbSURPDWs1+Zezb/FwAb7c2osbEm4WT00MeqLuK2W8eFBBKI7+fIEFFQvG\n\t cJudpplgGtWBmjF92NK2VKaLh1qnhBbT1PXTotyVI7zJ7q0/T1tEz/3P6S/24w5fjL\n\t yja+nyP2ZSEbg==","From":"Eric Biggers ","To":"linux-cifs@vger.kernel.org,\n\tSteve French ","Cc":"Paulo Alcantara ,\n\tRonnie Sahlberg ,\n\tShyam Prasad N ,\n\tTom Talpey ,\n\tBharath SM ,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org,\n\tEric Biggers ","Subject":"[PATCH] smb: client: Remove unnecessary selection of CRYPTO_ECB","Date":"Sat, 4 Apr 2026 12:42:10 -0700","Message-ID":"<20260404194210.20876-1-ebiggers@kernel.org>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Since the SMB client never uses any ecb(...) algorithm from the\ncrypto_skcipher API, selecting CRYPTO_ECB is unnecessary.\n\nSpecifically, it has been unnecessary since commit 06deeec77a5a (\"cifs:\nFix smbencrypt() to stop pointing a scatterlist at the stack\") in 2016.\n\nSigned-off-by: Eric Biggers \n---\n\nThis patch is targeting the smb client tree.\n\n fs/smb/client/Kconfig | 1 -\n fs/smb/client/cifsfs.c | 1 -\n 2 files changed, 2 deletions(-)\n\n\nbase-commit: 2febe6e6ee6e34c7754eff3c4d81aa7b0dcb7979","diff":"diff --git a/fs/smb/client/Kconfig b/fs/smb/client/Kconfig\nindex 6d7e178e202db..63831242fddfb 100644\n--- a/fs/smb/client/Kconfig\n+++ b/fs/smb/client/Kconfig\n@@ -7,11 +7,10 @@ config CIFS\n \tselect CRYPTO\n \tselect CRYPTO_CMAC\n \tselect CRYPTO_AEAD2\n \tselect CRYPTO_CCM\n \tselect CRYPTO_GCM\n-\tselect CRYPTO_ECB\n \tselect CRYPTO_AES\n \tselect CRYPTO_LIB_ARC4\n \tselect CRYPTO_LIB_MD5\n \tselect CRYPTO_LIB_SHA256\n \tselect CRYPTO_LIB_SHA512\ndiff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c\nindex 0541706c36c52..2025739f070ac 100644\n--- a/fs/smb/client/cifsfs.c\n+++ b/fs/smb/client/cifsfs.c\n@@ -2156,11 +2156,10 @@ MODULE_AUTHOR(\"Steve French\");\n MODULE_LICENSE(\"GPL\");\t/* combination of LGPL + GPL source behaves as GPL */\n MODULE_DESCRIPTION\n \t(\"VFS to access SMB3 servers e.g. Samba, Macs, Azure and Windows (and \"\n \t\"also older servers complying with the SNIA CIFS Specification)\");\n MODULE_VERSION(CIFS_VERSION);\n-MODULE_SOFTDEP(\"ecb\");\n MODULE_SOFTDEP(\"nls\");\n MODULE_SOFTDEP(\"aes\");\n MODULE_SOFTDEP(\"cmac\");\n MODULE_SOFTDEP(\"aead2\");\n MODULE_SOFTDEP(\"ccm\");\n","prefixes":[]}