{"id":2219800,"url":"http://patchwork.ozlabs.org/api/patches/2219800/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260404140328.3724864-3-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260404140328.3724864-3-sjg@chromium.org>","list_archive_url":null,"date":"2026-04-04T14:03:06","name":"[02/14] test: fs_helper: Skip empty srcdir when creating a filesystem","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"388153fe306ba17a13ffcccaa95dc7e18f3841ef","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260404140328.3724864-3-sjg@chromium.org/mbox/","series":[{"id":498729,"url":"http://patchwork.ozlabs.org/api/series/498729/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498729","date":"2026-04-04T14:03:04","name":"test: Convert tests to use FsHelper and DiskHelper","version":1,"mbox":"http://patchwork.ozlabs.org/series/498729/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219800/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219800/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=T9163AIB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"T9163AIB\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fny4t6FFhz1yG2\n\tfor ; Sun, 05 Apr 2026 01:04:14 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4F6778407E;\n\tSat, 4 Apr 2026 16:03:58 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 5D977840ED; Sat, 4 Apr 2026 16:03:57 +0200 (CEST)","from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com\n [IPv6:2001:4860:4864:20::2e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3A91B84020\n for ; Sat, 4 Apr 2026 16:03:55 +0200 (CEST)","by mail-oa1-x2e.google.com with SMTP id\n 586e51a60fabf-41c420d1460so846716fac.3\n for ; Sat, 04 Apr 2026 07:03:55 -0700 (PDT)","from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-4232eb3d0e4sm2348235fac.6.2026.04.04.07.03.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 04 Apr 2026 07:03:52 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775311433; x=1775916233; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pMoGHOaqF9w9n8yN2izhCpnr/grNuKtnhFwHRXPEr2M=;\n b=T9163AIBpnZEpjgKNgu7Qu10IHMNrnPCaKkoToaq/8FXQmpn+OeDhJaQKeaXi48+NR\n jX7vVvuvrIBcfojIR2uDc9GCPBxwUcLcopqr9u2maivC1idpz9TMvxPhle7PIvThh6L4\n hrAV8d6yiORYjfMX2/SZCyPS9y263PZmj1qeI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775311433; x=1775916233;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pMoGHOaqF9w9n8yN2izhCpnr/grNuKtnhFwHRXPEr2M=;\n b=g+wEN4Br6d0MRVjLl+C6bYRSo7sWNSPEWPJQl10dbSK21daeuzz6EsraXCwcA1Btj5\n 1wBq+aC0NhRJOQRIJLKhvWAARbnU6Ro7AjU7NJ/dErTHNCAItu176GeSNZ5me1VJzmXS\n rAm06XeoCn0elO3rb06x7W+oYJCQfPGSwKdmjcHsjEn6JPEqs5qAIwbU7Y6YY1lsnaPb\n OJvtYKK7GIRbH0Q2xcEKOZyaKXCv1hdrFexTToPsR+DN6WBnOsj3r5gWz+NlDmjvPbNh\n 3JxNFeAYJ0a45MMdKJHIlWKXCcO9fgQS+mVUCAMkr7ICtPD09K/V7iPHWfl47QQeA/ls\n wQFQ==","X-Gm-Message-State":"AOJu0Yw5pyOPM2pTHyMPt3SOa/YatqasSF8cEraO7sPc9A/d41f7U3n3\n 6AG0CEHpOsJCqCmAe3g/PhkWEtPegjKr9jkHVxPiGh+krRAq3vmoUknjWwqWGbsEvf3Y9v1Naua\n 9T4w=","X-Gm-Gg":"AeBDiesiUbvIxpZZwHcD9BnNikpa2GhglP1OZs/goFzWSr/2rzurWc1ZAOTV4Cs5+fJ\n ZoF5bmE7jxLccgS6yPfWla0BEtyi8eIIH5+NPeP7jQR+Kg0YaDtZDxt/r4IPL7TqncDsAgXFRhM\n fmLgWNjA6sN19JqkT70h/Lav+bM20b7W+rqm7WSCzilv53VA3COteUVz7MFKjKUNlte3dbho2Y9\n nkFre3hrHnwZ+cuYYGofQevLst5hCrtv8u7O9Wll1phkxCJwnWZgEchuZ/pPl90YscKYY5ysopN\n SZ2SMh/2nlw1vctpaCF2m6DrL4TqIPRuE+YOV3YPCDJ8GUyljl7rDJbOvJ8Wsnvy9rOHKw2W+Jc\n HZ5EzF+LeZrdeJKX/V93Qsr6/SnFfo9ziw5v5hSK9SGQR9RIU1RcnKRwFbDxgXtRTenvc+DWdj6\n UoK7jaVuO8KrOugA4d+Q==","X-Received":"by 2002:a05:6871:79b:b0:423:1a33:c275 with SMTP id\n 586e51a60fabf-4231a342d07mr3053146fac.9.1775311433146;\n Sat, 04 Apr 2026 07:03:53 -0700 (PDT)","From":"Simon Glass ","To":"u-boot@lists.denx.de","Cc":"Simon Glass ,\n Christian Taedcke ,\n Tom Rini ","Subject":"[PATCH 02/14] test: fs_helper: Skip empty srcdir when creating a\n filesystem","Date":"Sat, 4 Apr 2026 08:03:06 -0600","Message-ID":"<20260404140328.3724864-3-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260404140328.3724864-1-sjg@chromium.org>","References":"<20260404140328.3724864-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"FsHelper.mk_fs() always creates a srcdir via setup(), then passes it\nto the module-level mk_fs(). This fails for filesystem types like ext2\nthat do not support the -d flag, raising ValueError even when no files\nneed to be copied.\n\nPass None for src_dir when the srcdir is empty, so that creating an\nempty filesystem works for all supported types.\n\nSigned-off-by: Simon Glass \n---\n\n test/py/tests/fs_helper.py | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/test/py/tests/fs_helper.py b/test/py/tests/fs_helper.py\nindex e323a97b220..ee779474ce6 100644\n--- a/test/py/tests/fs_helper.py\n+++ b/test/py/tests/fs_helper.py\n@@ -66,8 +66,9 @@ class FsHelper:\n \"\"\"Make a new filesystem and copy in the files\"\"\"\n self.setup()\n self._do_cleanup = True\n+ src_dir = self.srcdir if os.listdir(self.srcdir) else None\n self.fs_img = mk_fs(self.config, self.fs_type, self.size_mb << 20,\n- self.prefix, self.srcdir, quiet=self.quiet)\n+ self.prefix, src_dir, quiet=self.quiet)\n \n def setup(self):\n \"\"\"Set up the srcdir ready to receive files\"\"\"\n","prefixes":["02/14"]}