{"id":2219767,"url":"http://patchwork.ozlabs.org/api/patches/2219767/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260404101005.5-powerpc-boot-pengpeng@iscas.ac.cn/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260404101005.5-powerpc-boot-pengpeng@iscas.ac.cn>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260404101005.5-powerpc-boot-pengpeng@iscas.ac.cn/","date":"2026-04-03T08:56:36","name":"powerpc/boot: validate compatible entries before comparing them","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"74e921369411c4ee4579dabfd612f598a5d85385","submitter":{"id":93000,"url":"http://patchwork.ozlabs.org/api/people/93000/?format=json","name":"Pengpeng Hou","email":"pengpeng@iscas.ac.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260404101005.5-powerpc-boot-pengpeng@iscas.ac.cn/mbox/","series":[{"id":498708,"url":"http://patchwork.ozlabs.org/api/series/498708/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=498708","date":"2026-04-03T08:56:36","name":"powerpc/boot: validate compatible entries before comparing them","version":1,"mbox":"http://patchwork.ozlabs.org/series/498708/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219767/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219767/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19307-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=159.226.251.25","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=iscas.ac.cn","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=iscas.ac.cn\n (client-ip=159.226.251.25; helo=cstnet.cn;\n envelope-from=pengpeng@iscas.ac.cn; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnq8B1wkZz1yG2\n\tfor ; Sat, 04 Apr 2026 19:51:37 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fnq842pd1z2ygd;\n\tSat, 04 Apr 2026 19:51:32 +1100 (AEDT)","from cstnet.cn (smtp25.cstnet.cn [159.226.251.25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fnq826MQNz2yVB\n\tfor ; Sat, 04 Apr 2026 19:51:28 +1100 (AEDT)","from 0005-powerpc-boot.eml (unknown [111.196.245.197])\n\tby APP-05 (Coremail) with SMTP id zQCowAD3hAgH0dBpKbVzDA--.7742S2;\n\tSat, 04 Apr 2026 16:51:19 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775292692;\n\tcv=none;\n b=l7FVPolLOKdGN2lx76n3nMY18Zs8sc36K84Iop4eGoPzrRB/GjVi3sqZhzkhr8ThC4fxzDYeggnkZuiFdRoO9a7vKh+++mLULfdzPZl3FDprrI4adXUH2juUMLuDPQLwzglj+T8XjWIOFtIen32xp3X55h1WYaxOa97LWenjOEzTB+XrwEuoY0OUdK5Cv0qsdYLkxH5C+Ire3WOdHBhe/pF/TgPVkBqCCn61zO4442TAwkkjJPavR9K4gx1XgZkmQQlfby+v8zJd+Kpn+P88r3g57hhrmq/2u3nZcs7nr5Jbq4f9If740zzeScWurClMiOBKkVJ+Iq5iq8cb8OLSIw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775292692; c=relaxed/relaxed;\n\tbh=1mpD1bDbjcLnXe+o1oUFx3zEgJ5MkrONX/rIQiw//RE=;\n\th=From:Date:Message-ID:To:Cc:Subject;\n b=BdoreYHSh6OH05haGUbjCfDwDYeRkJ6IxqkcWcrgUiGBeG/LyIiE/MyJrmoOF/5OGOsHq7ToDfrofdt3AKOkpeX/4u6VIv/lmUlj5kHBqnNRsStx8n4PytL9OJgtjU7JCEppDAdjaSw9z1nt+7Bdj/CJM5rvpqHD1ci99GaqzPrheAOLez4r5LxNQqwPRbjMALhu2/o2zMER/t4zW++atGtOVJ5+4ptXhxEtNj6RkN2edzVO66BCiDki+EIxaCn6YsF8p3IwURQdciAC71s9S11il+ZrF9p+cVoTkL4OWhQY2DAfJSmzNc5hCU3kKV/EozSoDKEslXHIblP6KTnqcA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=iscas.ac.cn;\n spf=pass (client-ip=159.226.251.25; helo=cstnet.cn;\n envelope-from=pengpeng@iscas.ac.cn;\n receiver=lists.ozlabs.org) smtp.mailfrom=iscas.ac.cn","From":"Pengpeng Hou ","Date":"Fri, 3 Apr 2026 16:56:36 +0800","Message-ID":"<20260404101005.5-powerpc-boot-pengpeng@iscas.ac.cn>","To":"Madhavan Srinivasan ,\n Michael Ellerman ","Cc":"Nicholas Piggin ,\n \"Christophe Leroy (CS GROUP)\" ,\n linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n pengpeng@iscas.ac.cn","Subject":"[PATCH] powerpc/boot: validate compatible entries before comparing\n them","X-CM-TRANSID":"zQCowAD3hAgH0dBpKbVzDA--.7742S2","X-Coremail-Antispam":"1UD129KBjvJXoWruw13CFyDKry7Aw1UKrW7Arb_yoW8JryxpF\n\tZ0yF9Fy3yrWw4UAay3KF1rWFyYvwn2kF4Utw4DW34kArnFqFy0gF1jkF1YvrW8WFySg3yS\n\tvFWrKw10vF4fWaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUvl14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n\trVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK6x804I0_Grv_XF1l8cAvFVAK0II2c7\n\txJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE\n\t2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwV\n\tC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC\n\t0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Jr0_Gr\n\t1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIF\n\txwCY1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJV\n\tW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF\n\t1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6x\n\tIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvE\n\tx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvj\n\tDU0xZFpf9x0JUmjgxUUUUU=","X-Originating-IP":"[111.196.245.197]","X-CM-SenderInfo":"pshqw1xhqjqxpvfd2hldfou0/","X-Spam-Status":"No, score=0.8 required=3.0 tests=DATE_IN_PAST_12_24,\n\tRCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list"},"content":"`dt_is_compatible()` reads a raw `\"compatible\"` property into `prop_buf`\nand then immediately calls `strcmp(buf + pos, compat)` on each string-list\nentry.\n\nIf the current entry is not NUL-terminated within the returned property\nlength, `strcmp()` reads past the end of the local buffer before the\nfollowing `strnlen()` has any chance to reject the malformed property.\n\nValidate the current entry with `strnlen()` first and only compare\nbounded, terminated compatible strings.\n\nSigned-off-by: Pengpeng Hou \n---\n arch/powerpc/boot/devtree.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/powerpc/boot/devtree.c b/arch/powerpc/boot/devtree.c\nindex 58fbcfcc98c9..d93822f61831 100644\n--- a/arch/powerpc/boot/devtree.c\n+++ b/arch/powerpc/boot/devtree.c\n@@ -343,11 +343,16 @@ int dt_is_compatible(void *node, const char *compat)\n \tif (len < 0)\n \t\treturn 0;\n \n-\tfor (pos = 0; pos < len; pos++) {\n+\tfor (pos = 0; pos < len; ) {\n+\t\tint entry_len = strnlen(&buf[pos], len - pos);\n+\n+\t\tif (entry_len == len - pos)\n+\t\t\treturn 0;\n+\n \t\tif (!strcmp(buf + pos, compat))\n \t\t\treturn 1;\n \n-\t\tpos += strnlen(&buf[pos], len - pos);\n+\t\tpos += entry_len + 1;\n \t}\n \n \treturn 0;\n","prefixes":[]}