{"id":2219725,"url":"http://patchwork.ozlabs.org/api/patches/2219725/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260404012002.111873-2-carlos.bilbao@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260404012002.111873-2-carlos.bilbao@kernel.org>","list_archive_url":null,"date":"2026-04-04T01:20:01","name":"[1/2] misc: pci_endpoint_test: validate BAR index in doorbell test","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bb4958c68a3a951e3282b7eef330ef3df3f74786","submitter":{"id":93050,"url":"http://patchwork.ozlabs.org/api/people/93050/?format=json","name":null,"email":"carlos.bilbao@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260404012002.111873-2-carlos.bilbao@kernel.org/mbox/","series":[{"id":498691,"url":"http://patchwork.ozlabs.org/api/series/498691/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=498691","date":"2026-04-04T01:20:00","name":"misc: pci_endpoint_test: doorbell fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/498691/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219725/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219725/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kgS/UBqI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-51857-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"kgS/UBqI\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnd7Z3mKwz1yD3\n\tfor ; Sat, 04 Apr 2026 12:20:26 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 0E4EB300E4AF\n\tfor ; Sat, 4 Apr 2026 01:20:08 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7736223D28C;\n\tSat, 4 Apr 2026 01:20:07 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B8123D7FF;\n\tSat, 4 Apr 2026 01:20:07 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CFCB1C19421;\n\tSat, 4 Apr 2026 01:20:06 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775265607; cv=none;\n b=mufsMFmKRPYJ7YcGXJ/NszVjFM9VUarBHevrZtyLLS7zNPWt6xH/spftLUsoIXnDnNNxabkSrX/UHBlN2JqjeDta8sfBmpPewt+uN3i7W8l9CbWULvvAkIgoRXDzZhkdHVTg37+ItUnHhDjPPdSUc45nn78d5sC7y49Dy+h76iE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775265607; c=relaxed/simple;\n\tbh=ETZOx9K7I20ciJf/L/y9FtbnIEE/Wq01xt8MytYNDZg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=ldYe3Z668qMTlEOO9jDr+KYrljivYHc+25UBekNDEpZm+SDIWaiZxHml1ea0tA0a6t3pr6GwkPNjbxVL9G29epv4CScbkUCfXz55GVs+g7ln7n2zt3eFruuceUN1gdeDFSlUQM0KFv8SxgWrRENx2xqwOYC8D1I1ODUW/0yBEW0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=kgS/UBqI; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775265607;\n\tbh=ETZOx9K7I20ciJf/L/y9FtbnIEE/Wq01xt8MytYNDZg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kgS/UBqI44h1bOI7Qa2G1M7sMhD+fD3e48RoTm48TaOrDKwkcUyiLD5iJTK26a0iP\n\t NignMXiiihYuqt6u57+Zvg7Ul83ea9VJwn9w6ahm1oX1eCVCj0lOC97bpk6rORElYT\n\t Ws7jq1uxj19GDeivuo1LaI+CGheIjhU9eynbEAFds+GlJtYkgYlIfLvlFH79GmFhA1\n\t rFJxDohInZEEzs9RFpSp+U3w5ijYNyku+pIb6EJPVEvtSn94oJc8mSc2t84m1v5TS6\n\t Tp3/yg4qTvGNc19Y4KBAyc/HjE+ulF5T38wsleWYO8NEaLmSlgXyWFl7qxafMbD/N1\n\t UIUQZ20kT1BXg==","From":"carlos.bilbao@kernel.org","To":"mani@kernel.org,\n\tkwilczynski@kernel.org,\n\tkishon@kernel.org","Cc":"arnd@arndb.de,\n\tgregkh@linuxfoundation.org,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tbilbao@vt.edu,\n\tCarlos Bilbao ","Subject":"[PATCH 1/2] misc: pci_endpoint_test: validate BAR index in doorbell\n test","Date":"Fri, 3 Apr 2026 18:20:01 -0700","Message-ID":"<20260404012002.111873-2-carlos.bilbao@kernel.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260404012002.111873-1-carlos.bilbao@kernel.org>","References":"<20260404012002.111873-1-carlos.bilbao@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"From: Carlos Bilbao \n\npci_endpoint_test_doorbell() reads the BAR number directly from an endpoint\ntest register and uses it as an index into test->bar[] without bounds\nchecking. Since the value is a raw u32 from device MMIO, any value is\npossible and if greater than or equal to PCI_STD_NUM_BARS the access goes\nout of bounds.\n\nAdd a bounds check before dereferencing test->bar[bar].\n\nFixes: eefb83790a0d (\"misc: pci_endpoint_test: Add doorbell test case\")\nSigned-off-by: Carlos Bilbao (Lambda) \n---\n drivers/misc/pci_endpoint_test.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c\nindex 74ab5b5b9011..276bed3f1c18 100644\n--- a/drivers/misc/pci_endpoint_test.c\n+++ b/drivers/misc/pci_endpoint_test.c\n@@ -1089,6 +1089,11 @@ static int pci_endpoint_test_doorbell(struct pci_endpoint_test *test)\n \tpci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_STATUS, 0);\n \n \tbar = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_BAR);\n+\tif (bar >= PCI_STD_NUM_BARS) {\n+\t\tdev_err(dev, \"BAR %u reported by endpoint out of range [0, %u]\\n\",\n+\t\t\tbar, PCI_STD_NUM_BARS - 1);\n+\t\treturn -EINVAL;\n+\t}\n \n \twritel(data, test->bar[bar] + addr);\n \n","prefixes":["1/2"]}