{"id":2219619,"url":"http://patchwork.ozlabs.org/api/patches/2219619/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260403153538.11516-1-emil.s.tantilov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403153538.11516-1-emil.s.tantilov@intel.com>","list_archive_url":null,"date":"2026-04-03T15:35:38","name":"[iwl-net] idpf: fix read_dev_clk_lock spinlock init in idpf_ptp_init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ca1d1fd254464bcc9c63d61bf71fbe84c306e150","submitter":{"id":1670,"url":"http://patchwork.ozlabs.org/api/people/1670/?format=json","name":"Emil Tantilov","email":"emil.s.tantilov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260403153538.11516-1-emil.s.tantilov@intel.com/mbox/","series":[{"id":498645,"url":"http://patchwork.ozlabs.org/api/series/498645/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498645","date":"2026-04-03T15:35:38","name":"[iwl-net] idpf: fix read_dev_clk_lock spinlock init in idpf_ptp_init()","version":1,"mbox":"http://patchwork.ozlabs.org/series/498645/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219619/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219619/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=lt2yKAcW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnN8p4JNkz1yCs\n\tfor ; Sat, 04 Apr 2026 02:35:36 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 8D31540A6E;\n\tFri, 3 Apr 2026 15:35:34 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Cj5H-0BO7Afh; Fri, 3 Apr 2026 15:35:33 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 8D9A040A79;\n\tFri, 3 Apr 2026 15:35:33 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 7F6441A9\n for ; Fri, 3 Apr 2026 15:35:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 71552811B8\n for ; Fri, 3 Apr 2026 15:35:32 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id EgvMaGMWcT6T for ;\n Fri, 3 Apr 2026 15:35:31 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 758A18119D\n for ; Fri, 3 Apr 2026 15:35:30 +0000 (UTC)","from fmviesa004.fm.intel.com ([10.60.135.144])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Apr 2026 08:35:30 -0700","from estantil-desk.jf.intel.com ([10.166.241.24])\n by fmviesa004.fm.intel.com with ESMTP; 03 Apr 2026 08:35:29 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8D9A040A79","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 758A18119D"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775230533;\n\tbh=BR/s9kGabTQiY7E2H+81P/E9BH3B3A02t9rJ0TdSczY=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=lt2yKAcWQiY+3T8a13WjkEiiBBhshbH+hLqNk270b2M1ll94XSFv6C5JpNKG27kOC\n\t mWSrRz0qyCWje+/tWHn/Aab7iY+YTtJYx20efA0CARo+ndsl9wqydb07Tnvxrx4JEP\n\t fy/M7qfWPUNHCRcMypWk3FuFBvJYtWu2kKu0dvqQCUksAzUv9gf/SIBQgTESlYVt7E\n\t J8qwpzMVdxTBu/UjaNy6v1K+WPOgMpN4n3YmLvVE7YwhnKx6s9nO+NxDuN8YiYCHp8\n\t gK7aSF3hMDgO6JI3i87FNSpd1drnoXsKTyBDWyD/fxukZtglJqqZ458Gbym/oOUcau\n\t fhnIC2HRezS+A==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=emil.s.tantilov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 758A18119D","X-CSE-ConnectionGUID":["dDzyIYxHQoGGYO1nKwzxoA==","ibUhVm37TqKdk7EgYGyaZQ=="],"X-CSE-MsgGUID":["B+Gm3zd1R82JHPZjr1m0mQ==","ye/U7QWRRIK2zA/nBZh43Q=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11748\"; a=\"87365586\"","E=Sophos;i=\"6.23,158,1770624000\"; d=\"scan'208\";a=\"87365586\"","E=Sophos;i=\"6.23,158,1770624000\"; d=\"scan'208\";a=\"228908233\""],"X-ExtLoop1":"1","From":"Emil Tantilov ","To":"intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com,\n milena.olech@intel.com, jacob.e.keller@intel.com,\n konstantin.ilichev@intel.com","Date":"Fri, 3 Apr 2026 08:35:38 -0700","Message-Id":"<20260403153538.11516-1-emil.s.tantilov@intel.com>","X-Mailer":"git-send-email 2.17.2","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775230531; x=1806766531;\n h=from:to:cc:subject:date:message-id;\n bh=m6upnxiH1P+6zCK7Xqx4QkGQ+RwHOvo5Qald/CwjdMk=;\n b=gRmjZZztl/NMfkJoQ5HzVBEOXRhTtoNG64NDfC7HRhgIBfVSwu23ndQk\n KRibPd5oInXQgia7iOuMkFBr8Jj4ELjtrKV2HjM2WtervF1T1yY/25K8O\n OECRA7CTjKJgX1kCmO/A9TDMTOKh13M+HCJ4FVgQEFf66UqcVIoLnXZyy\n 6vF42ppzKlkPnXK/5eX0HVgahhRgKchttPaQRgV3dJyJGS5xGSdarFqpf\n 8EVYwRdt6pUjfCc87JZeKQqgV0H6wQn7IezDjjsKAAjg9mB0X/SzIC6ay\n D2RZMxwR3XW24FLMddJ3cGt0zb39p0n7EpOZ1hhMN8m8kmPa///DxQz9I\n A==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=gRmjZZzt"],"Subject":"[Intel-wired-lan] [PATCH iwl-net] idpf: fix read_dev_clk_lock\n spinlock init in idpf_ptp_init()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"In idpf_ptp_init(), read_dev_clk_lock is initialized after\nptp_schedule_worker() had already been called (and after\nidpf_ptp_settime64() could reach the lock). The PTP aux worker\nfires immediately upon scheduling and can call into\nidpf_ptp_read_src_clk_reg_direct(), which takes\nspin_lock(&ptp->read_dev_clk_lock) on an uninitialized lock, triggering\nthe lockdep \"non-static key\" warning:\n\n[12973.796587] idpf 0000:83:00.0: Device HW Reset initiated\n[12974.094507] INFO: trying to register non-static key.\n...\n[12974.097208] Call Trace:\n[12974.097213] \n[12974.097218] dump_stack_lvl+0x93/0xe0\n[12974.097234] register_lock_class+0x4c4/0x4e0\n[12974.097249] ? __lock_acquire+0x427/0x2290\n[12974.097259] __lock_acquire+0x98/0x2290\n[12974.097272] lock_acquire+0xc6/0x310\n[12974.097281] ? idpf_ptp_read_src_clk_reg+0xb7/0x150 [idpf]\n[12974.097311] ? lockdep_hardirqs_on_prepare+0xde/0x190\n[12974.097318] ? finish_task_switch.isra.0+0xd2/0x350\n[12974.097330] ? __pfx_ptp_aux_kworker+0x10/0x10 [ptp]\n[12974.097343] _raw_spin_lock+0x30/0x40\n[12974.097353] ? idpf_ptp_read_src_clk_reg+0xb7/0x150 [idpf]\n[12974.097373] idpf_ptp_read_src_clk_reg+0xb7/0x150 [idpf]\n[12974.097391] ? kthread_worker_fn+0x88/0x3d0\n[12974.097404] ? kthread_worker_fn+0x4e/0x3d0\n[12974.097411] idpf_ptp_update_cached_phctime+0x26/0x120 [idpf]\n[12974.097428] ? _raw_spin_unlock_irq+0x28/0x50\n[12974.097436] idpf_ptp_do_aux_work+0x15/0x20 [idpf]\n[12974.097454] ptp_aux_kworker+0x20/0x40 [ptp]\n[12974.097464] kthread_worker_fn+0xd5/0x3d0\n[12974.097474] ? __pfx_kthread_worker_fn+0x10/0x10\n[12974.097482] kthread+0xf4/0x130\n[12974.097489] ? __pfx_kthread+0x10/0x10\n[12974.097498] ret_from_fork+0x32c/0x410\n[12974.097512] ? __pfx_kthread+0x10/0x10\n[12974.097519] ret_from_fork_asm+0x1a/0x30\n[12974.097540] \n\nMove the call to spin_lock_init() up a bit to make sure read_dev_clk_lock\nis not touched before it's been initialized.\n\nFixes: 5cb8805d2366 (\"idpf: negotiate PTP capabilities and get PTP clock\")\nSigned-off-by: Emil Tantilov \nReviewed-by: Madhu Chittim \n---\n drivers/net/ethernet/intel/idpf/idpf_ptp.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/idpf/idpf_ptp.c b/drivers/net/ethernet/intel/idpf/idpf_ptp.c\nindex eec91c4f0a75..4a51d2727547 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_ptp.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_ptp.c\n@@ -952,6 +952,8 @@ int idpf_ptp_init(struct idpf_adapter *adapter)\n \t\tgoto free_ptp;\n \t}\n \n+\tspin_lock_init(&adapter->ptp->read_dev_clk_lock);\n+\n \terr = idpf_ptp_create_clock(adapter);\n \tif (err)\n \t\tgoto free_ptp;\n@@ -977,8 +979,6 @@ int idpf_ptp_init(struct idpf_adapter *adapter)\n \t\t\tgoto remove_clock;\n \t}\n \n-\tspin_lock_init(&adapter->ptp->read_dev_clk_lock);\n-\n \tpci_dbg(adapter->pdev, \"PTP init successful\\n\");\n \n \treturn 0;\n","prefixes":["iwl-net"]}