{"id":2219611,"url":"http://patchwork.ozlabs.org/api/patches/2219611/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/3f54ff54a873a8f8a0cc5f14660703b4025a69e2.1775228029.git.balaton@eik.bme.hu/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<3f54ff54a873a8f8a0cc5f14660703b4025a69e2.1775228029.git.balaton@eik.bme.hu>","list_archive_url":null,"date":"2026-04-03T14:59:28","name":"[2/2] ati-vga: Update mode on CRTC_PITCH change","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ab8c5c0891e157608bdd5362a641622351eea9e3","submitter":{"id":16148,"url":"http://patchwork.ozlabs.org/api/people/16148/?format=json","name":"BALATON Zoltan","email":"balaton@eik.bme.hu"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/3f54ff54a873a8f8a0cc5f14660703b4025a69e2.1775228029.git.balaton@eik.bme.hu/mbox/","series":[{"id":498641,"url":"http://patchwork.ozlabs.org/api/series/498641/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498641","date":"2026-04-03T14:59:27","name":"More ati-vga fixes for 11.0","version":1,"mbox":"http://patchwork.ozlabs.org/series/498641/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219611/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219611/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnMN371Kkz1yDH\n\tfor ; Sat, 04 Apr 2026 02:00:18 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8fzy-0003bC-Sk; Fri, 03 Apr 2026 10:59:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8fzm-0003ZF-47\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 10:59:39 -0400","from zero.eik.bme.hu ([2001:738:2001:2001::2001])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8fzi-0006kl-C2\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 10:59:36 -0400","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id 12BFE596A38;\n Fri, 03 Apr 2026 16:59:31 +0200 (CEST)","from zero.eik.bme.hu ([127.0.0.1])\n by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP\n id Ke2oi-FZ7-vm; Fri, 3 Apr 2026 16:59:28 +0200 (CEST)","by zero.eik.bme.hu (Postfix, from userid 432)\n id 48877596A22; Fri, 03 Apr 2026 16:59:28 +0200 (CEST)"],"X-Virus-Scanned":"amavis at eik.bme.hu","Message-ID":"\n <3f54ff54a873a8f8a0cc5f14660703b4025a69e2.1775228029.git.balaton@eik.bme.hu>","In-Reply-To":"","References":"","From":"BALATON Zoltan ","Subject":"[PATCH 2/2] ati-vga: Update mode on CRTC_PITCH change","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , marcandre.lureau@redhat.com,\n Chad Jablonski ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Peter Maydell ","Date":"Fri, 03 Apr 2026 16:59:28 +0200 (CEST)","Received-SPF":"pass client-ip=2001:738:2001:2001::2001;\n envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When changing line length we need to update display parameters so call\nmode change when changing CRTC_PITCH if the value has changed.\n\nSigned-off-by: BALATON Zoltan \n---\n hw/display/ati.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 3976f5f01c..07c0961b61 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -758,7 +758,11 @@ static void ati_mm_write(void *opaque, hwaddr addr,\n s->regs.crtc_offset_cntl = data; /* FIXME */\n break;\n case CRTC_PITCH:\n- s->regs.crtc_pitch = data & 0x07ff07ff;\n+ data &= 0x07ff07ff;\n+ if (s->regs.crtc_pitch != data) {\n+ s->regs.crtc_pitch = data;\n+ ati_vga_switch_mode(s);\n+ }\n break;\n case 0xf00 ... 0xfff:\n /* read-only copy of PCI config space so ignore writes */\n","prefixes":["2/2"]}