{"id":2219543,"url":"http://patchwork.ozlabs.org/api/patches/2219543/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260403-enetc-v1-1-e42ae28ae3fe@nxp.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403-enetc-v1-1-e42ae28ae3fe@nxp.com>","list_archive_url":null,"date":"2026-04-03T09:41:26","name":"[v1,1/3] net: fsl_enetc: fix the duplex setting on the iMX platform","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e50fccb2085fade80eb2b0df17c0fa06555aa523","submitter":{"id":80695,"url":"http://patchwork.ozlabs.org/api/people/80695/?format=json","name":"Alice Guo (OSS)","email":"alice.guo@oss.nxp.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260403-enetc-v1-1-e42ae28ae3fe@nxp.com/mbox/","series":[{"id":498615,"url":"http://patchwork.ozlabs.org/api/series/498615/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498615","date":"2026-04-03T09:41:25","name":"Enable ENETC on i.MX952 EVK","version":1,"mbox":"http://patchwork.ozlabs.org/series/498615/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219543/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219543/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-NXP1-onmicrosoft-com\n header.b=bBi3KnKD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=oss.nxp.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com\n header.b=\"bBi3KnKD\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=oss.nxp.com","phobos.denx.de;\n spf=pass smtp.mailfrom=alice.guo@oss.nxp.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=oss.nxp.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnG5551QTz1yCt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 22:02:01 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DF21984099;\n\tFri,  3 Apr 2026 13:01:55 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A1B2B8341A; Fri,  3 Apr 2026 13:01:55 +0200 (CEST)","from DU2PR03CU002.outbound.protection.outlook.com\n (mail-northeuropeazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c200::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B45AD84099\n for <u-boot@lists.denx.de>; Fri,  3 Apr 2026 13:01:53 +0200 (CEST)","from PAXPR04MB9644.eurprd04.prod.outlook.com (2603:10a6:102:242::11)\n by AS8PR04MB7766.eurprd04.prod.outlook.com (2603:10a6:20b:2aa::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Fri, 3 Apr\n 2026 11:01:50 +0000","from PAXPR04MB9644.eurprd04.prod.outlook.com\n ([fe80::cf3:c5b0:7a0c:d11b]) by PAXPR04MB9644.eurprd04.prod.outlook.com\n ([fe80::cf3:c5b0:7a0c:d11b%5]) with mapi id 15.20.9769.016; Fri, 3 Apr 2026\n 11:01:50 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,\n T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=gEVYTfZ6jwT9gDwuc78FOBuGJgRwSS/AiV/ge8AEGl9BlMGzzgHnTZXCGY6QJlNSiAn9Y4LeM0t/YUv22DN5mOOT7C7ExaanrublTlXf7UW0gqUmDVTT6FZxmm3uotE52w5jOj3nF4+Wu620xdTJAt2TBnQi1KoFqmNyVZz7AaPvx3UfdDf03kehUn5zadmCqliIJpQy8X8q3qRO/XW5mL32G2fw81eDplEDoQWPdcVsvc+d8pvKuCARo3g69g0TUN2GBoXaUC2N1dkWGOgo7dYA122+qN9TqLoNkReP+qT92O4gb2dl538SZH57ZgOjdUoguXU7/jtpTdLuBeRjxg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ezCyr4hwGoYR/LCj3nke3RjIiYVDQKGw/IK5U+KN4II=;\n b=l6XEmDd6N+3vTlr36AV5FpKetOUXeHKrzrcuulE9kpcr2TnDtX2flVGgIdfsQaNfOpQlwLB73QJ90mO9ES58EqGxiF4VcQj3dybAcqKdD/vAvwHPrjzS726PvGSOJ2k/iybvVHQdWeO2XUCOvdatos1oz/ALDNdENVyLEYj+7jVenOq8gOjuJUvL0CkViQ1jeStA1iRvunXGpowVdewI+363JY+B6EIUch59qRX9R+OlM1Oa/ry+5w02DN4AM073iXZI0hkz/4Z/Iegd+6Ux99pI3zP9Z+rys/XYYOCtG22NXoh5GYZ564exjp+xpT2w57ZwuggryN+ukh/B/LNAHA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;\n dkim=pass header.d=oss.nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n s=selector1-NXP1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ezCyr4hwGoYR/LCj3nke3RjIiYVDQKGw/IK5U+KN4II=;\n b=bBi3KnKDh09X/evlniSeINkvES8yvEVqKwojQtz0HCRE9SgRlTvJ3Yzjs7Jn/u1QPNUnloUbIP6v5wXhaiNkEBqn4MalVcVPj8T8RjZF8KtEwRiUVyA3oLesHSKK33rf+rT/ec5DX4ZbR8hNDeUU/WEPJL/454USSBdDl2OBn+t6m8kiout84i42SkacB/qjQ1/AzfBMnGMvupUGpJMI2fK1kYNaOtb1UbgvFdSCydeJ4DnOglyhbzDdSUJ7GcPLkQCIgebSH5Y2lw1RDmafJK3U2PvDUayOb9ZEBfC4p8dhNOIsx6DmrBMYd34Bz1eaI9Fx2qkskYZI7NFR264+/w==","From":"alice.guo@oss.nxp.com","Date":"Fri, 03 Apr 2026 17:41:26 +0800","Subject":"[PATCH v1 1/3] net: fsl_enetc: fix the duplex setting on the iMX\n platform","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260403-enetc-v1-1-e42ae28ae3fe@nxp.com>","References":"<20260403-enetc-v1-0-e42ae28ae3fe@nxp.com>","In-Reply-To":"<20260403-enetc-v1-0-e42ae28ae3fe@nxp.com>","To":"Marek Vasut <marex@nabladev.com>, Tim Harvey <tharvey@gateworks.com>,\n Ye Li <ye.li@nxp.com>, u-boot@lists.denx.de,\n \"NXP i.MX U-Boot Team\" <uboot-imx@nxp.com>","Cc":"Jerome Forissier <jerome.forissier@arm.com>,\n Tom Rini <trini@konsulko.com>,\n Thomas Schaefer <thomas.schaefer@kontron.com>,\n Michael Walle <mwalle@kernel.org>, Clark Wang <xiaoning.wang@nxp.com>,\n Christian Marangi <ansuelsmth@gmail.com>, Simon Glass <sjg@chromium.org>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,\n Robert Marko <robert.marko@sartura.hr>, Yao Zi <me@ziyao.cc>,\n Heiko Thiery <heiko.thiery@gmail.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>, Peng Fan <peng.fan@nxp.com>,\n Jacky Bai <ping.bai@nxp.com>, Andrew Goodbody <andrew.goodbody@linaro.org>,\n Stefano Babic <sbabic@nabladev.com>, Fabio Estevam <festevam@gmail.com>,\n Alice Guo <alice.guo@nxp.com>","X-Mailer":"b4 0.13.0","X-ClientProxiedBy":"SG2PR03CA0093.apcprd03.prod.outlook.com\n (2603:1096:4:7c::21) To PAXPR04MB9644.eurprd04.prod.outlook.com\n (2603:10a6:102:242::11)","MIME-Version":"1.0","X-MS-Exchange-MessageSentRepresentingType":"1","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PAXPR04MB9644:EE_|AS8PR04MB7766:EE_","X-MS-Office365-Filtering-Correlation-Id":"16f6449a-7e27-43ce-e50d-08de9170685d","X-MS-Exchange-SharedMailbox-RoutingAgent-Processed":"True","X-LD-Processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|19092799006|7416014|376014|52116014|38350700014|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n lqoaOLBs7UZy7xUMIZju5vK/3AN7Xf5MHjBERkBnUIABUWgru0Oe/ive1HV4AwNdopK1wZ25UB8EMtqXBJmwvUi6p0skApoYY01VB1qsG8Wwxrq+MNuPVdxLkMYBe0tXIXgcFHC+f6RLGBrFMC/3yTgTaAyvFISL3fnteGqQERLqSkcb+tvtAitMv12x7PN9YG0YZBTuKFGYvj06WEaDJXFfUnzz2FfLqDITxm43ogZQOwxrSLZbDt62xea33u6qvzBKlqjAb3GGYJybQVkbBSK1Rgs/tC+q1OPQDyv47OkcIHjgMJNUzTwI9mk0AXqFa0CZKzVW6SQGOEX+rEe3Mpb2G7Xn6OJS/6Q1ez2Z5gAmPzUSPXaqBpEpIz6l+qn2bO0j9ksR4x/U2GU+3fjm/aNiAR+Yl245Qn+qE9ptU3bIEX63c/71nf/XZVMn51G1FFINhJONzGR6EDi7PImdCOnkXVTQyPKW4aRcnZiG8+lPN/u5orBOjLoiYZ0J8sWqlR1FBeSuYIRBeBZBsc6CgxdU0yh3JaLzB5NDfs1qQoC+ZJe0H8B5Cay93aMxOQR6JDuH+Af7hM6wXfpkb7YPxOvj1hAa2/KUf3rcBU+9R5wqADui4jYD3p3h7co92jPjUkwLmvzfqQZa9BnTHfC0lvfNzYbcdFRoQeOi0WvW/y+GS7a7vU6fmYBwx+ReimzCZf4SXInVZ5QrfkQ0INjn20sRAkvP2FUaULuR3/xthbTcsA9rEMVH3eAJhT0O5wuksUuYhDkwp0Qw/FKcK/4593BE20U5lXBXvAQqXPAjqPs=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:PAXPR04MB9644.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(19092799006)(7416014)(376014)(52116014)(38350700014)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?+NtZxXiKakRPyluL8zEc8fJWa+l0?=\n\t=?utf-8?q?KLFzn5ayxZVZdhTWQsmkxcUaQkt7rm6Km9ke4As3iVNYLh+jINoACUcJTBVIntmGO?=\n\t=?utf-8?q?czv0BtGVaeTn8ZNSoY85n2jLxyILguoU451jnVIV+5uNT6aHejGUMw3HjRqBjW3yW?=\n\t=?utf-8?q?ZqdBbEDPuld2Knxo7QHSfkRB0BOJWUBgag9rziVbYOVAEWoVHOruwc7wTFe1Xg0Gy?=\n\t=?utf-8?q?P77KhzJnrAT6wK2S4gRmuL8n/O6P1Cu6yRbYIZQsYAFDm34c+rS9b5npNWri1ZUEm?=\n\t=?utf-8?q?Ekn0QyGKnYx6kVqSYUPNSUSmw5ijvsLBYkHuIrc1WQKAmhyw20PlpC2/cNo+RBVqp?=\n\t=?utf-8?q?4Uz5Tu6KEQu7gE7yDfFTMZqBRowD3KXu+vhlH4KIqkajQJkdL4ytJEoAuqbRYAjJw?=\n\t=?utf-8?q?bJ+36qhLjVVSmQrsHUazGvA/dq+dzgXb2++djL2aZdemnchvlpki0pupxqOxP0jrP?=\n\t=?utf-8?q?hmiWItULbDgK6wh2ffFjL78FniCQ4P1SwD93JU2Q6WATO2W2ZRd5pe5gh/Z42kQXC?=\n\t=?utf-8?q?2nk4jdDjc/DcIyK/TRLTlkjradJAWM+Bx6l896NLSlFiX8nZWWIldVZsTINoExFgW?=\n\t=?utf-8?q?BEfkRND0z5nWZPTaiJb6dj/F2RXUDBwgOik1S6jghz/M5X10StLgHyM9ett4oqb2g?=\n\t=?utf-8?q?lhZVMq+KegQtmW2YZ+aaErrupOnn/uiRra5XRB0WBkaBuWMU7PpyAWQXAsTVvdT3d?=\n\t=?utf-8?q?qzhN2XZqR2XK4RUkXaL3nfRvjCEoe/Tby2le1XsiFJvnrB8cvU5R3pcLj3KZLwj5d?=\n\t=?utf-8?q?76wI4t9qI71nyNoL4I9C1WNj+525iCWv6rFy6z1Ng5IECCwBDqG7buvN6SDbzIB8X?=\n\t=?utf-8?q?bELdFlydKnRp08S2hbKtgreoBR4CdLiv1JMOf56kmuQ6rQo+GKltio9ACVCL7ONYW?=\n\t=?utf-8?q?Nj2f4fKh5Erp4REkoObToxrwFvLu7bJ1V5R2/zdeHeL91JmeDXyliJm3Wd59WM5bw?=\n\t=?utf-8?q?rYRZy7tOGtalSj5rwSwPG8VO5mat3lU06mOE2vjW0U+YQo0nEVvS63tjEGIoVu6Yy?=\n\t=?utf-8?q?CvmvNQpSZjtwtFnGfSjfnqErRUYtlydZkrW1HfSv2H8Vdc/S9e/z9MuwE2me7IMge?=\n\t=?utf-8?q?BBK6s07m8VIhXpX/LyqymfvyfqkgW3daZv9DDYMuAVJZBiq6Xdp/UH2Lfx12n2WTS?=\n\t=?utf-8?q?uTEM+EqN/eM0Vto0YZMuUtbcOzjvMuFCpO+zybfTWrHlubCgKUBn9/9OxDo6nEMFT?=\n\t=?utf-8?q?Nvc5XzsST8XSAjJBdA42GGc37ahE1eeFnG5RYi8LvxhOY4THDXRH2bpqpge2Uoch1?=\n\t=?utf-8?q?LQumyIC4Mgc1BPiIMzJlB1zIDEpjxi4SWQbL3vwzN9XkpFkv+dI2eFey5ImUIWeYM?=\n\t=?utf-8?q?thOIwrQj0vKWEipPPazYNiG8KOYkvNnpcIGyhHNZRxcpZyW4sD3uiNvzL5KfYonRy?=\n\t=?utf-8?q?cdj+XLlRjFAT/du/0FdxhSe641jqzg0NXOeiaJsUQ45CgmPV/JFTu/VPY/LHOzvMy?=\n\t=?utf-8?q?Mh16gZIeyRRMLmmqf1Yl9cZASfdF5EYPSJcdIPGhogxPv5LDNalxFzy5JV0+4qkcg?=\n\t=?utf-8?q?jkyBNIeFdyeUj3IAWI9heaqJxw8odXF8SiUbJ/iwl/NDKWrT2ReFHKjmUsZD4qQQK?=\n\t=?utf-8?q?JQKEg9uu+iwlF+L/Tm9KYTiOtLgpG4/24d5wGMZqMEvAbBUesHizaNpA03qSc9HE8?=\n\t=?utf-8?q?Z1Dy/r3ohVocO+MYn5sG8gGllYH5XfhA=3D=3D?=","X-OriginatorOrg":"oss.nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 16f6449a-7e27-43ce-e50d-08de9170685d","X-MS-Exchange-CrossTenant-AuthSource":"PAXPR04MB9644.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"03 Apr 2026 11:01:50.8297 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n fqUGzXvutdCyoiMGK3NRmIfujUTsMvh5uTKWkkQgppfGh6XRn5+Sm3hUxnzD+Wj9egNNXNmeM5C0zZSYrHPvNg==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS8PR04MB7766","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Clark Wang <xiaoning.wang@nxp.com>\n\nThe iMX and LS platforms use different bits in the same register to\nset duplex, but their logics are opposite.\nThe current settings will result in unexpected configurations in\nRGMII mode.\n\nFixes: e6df2f5e22c6 (\"net: fsl_enetc: Update enetc driver to support i.MX95\")\nSigned-off-by: Clark Wang <xiaoning.wang@nxp.com>\nSigned-off-by: Alice Guo <alice.guo@nxp.com>\n---\n drivers/net/fsl_enetc.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/net/fsl_enetc.c b/drivers/net/fsl_enetc.c\nindex a4ba27904bc..766aea035d3 100644\n--- a/drivers/net/fsl_enetc.c\n+++ b/drivers/net/fsl_enetc.c\n@@ -17,6 +17,7 @@\n #include <asm/io.h>\n #include <pci.h>\n #include <miiphy.h>\n+#include <linux/bitfield.h>\n #include <linux/bug.h>\n #include <linux/delay.h>\n #include <linux/build_bug.h>\n@@ -388,7 +389,7 @@ static int enetc_init_sgmii(struct udevice *dev)\n /* set up MAC for RGMII */\n static void enetc_init_rgmii(struct udevice *dev, struct phy_device *phydev)\n {\n-\tu32 old_val, val, dpx = 0;\n+\tu32 old_val, val = 0;\n \n \told_val = val = enetc_read_mac_port(dev, ENETC_PM_IF_MODE);\n \n@@ -408,15 +409,14 @@ static void enetc_init_rgmii(struct udevice *dev, struct phy_device *phydev)\n \t\tval |= ENETC_PM_IFM_SSP_10;\n \t}\n \n-\tif (enetc_is_imx95(dev))\n-\t\tdpx = ENETC_PM_IFM_FULL_DPX_IMX;\n+\tif  (enetc_is_imx95(dev))\n+\t\tval = u32_replace_bits(val,\n+\t\t\t\t       phydev->duplex == DUPLEX_FULL ? 0 : 1,\n+\t\t\t\t       ENETC_PM_IFM_FULL_DPX_IMX);\n \telse if (enetc_is_ls1028a(dev))\n-\t\tdpx = ENETC_PM_IFM_FULL_DPX_LS;\n-\n-\tif (phydev->duplex == DUPLEX_FULL)\n-\t\tval |= dpx;\n-\telse\n-\t\tval &= ~dpx;\n+\t\tval = u32_replace_bits(val,\n+\t\t\t\t       phydev->duplex == DUPLEX_FULL ? 1 : 0,\n+\t\t\t\t       ENETC_PM_IFM_FULL_DPX_LS);\n \n \tif (val == old_val)\n \t\treturn;\n","prefixes":["v1","1/3"]}