{"id":2219534,"url":"http://patchwork.ozlabs.org/api/patches/2219534/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403104327.1163942-5-mjt@tls.msk.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403104327.1163942-5-mjt@tls.msk.ru>","list_archive_url":null,"date":"2026-04-03T10:43:24","name":"[for-11.0,4/6] qom: Declare compat properties API in 'qom/compat-properties.h'","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"534ab4fc2a783ab519a6101228ba82e461b03007","submitter":{"id":183,"url":"http://patchwork.ozlabs.org/api/people/183/?format=json","name":"Michael Tokarev","email":"mjt@tls.msk.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403104327.1163942-5-mjt@tls.msk.ru/mbox/","series":[{"id":498613,"url":"http://patchwork.ozlabs.org/api/series/498613/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498613","date":"2026-04-03T10:43:24","name":"allow building tools and qemu-guest-agent on 32bit hosts","version":1,"mbox":"http://patchwork.ozlabs.org/series/498613/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219534/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219534/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=tls.msk.ru header.i=@tls.msk.ru header.a=rsa-sha256\n header.s=202602 header.b=rqdgxJPy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnFhZ2HDgz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 21:44:14 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8c09-00040W-Sc; Fri, 03 Apr 2026 06:43:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>) id 1w8c06-0003ze-Qx\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 06:43:43 -0400","from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>) id 1w8c04-0005Zm-Oc\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 06:43:42 -0400","from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id 25B2119A63E;\n Fri, 03 Apr 2026 13:42:51 +0300 (MSK)","from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by tsrv.corpit.ru (Postfix) with ESMTP id D8C7738DB6E;\n Fri, 03 Apr 2026 13:43:28 +0300 (MSK)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602;\n t=1775212971; bh=gq60/YFiZnFG3mBQOq32B3RaPpFjLtZ3CVqIC3UfUdg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=rqdgxJPyRAEr3wE0PfNtvcFiDQu3Fu7RsALFptLWK9STdfZEWyD3p1q0BysEQFrgW\n iZ57Ui0KaCd0Jae/M1qmlGOe5g1XjmoN0DGDTlRe1GkHFA/jU85o7M8blwm3ZbOmYW\n xRxhcciWjToW2hNEx64KfvlhZldu4tHrhszJpMwQjp+dix5uA7AnVxyQfG3LP6YsDT\n IFld1hqr7p0j1iJk9u+myizY1KpTk1z1dcxy7dl0WruGvzsge2jt9sCeu0x85hfbwT\n POcuF/F+TOae9fYVnj9jODTmMEJu8tiEYreWyZH/cXQsr+cmIQvmzPDDqoiCcB1h8v\n 74QlvM6hTcXKQ==","From":"Michael Tokarev <mjt@tls.msk.ru>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Michael Tokarev <mjt@tls.msk.ru>","Subject":"[PATCH for-11.0 4/6] qom: Declare compat properties API in\n 'qom/compat-properties.h'","Date":"Fri,  3 Apr 2026 13:43:24 +0300","Message-ID":"<20260403104327.1163942-5-mjt@tls.msk.ru>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260403104327.1163942-1-mjt@tls.msk.ru>","References":"<20260403104327.1163942-1-mjt@tls.msk.ru>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Philippe Mathieu-Daudé <philmd@linaro.org>\n\nWhile most of QEMU files use the QOM concept, few of them\nuse the compatibility properties API (mostly use in system\nemulation). Move its prototype to a new \"qom/compat-properties.h\"\nheader, keeping \"qom/object.h\" for generic QOM.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Michael Tokarev <mjt@tls.msk.ru>\n---\n accel/accel-system.c            | 1 +\n backends/hostmem.c              | 1 +\n hw/core/machine.c               | 1 +\n hw/core/qdev-properties.c       | 1 +\n hw/core/qdev.c                  | 1 +\n hw/i386/pc_q35.c                | 1 +\n include/qom/compat-properties.h | 8 ++++++++\n include/qom/object.h            | 8 --------\n system/rtc.c                    | 1 +\n system/vl.c                     | 1 +\n target/i386/sev.c               | 1 +\n ui/vdagent.c                    | 1 +\n 12 files changed, 18 insertions(+), 8 deletions(-)","diff":"diff --git a/accel/accel-system.c b/accel/accel-system.c\nindex 150af05bf5..9176665202 100644\n--- a/accel/accel-system.c\n+++ b/accel/accel-system.c\n@@ -25,6 +25,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"qemu/accel.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qapi/qapi-commands-accelerator.h\"\n #include \"monitor/monitor.h\"\n #include \"hw/core/boards.h\"\ndiff --git a/backends/hostmem.c b/backends/hostmem.c\nindex 15d4365b69..cd2085fb3c 100644\n--- a/backends/hostmem.c\n+++ b/backends/hostmem.c\n@@ -18,6 +18,7 @@\n #include \"qapi/qapi-builtin-visit.h\"\n #include \"qapi/visitor.h\"\n #include \"qemu/config-file.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object_interfaces.h\"\n #include \"qemu/mmap-alloc.h\"\n #include \"qemu/madvise.h\"\ndiff --git a/hw/core/machine.c b/hw/core/machine.c\nindex 0aa77a57e9..cba5031094 100644\n--- a/hw/core/machine.c\n+++ b/hw/core/machine.c\n@@ -21,6 +21,7 @@\n #include \"qapi/qapi-visit-machine.h\"\n #include \"qapi/qapi-commands-machine.h\"\n #include \"qemu/madvise.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object_interfaces.h\"\n #include \"system/cpus.h\"\n #include \"system/system.h\"\ndiff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c\nindex ba8461e9a4..73539c727b 100644\n--- a/hw/core/qdev-properties.c\n+++ b/hw/core/qdev-properties.c\n@@ -10,6 +10,7 @@\n #include \"qemu/units.h\"\n #include \"qemu/cutils.h\"\n #include \"qdev-prop-internal.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/qom-qobject.h\"\n \n void qdev_prop_set_after_realize(DeviceState *dev, const char *name,\ndiff --git a/hw/core/qdev.c b/hw/core/qdev.c\nindex e48616b2c6..b36101f3a7 100644\n--- a/hw/core/qdev.c\n+++ b/hw/core/qdev.c\n@@ -32,6 +32,7 @@\n #include \"qapi/visitor.h\"\n #include \"qemu/error-report.h\"\n #include \"qemu/option.h\"\n+#include \"qom/compat-properties.h\"\n #include \"hw/core/irq.h\"\n #include \"hw/core/qdev-properties.h\"\n #include \"hw/core/boards.h\"\ndiff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c\nindex cb23322f5a..6a0967ecd1 100644\n--- a/hw/i386/pc_q35.c\n+++ b/hw/i386/pc_q35.c\n@@ -56,6 +56,7 @@\n #include \"hw/usb/hcd-uhci.h\"\n #include \"qapi/error.h\"\n #include \"qemu/error-report.h\"\n+#include \"qom/compat-properties.h\"\n #include \"system/numa.h\"\n #include \"hw/hyperv/vmbus-bridge.h\"\n #include \"hw/mem/nvdimm.h\"\ndiff --git a/include/qom/compat-properties.h b/include/qom/compat-properties.h\nindex 6e44aabc26..90f8320adf 100644\n--- a/include/qom/compat-properties.h\n+++ b/include/qom/compat-properties.h\n@@ -29,4 +29,12 @@ typedef struct GlobalProperty {\n     bool optional;\n } GlobalProperty;\n \n+void object_set_machine_compat_props(GPtrArray *compat_props);\n+void object_set_accelerator_compat_props(GPtrArray *compat_props);\n+void object_register_sugar_prop(const char *driver, const char *prop,\n+                                const char *value, bool optional);\n+void object_apply_compat_props(Object *obj);\n+bool object_apply_global_props(Object *obj, const GPtrArray *props,\n+                               Error **errp);\n+\n #endif\ndiff --git a/include/qom/object.h b/include/qom/object.h\nindex 26df6137b9..510885218b 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -700,14 +700,6 @@ Object *object_new_with_propv(const char *typename,\n                               Error **errp,\n                               va_list vargs);\n \n-bool object_apply_global_props(Object *obj, const GPtrArray *props,\n-                               Error **errp);\n-void object_set_machine_compat_props(GPtrArray *compat_props);\n-void object_set_accelerator_compat_props(GPtrArray *compat_props);\n-void object_register_sugar_prop(const char *driver, const char *prop,\n-                                const char *value, bool optional);\n-void object_apply_compat_props(Object *obj);\n-\n /**\n  * object_set_props:\n  * @obj: the object instance to set properties on\ndiff --git a/system/rtc.c b/system/rtc.c\nindex 56951288c4..f13dd392a7 100644\n--- a/system/rtc.c\n+++ b/system/rtc.c\n@@ -28,6 +28,7 @@\n #include \"qemu/error-report.h\"\n #include \"qemu/option.h\"\n #include \"qemu/timer.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object.h\"\n #include \"system/replay.h\"\n #include \"system/system.h\"\ndiff --git a/system/vl.c b/system/vl.c\nindex 246623b319..0e1fc217b4 100644\n--- a/system/vl.c\n+++ b/system/vl.c\n@@ -119,6 +119,7 @@\n #include \"qapi/string-input-visitor.h\"\n #include \"qapi/opts-visitor.h\"\n #include \"qapi/clone-visitor.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object_interfaces.h\"\n #include \"semihosting/semihost.h\"\n #include \"crypto/init.h\"\ndiff --git a/target/i386/sev.c b/target/i386/sev.c\nindex 9dde972c11..261b6aaa37 100644\n--- a/target/i386/sev.c\n+++ b/target/i386/sev.c\n@@ -36,6 +36,7 @@\n #include \"system/reset.h\"\n #include \"trace.h\"\n #include \"migration/blocker.h\"\n+#include \"qom/compat-properties.h\"\n #include \"qom/object.h\"\n #include \"monitor/monitor.h\"\n #include \"monitor/hmp.h\"\ndiff --git a/ui/vdagent.c b/ui/vdagent.c\nindex bb0c4aa14c..bb55cbefc9 100644\n--- a/ui/vdagent.c\n+++ b/ui/vdagent.c\n@@ -5,6 +5,7 @@\n #include \"qemu/error-report.h\"\n #include \"qemu/option.h\"\n #include \"qemu/units.h\"\n+#include \"qom/compat-properties.h\"\n #include \"hw/core/qdev.h\"\n #include \"hw/core/qdev-properties.h\"\n #include \"migration/blocker.h\"\n","prefixes":["for-11.0","4/6"]}