{"id":2219529,"url":"http://patchwork.ozlabs.org/api/patches/2219529/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403091621.88914-1-guobin@linux.alibaba.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403091621.88914-1-guobin@linux.alibaba.com>","list_archive_url":null,"date":"2026-04-03T09:16:21","name":"hw/virtio/vhost: simplify ring mapping verification with loop","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2cb4fa587390f059afdf8a029877cacabc6f0f58","submitter":{"id":91693,"url":"http://patchwork.ozlabs.org/api/people/91693/?format=json","name":"Bin Guo","email":"guobin@linux.alibaba.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403091621.88914-1-guobin@linux.alibaba.com/mbox/","series":[{"id":498608,"url":"http://patchwork.ozlabs.org/api/series/498608/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498608","date":"2026-04-03T09:16:21","name":"hw/virtio/vhost: simplify ring mapping verification with loop","version":1,"mbox":"http://patchwork.ozlabs.org/series/498608/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219529/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219529/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com\n header.a=rsa-sha256 header.s=default header.b=Zb91/yBB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnClz4w3Jz1yCt\n\tfor ; Fri, 03 Apr 2026 20:17:03 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8ae3-0005LW-KU; Fri, 03 Apr 2026 05:16:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8ae0-0005Kc-Nb\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 05:16:48 -0400","from out30-133.freemail.mail.aliyun.com ([115.124.30.133])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8ady-0005QE-Jo\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 05:16:48 -0400","from localhost(mailfrom:guobin@linux.alibaba.com\n fp:SMTPD_---0X0JsEZX_1775207782 cluster:ay36) by smtp.aliyun-inc.com;\n Fri, 03 Apr 2026 17:16:29 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linux.alibaba.com; s=default;\n t=1775207790; h=From:To:Subject:Date:Message-ID:MIME-Version;\n bh=5hm8I+JbM6PGG1mMVTB6bqbuy7AeKFvxXupmSTgLp/4=;\n b=Zb91/yBBdFcoTbHF+qr2O0RjWiMCThGYZmPVjlipWjvaMzHzZK7NiKf5LKbUsLZcCBD5SrkWf+fvFO6dFnYkxumOAJjut3BJwB6D13iCAJ1rWwx4r8znqBuTlSAAld2sCrXR8yCfiA2QShFLY7r44esZHoDwygpVKGKx31y3xwg=","X-Alimail-AntiSpam":"AC=PASS; BC=-1|-1; BR=01201311R101e4; CH=green;\n DM=||false|;\n DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam011083073210;\n MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=4; SR=0;\n TI=SMTPD_---0X0JsEZX_1775207782;","From":"Bin Guo ","To":"qemu-devel@nongnu.org","Cc":"mst@redhat.com,\n\trichard.henderson@linaro.org,\n\tphilmd@linaro.org","Subject":"[PATCH] hw/virtio/vhost: simplify ring mapping verification with loop","Date":"Fri, 3 Apr 2026 17:16:21 +0800","Message-ID":"<20260403091621.88914-1-guobin@linux.alibaba.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=115.124.30.133;\n envelope-from=guobin@linux.alibaba.com;\n helo=out30-133.freemail.mail.aliyun.com","X-Spam_score_int":"-174","X-Spam_score":"-17.5","X-Spam_bar":"-----------------","X-Spam_report":"(-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5,\n USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Replace the three nearly-identical vhost_verify_ring_part_mapping() calls\nwith a simple loop over arrays. This eliminates code duplication while\nmaintaining identical behavior and error reporting.\n\nSigned-off-by: Bin Guo \n---\n hw/virtio/vhost.c | 34 ++++++++++++----------------------\n 1 file changed, 12 insertions(+), 22 deletions(-)","diff":"diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex b9dc4ed13b..7b5bfc86e6 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -525,31 +525,21 @@ static int vhost_verify_ring_mappings(struct vhost_dev *dev,\n continue;\n }\n \n- j = 0;\n- r = vhost_verify_ring_part_mapping(\n- vq->desc, vq->desc_phys, vq->desc_size,\n- reg_hva, reg_gpa, reg_size);\n- if (r) {\n- break;\n- }\n-\n- j++;\n- r = vhost_verify_ring_part_mapping(\n- vq->avail, vq->avail_phys, vq->avail_size,\n- reg_hva, reg_gpa, reg_size);\n- if (r) {\n- break;\n- }\n-\n- j++;\n- r = vhost_verify_ring_part_mapping(\n- vq->used, vq->used_phys, vq->used_size,\n- reg_hva, reg_gpa, reg_size);\n- if (r) {\n- break;\n+ void *ring_addrs[] = {vq->desc, vq->avail, vq->used};\n+ uint64_t ring_phys[] = {vq->desc_phys, vq->avail_phys, vq->used_phys};\n+ uint64_t ring_sizes[] = {vq->desc_size, vq->avail_size, vq->used_size};\n+\n+ for (j = 0; j < 3; j++) {\n+ r = vhost_verify_ring_part_mapping(\n+ ring_addrs[j], ring_phys[j], ring_sizes[j],\n+ reg_hva, reg_gpa, reg_size);\n+ if (r) {\n+ goto out;\n+ }\n }\n }\n \n+out:\n if (r == -ENOMEM) {\n error_report(\"Unable to map %s for ring %d\", part_name[j], i);\n } else if (r == -EBUSY) {\n","prefixes":[]}