{"id":2219509,"url":"http://patchwork.ozlabs.org/api/patches/2219509/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260403073251.1051533-2-paul.henrys_ext@softathome.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403073251.1051533-2-paul.henrys_ext@softathome.com>","list_archive_url":null,"date":"2026-04-03T07:32:50","name":"[v3,2/3] binman: Generate preload header and sign data only once","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0fddace1f7bc395e5ff1c538706e31fe793c0135","submitter":{"id":83555,"url":"http://patchwork.ozlabs.org/api/people/83555/?format=json","name":"Paul HENRYS","email":"paul.henrys_ext@softathome.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260403073251.1051533-2-paul.henrys_ext@softathome.com/mbox/","series":[{"id":498597,"url":"http://patchwork.ozlabs.org/api/series/498597/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=498597","date":"2026-04-03T07:32:49","name":"[v3,1/3] tools: binman: Test signing an encrypted FIT with a preload header","version":3,"mbox":"http://patchwork.ozlabs.org/series/498597/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219509/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219509/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=XX3+/7L8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"XX3+/7L8\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=paul.henrys_ext@softathome.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn9T661p3z1xtJ\n\tfor ; Fri, 03 Apr 2026 18:34:02 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 19D4983DC9;\n\tFri, 3 Apr 2026 09:33:49 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 16131840F1; Fri, 3 Apr 2026 09:33:48 +0200 (CEST)","from PA5P264CU001.outbound.protection.outlook.com\n (mail-francecentralazlp170100000.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 291648382A\n for ;\n Fri, 3 Apr 2026 09:33:46 +0200 (CEST)","from PR1P264CA0146.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:346::11)\n by MR1PPFCEF4AF3E0.FRAP264.PROD.OUTLOOK.COM (2603:10a6:508:1::2d2)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Fri, 3 Apr\n 2026 07:33:37 +0000","from PA3PEPF000089B9.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:346:cafe::35) by PR1P264CA0146.outlook.office365.com\n (2603:10a6:102:346::11) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.21 via Frontend Transport; Fri,\n 3 Apr 2026 07:33:37 +0000","from proxy.softathome.com (149.6.166.170) by\n PA3PEPF000089B9.mail.protection.outlook.com (10.167.242.21) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.17\n via Frontend Transport; Fri, 3 Apr 2026 07:33:36 +0000","from sah2lpt245.. (unknown [192.168.72.220])\n by proxy.softathome.com (Postfix) with ESMTPSA id 80CA61FFF4;\n Fri, 3 Apr 2026 09:33:36 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,\n SUSPICIOUS_RECIPS autolearn=no autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=hv5x9ir3tPf/EiW5MWgML/MT/WQ1t6pCZ4jQ5ToZlwMFnffHdkmssXVbdSRcT+LDSrV7pSeAnZnCzJXaKqR/aBBtEgh0lhH/BzB+MIsQ/GfD/vlmV+NY9EZbwX1ECdfVUWqusHygQUf4mT1Ba8H7mtdu652DxDGwNCZzjOEvVPGwNpn84oxtREVmFwLITmtrB5HIzD6sZTCLcaYp1jRYcSkB0P9GMJ6k7a3OaaDod0muER+Ga0vG9+EA8bFtaRT7eSau6XAOGCo5GT+4M1GwUri2KZSxNa/SxABv586oZzLPK3Wtf6KrRGOxbi5yOjFNWk9UqJlC1/dlsmw7JbwUag==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=XU7MX61vm2OOw8WWJoa7e2PbQ/b8EeakMPe3VZayGSA=;\n b=rV1cdLb+XOUfNaPIZOHariwCTqXBPZjEvC46FQs4PCUc63EvuGAfHYzEL/z23yevEVBeILeJuSIVYUJ64orNAGaP0bvsWrYvJ36NnFUhhoSqvL0EjpkPoCUJQWKTxgsZWAPBWKmkD3Pa2GqieO+C1YS+vRg0ZWfGCDmrtabNxwmPcXuHGZI4+kDCgKFcotoYS5wfhdx4as2/qpmVgg5qTNJ4QySyHug3Eqc1RJoBsY9FwYwhIAcXrURkbphKxsakJbKX78ie52hO+WLepcvNcwalPxyJVLib0fAk2VZUJT3/KACH1ZsCO6Nkm48prZalf7B/QT8YF0J+NGEUGJMc3w==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=chromium.org smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XU7MX61vm2OOw8WWJoa7e2PbQ/b8EeakMPe3VZayGSA=;\n b=XX3+/7L8QsZY/Q3Yww/Rywukrl2jvYGIhy0PPVGhgx5A8vDuO+n3JTgy7dtjgYNvLgCHTnlIhluI/lbTQduw4KGsIc5vnNYVNy7OHXTFWB4P+c/xQNUQvNQYbdf0Fy7EZJUJpeut6wWyBn/QhZGZTLny+vM5XPvUwDhejh5EvDDOQXOuZ6FNHEQA8lvU4u9LX9lwXcmXezz1+63J4RTuUph09rTjUApWfUx9EnIjFwcp/un8h0HAnn70OvFI2dig2tF61EU2/K1GbDtfa4CN4B0thh6gZDBBPM4w0RR6MXNnHvHAuROsMrcFmq0Ytd4ePLW89ww1Vx0hfe49w0bU8g==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;","Received-SPF":"Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C","From":"Paul HENRYS ","To":"u-boot+nodisclaimer@lists.denx.de","Cc":"sjg+nodisclaimer@chromium.org, trini+nodisclaimer@konsulko.com,\n alpernebiyasak+nodisclaimer@gmail.com,\n philippe.reynes+nodisclaimer@softathome.com,\n Paul HENRYS ","Subject":"[PATCH v3 2/3] binman: Generate preload header and sign data only\n once","Date":"Fri, 3 Apr 2026 09:32:50 +0200","Message-ID":"<20260403073251.1051533-2-paul.henrys_ext@softathome.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260403073251.1051533-1-paul.henrys_ext@softathome.com>","References":"<20260402192431.2421155-1-yan.wang@softathome.com>\n <20260403073251.1051533-1-paul.henrys_ext@softathome.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PA3PEPF000089B9:EE_|MR1PPFCEF4AF3E0:EE_","Content-Type":"text/plain","X-MS-Office365-Filtering-Correlation-Id":"08abcf58-1efe-4bed-0d50-08de9153518a","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|36860700016|82310400026|1800799024|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n UYIZ7pImr9ZjyMABuLgCwehRBoBp2ajrgrMfxHrlVs1bcYvEfqnK46Ma4HXbEXxJmaw4VNZAtKqoGgVdm6P6zx+EhvQQqPOYaob+7T1qp2rQKvkZfgSTYBgvU1K3P5dLsoaT6Gw44f1hxjPNKJ/XDhg7SLcPjqp2myIsm9NND0Z/RNaTnY9TE4hdj2GD/tbkYf6+p6XhTsnqrd0JdtcmVTdmq/AyRX5LDHP/FMFRkvgEoREhrQchNaZdz0LOayw9jIpT9R7eT1AbQRtW4H/fzRlocXbdgwK4Zrvc8lwxoDafOZPmpIicNpiu+Vl26CsMKMwpZpGaK6+yhiLiiOhHi1lfIYtV4U0QEq0ejBs3EjWVRqWWge+Ag1pte3XVvcv89pDFoW/gHXe89SOxK1qOt4859fXFptezrl4rVB7SU4s9CjFZud8GjSs9qbnyoeEBsU44wyeRrn8lOUdjVTLFZ96lKSBC6FTxYBXSDlp0ZM8M0R8HrNd/tuk6+Qz9gnaT4iosfhMMXzm+m62MvDM5Xt28yhHNDS6R1ro2dcD4OmLxCibg0AVU4uJ0aBG2TPoSZGVkfMFH5t7PUIxHBCpxazYd4taxJ8IkLzyk4I5y9JfDwqMV0R33yLLm3ahEtn3LbCUXBunRB2GyzjbaRKLjmFWfFwVkTn/94y1L8eJ0EabAf5K6Z+2hPY/E5d1zmes3O5c7rMlyTMHuekcbS7hW4Q+MlVWPrI8c0bTEqVjmiJaJKXHmHxKbvljfL7IuXzoF+yV+cEWxiucC+RBbayabXQ==","X-Forefront-Antispam-Report":"CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(376014)(36860700016)(82310400026)(1800799024)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n 0wAKxR4jfqPuu4uO3KMrnm34sOxzjy8j3whcHxKLuByigY/afjWpQlSOQ/pARMV2bKl+IDffcp+4ZOYFiS1z6Av2/6c49yb0DkpxwRiyod2Aqc2EtGapNpp7wsAO8yXNYx3xxzY6I+R0CIsdhLXbhi2jBAdcJOV8BRJjpwKksNqIwWrQzhPqQUcgY1NmGGQpQLZFkCqcs3GvGysWhgHvNKDhSS2Ltfq22eHPfSIPT8fGqwZ8+fUeh11dOdFfbMqjAfP7CFeWlXtH/6YlvMmH2eO6AqDzLMDFtvp7TMSLPscdI4UX2bYNWXAmsb0WuUo7ND36qTcm8+qOqqnMRTuytgq2b/wSun5BtIKZrKO3OO4rK1oSZdzdleTir/EK4CJgTW7gukNoGhlmqaH2SrAB8NYu6mFisqlFHtqwRIuFC2wr1J+DgQu2H6LxLZZ5XNi4","X-OriginatorOrg":"softathome.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"03 Apr 2026 07:33:36.8934 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 08abcf58-1efe-4bed-0d50-08de9153518a","X-MS-Exchange-CrossTenant-Id":"aa10e044-e405-4c10-8353-36b4d0cce511","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]","X-MS-Exchange-CrossTenant-AuthSource":"PA3PEPF000089B9.FRAP264.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MR1PPFCEF4AF3E0","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"To optimize preload generation, generate the header and signatures only\nafter all data has been collected. This avoids signing the data multiple\ntimes.\n\nSince header_size is known upfront (from __init__), set the preload\nheader size in `ObtainContents()` to avoid an extra packing pass when\nProcessContentsUpdate() detects the size changed from 0 to header_size.\n\nThis reduces unnecessary repacking and signing operations.\n\nSigned-off-by: Paul HENRYS \n---\nChanges for v3:\n- Rebase against 'next' branch\n\n tools/binman/etype/pre_load.py | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/tools/binman/etype/pre_load.py b/tools/binman/etype/pre_load.py\nindex 00f1a896767..34a7bc1b985 100644\n--- a/tools/binman/etype/pre_load.py\n+++ b/tools/binman/etype/pre_load.py\n@@ -152,14 +152,14 @@ class Entry_pre_load(Entry_collection):\n return data + pad\n \n def ObtainContents(self):\n- \"\"\"Obtain a placeholder for the header contents\"\"\"\n- # wait that the image is available\n- self.image = self.GetContents(False)\n- if self.image is None:\n- return False\n- self.SetContents(self._CreateHeader())\n+ \"\"\"Only set the known size of the preload header. The data will be\n+ generated later on in ProcessContents() when the data from every entries\n+ can be retrieved.\n+ \"\"\"\n+ self.contents_size = self.header_size\n return True\n \n def ProcessContents(self):\n+ self.image = self.GetContents(True)\n data = self._CreateHeader()\n return self.ProcessContentsUpdate(data)\n","prefixes":["v3","2/3"]}