{"id":2219500,"url":"http://patchwork.ozlabs.org/api/patches/2219500/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260403054029.3789616-11-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403054029.3789616-11-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-04-03T05:40:28","name":"[iwl-net,10/10] ice: allow setting min_tx_rate to 0 to resolve VF bandwidth oversubscription","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c376efaf022e03e5d984f973501002347db9b8a7","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260403054029.3789616-11-aleksandr.loktionov@intel.com/mbox/","series":[{"id":498590,"url":"http://patchwork.ozlabs.org/api/series/498590/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498590","date":"2026-04-03T05:40:19","name":"ice: bug fixes -- no link, tc-flower, VF rate","version":1,"mbox":"http://patchwork.ozlabs.org/series/498590/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219500/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219500/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=QxUZc9aL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn6ys19n4z1yD3\n\tfor ; Fri, 03 Apr 2026 16:41:09 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B0ABA40F33;\n\tFri, 3 Apr 2026 05:40:50 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id E5qG_s-Dto28; Fri, 3 Apr 2026 05:40:50 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E2FC040E83;\n\tFri, 3 Apr 2026 05:40:49 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 463791F3\n for ; Fri, 3 Apr 2026 05:40:46 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 387324008E\n for ; Fri, 3 Apr 2026 05:40:46 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id AYJv-1VLT_bx for ;\n Fri, 3 Apr 2026 05:40:45 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.20])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 63A1640071\n for ; Fri, 3 Apr 2026 05:40:45 +0000 (UTC)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Apr 2026 22:40:45 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa007.fm.intel.com with ESMTP; 02 Apr 2026 22:40:44 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org E2FC040E83","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 63A1640071"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775194849;\n\tbh=HYfOhaScBI57s8uF+aOnVVxrGbvnYvmxP+1j5VoWcbM=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=QxUZc9aLoiAmKC5bFsSKF5DQbpXicQuSreFIRotDjSqa47VNVtwN2Nui/Ebk8xaVU\n\t PZpf1ilifSuSGaQiJhAmf0/D7NKQUYoAYqCzjehqzbO2ArO9uy2R5t8dghlXfoasFE\n\t 5P60g0UssqQrD6NVwslwfXhSALdkwoNly3m1zvd8X/DTzvpjTP08y1f4mzX79Yvo2y\n\t xpJihbfWT9cUHr+V7s844tAx8+bXajZgaCeofP2i/PMGbikVNf9P4DNp52U1AFZnz9\n\t TZEvNWRSiFhkp5Hzf/a0uqPZvtu9hnvZuPyAGs/OCnmUT/MViNZpUIqDJC38UMlcwU\n\t iC34U/WaYweRA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.20;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 63A1640071","X-CSE-ConnectionGUID":["iedwA6z0R/SgnXFyfYeBXw==","DHKv9Q/bSWOapH5+nk6vsw=="],"X-CSE-MsgGUID":["9yGXEjqwSNaODKNab8PvsQ==","F7TH3JMjRbyWiRLV0GQgwg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11747\"; a=\"75981760\"","E=Sophos;i=\"6.23,157,1770624000\"; d=\"scan'208\";a=\"75981760\"","E=Sophos;i=\"6.23,157,1770624000\"; d=\"scan'208\";a=\"223904951\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Fri, 3 Apr 2026 07:40:28 +0200","Message-ID":"<20260403054029.3789616-11-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260403054029.3789616-1-aleksandr.loktionov@intel.com>","References":"<20260403054029.3789616-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775194846; x=1806730846;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=nFD8pkeZbVN+oILrj3B+/KCNeAfTezohFmcf1myKIyA=;\n b=IXvB8TokZmpmzlZoE6usHYl1XajSpfttSpplSDPltYEEDQz23+sTXxPt\n Ecgs4VJxY6jYruIpsdohPuVxmujLiS2nDdMn1xjMEFpVgWSoTbFvFyPMw\n OuaaQhFI+jUkk5rWoTjIqSV5p2ldNGPXEaBtsBR2eEbOzS9tW7meb+KtH\n hrufGo5s14S+lHFiaz0+WiX59wl8vFI53Fon1EpAOSKPgpDWvB9v3sChM\n BnTH+BXKlFBbubqrfq6WJ/3JmyBxWZaVlRlDbT54ZYf8BhUMuG4yS9XSK\n CaYrPPWYfjbnTfosRknEOVxtoFrqyecG9iNpBID/Fdsx5e3Kk3gp4JnSV\n w==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=IXvB8Tok"],"Subject":"[Intel-wired-lan] [PATCH iwl-net 10/10] ice: allow setting\n min_tx_rate to 0 to resolve VF bandwidth oversubscription","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"ice_set_vf_bw() refuses to accept any min_tx_rate value when the\ntotal guaranteed bandwidth is already oversubscribed, even when the\nrequested value is 0. This makes it impossible to recover from an\noversubscribed state via \"ip link set vf min_tx_rate 0\".\n\nAllow a zero min_tx_rate to bypass the oversubscription check so\nusers can always clear the guaranteed rate. Additionally print an\ninformational message when the oversubscription guard fires to help\ndiagnose why a non-zero request was rejected.\n\nFixes: 4ecc8633056b (\"ice: Add support for VF rate limiting\")\nCc: stable@vger.kernel.org\nSigned-off-by: Sudheer Mogilappagari \nSigned-off-by: Aleksandr Loktionov \n---\n drivers/net/ethernet/intel/ice/ice_sriov.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c b/drivers/net/ethernet/intel/ice/ice_sriov.c\nindex 7e00e09..6e3bec7 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sriov.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sriov.c\n@@ -1507,6 +1507,12 @@ ice_min_tx_rate_oversubscribed(struct ice_vf *vf, int min_tx_rate)\n \tall_vfs_min_tx_rate -= vf->min_tx_rate;\n \n \tif (all_vfs_min_tx_rate + min_tx_rate > link_speed_mbps) {\n+\t\tif (ice_calc_all_vfs_min_tx_rate(vf->pf) > link_speed_mbps) {\n+\t\t\tdev_info(ice_pf_to_dev(vf->pf),\n+\t\t\t\t \"The sum of min_tx_rate for all VFs is greater than the link speed\\n\");\n+\t\t\tdev_info(ice_pf_to_dev(vf->pf),\n+\t\t\t\t \"Set min_tx_rate to 0 on VFs to resolve oversubscription\\n\");\n+\t\t}\n \t\tdev_err(ice_pf_to_dev(vf->pf), \"min_tx_rate of %d Mbps on VF %u would cause oversubscription of %d Mbps based on the current link speed %d Mbps\\n\",\n \t\t\tmin_tx_rate, vf->vf_id,\n \t\t\tall_vfs_min_tx_rate + min_tx_rate - link_speed_mbps,\n@@ -1556,7 +1562,7 @@ ice_set_vf_bw(struct net_device *netdev, int vf_id, int min_tx_rate,\n \t\tgoto out_put_vf;\n \t}\n \n-\tif (ice_min_tx_rate_oversubscribed(vf, min_tx_rate)) {\n+\tif (min_tx_rate && ice_min_tx_rate_oversubscribed(vf, min_tx_rate)) {\n \t\tret = -EINVAL;\n \t\tgoto out_put_vf;\n \t}\n","prefixes":["iwl-net","10/10"]}