{"id":2219489,"url":"http://patchwork.ozlabs.org/api/patches/2219489/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403053748.78831-2-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403053748.78831-2-mohamed@unpredictable.fr>","list_archive_url":null,"date":"2026-04-03T05:37:42","name":"[v4,1/7] target/i386: emulate: include name of unhandled instruction","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3a767fdef94ad0a8b91bb13206d74bf020915274","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403053748.78831-2-mohamed@unpredictable.fr/mbox/","series":[{"id":498589,"url":"http://patchwork.ozlabs.org/api/series/498589/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498589","date":"2026-04-03T05:37:41","name":"whpx: i386: x2apic emulation for kernel-irqchip=off, feature probing","version":4,"mbox":"http://patchwork.ozlabs.org/series/498589/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219489/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219489/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=O2S9ESK5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn6wv31cTz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 16:39:27 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8XEH-0004F2-IA; Fri, 03 Apr 2026 01:38:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w8XEF-0004Cz-M4\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 01:37:59 -0400","from qs-2001a-snip4-1.eps.apple.com ([57.103.87.4]\n helo=outbound.qs.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w8XED-00088a-V9\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 01:37:59 -0400","from outbound.qs.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-4 (Postfix) with ESMTPS id\n 7A47F1800133; Fri, 03 Apr 2026 05:37:54 +0000 (UTC)","from localhost.localdomain (unknown [17.57.155.37])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-4 (Postfix) with ESMTPSA id\n 7CAB7180010B; Fri, 03 Apr 2026 05:37:52 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775194677; x=1777786677;\n bh=jSFEY3OW57r5Gmf0SB6G349rIgUNCT10rXc1M/CBSww=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=O2S9ESK5MJC5cWoRat5l5hV0IEWNqeMppul/NF4yVwItDVr7En0mwHOymVvtaMNZJiKSlJDKeyMQ52UUj9RVBcw9HQnxnFpm0NrhEiN+VtBq2e0yfv8uG2hyAB+mtXXN69AJ7/BBlPuekZGxI/5tH7KsQ8dtaX5lrhCU4gugs/YKHz8Bjd0EhHCAMPd+EnxZfyG3nVGp4vjL+Zbh4bwOabTwBI44rlxV1VliNEVesfeFHSy7GIT7SDF25gctSjrgRXKdypfmKBxGhmjdu3j4PFedfG60JS/mtx6bwoyXKyehSZSy/JiDZlV20quAyHS9Rlm7Lq2Iq3OZClrY0n61YA==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni <mohamed@unpredictable.fr>","To":"qemu-devel@nongnu.org","Cc":"Wei Liu <wei.liu@kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>, Pedro Barbuda <pbarbuda@microsoft.com>,\n Phil Dennis-Jordan <phil@philjordan.eu>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Roman Bolshakov <rbolshakov@ddn.com>","Subject":"[PATCH v4 1/7] target/i386: emulate: include name of unhandled\n instruction","Date":"Fri,  3 Apr 2026 07:37:42 +0200","Message-ID":"<20260403053748.78831-2-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260403053748.78831-1-mohamed@unpredictable.fr>","References":"<20260403053748.78831-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Authority-Info-Out":"v=2.4 cv=MeNhep/f c=1 sm=1 tr=0 ts=69cf5233\n cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117\n a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=x0iqa3ucmZZh0HPruXgA:9","X-Proofpoint-GUID":"44Nq6UuvglLxDl6l_mslxE2ZJqS4-kL7","X-Proofpoint-ORIG-GUID":"44Nq6UuvglLxDl6l_mslxE2ZJqS4-kL7","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAzMDA0NyBTYWx0ZWRfX6NLfJNSiomEK\n VZULv9XQy8lP5fkLHx9yKx/XZOOYktvjM96Q7YcwUu2SeLWVgGYB9zoFcPeyAiOBYaMmO0L423G\n vDOJdaJkW3h0Jwp6ZzhIFZk6gzASfF58zteZ0iLvyCw4ljHJwJzW4TJ0fKQOAALPUyKMnhRYxkF\n QFVTuHUAA02FusoAXz4cyEptPhzqkmPnFVolrc6smBesM1zDbP7bHzTYPzWpbYBk0DvTUHvYPk9\n pviFQpuDfw5o/UF3sJpUhyRx1CFUGtzKOIGMjoeZAK3NBK8igV26ebW2a1S4gdXA0p22A3kTpBf\n SjFV7LgpOzhInNV0hWNSZEj0OF1iaoPgLdsSk7xSX0/GiMHmJOHShzaL7JdI+o=","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-03_02,2026-04-02_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 phishscore=0\n lowpriorityscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=903\n bulkscore=0 mlxscore=0 malwarescore=0 clxscore=1030 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604030047","Received-SPF":"pass client-ip=57.103.87.4;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Instead of just the command number, include the instruction name to make debugging easier.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/emulate/x86_emu.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/target/i386/emulate/x86_emu.c b/target/i386/emulate/x86_emu.c\nindex 55b1a68eb6..c2da1a133f 100644\n--- a/target/i386/emulate/x86_emu.c\n+++ b/target/i386/emulate/x86_emu.c\n@@ -1399,8 +1399,8 @@ static void init_cmd_handler(void)\n bool exec_instruction(CPUX86State *env, struct x86_decode *ins)\n {\n     if (!_cmd_handler[ins->cmd].handler) {\n-        printf(\"Unimplemented handler (\" TARGET_FMT_lx \") for %d (%x %x)\\n\",\n-                env->eip,\n+        printf(\"Unimplemented handler (\" TARGET_FMT_lx \") for %s - %d (%x %x)\\n\",\n+                env->eip, decode_cmd_to_string(ins->cmd),\n                 ins->cmd, ins->opcode[0],\n                 ins->opcode_len > 1 ? ins->opcode[1] : 0);\n         env->eip += ins->len;\n","prefixes":["v4","1/7"]}