{"id":2219464,"url":"http://patchwork.ozlabs.org/api/patches/2219464/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403035541.18355-5-zhenzhong.duan@intel.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260403035541.18355-5-zhenzhong.duan@intel.com>","list_archive_url":null,"date":"2026-04-03T03:55:28","name":"[v3,04/14] intel_iommu: Create the nested hwpt with IOMMU_HWPT_ALLOC_PASID flag","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5972cc21f8a337e8f098ff8f610907763c6b7434","submitter":{"id":81636,"url":"http://patchwork.ozlabs.org/api/people/81636/?format=json","name":"Duan, Zhenzhong","email":"zhenzhong.duan@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403035541.18355-5-zhenzhong.duan@intel.com/mbox/","series":[{"id":498583,"url":"http://patchwork.ozlabs.org/api/series/498583/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498583","date":"2026-04-03T03:55:36","name":"intel_iommu: Enable PASID support for passthrough device","version":3,"mbox":"http://patchwork.ozlabs.org/series/498583/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219464/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219464/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=JBVuOFBn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn4g86Q1Yz1yFT\n\tfor ; Fri, 03 Apr 2026 14:57:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8Vdi-0001C7-7U; Thu, 02 Apr 2026 23:56:10 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8Vdg-0001BP-5P\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 23:56:08 -0400","from mgamail.intel.com ([198.175.65.19])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8Vde-0004N9-HK\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 23:56:07 -0400","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Apr 2026 20:56:05 -0700","from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229])\n by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Apr 2026 20:56:02 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775188566; x=1806724566;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=WhVGnhbo+Pqtx83Hy48OkP5Wl8zor8CPU++Q6Tws2aA=;\n b=JBVuOFBnleSL/KvoANYAU1Ilw6z51DXZE+z5klDdaGBvUujKYAd1DbJ+\n DzGSJrWIFTZ2yr1uBFMAqKyTvt6Le/6GpgSlVh09nFfqMh+30k6EIrg9a\n /EVPDn5Z4SL7325aQX6W6D3m0b8aH1ACVX8yJzA5Hi2YK0a7lP67jWfxH\n KJJ6zkxC34/o/c9lXMdp1rUs9T8kggu82kG8xTW72HKHsdOrvvaAvCEJW\n ThLy0l/795b3asSTmM7JXKgqo5QmZ6VaUi6xnqVMfCiB3AwzVvqKHVeuw\n 2cJnbEylNyiG+D6ATQSbgmnlAZdJlgVfVEB1v/Qa1A1qtEIBJ0yZQMIyq g==;","X-CSE-ConnectionGUID":["R2Nqa2C2Rwa2lQXmuUNMNA==","sjJeVgYlTcC5k+JuG4N1Aw=="],"X-CSE-MsgGUID":["PJ8VrpDnSdSLmETvJgX+cA==","Gsxqc7fMSpWtsbd7rEXfNw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11747\"; a=\"76140609\"","E=Sophos;i=\"6.23,157,1770624000\"; d=\"scan'208\";a=\"76140609\"","E=Sophos;i=\"6.23,157,1770624000\"; d=\"scan'208\";a=\"223884861\""],"X-ExtLoop1":"1","From":"Zhenzhong Duan ","To":"qemu-devel@nongnu.org","Cc":"alex@shazbot.org, clg@redhat.com, eric.auger@redhat.com, mst@redhat.com,\n jasowang@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com,\n skolothumtho@nvidia.com, joao.m.martins@oracle.com,\n clement.mathieu--drif@bull.com, kevin.tian@intel.com, yi.l.liu@intel.com,\n xudong.hao@intel.com, Zhenzhong Duan ","Subject":"[PATCH v3 04/14] intel_iommu: Create the nested hwpt with\n IOMMU_HWPT_ALLOC_PASID flag","Date":"Thu, 2 Apr 2026 23:55:28 -0400","Message-ID":"<20260403035541.18355-5-zhenzhong.duan@intel.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260403035541.18355-1-zhenzhong.duan@intel.com>","References":"<20260403035541.18355-1-zhenzhong.duan@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=198.175.65.19;\n envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com","X-Spam_score_int":"-48","X-Spam_score":"-4.9","X-Spam_bar":"----","X-Spam_report":"(-4.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.542,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When pasid is enabled, any hwpt attached to non-PASID or PASID should be\nIOMMU_HWPT_ALLOC_PASID flagged, or else attachment fails.\n\nChange vtd_destroy_old_fs_hwpt() to pass in 'VTDHostIOMMUDevice *' for\nnaming consistency.\n\nSigned-off-by: Zhenzhong Duan \nReviewed-by: Clement Mathieu--Drif \nReviewed-by: Yi Liu \nTested-by: Xudong Hao \n---\n hw/i386/intel_iommu_accel.c | 19 ++++++++++++-------\n 1 file changed, 12 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/i386/intel_iommu_accel.c b/hw/i386/intel_iommu_accel.c\nindex 3217a2afac..bd1236c070 100644\n--- a/hw/i386/intel_iommu_accel.c\n+++ b/hw/i386/intel_iommu_accel.c\n@@ -69,11 +69,13 @@ VTDHostIOMMUDevice *vtd_find_hiod_iommufd(VTDAddressSpace *as)\n return NULL;\n }\n \n-static bool vtd_create_fs_hwpt(HostIOMMUDeviceIOMMUFD *hiodi,\n+static bool vtd_create_fs_hwpt(VTDHostIOMMUDevice *vtd_hiod,\n VTDPASIDEntry *pe, uint32_t *fs_hwpt_id,\n Error **errp)\n {\n+ HostIOMMUDeviceIOMMUFD *hiodi = HOST_IOMMU_DEVICE_IOMMUFD(vtd_hiod->hiod);\n struct iommu_hwpt_vtd_s1 vtd = {};\n+ uint32_t flags = vtd_hiod->iommu_state->pasid ? IOMMU_HWPT_ALLOC_PASID : 0;\n \n vtd.flags = (VTD_SM_PASID_ENTRY_SRE(pe) ? IOMMU_VTD_S1_SRE : 0) |\n (VTD_SM_PASID_ENTRY_WPE(pe) ? IOMMU_VTD_S1_WPE : 0) |\n@@ -82,13 +84,16 @@ static bool vtd_create_fs_hwpt(HostIOMMUDeviceIOMMUFD *hiodi,\n vtd.pgtbl_addr = (uint64_t)vtd_pe_get_fspt_base(pe);\n \n return iommufd_backend_alloc_hwpt(hiodi->iommufd, hiodi->devid,\n- hiodi->hwpt_id, 0, IOMMU_HWPT_DATA_VTD_S1,\n- sizeof(vtd), &vtd, fs_hwpt_id, errp);\n+ hiodi->hwpt_id, flags,\n+ IOMMU_HWPT_DATA_VTD_S1, sizeof(vtd), &vtd,\n+ fs_hwpt_id, errp);\n }\n \n-static void vtd_destroy_old_fs_hwpt(HostIOMMUDeviceIOMMUFD *hiodi,\n+static void vtd_destroy_old_fs_hwpt(VTDHostIOMMUDevice *vtd_hiod,\n VTDAddressSpace *vtd_as)\n {\n+ HostIOMMUDeviceIOMMUFD *hiodi = HOST_IOMMU_DEVICE_IOMMUFD(vtd_hiod->hiod);\n+\n if (!vtd_as->fs_hwpt_id) {\n return;\n }\n@@ -116,7 +121,7 @@ static bool vtd_device_attach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n }\n \n if (vtd_pe_pgtt_is_fst(pe)) {\n- if (!vtd_create_fs_hwpt(hiodi, pe, &hwpt_id, errp)) {\n+ if (!vtd_create_fs_hwpt(vtd_hiod, pe, &hwpt_id, errp)) {\n return false;\n }\n }\n@@ -126,7 +131,7 @@ static bool vtd_device_attach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n trace_vtd_device_attach_hwpt(hiodi->devid, IOMMU_NO_PASID, hwpt_id, ret);\n if (ret) {\n /* Destroy old fs_hwpt if it's a replacement */\n- vtd_destroy_old_fs_hwpt(hiodi, vtd_as);\n+ vtd_destroy_old_fs_hwpt(vtd_hiod, vtd_as);\n if (vtd_pe_pgtt_is_fst(pe)) {\n vtd_as->fs_hwpt_id = hwpt_id;\n }\n@@ -161,7 +166,7 @@ static bool vtd_device_detach_iommufd(VTDHostIOMMUDevice *vtd_hiod,\n }\n \n if (ret) {\n- vtd_destroy_old_fs_hwpt(hiodi, vtd_as);\n+ vtd_destroy_old_fs_hwpt(vtd_hiod, vtd_as);\n }\n \n return ret;\n","prefixes":["v3","04/14"]}