{"id":2219457,"url":"http://patchwork.ozlabs.org/api/patches/2219457/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260403014736.33014-1-wangdich9700@163.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260403014736.33014-1-wangdich9700@163.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260403014736.33014-1-wangdich9700@163.com/","date":"2026-04-03T01:47:36","name":"[v2,1/2] ALSA: aoa/onyx: Fix OF node leak on probe failure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9e051b89dde976819b3298c99d4da5c876e1d399","submitter":{"id":93045,"url":"http://patchwork.ozlabs.org/api/people/93045/?format=json","name":null,"email":"wangdich9700@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260403014736.33014-1-wangdich9700@163.com/mbox/","series":[{"id":498581,"url":"http://patchwork.ozlabs.org/api/series/498581/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=498581","date":"2026-04-03T01:47:36","name":"[v2,1/2] ALSA: aoa/onyx: Fix OF node leak on probe failure","version":2,"mbox":"http://patchwork.ozlabs.org/series/498581/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219457/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219457/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linuxppc-dev+bounces-19259-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=JmWex4Mu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19259-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=117.135.210.3","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=JmWex4Mu;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=163.com\n (client-ip=117.135.210.3; helo=m16.mail.163.com;\n envelope-from=wangdich9700@163.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn2lw5zDMz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 13:31:23 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fn2lt2TXHz2ygT;\n\tFri, 03 Apr 2026 13:31:22 +1100 (AEDT)","from m16.mail.163.com (m16.mail.163.com [117.135.210.3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fn1xl0Dh5z2xN8\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 03 Apr 2026 12:54:48 +1100 (AEDT)","from localhost.localdomain (unknown [])\n\tby gzga-smtp-mtada-g0-2 (Coremail) with SMTP id\n _____wBnZAE6HM9pTfLWCw--.54645S2;\n\tFri, 03 Apr 2026 09:47:39 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775181294;\n\tcv=none;\n b=CnzDk8t5/oDqhiApGUjLNUe2LJS7X+nVhi/bW/2k8OrIBjOE44adCtTUfNACqCLl0LM//xudg2RUd7mBNjU4w8ViRzR4ioCkRp6YrYcomHtHpa8briRgUsq3kbbpHt1y60nFeheLtcKiVfLckubwgafclbzC5JltqA3RUA8TEZyG+A2ePLgLhgroE/vdbPB7GZV8mAN/IEwi1Bprx4ZLYCVOtCCDbJZpHWGk08S3mXJQSsRakkuQ8CjrgGb1KVzdM7ti9FCerVwpwRFgOJ/Fur31h7nK9mfdTZaBWgw0J2j3kk4wYjMSQIcbXuSjnUgF+GWMHL4QloKv9gH8tq5utQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775181294; c=relaxed/relaxed;\n\tbh=BjV3zxihmqtsHZ19nXPiN3UVuXXarr2GiOFicubZu5E=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=D9TRUoLgQFIMjeFJvD1phjc0HpNKXTYNO/+T9VQwzHyNsZy1bei7iKsnM6y4Bas/EfdDIWVJfGbxdGjR0vp0ZDMO+SAPUSKGkCmVojeJMJPn6yceR0/d2l28UmJWCKNown+tsmseb7g8nEFhmjUTgqbjW26ukKNF2l0Gnyh6R3uxutc9ijQ6bKbSAKXwsuoY1KMCi9ThZ7h2TMI1sl5t/dddD6Dijj4zJvULycBaUDDDoCgxhd08w0CAmRoEkVpdityJA+N2Tr9uNSX03YenIMqa47VdLkjSMLqmv14inep2RoZyarJpBsi5T73Jc2b2swMCjVD5tscOd0o+CFRamQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com; dkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=JmWex4Mu; dkim-atps=neutral;\n spf=pass (client-ip=117.135.210.3; helo=m16.mail.163.com;\n envelope-from=wangdich9700@163.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=163.com","X-Greylist":"delayed 248 seconds by postgrey-1.37 at boromir;\n Fri, 03 Apr 2026 12:54:51 AEDT","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Bj\n\tV3zxihmqtsHZ19nXPiN3UVuXXarr2GiOFicubZu5E=; b=JmWex4Mua9Xg4/86TY\n\tzcwXRxtax+2rLvsfBAqbisZHilh2k1Q9wXQW09AYr2ilb18n937Mw2enT7rM/z/Y\n\tKOC8+ll+res7BrGkNY1g/GgswlA9piJ4lnare4P9yKZkGMQlrBYM9Tt+VkmtC+i/\n\tHwl81/BkN+SCV6K8ki3CruJ8E=","From":"wangdich9700@163.com","To":"johannes@sipsolutions.net,\n\tperex@perex.cz,\n\ttiwai@suse.com,\n\twangdich9700@163.com","Cc":"linuxppc-dev@lists.ozlabs.org,\n\tlinux-sound@vger.kernel.org,\n\twangdicheng <wangdicheng@kylinos.cn>","Subject":"[PATCH v2 1/2] ALSA: aoa/onyx: Fix OF node leak on probe failure","Date":"Fri,  3 Apr 2026 09:47:36 +0800","Message-Id":"<20260403014736.33014-1-wangdich9700@163.com>","X-Mailer":"git-send-email 2.25.1","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wBnZAE6HM9pTfLWCw--.54645S2","X-Coremail-Antispam":"1Uf129KBjvdXoW7Gr47JryxtFW3uF18Cw4Durg_yoWfZrX_JF\n\t409rZYg34rKr4xCw4DXFWSvw1v9r18Ca1S9FnYyF17C34rtrs8CFnIyFn3Cr9rWryIkFy3\n\tJFn0qr1UGrWakjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRqPS4PUUUUU==","X-Originating-IP":"[116.128.244.169]","X-CM-SenderInfo":"pzdqwv5lfkmliqq6il2tof0z/xtbC5xtjsmnPHDsfiQAA36","X-Spam-Status":"No, score=0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS,UNPARSEABLE_RELAY autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"From: wangdicheng <wangdicheng@kylinos.cn>\n\nAdd missing of_node_put() in the error path.\n\nSigned-off-by: wangdicheng <wangdicheng@kylinos.cn>\n---\n\nv1->v2:\nonyx_read_register()--->goto fail--->kfree\naoa_codec_register()--->goto fail_put--->of_node_put + kfree\n\n sound/aoa/codecs/onyx.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c\nindex 04961c456d2c..da0eebf5dfbc 100644\n--- a/sound/aoa/codecs/onyx.c\n+++ b/sound/aoa/codecs/onyx.c\n@@ -980,10 +980,12 @@ static int onyx_i2c_probe(struct i2c_client *client)\n \tonyx->codec.node = of_node_get(node);\n \n \tif (aoa_codec_register(&onyx->codec)) {\n-\t\tgoto fail;\n+\t\tgoto fail_put;\n \t}\n \tprintk(KERN_DEBUG PFX \"created and attached onyx instance\\n\");\n \treturn 0;\n+ fail_put:\n+\tof_node_put(onyx->codec.node);\n  fail:\n \tkfree(onyx);\n \treturn -ENODEV;\n","prefixes":["v2","1/2"]}