{"id":2219309,"url":"http://patchwork.ozlabs.org/api/patches/2219309/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402194314.20104-1-viking4@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260402194314.20104-1-viking4@gmail.com>","list_archive_url":null,"date":"2026-04-02T19:43:14","name":"runstate: allow inmigrate -> debug transition on snapshot restore","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fa9771d372bfb3b14068e84548e5124f2fc47b37","submitter":{"id":92831,"url":"http://patchwork.ozlabs.org/api/people/92831/?format=json","name":"Trieu Huynh","email":"vikingtc4@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402194314.20104-1-viking4@gmail.com/mbox/","series":[{"id":498548,"url":"http://patchwork.ozlabs.org/api/series/498548/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498548","date":"2026-04-02T19:43:14","name":"runstate: allow inmigrate -> debug transition on snapshot restore","version":1,"mbox":"http://patchwork.ozlabs.org/series/498548/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2219309/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219309/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=qOa9ELm3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmsjw3FV7z1yCt\n\tfor ; Fri, 03 Apr 2026 06:44:04 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8Nx2-0006e5-Sx; Thu, 02 Apr 2026 15:43:36 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8Nx0-0006Yg-Ru\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 15:43:34 -0400","from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8Nwz-0002sR-8m\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 15:43:34 -0400","by mail-pg1-x529.google.com with SMTP id\n 41be03b00d2f7-c76c60c7502so552187a12.0\n for ; Thu, 02 Apr 2026 12:43:32 -0700 (PDT)","from localhost.localdomain ([42.118.191.4])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9c4387esm4094899b3a.31.2026.04.02.12.43.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Apr 2026 12:43:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775159011; x=1775763811; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=3rhdPOFMSj9i+ylqvIGg6bucMa4Ig+P7LWndpMGq004=;\n b=qOa9ELm3xu47liW2rptRVfDUOi0KyWgM1kXLh21JZb2ovKdSmi+ThXQcUO7LhCenPn\n lDzEPu1257+DW7sXX8PW5A3C50YsfJCH5VzLYkq8IcuzV53f3/0Ia2tZgLB/x5qajV7Q\n D+tnUpxp6+S2Z2rRxXHhmeZnXktX/b0p9PWnYjd9sccie1q50yiublec4qQKNipOeLQL\n nzc6nGxtE8nC31tjRqEYnvDW5zmHIs9WWNhNSrfRNYJ1D4L7ZlbN+io0rrSmFNNtHoIr\n QClBlSReBXtoMyTKyq9qX/JeaujiH6JluzJ6N8FYjTFrBQdVl81mRrfHkvhWSeA3DGG5\n WrLA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775159011; x=1775763811;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3rhdPOFMSj9i+ylqvIGg6bucMa4Ig+P7LWndpMGq004=;\n b=Y39DdNAPeiTZz9isS/OqTI03Lpdlgsa9AVc3rTdJbcD/96wi6mifpBxnHwm+PvXCic\n kGHwpvOINYJiaMnAVoIGrZZ7NrbWJyWVaQoiZI2WNFNFEpjYczW/j+tXMAv6+C+JoYv7\n i2Jh1eEANnjLRI6PKLc8my2t2OqSnW4H6Hd6nLRWDHslqLLHk6JkA+4+Ug8yIBMkZhmH\n nBGHQ/HncQuC7nsItqnpn+KmCnNx4TgIo4mLnXHcxw5X8ek1AT6b6/IQUIXM6V/CBzdJ\n sa6pJQz++aFxSC2vCg+LkQaZG1r4+pffFyWLYZIXwrTT8jzUGgaivTpZ6jPH+U4+v8fL\n gYyQ==","X-Gm-Message-State":"AOJu0Yzt+x7pyRQTgT8qM7whzRjmgVscTmOIHmvzWjJzGdUVeHxypQl2\n wVW0hsnEL9mOg5ojiGCtb/OVH8lrPgTUN+XXl9glzi4ClSrJ9NHQigZlWx4WKM7BbDs=","X-Gm-Gg":"ATEYQzwIV9rItp+w/qGDuakj9kYQttzH6pVZYX4Whhu9ObmxSGMpFDVGc4gQuGle+AK\n E0LOvYrxDZFuPjs1uC9JKRIVqpJ7Kyt71HyBgzRiI7N5CWBiHkSisMalsuR89t093OixRXXpLFf\n 4i0E4BXIdDRqBlVYgJ72YuLDkDjSq1jPZV6YY4aK2MLppqHc+ZZvOxQtopDvCkNcwKQFld2IAVv\n xUq+FCQoJYj/o048LThQOyOXFmKKmL2Yo6ItQK8FKivQoFjH6Pt8+LcIQQyp1VuICnqlRCs4L5T\n MvvDpBIpxj/Lr+kaczzLq8dAtLpEonfnDoTnjFW0Ep2uhbBB62BVgwJ+bmsUjR5LjrvrAbmvUhS\n 9H0r9sgSIQ8L0fqudFshLuT3nc8czoUtK4HOy3YLn1JDWTNkKJRcP7FuYERXIRgqz7Hl4f68d3w\n otpJHcMEifAEAuXevihdjLk7ZxWIiobyNIbvjEbaVqGHhi","X-Received":"by 2002:a05:6a20:3d0f:b0:398:9e47:f5e7 with SMTP id\n adf61e73a8af0-39f2db1afdamr332694637.31.1775159011383;\n Thu, 02 Apr 2026 12:43:31 -0700 (PDT)","From":"Trieu Huynh ","X-Google-Original-From":"Trieu Huynh ","To":"qemu-devel@nongnu.org","Cc":"Trieu Huynh ,\n\tPaolo Bonzini ","Subject":"[PATCH] runstate: allow inmigrate -> debug transition on snapshot\n restore","Date":"Fri, 3 Apr 2026 02:43:14 +0700","Message-ID":"<20260402194314.20104-1-viking4@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::529;\n envelope-from=vikingtc4@gmail.com; helo=mail-pg1-x529.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Trieu Huynh \n\nWhen a VM snapshot is taken while the guest is paused by a gdbstub\n(RUN_STATE_DEBUG), the saved runstate is 'debug', for instance:\n (gdb) monitor info status\n VM status: paused (debug)\n\nOn restore, the destination starts in 'inmigrate' and transitions\nto the saved runstate, but the 'inmigrate -> debug' transition\nwas missing from the table, causing an abort:\n\n $ ./qemu-system-x86_64 -machine pc,accel=kvm:tcg -m 128M\n -display none -gdb tcp::1235 -incoming \"exec:cat /tmp/snap.img\"\n > /tmp/qemu-restore.log 2>&1\n Aborted (core dumped)\n $ cat /tmp/qemu-restore.log\n qemu-system-x86_64: invalid runstate transition: 'inmigrate'\n -> 'debug'\n\nFix it by adding the missing one (Point out by the author\nDustin Spicuzza)\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/1231\n\nSigned-off-by: Trieu Huynh \n---\n system/runstate.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/system/runstate.c b/system/runstate.c\nindex 2d4e95a216..97a6a1c736 100644\n--- a/system/runstate.c\n+++ b/system/runstate.c\n@@ -94,6 +94,7 @@ static const RunStateTransition runstate_transitions_def[] = {\n { RUN_STATE_INMIGRATE, RUN_STATE_PRELAUNCH },\n { RUN_STATE_INMIGRATE, RUN_STATE_POSTMIGRATE },\n { RUN_STATE_INMIGRATE, RUN_STATE_COLO },\n+ { RUN_STATE_INMIGRATE, RUN_STATE_DEBUG },\n \n { RUN_STATE_INTERNAL_ERROR, RUN_STATE_PAUSED },\n { RUN_STATE_INTERNAL_ERROR, RUN_STATE_FINISH_MIGRATE },\n","prefixes":[]}