{"id":2218956,"url":"http://patchwork.ozlabs.org/api/patches/2218956/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260402072701.628293-3-ruanjinjie@huawei.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260402072701.628293-3-ruanjinjie@huawei.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260402072701.628293-3-ruanjinjie@huawei.com/","date":"2026-04-02T07:26:48","name":"[v12,02/15] powerpc/crash: Fix possible memory leak in update_crash_elfcorehdr()","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"50c7d434bf0ed52dce301f311ca5823ea37efaa5","submitter":{"id":84791,"url":"http://patchwork.ozlabs.org/api/people/84791/?format=json","name":"Jinjie Ruan","email":"ruanjinjie@huawei.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260402072701.628293-3-ruanjinjie@huawei.com/mbox/","series":[{"id":498443,"url":"http://patchwork.ozlabs.org/api/series/498443/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=498443","date":"2026-04-02T07:26:46","name":"arm64/riscv: Add support for crashkernel CMA reservation","version":12,"mbox":"http://patchwork.ozlabs.org/series/498443/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2218956/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2218956/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=tFzuTHsT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19193-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=113.46.200.222","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=tFzuTHsT;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com\n (client-ip=113.46.200.222; helo=canpmsgout07.his.huawei.com;\n envelope-from=ruanjinjie@huawei.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmYLQ1YNXz1yCs\n\tfor ; Thu, 02 Apr 2026 18:26:06 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fmYL95cLzz2yqc;\n\tThu, 02 Apr 2026 18:25:53 +1100 (AEDT)","from canpmsgout07.his.huawei.com (canpmsgout07.his.huawei.com\n [113.46.200.222])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fmYL85MKJz2yjw\n\tfor ; Thu, 02 Apr 2026 18:25:52 +1100 (AEDT)","from mail.maildlp.com (unknown [172.19.162.92])\n\tby canpmsgout07.his.huawei.com (SkyGuard) with ESMTPS id 4fmYBz53n1zLlTb;\n\tThu, 2 Apr 2026 15:19:39 +0800 (CST)","from dggpemf500011.china.huawei.com (unknown [7.185.36.131])\n\tby mail.maildlp.com (Postfix) with ESMTPS id 4BBA04056C;\n\tThu, 2 Apr 2026 15:25:49 +0800 (CST)","from huawei.com (10.90.53.73) by dggpemf500011.china.huawei.com\n (7.185.36.131) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 2 Apr\n 2026 15:25:46 +0800"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775114753;\n\tcv=none;\n b=PSiUs3GwKPZPOnlrTSIV6NVwKWv5ZAOiEgbJq5ERYwsbb+idEsFRUBbKDN+0WzKUO0CQCr1DRk04H2O2j3cKpRCWnLG6uK0tVE5w7UnU4ynKAl9Ajjg2cEiOZ4tRsnw9bUfICkeghwp5jb7Sv29Y6pynnsccoYqFC9qHj02ejcTViUXvtj+euxINFlHWIxj43cQVkd7fX0JlE3we/72vnIxQ067FI6d8XJXMHL+9nlzjd9e9g/6UXf0xTxRUP6FMvMIIP9Y1rV/xUTkIdkwzQZGVU9deL5rvYZ2eca8g8qp3EmmyQHMAZ0rtQC+Gmk0pJJGqCGiPNwNJ18B9OAlVMg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775114753; c=relaxed/relaxed;\n\tbh=jId8P+ONUCkepbB9G1MdtS+YuPsIL1WMFxljnCguKpc=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=DLqoDn6XB9moCbkm91RA2t3Hf4JGuw0cUVakNkYwYPtjxc1pDD9TLBr374dQ9KsHmhFmtfYRS6I6JqifzBPSk/HQJKIN89PpUUVjLwBOxXhem2kb+dkvZl1x/9Xg0yyb/jbBux9JoL8VvRHbesX57uPce9UIgtDjFasXT/i4w+hmIhguWCBw2uGaGC+ELT0RH7/0whRA/rFNLoNBR6QQbLVv4InjeobgkoBYg3hdPJNpeSdV35QDjOgbRYAUDKue55Y0owBwje9KLhstx2c0boN9VM8/jDrqsybO8qZTgUmh0087bYA74Lc21u94R1F1lFiwC5GCqsE+Sq/hSZXm2A==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=tFzuTHsT; dkim-atps=neutral;\n spf=pass (client-ip=113.46.200.222; helo=canpmsgout07.his.huawei.com;\n envelope-from=ruanjinjie@huawei.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=huawei.com","dkim-signature":"v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=jId8P+ONUCkepbB9G1MdtS+YuPsIL1WMFxljnCguKpc=;\n\tb=tFzuTHsTkjp4T9eVg+QMjSR1BwdJKPVGlbxtsiR/GAHmEdxR/pSdAVK0KLuk7PcltF+4loIVu\n\tCdZt6dmuUw92EX/5a4EchYTeJiN0hf+WMgxJIDJeJrMc3/wVkKB6Iq0m+GnTt7eqZbUqXZ3vuva\n\toUihRt+/+uUS97kTDqFf1qs=","From":"Jinjie Ruan ","To":", , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, ,\n\t, , ,\n\t, ,\n\t, ,\n\t, ,\n\t, ,\n\t","CC":"","Subject":"[PATCH v12 02/15] powerpc/crash: Fix possible memory leak in\n update_crash_elfcorehdr()","Date":"Thu, 2 Apr 2026 15:26:48 +0800","Message-ID":"<20260402072701.628293-3-ruanjinjie@huawei.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260402072701.628293-1-ruanjinjie@huawei.com>","References":"<20260402072701.628293-1-ruanjinjie@huawei.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-Originating-IP":"[10.90.53.73]","X-ClientProxiedBy":"kwepems100002.china.huawei.com (7.221.188.206) To\n dggpemf500011.china.huawei.com (7.185.36.131)","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"In get_crash_memory_ranges(), if crash_exclude_mem_range() failed\nafter realloc_mem_ranges() has successfully allocated the cmem\nmemory, it just returns an error but leaves cmem pointing to\nthe allocated memory, nor is it freed in the caller\nupdate_crash_elfcorehdr(), which cause a memory leak, goto out\nto free the cmem.\n\nCc: Sourabh Jain \nCc: Hari Bathini \nCc: Michael Ellerman \nFixes: 849599b702ef (\"powerpc/crash: add crash memory hotplug support\")\nSigned-off-by: Jinjie Ruan \n---\n arch/powerpc/kexec/crash.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c\nindex a325c1c02f96..1d12cef8e1e0 100644\n--- a/arch/powerpc/kexec/crash.c\n+++ b/arch/powerpc/kexec/crash.c\n@@ -440,7 +440,7 @@ static void update_crash_elfcorehdr(struct kimage *image, struct memory_notify *\n \tret = get_crash_memory_ranges(&cmem);\n \tif (ret) {\n \t\tpr_err(\"Failed to get crash mem range\\n\");\n-\t\treturn;\n+\t\tgoto out;\n \t}\n \n \t/*\n","prefixes":["v12","02/15"]}