{"id":2218954,"url":"http://patchwork.ozlabs.org/api/patches/2218954/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260402072701.628293-2-ruanjinjie@huawei.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260402072701.628293-2-ruanjinjie@huawei.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260402072701.628293-2-ruanjinjie@huawei.com/","date":"2026-04-02T07:26:47","name":"[v12,01/15] riscv: kexec_file: Fix crashk_low_res not exclude bug","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"a96c778c1e2f861a76d8418421aa707a5e543da1","submitter":{"id":84791,"url":"http://patchwork.ozlabs.org/api/people/84791/?format=json","name":"Jinjie Ruan","email":"ruanjinjie@huawei.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260402072701.628293-2-ruanjinjie@huawei.com/mbox/","series":[{"id":498443,"url":"http://patchwork.ozlabs.org/api/series/498443/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=498443","date":"2026-04-02T07:26:46","name":"arm64/riscv: Add support for crashkernel CMA reservation","version":12,"mbox":"http://patchwork.ozlabs.org/series/498443/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2218954/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2218954/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=xXm5VJ0g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19191-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=113.46.200.221","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=xXm5VJ0g;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com\n (client-ip=113.46.200.221; helo=canpmsgout06.his.huawei.com;\n envelope-from=ruanjinjie@huawei.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmYLB2ZlCz1yGY\n\tfor ; Thu, 02 Apr 2026 18:25:54 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fmYL83GfNz2yZc;\n\tThu, 02 Apr 2026 18:25:52 +1100 (AEDT)","from canpmsgout06.his.huawei.com (canpmsgout06.his.huawei.com\n [113.46.200.221])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fmYL55VpCz2ySk\n\tfor ; Thu, 02 Apr 2026 18:25:49 +1100 (AEDT)","from mail.maildlp.com (unknown [172.19.163.0])\n\tby canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4fmYBv53hPzRhWN;\n\tThu, 2 Apr 2026 15:19:35 +0800 (CST)","from dggpemf500011.china.huawei.com (unknown [7.185.36.131])\n\tby mail.maildlp.com (Postfix) with ESMTPS id 14BA14056B;\n\tThu, 2 Apr 2026 15:25:46 +0800 (CST)","from huawei.com (10.90.53.73) by dggpemf500011.china.huawei.com\n (7.185.36.131) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 2 Apr\n 2026 15:25:42 +0800"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775114752;\n\tcv=none;\n b=Nl6p+UWmDzhoYt6TQAMMJIt4jQ4ET7nstGJTYpZi81Si5DMWZjIZ96ZLXGw16JTmURJjz4jnfyTTDQuGdLKvAgTfPT2Ya6UwgeXBwXLx7zbT0r2bmNtF1qsENq2JozWKdvYwIhW/XZi7gSL8WmGF2mPmIiXL9hnzJgceyCwWasF63V9CyEo3aUb/7SQhcsH1qJTSqQQ5bpRd2qhXOJ5VQO57kGs4aE1/++bcbXJcrLn8e+xz8mUM7DEtTHGuYXyu6HLfJzFD9Sfvx5uTJw01eZO+ExfPVuweA4as3mhLZkahZgTkPfUrkADAxk3z0ReqO6Wqg+n8TYnwzNUnjxK4ZQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775114752; c=relaxed/relaxed;\n\tbh=MS+svJjwX+WERXmMYEnQYyI5Mc94faKy2CdWQtmAb8o=;\n\th=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=RZ9Y4f/HmDPnHfDtxIAKnmut7XM/D3Xpe7E3wmliz+dqbybEcplNpIrAv7cFdqSk6wiN4N4DIAxG4Sh0HmGLXwFbuSjjYg9hF5zCpKmHrsNJjIHrWEWY9RSvHR9bwPSqDncMQ1GnILn+mvprjzqG4PFOXv6ll6IStNggi9U5/zTtajM9MaCWnq5OZdqwMtnQrAF1Sz5iXUNqEt6UJSg68bPRWJ25sjqJmYophvx0Xbc8f9y1XTY/FOWPgapGHVpI7lBzkX4DZIwr87GMV+RlcL4O4pXH8V8q7wWwIZZD2mtozatnPhNGKeO25s6/s8m4Wt5Sv+RItn3DP1JSLRhcsw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=huawei.com;\n dkim=pass (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=xXm5VJ0g; dkim-atps=neutral;\n spf=pass (client-ip=113.46.200.221; helo=canpmsgout06.his.huawei.com;\n envelope-from=ruanjinjie@huawei.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=huawei.com","dkim-signature":"v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=MS+svJjwX+WERXmMYEnQYyI5Mc94faKy2CdWQtmAb8o=;\n\tb=xXm5VJ0gzjFo5FI6ifJNt2lYYB9fpiEFwKvKrblrK5cZ5X5QR0VEIsC4iprJlRC3urHXpb75e\n\tXRqctvGI7uS/yew73xY6QXp4G2a2n8T+yKdd4nuZDj5kccyoaXIEo3Ic4MOgmKWA5NZ5J2KJg3p\n\tVaGi5GtRXJK44kah7P/dE2Q=","From":"Jinjie Ruan ","To":", , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, ,\n\t, , ,\n\t, ,\n\t, ,\n\t, ,\n\t, ,\n\t","CC":"","Subject":"[PATCH v12 01/15] riscv: kexec_file: Fix crashk_low_res not exclude\n bug","Date":"Thu, 2 Apr 2026 15:26:47 +0800","Message-ID":"<20260402072701.628293-2-ruanjinjie@huawei.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260402072701.628293-1-ruanjinjie@huawei.com>","References":"<20260402072701.628293-1-ruanjinjie@huawei.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-Originating-IP":"[10.90.53.73]","X-ClientProxiedBy":"kwepems100002.china.huawei.com (7.221.188.206) To\n dggpemf500011.china.huawei.com (7.185.36.131)","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"As done in commit 944a45abfabc (\"arm64: kdump: Reimplement crashkernel=X\")\nand commit 4831be702b95 (\"arm64/kexec: Fix missing extra range for\ncrashkres_low.\") for arm64, while implementing crashkernel=X,[high,low],\nriscv should have excluded the \"crashk_low_res\" reserved ranges from\nthe crash kernel memory to prevent them from being exported through\n/proc/vmcore, and the exclusion would need an extra crash_mem range.\n\nJust simply tested on qemu with crashkernel=4G with kexec in [1] mentioned\nin [2]. And the second kernel can be started normally.\n\n\t# dmesg | grep crash\n\t[ 0.000000] crashkernel low memory reserved: 0xf8000000 - 0x100000000 (128 MB)\n\t[ 0.000000] crashkernel reserved: 0x000000017fe00000 - 0x000000027fe00000 (4096 MB)\n\nCc: Guo Ren \nCc: Baoquan He \n[1]: https://github.com/chenjh005/kexec-tools/tree/build-test-riscv-v2\n[2]: https://lore.kernel.org/all/20230726175000.2536220-1-chenjiahao16@huawei.com/\nFixes: 5882e5acf18d (\"riscv: kdump: Implement crashkernel=X,[high,low]\")\nReviewed-by: Guo Ren \nSigned-off-by: Jinjie Ruan \n---\n arch/riscv/kernel/machine_kexec_file.c | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)","diff":"diff --git a/arch/riscv/kernel/machine_kexec_file.c b/arch/riscv/kernel/machine_kexec_file.c\nindex 54e2d9552e93..3f7766057cac 100644\n--- a/arch/riscv/kernel/machine_kexec_file.c\n+++ b/arch/riscv/kernel/machine_kexec_file.c\n@@ -61,7 +61,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)\n \tunsigned int nr_ranges;\n \tint ret;\n \n-\tnr_ranges = 1; /* For exclusion of crashkernel region */\n+\tnr_ranges = 2; /* For exclusion of crashkernel region */\n \twalk_system_ram_res(0, -1, &nr_ranges, get_nr_ram_ranges_callback);\n \n \tcmem = kmalloc_flex(*cmem, ranges, nr_ranges);\n@@ -76,8 +76,16 @@ static int prepare_elf_headers(void **addr, unsigned long *sz)\n \n \t/* Exclude crashkernel region */\n \tret = crash_exclude_mem_range(cmem, crashk_res.start, crashk_res.end);\n-\tif (!ret)\n-\t\tret = crash_prepare_elf64_headers(cmem, true, addr, sz);\n+\tif (ret)\n+\t\tgoto out;\n+\n+\tif (crashk_low_res.end) {\n+\t\tret = crash_exclude_mem_range(cmem, crashk_low_res.start, crashk_low_res.end);\n+\t\tif (ret)\n+\t\t\tgoto out;\n+\t}\n+\n+\tret = crash_prepare_elf64_headers(cmem, true, addr, sz);\n \n out:\n \tkfree(cmem);\n","prefixes":["v12","01/15"]}