{"id":2216060,"url":"http://patchwork.ozlabs.org/api/patches/2216060/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260325190025.3428560-1-trini@konsulko.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260325190025.3428560-1-trini@konsulko.com>","list_archive_url":null,"date":"2026-03-25T19:00:25","name":"arm: rockchip: Guard call of board_early_init_f in SPL","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ededc45b718a38be61a04799af0bd936c8bdd1c1","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/?format=json","name":"Tom Rini","email":"trini@konsulko.com"},"delegate":{"id":93623,"url":"http://patchwork.ozlabs.org/api/users/93623/?format=json","username":"kevery","first_name":"Kever","last_name":"Yang","email":"ykai007@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260325190025.3428560-1-trini@konsulko.com/mbox/","series":[{"id":497489,"url":"http://patchwork.ozlabs.org/api/series/497489/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=497489","date":"2026-03-25T19:00:25","name":"arm: rockchip: Guard call of board_early_init_f in SPL","version":1,"mbox":"http://patchwork.ozlabs.org/series/497489/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2216060/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2216060/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=G/hny2+8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"G/hny2+8\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgx895Rklz1xy3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 06:01:13 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8E42B83FD3;\n\tWed, 25 Mar 2026 20:00:36 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 08A9A83FC6; Wed, 25 Mar 2026 20:00:31 +0100 (CET)","from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com\n [IPv6:2607:f8b0:4864:20::32c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D197983F60\n for <u-boot@lists.denx.de>; Wed, 25 Mar 2026 20:00:28 +0100 (CET)","by mail-ot1-x32c.google.com with SMTP id\n 46e09a7af769-7d9c98e437cso124997a34.0\n for <u-boot@lists.denx.de>; Wed, 25 Mar 2026 12:00:28 -0700 (PDT)","from bill-the-cat.. (fixed-189-203-97-235.totalplay.net.\n [189.203.97.235]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-67e0a9e18desm550887eaf.3.2026.03.25.12.00.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 12:00:27 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1774465227; x=1775070027; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=MCLjJTnbX7Ov0OE5hw+rtvI/0iJAL1M3jDdYvML7vCo=;\n b=G/hny2+8SXjZmEtiMQo4j+wfVbN+mCWt4BOBiY+zjoW0a238WQuHVTvaLZpD2ZASxU\n krqIb+2KFwCcybE072L68ZxptyQQigMw7NWuuJQatbqmXqclX/X4cOskd7QUSIRP+N4b\n S+xGMmvNBI4d22MbbSBCzH/NhZjvKcRYTb1kw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774465227; x=1775070027;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MCLjJTnbX7Ov0OE5hw+rtvI/0iJAL1M3jDdYvML7vCo=;\n b=ZFDuqeqmONgqFBLkvs1L66mY9OUya62NFSaQzK4JtQOJwCkNXDkrvHHxXORZWuPQ1D\n SdmQPQN6l1D1BCGSNE2yJss5kP5XTtJnsNL6PnvDIEfD2p1FVzMRz+KBMJ2LJixHDenJ\n HlWFoGr0MwLL0Ey5ZozudxCjcLkCV+t+abB2V4qzcHvzK2Nq3OS1abdHDrRKfxtVg7NU\n MWnkYdCP1qXsRwTL++TtFWx8rl4aDkaFEPcZUp0iMAWYTYtzEg6EpYzmTgv7jB3K4eI0\n rAswRVwU1T3xpqFukdtS12NT91I0eId2FOvGV2ZttQeBCM0HpCJ5FGHT4zNhiAmmQkyL\n FuxQ==","X-Gm-Message-State":"AOJu0YwQBpbrecm77sxKZ17y+cVIweeJEDC1RhAeugbiKbXlxG/KYKtR\n expj0c+t/r6Y+CbTmSo0A4o5GsYgycAocuVfM5zyRTUtmMVZ1uVymKrtRRUKOMweiot5nJy1idv\n k2ZV5p9o=","X-Gm-Gg":"ATEYQzzOYjP2IdYtuh9Jg7UfDS5N6p0wYjyAtQAQIJNp+Ph4po2CjffQ0SHXQU4lKW8\n NxvPAh+NYsKMDTQF/jqYle3sJuBai2GXcgpP/qcVtWPd6P0Xhh+D8fbuGWVXFYxu6/VlSx3Cj/4\n Q0/AOCXMfAQRmZCe2ybtDXYs3uPwvXRKdbOMUzdWt2m7wPteV4wgRW9kzVKLoZ/+yk0LewXIp9z\n g69kTvK/Sv1Z+w9oUoonzandHKrGKyJ5IVtfRQqAIwbOLo9+3oHCLFJSHdsAxnJg1cNsjIGPwWT\n qndn6SJy5MvkuwM7yEYKjMxqhW1V/VdJWMnNocE98Ow72hA4QG8rRFo43TegPMRAB8Xt9nPXBq+\n A/429K9XptZfSWTlyuzlqeNT9VstBS0r50EnE5rUAiya8gxdXm5gXbqCcPXU9TJmHRG4oDd3Ia5\n qzlOLrr3B4cki9tPvO4PpnnyCQ22YGyD2VZYmsnyL8qAxiv55+5nyeGSUBIX8PkYV0GccTxtcwd\n sOZ7DuPNniDQ/PF+6sFiklax5embqAU5bBzGbcBGKKYlD2F/z8=","X-Received":"by 2002:a05:6820:168c:b0:67d:ef28:8dca with SMTP id\n 006d021491bc7-67dff3dd541mr2540109eaf.24.1774465227407;\n Wed, 25 Mar 2026 12:00:27 -0700 (PDT)","From":"Tom Rini <trini@konsulko.com>","To":"u-boot@lists.denx.de","Cc":"Philipp Tomsich <philipp.tomsich@vrull.eu>,\n Kever Yang <kever.yang@rock-chips.com>","Subject":"[PATCH] arm: rockchip: Guard call of board_early_init_f in SPL","Date":"Wed, 25 Mar 2026 13:00:25 -0600","Message-ID":"<20260325190025.3428560-1-trini@konsulko.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Today, no platforms call board_early_init_f, and rockchip provides a\nweak default function. Change this to not providing a weak function and\nonly call board_early_init_f if CONFIG_BOARD_EARLY_INIT_F is enabled.\nThis will allow any potential future needs to be taken care of, and make\nfuture consolidation easier.\n\nSigned-off-by: Tom Rini <trini@konsulko.com>\n---\nCc: Philipp Tomsich <philipp.tomsich@vrull.eu>\nCc: Kever Yang <kever.yang@rock-chips.com>\n---\n arch/arm/mach-rockchip/spl.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)","diff":"diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c\nindex e989c148079a..8026cc0abb8d 100644\n--- a/arch/arm/mach-rockchip/spl.c\n+++ b/arch/arm/mach-rockchip/spl.c\n@@ -97,11 +97,6 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)\n \treturn MMCSD_MODE_RAW;\n }\n \n-__weak int board_early_init_f(void)\n-{\n-\treturn 0;\n-}\n-\n __weak int arch_cpu_init(void)\n {\n \treturn 0;\n@@ -111,7 +106,8 @@ void board_init_f(ulong dummy)\n {\n \tint ret;\n \n-\tboard_early_init_f();\n+\tif (IS_ENABLED(CONFIG_BOARD_EARLY_INIT_F))\n+\t\tboard_early_init_f();\n \n \tret = spl_early_init();\n \tif (ret) {\n","prefixes":[]}